Skip to content

fix: backport 0.12.1 fast batch v2b-2 (16 user-facing fixes) - #32977

Merged
buluoray merged 16 commits into
release/0.12.0from
crew/slack/0.12.1-fast-v2b-2
Nov 8, 2026
Merged

buluoray merged 16 commits into
release/0.12.0from
crew/slack/0.12.1-fast-v2b-2

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring sixteen fixes for problems a 0.12.0 user can hit, merged on main after v0.12.0, onto release/0.12.0, one commit each, in a PR of its own.

Why it matters

Each fix changes behaviour a 0.12.0 user can run into today. Every pick applied to release/0.12.0 cleanly, so the code each one replaces is on release.

PR Area What a 0.12.0 user sees today
#31046 settings Slack or agent select save crashes on non-object config
#31092 cron Cron logs a traceback every tick without timezone data
#30840 security narrowed origin policy takes effect on live refresh
#22017 update cancelling an update while it starts actually stops the apply
#30991 crew crew sidebar/board shows red only for what needs you
#31777 security status roster checks session ownership before showing sessions
#31983 chat embed bare /embed/chat/ link opens its own chat, not another
#31810 security Sandbox file guard tightened on fresh installs
#31719 chat Streaming replies keep updating on slow devices
#31703 security SEL audit log is owner-only on Windows
#31445 deploy deploy-skill credential scan no longer stalls on large files
#32325 chat guide card status no longer flips back to an older state
#27055 remote crew Remote crew one-off 502 when SSM forward drops a read
#32370 apps/messaging App with revoked messaging could still edit its Slack posts
#32502 settings/theme Theme delete used native confirm that can freeze the desktop window
#31194 apps App with malformed mcpServers crashes instead of clear error

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change.
  • Rows whose pick conflicts; they go in a later batch.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ b447cd4fc6, in merge order on main, one commit each. Every pick applied cleanly, and every commit keeps its original author.

# PR main commit release commit
1 #31046 keep a non-object slack or agent config entry on select writes 6792d171e4 b0268785f3
2 #31092 warn once per job when its timezone cannot be resolved 7e339ced37 ac1e43b5ca
3 #30840 apply a narrowed origin policy on a live refresh 4a35d06f11 4514805c8b
4 #22017 stop the apply command when a cancel lands while it is starting 89a61071c5 36a7cc186b
5 #30991 red only for what needs you; a stall is muted and hidden while the conductor handles it 1ed5cf491d c17249aec8
6 #31777 tighten a session ownership check in the status roster 4c55f55efb ecc9ac94b9
7 #31983 keep a bare /embed/chat/ link on its own chat 0140686ccd 171ecedd71
8 #31810 tighten another sandbox file guard on fresh installs 2b0c135059 2df3292c8e
9 #31719 keep a streaming reply's text live on slow devices 9d37818b2a 0d00995fc9
10 #31703 make the audit log owner-only on Windows d939b8c168 32888a68fc
11 #31445 run the deploy-skill and ledger credential scans in linear time 7aaf1b10d7 d9b91ebde6
12 #32325 order a card row's copies by a per-patch revision e702910806 8baa1506d2
13 #27055 redial a proxied read once when the forward drops it before a response f09928e823 f4bc5696c1
14 #32370 re-vet the calling app's messaging grant on an edit 3d72faec34 c2f37eedcd
15 #32502 ask before deleting a custom theme in the app's own dialog 9aeb2ebb92 160587a550
16 #31194 refuse a non-object mcpServers with a clear error 359db48c03 0bcd8fa9d9

Picks whose co-author trailers carried internal addresses have each trailer rewritten as a plain "Co-author on main: " line, because the commit guard refuses the address.

#30296, #31018, #30516 and #31949 now conflict, in a test, translator notes, a test and a spec doc only, so they wait for a docs/tests batch.

Backwards compatibility

Compatible: each change is the one already merged on main, and its compatibility note applies unchanged.

Removes nothing: no setting, key or caller is removed.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the direct test modules were run here: the 22 Python test files these picks touch gave 1,646 passed and 3 skipped.
  • Frontend: tsc -p tsconfig.app.json --noEmit passes; the 10 vitest files these picks touch gave 285 passed; lint:i18n passes at the same count as clean release.
  • flake8, isort, the black gate and mypy src/kiro_crew pass. i18n:check without a base reports the same findings class as a clean release/0.12.0 on this host, and fewer of them.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: the frontend picks carry the same rendered change as their main PRs, which show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #31046, #31092, #30840, #22017, #30991, #31777, #31983, #31810, #31719, #31703, #31445, #32325, #27055, #32370, #32502, #31194.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

RohanK6 and others added 16 commits November 8, 2026 06:21
…31046)

_set_default_agent and the Slack users and channels select handlers
set one key inside the agent or slack config section. When that entry
held a list, string, number or null, setdefault returned it and the
item assignment raised TypeError, an unhandled crash out of the
locked write. Each mutate now returns None for a non-object section,
so nothing is written and runtime state is unchanged. The select
handlers log and return as on an unreadable config, and
_set_default_agent raises ValueError. The /kirocrew agent slash
handler now replies with that error, as the !agent command does.

(cherry picked from commit 6792d17)
…1092)

* fix(cron): warn once per job when its timezone cannot be resolved

* test(cron): drop issue number from timezone warn-once docstring

---------

Co-author on main: Jacob Largent
(cherry picked from commit 7e339ce)
Co-authored-by: w <w@k.local>
(cherry picked from commit 4a35d06)
…tarting (#22017)

asyncio.create_subprocess_exec forks the child before it finishes connecting the pipes, so a cancel inside that await went through asyncio's own transport cleanup. That cleanup sends SIGKILL to the leader pid alone. CommandProvider.apply never held the process, and the installer's TERM trap never ran, leaving the venv moved aside and the rest of its group alive.

The child now starts in a task the cancel does not interrupt. A cancel that arrives during the start waits for it inside the TERM grace and then stops the child through _stop_installer with the grace that is left, so the whole stop still fits UPDATE_INSTALLER_STOP_SECS. A start that ends after the grace has run out is logged, since that child gets SIGKILL with no graceful stop. A start still pending when the grace runs out is cancelled, which falls back to asyncio's own kill. A regression test holds the pipe connection open to force the window, and a second test holds it past the grace.

Closes #21882

(cherry picked from commit 89a6107)
…hile the conductor handles it (#30991)

Co-author on main: Joe Guo
(cherry picked from commit 1ed5cf4)
Co-authored-by: w <w@k.local>
(cherry picked from commit 0140686)
Closes one more case of the gap tracked in #10716. The issue stays
open for the cases that still need their own argument.

Part of #10716

(cherry picked from commit 2b0c135)
Every streamed chunk made a new transcript, and the whole transcript
went through the slot-scoped deferred value, so each chunk scheduled a
background render of the chat page. On a slow phone the next chunk
interrupted that render every time, so the reply's text almost never
updated; on desktop it cost a second page render per chunk.

A chunk that only grows the last row renders at urgent priority:
useSlotDeferredValue takes an optional sameShape check, and
useTranscriptRows passes grewOnlyAtTail. A landed page, a new row or a
regroup is still deferred, and while one is pending the hook shows the
last value it rendered live, never an older frame. The window while a
change of shape is pending is tracked in #31704.

Builds on #23487.

Closes #23486

Co-authored-by: Pearcekieser <5055971+Pearcekieser@users.noreply.github.com>
(cherry picked from commit 9d37818)
…31445)

The artifact-deploy skill's pre-upload scans (deploy.sh, _common.sh)
and the ops ledger's pre-push scan ran get_credential_patterns()'s raw
search over whole files or lines. That search re-walks a long eyJ or
digit run from every start, so one such file or line stalls the scan
for seconds to minutes.

Export the shared linear scanner as kiro_crew.security's public
iter_credential_matches and move every caller outside the package to
it, including the two that imported the private _credential_matches.
Drop the unused get_credential_patterns re-export from the design
tweak server. Findings stay those redact_credentials sees, and a
scanner error still aborts the deploy.

(cherry picked from commit 7aaf1b1)
A guide replay ("Show again") takes a completed guide back to offered,
patching the same transcript row in place. The slot-detail merge could
not tell a stale snapshot of that row from a newer one, so a snapshot
taken before a patch redrew the card's earlier status in either
direction.

Each in-place patch of a card row now bumps meta.card.rev, and the
dashboard merge keeps the copy with the higher revision whichever way
the status moved. Copies with equal revisions keep the existing
status-anchor rule.

Closes #22795

(cherry picked from commit e702910)
…before a response (#27055)

An SSM port-forward can accept the connection and drop the stream before the peer answers; aiohttp raises ServerDisconnectedError and the dashboard shows a one-off 502 proxy_peer_unreachable while the next dial succeeds. GET/HEAD/OPTIONS now get one fresh dial for a drop or reset; refused dials, timeouts and state-changing methods are not redialled.

(cherry picked from commit f09928e)
…32370)

POST /api/update-message rewrites one of the bot's own Slack posts with
new agent-authored text, but it never asked the calling app's own
capabilities.messaging grant. Every send_message egress leg asks it at
the gateway, because the MCP tool's vet runs where no app is known. An
app whose messaging is revoked could still reach Slack by editing a
message it posted earlier.

Ask _vet_app_messaging before the target is resolved, audited under
update_message, and answer 403 channel_not_permitted like a refused send.

Co-authored-by: Leon <leon.lai.yc@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 3d72fae)
#32502)

Co-authored-by: w <w@k.local>
(cherry picked from commit 9aeb2eb)
AppManifest.from_dict read mcpServers as dict(data.get("mcpServers",
{})). A genuine non-object made that dict() raise -- TypeError on a
scalar or bool, ValueError on a non-empty list or string -- and the
exception escaped install, discovery and lookup as an uncaught 500
(install catches ValueError but not TypeError). Wrap it so a non-object
raises one clear ValueError instead.

The empty forms dict() already accepted ([] and "", which yield {}) keep
parsing to an empty map, so no manifest that parses today is newly
rejected. The raise keeps every reader that skips validate() fail-closed
exactly as before: get_app_manifest returns None on a parse error, so
the dashboard MCP-ownership PUT and the boot reconcile prune treat the
manifest as unreadable and preserve the app's live bridges rather than
reading an empty map as "declares none". The install path surfaces the
ValueError as a clean refusal.

Fixes #31178

(cherry picked from commit 359db48)
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 06:38
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 8, 2026 06:38
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/sandbox.py

  • src/kiro_crew/sandbox_argv.py

  • src/kiro_crew/sandbox_staging.py

  • src/kiro_crew/security/__init__.py

  • src/kiro_crew/security/_exports.py

  • src/kiro_crew/security/redaction.py

  • src/kiro_crew/security/redaction_patterns.py

  • src/kiro_crew/security_posture_sinks_delivery.py

  • No reasoning template for 0bcd8fa yet.

How to clear this check:

  1. The PR author posts the template below as a PR comment, with
    every field filled (N/A needs a reason). Keep the
    Head commit line: it must name the current head SHA.
  2. The check turns green within a minute, with no push.
  3. A new push resets this check: post it again for the new head.

Only the author's comment counts this way. A reviewer can instead
paste the filled template into an "Approve" review on this head.
Merging still needs a reviewer's approval.

## Sensitive change review
- Head commit: 0bcd8fa9d9447e008dd8dd3e0dc97301554c33c5
- What rule changed:
- Before -> after (what was allowed/blocked, now):
- Worst case if wrong (breaks commands / leaks secret / locks user out):
- Evidence checked (which sandbox result proves it):
- No regression:
  - Tools still work (which tools/commands were run, result):
  - Backward compatible (old config / old data / old callers still work, how checked):
  - Existing tests (which suites passed on this head):
- How to undo:

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 0bcd8fa9d9447e008dd8dd3e0dc97301554c33c5 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots of the new theme-delete dialog and the muted crew stall states. The PR changes visible UI but attaches no images, so the blind read was not performed.

Evidence gaps

  • Theme delete dialog (themeEditor.tsx askAppConfirm, title/button "Delete theme", body "Delete “{{name}}”? If it is your current theme, the default theme is used instead."). Close with a screenshot of Settings → Display with the editor open and this dialog stacked above it.
  • Crew sidebar stall line (SessionRow.tsx crew-work-stalled, now text-muted instead of --warn) and the "N stalled" count (CrewRowCounts.tsx, no longer text-danger). Close with a sidebar screenshot showing a stalled crew next to a "needs you" crew.
  • Stall line hidden while the conductor runs (handling ? 0 : …). Close with before/after sidebar shots of one crew: conductor idle, then running.
  • UltraCrewPanel quiet/stuck icons and the ultra-pulse label, now muted. Close with a screenshot of the milestone list with a stuck or quiet milestone.
  • The description says the frontend picks carry "the same rendered change as their main PRs, which show it". That cites the source PRs' images; it does not supply any for this revision. Attach the stills here.

Notes

  • Stuck and quiet now share the same muted colour and differ only by icon (AlertTriangle vs Pause). A screenshot should show the two are still easy to tell apart at 11px.

[UX-REVIEWED] 0bcd8fa

Description read

[DESCRIPTION-READ] f062a0d508ce2c8dd75a91c8c13ef761923701ebc08532970d17e4ba0d860712

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

Design-level review of 0bcd8fa9d9447e008dd8dd3e0dc97301554c33c5 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

cannot evaluate: missing a screenshot of the in-app theme-delete dialog and the crew sidebar's new red/muted states, rendered from this revision. The evidence list names nothing, and the description points only to the main PRs' screenshots.

Blockers

The new or changed UI surfaces have no rendered evidence for this revision
Trigger: themeEditor.tsx replaces the browser's confirm() with askAppConfirm({ title: …delete_theme_title, body: …delete_theme_confirm }), a second Modal stacked on the editor's. CrewRowCounts.tsx, SessionRow.tsx and UltraCrewPanel.tsx change what the sidebar and board show in red. design-evidence.txt lists 0 images and 0 recordings, and the description says only "the frontend picks carry the same rendered change as their main PRs, which show it."
Outcome: screenshots taken on main are not evidence of release/0.12.0 → the stacked dialog over the editor, with its Escape guard, and the muted-stall rendering are never seen on the branch that ships → nobody can judge whether 0.12.1's surfaces render correctly before the RC soak.
Fix: attach screenshots taken from this branch.
Clears when: the description attaches a github.com/user-attachments screenshot, taken on this branch, of the theme-delete confirm dialog open over the theme editor, and one of the crew sidebar showing a muted stall next to a red needs-you row.

Notes

  • "Manual verification: N/A" covers fix(sel): make the audit log owner-only on Windows #31703, the Windows owner-only SEL log in sel_append.py, which only runs on Windows. The description also says CI doesn't run the backend suite on PRs into release/*. A Windows check of that pick on this branch belongs in the RC soak plan.

[DESIGN-REVIEWED] 0bcd8fa

Description read

[DESCRIPTION-READ] e152f43465b0cb99fdc7e765cfc7fdf49591c500cfe4c1573019893bf20f5ec3

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 0bcd8fa9d9447e008dd8dd3e0dc97301554c33c5 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: every item is a clean cherry-pick of a fix already merged on main, and the diff carries nothing those sixteen picks don't contain.

What this change ships

Inventory (10 items) — 10 justified

Intent: bring sixteen fixes already merged on main onto release/0.12.0 so 0.12.1 users get them. This is a FIX (a backport).

  1. Slack users/channels select and /agent refuse a non-object config section instead of crashing — justified
  2. Cron warns once per job about an unresolvable timezone, not a traceback every tick — justified
  3. A live policy refresh withdraws dashboard origins the new ceiling refuses, with no restart — justified
  4. Cancelling an update while its installer is still starting stops that installer — justified
  5. Crew sidebar and goal board show red only for needs-you; a stall the conductor handles is muted — justified
  6. Status roster's history rows need a crew-log creation record for fenced callers — justified
  7. Bare /embed/chat/<key> link stays on its own chat; streaming text stays live on slow devices — justified
  8. Sandbox pre-creates refresh_chains.json so its mask mounts; SEL log gets an owner-only DACL on Windows — justified
  9. Deploy-skill, ledger and preview credential scans use the public linear iter_credential_matches (6 callers) — justified
  10. Card revision ordering, one proxied-read redial, app messaging re-check on edit, theme delete in-app dialog, and a clear error for a non-object mcpServers — justified

[FIRST-PRINCIPLES-REVIEWED] 0bcd8fa

Description read

[DESCRIPTION-READ] 53d45c0afaff00709806f05040d87a66b0e274d1049a5668fb142e7f6fc60631

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Security Scope Review -- ✅ PASS

Which legitimate operations does 0bcd8fa9d9447e008dd8dd3e0dc97301554c33c5 newly refuse? Updated in place on each push. A script-confirmed regression blocks; the model proposes candidates and never decides a refusal.

Verdict basis: adjudicated, zero confirmed regressions.

Security scope review -- adjudicated candidates

  • macos-latest (platform posix): 11 classified, 0 newly refused, 11 still allowed.
  • ubuntu-latest (platform posix): 11 classified, 0 newly refused, 11 still allowed.
  • windows-latest (platform windows): 4 classified, 0 newly refused, 4 still allowed.

No candidate flipped from allowed to refused.

Scope-Verdict: PASS

Reason: The patch does not touch the shell-command deny checks (sensitive-bash, exfil, deny-rules in src/kiro_crew/hooks.py), so the 15 shell candidates can only measure the area around those checks. The stricter guards it adds sit outside those checks and cannot be classified: the live dashboard-origin withdrawal, the app messaging-grant check on update_message, the history-roster ownership fence, the refresh_chains.json mask stub, and the Windows owner-only DACL on the audit log. They are named under UNADJUDICATED. No regression is confirmed and no gap is shown with a call path.

TIGHTENING: The main one is the live removal of dashboard_origins on a policy refresh. It stops a dashboard origin that an updated governance ceiling refuses from staying trusted until the next restart. The hunk is src/kiro_crew/dashboard/origin.py: refused = {o for o in allowed - kept() if not origin_permitted(o) and not origin_permitted(o, audit_tool="dashboard_origin")} … loop.call_soon_threadsafe(lambda: allowed.difference_update(refused - kept())).

ADJUDICATED: 15 candidates, 0 confirmed newly-refused

PLATFORM COVERAGE: posix (11 rows) covers the operations maintainers run in the touched areas: the new and neighbouring tests, check_lockdown_before_publish.py, artifact-deploy deploy.sh (its credential scan now calls iter_credential_matches), a data-home listing, kirocrew doctor, kirocrew cron list, a loopback Origin probe, and the website vitest run. windows (4 rows) covers the one Windows-specific assumption in the patch, the platform_compat.restrict_to_owner DACL in sel_append.py, which checks volume_is_local when called on the event loop. Those rows use %USERPROFILE% with \ separators, icacls, kirocrew.exe, and a test\… pytest path. No row is any, because every row names an executable or a path. A UNC or mapped-drive data home is assumed by the new non-local-volume branch, but no shell row can reach that branch; it is listed below.

UNADJUDICATED:

  • origin.withdraw_refused_origins (origin gate). Call path: governance poller confirms install or unchanged → post-install hook registered in service_boot.run → withdraw_refused_origins(app, loop) → origin_permitted(o) for each extra in app["allowed_origins"] minus origin_floor(port, tailnet) ∪ tailnet_direct().urls → removal from the set on the loop → check_origin/check_host. Inputs I would have submitted:

    • a configured https://crew.example.com:443 that is stored as https://crew.example.com and must still match its policy entry when asked again in the stored form;
    • an IPv6 extra http://[2001:db8::1]:8080;
    • the connected tunnel URL, which was approved at connect;
    • a kirocrew.localhost origin on a port other than the bound one.

    Open point: the hook asks again using the stored (browser-serialized) spelling, not the configured one. An oss glob policy written against the configured spelling could therefore withdraw an origin that was approved at start. I can argue this but not confirm it.

  • api_update_message → _vet_app_messaging(..., tool_name="update_message") (messaging egress grant). Call path: POST /api/update-message → effective_request_app(state, request) → capabilities.messaging asked fail-closed → 403 channel_not_permitted. Inputs I would have submitted:

    • the person's own dashboard edit (empty app, which should not be asked);
    • an app with messaging granted editing its own post in a tracked channel;
    • an edit to the owner DM from an app that holds the grant.
  • _created_history_roster(..., ownership_fenced) (history ownership fence). Call path: created_session_status → worker thread → _creation_parent(slot_key) must equal caller_key. Inputs I would have submitted:

    • a fenced member caller listing its own archived sessions with the crew log disabled (now dropped and marked incomplete);
    • sessions created before the crew log was seeded.
  • _materialize_refresh_chains_mask_target (sandbox mask staging). Call path: namespace_argv → _create_absent_mask_target("refresh_chains.json", b"{}") with O_EXCL. Inputs I would have submitted:

    • a home where the operator's store already exists as a symlink managed by dotfile tooling;
    • a read-only data home, where creation fails and only warns.
  • sel_append._append_lines_locked Windows DACL. Inputs I would have submitted: an append on the event loop to a \\server\share or mapped-drive data home (DACL skipped with a warning), and the same append from a worker thread (DACL applied over SMB).

  • AppManifest.from_dict mcpServers type check (install validator). Inputs I would have submitted: "mcpServers": [] and "mcpServers": "", both still {}; an object map. A manifest written by an older build with "mcpServers": null now raises, so the app becomes unreadable and its install is refused.

[SCOPE-REVIEWED] 0bcd8fa

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 0bcd8fa9d9447e008dd8dd3e0dc97301554c33c5 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 0bcd8fa

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 0bcd8fa9d9447e008dd8dd3e0dc97301554c33c5 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 0bcd8fa9d9447e008dd8dd3e0dc97301554c33c5 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 0bcd8fa

Verdict parsed from the review's SHA-scoped output markers for commit 0bcd8fa9d9447e008dd8dd3e0dc97301554c33c5.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 0bcd8fa9d9447e008dd8dd3e0dc97301554c33c5 false-positive: <reason, 20 to 500 characters>

@buluoray
buluoray merged commit 19bd79b into release/0.12.0 Nov 8, 2026
26 of 30 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-fast-v2b-2 branch November 8, 2026 06:50
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants