Skip to content

fix: backport 0.12.1 wide batch 6 (11 user-facing fixes + 1 prerequisite) - #32984

Merged
buluoray merged 12 commits into
release/0.12.0from
crew/slack/0.12.1-wide-6
Nov 8, 2026
Merged

buluoray merged 12 commits into
release/0.12.0from
crew/slack/0.12.1-wide-6

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring eleven fixes for problems a 0.12.0 user can hit, merged on main after v0.12.0, onto release/0.12.0, with the one main commit one of them needs first, one commit each, in a PR of its own.

Why it matters

Each fix changes behaviour a 0.12.0 user can run into today. Every pick applied to release/0.12.0, with only the catalog hunk listed under "What changed" resolved by hand, so the code each one replaces is on release.

PR Reported by What a 0.12.0 user sees today
#30880 chenmingwei23 (#30851) Dashboard chat blocks while sub-agents run, and the async "N agents" card does not appear.
#26915 rohnkum (#26912) Listing your own WhatsApp number in allowed_wa_ids makes the agent refuse to DM you as "ambiguous".
#31037 RohanK6 (#31032) Knowledge ingest-text returns a 500 when name is not a string.
#31107 RohanK6 (#28955) A non-UTF-8 installed-app or grants file raises instead of reading as unreadable.
#30714 RohanK6 (#30706) Settings > MCP pre-install result says "server(s)" instead of a real plural. Also the prerequisite of #31156.
#31156 CrysisDeu (#30351) "Update now" for npm pre-install says "Already up to date." when every install failed.
#30848 CrysisDeu (#30397) The snapshot command fails when the memory store is read-only by file permissions.
#31197 RohanK6 (#31192) Changing the embedding model shows a raw TypeError when config memory is not an object.
#31065 CrysisDeu (#29815) The update command on a git install skips the dashboard rebuild when Node came from ensure-node.sh.
#31052 bolichen97 A channel token check fails for users behind the channel's proxy.
#30992 rubencu (#30068) Under the installed Linux service, an app's Open says Kiro Crew is running remotely on a desktop host.
#31081 bolichen97 Long chats slow down because settled turns keep every folded tool pill mounted.

Not a goal

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ 19bd79b4a8, in merge order on main, one commit each. #30714 sits right before #31156: #31156's component line and test call resolve_all_failed with count, which only #30714's plural catalog entry reads. Without it, #31156's new test fails on release.

# PR main commit release commit
1 #30880 steer model to spawn_run by default, not spawn_sub_agents 559ae18e98 bf3b5c407d
2 #26915 dedupe the operator's own WhatsApp number 6c62426388 a2cd955427
3 #31037 keep a non-string ingest-text name from failing the ingest 8a8272489f 1d385984d2
4 #31107 read a non-UTF-8 install record or grants file as unreadable 3922b02a5e aa5300bb33
5 #30714 pluralize the MCP pre-install server counts 7785e9c4f0 eadcd6151a
6 #31156 count unresolved npm pre-installs as failures 4f9738e6c5 03b5a18642
7 #30848 stage a permission-read-only store's database writable 9694b2482a b596a41a92
8 #31197 refuse a model change when the config memory section is not an object b91ee25926 d4f5a9451e
9 #31065 put the node ensure-node.sh records on PATH during the update command 55e8007971 118bf09175
10 #31052 verify channel tokens through the channel's proxy 81d35e178f cb90458270
11 #30992 open an app's window under the installed linux service 0f93202938 dd72dcad10
12 #31081 stop settled turns keeping every folded tool pill mounted 323c4f65ec 7b1fda8da7

Hand-resolved hunk, not product code: #30714 in website/src/i18n/pluralKeys.json. Its two keys (resolve_all_failed, resolve_ready) were appended. The securityPanel.rule_count line beside them on main comes from a commit not on release, so it was left out. #30714 is authored with the public identity because the commit guard refuses the original address on a hand-resolved pick; its message names Rohan Khanderia. #31156's co-author trailer carried an internal host address and is rewritten as a plain "Co-author on main" line.

Backwards compatibility

Compatible: each change is the one already merged on main, and its compatibility note applies unchanged.

Removes nothing: no setting, key or caller is removed. #31197 refuses a model change while config memory is not an object, which today fails with a raw TypeError instead.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the related set was run here. Every touched test file plus the test files that import a touched source module, 81 files, gave 3,338 passed and 4 failed. The same 4 fail on a clean release/0.12.0 @ 19bd79b4a8 on this host: three test_cli.py::TestDoctor cases and test_gateway_secret_senders_prove_peer.py::TestArtifactSendsThroughThePeerProof::test_list_goes_through_the_proof.
  • Frontend: tsc -p tsconfig.app.json --noEmit passes. vitest on the touched test files gave 114 passed (mcpResolveCountPlural, McpManagement.resolveOnce, the TurnBlock files). gen-ui-index --check and check-i18n-strings pass.
  • flake8, isort, black gate, subprocess-encoding gate, mypy src/kiro_crew and check_harness_parity.py pass. check_file_line_cap fails only on dashboard/chat_api/resume.py, which is already over the cap on release and is not touched here.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: the frontend picks (#30714, #31156, #31081) carry the same rendered change as their main PRs, which show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #30880, #26915, #31037, #31107, #30714, #31156, #30848, #31197, #31065, #31052, #30992 and #31081. Source issues: #30851, #26912, #31032, #28955, #30706, #30351, #30397, #31192, #29815, #30068.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

chenmingwei23 and others added 12 commits November 8, 2026 06:58
…#30880)

The spawn_sub_agents description said 'Preferred over spawn_run when you
need results before continuing', which steered models to pick the blocking
tool by default. This caused dashboard chats to block while sub-agents ran
(issue #30851).

The description now says 'Use spawn_run instead unless the user explicitly
asks to wait' -- spawn_run keeps the chat responsive and shows a task card.

PR #29284 made KAS the default harness, making this blocking behavior
visible to more users.

Closes #30851

Co-authored-by: Raymond Chen <chenmingwei23@users.noreply.github.com>
(cherry picked from commit 559ae18)
… is not misread as ambiguous (#26915)

Closes #26912

(cherry picked from commit 6c62426)
…ngest (#31037)

POST /api/knowledge/sources/{id}/ingest-text passes the body's name to
the pipeline, which reads it as a file path, so a number, boolean, list
or object name failed the whole ingest with a 500. A list or object
namespace failed the same way when SQLite could not store it. Fall back
to the source's own name and to the default namespace instead. Values
that work today are unchanged.

Fixes #31032

(cherry picked from commit 8a82724)
…le (#31107)

An installed.json or approved-grants.json whose bytes are not UTF-8
raised UnicodeDecodeError out of the app manager's record readers,
which catch only bad JSON and OS errors. Such a file now reads like a
corrupt one: the install record as not installed, the grants file as
approving nothing.

Closes #28955

Co-authored-by: Gary Jennings <8486704+dodgeblaster@users.noreply.github.com>
(cherry picked from commit 3922b02)
Settings > MCP reports the result of "Pre-install npm servers" with
"{{ready}} server(s) pre-installed." and "Could not pre-install
{{failed}} server(s)." The (s) shortcut reads wrong for one server in
English and is copied into French, Spanish and Portuguese as
serveur(s) and servidor(es), while Russian had to dodge the plural
with a colon.

Make both strings plural catalog keys that take the count, with the
forms each language needs, so one server reads "1 server
pre-installed." and Russian gets 1 сервер, 3 сервера, 5 серверов.
(cherry picked from commit 7785e9c)

Originally authored on main by Rohan Khanderia (RohanK6); authored here with the public identity because the commit guard accepts only that identity on a hand-resolved pick.
* fix: count unresolved npm pre-installs as failures

* test: match the pluralized pre-install failure count

---------

Co-author on main: Jacob Largent.
(cherry picked from commit 4f9738e)
…#30848)

A store made read-only by file permissions (chmod a-w), not by a read-only
mount, failed kirocrew snapshot with "attempt to write a readonly database"
while the same layout on a read-only mount gave rc 0.

The source read already handled the read-only case: a closed WAL database that
SQLite cannot open mode=ro is read immutable. The failure was on the
DESTINATION. The staging tree walk copies each file with the SOURCE file's
mode, so the byte copy of a 0o444 store database is itself 0o444, and the
read-write open that writes the consistent copy over it is refused. On a
read-only mount the files keep an ordinary mode, so that copy stays writable.

Restore owner write on the staged copy before the consistent copy overwrites
it. The copy is this process's own file in its private staging tree; the live
store is never touched. Covered for WAL and delete journal modes.

Co-authored-by: kirocrew-agent <agent@kirocrew.local>
(cherry picked from commit 9694b24)
…te (#31065)

ensure-node.sh records the node bin dir it chose in
<data home>/node-bin-dir, but the process that ran it kept its own PATH.
On a git install whose Node came from that script (a mise install off
the shell's PATH), kirocrew update then looked npm up on PATH, printed
"npm not found -- skipping frontend build" and still reported success,
leaving the previous dashboard bundle in place.

After the Node check, the update now puts env.node_bin_dirs() first on
its own PATH, so the build's npm lookup and npm's own node both find
that toolchain. The gateway's boot-time Node repair is left as it was.

(cherry picked from commit 55e8007)
…1052)

On a host that reaches the internet only through HTTPS_PROXY, saving a
new Discord, Telegram or Webex bot token reported the service as
unreachable and stored the token unverified, while the running channel
connected fine. The token checks opened a plain aiohttp session, which
ignores the proxy environment, and dialed directly.

Each check now passes the proxy its own channel client uses: the Discord
and Webex clients' _resolve_proxy, and for Telegram the client's
forward-proxy rule, which skips the proxy for a loopback API base so the
token never leaves the machine. The messaging spec names the rule for
each save route.

Part of #20185

(cherry picked from commit 81d35e1)
…0992)

An app's Open action decided "remote" from the gateway's own
environment only. The installed Linux service is a system unit, so its
environment never names a display server, and every Open on a desktop
host answered "Kiro Crew is running remotely" instead of launching.

When the gateway names no display, ask the desktop session the user's
systemd manager names, the same checked lookup the file manager already
uses, and launch when it is live. The launcher gets that session's
display, X cookie and desktop name; the session never supplies a bus
address, so the child's bus reach is unchanged.

(cherry picked from commit 0f93202)
…31081)

With "Show Thinking Inline" off (the default), a finished turn folds its
working steps behind "Worked through N steps", but every folded tool
pill stayed mounted: hidden at zero height, still in the DOM and still
subscribed to the store. A turn with 100 tool calls kept about 2,000
hidden elements, and the transcript keeps several such turns mounted,
so the chat page's DOM grew with every tool-heavy turn.

A settled fold now drops the content of its folded tool rows in every
fold mode, as the fold already did with "Show Thinking Inline" on. The
row element stays, so opening the fold mounts the pills again; rows
that can still go live (running, an MCP App, a pill the user opened)
keep their content as before.

Part of #23281

(cherry picked from commit 323c4f6)
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 07:07
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 8, 2026 07:07
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 7b1fda8da76ee588d713289180d718052c1e25a7 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: these are faithful cherry-picks of fixes already merged on main. The only hand-resolved hunk is a catalog append, and no surface is added or reshaped.

Notes

[DESIGN-REVIEWED] 7b1fda8

Description read

[DESCRIPTION-READ] bf6cd9c55029a186266c51de607f1b182f7d7a15ad660278763e985388d35499

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 7b1fda8da76ee588d713289180d718052c1e25a7 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots for the changed MCP pre-install messages and the tool-row fold. No blind read was done because the PR attaches or commits no image.

Evidence gaps

  • Settings > MCP > "Pre-install npm servers" result messages. The new plural strings ("Could not pre-install {{count}} server." / "…servers.", "{{count}} server pre-installed." / "…servers pre-installed.") and the case where every install fails now show an error where they used to show "Already up to date." No screenshot shows any of this. To close it, attach stills of the all-failed (1 and N), success (1 and N) and partly-ready messages to this PR. The PR's note that the main PRs have screenshots does not count as evidence for this revision.
  • Chat TurnBlock folding a settled tool row in every mode, not just default. These rows now close at once instead of easing shut: "except a settled tool row whose content the fold drops…, which closes at once". No recording shows this. To close it, attach a recording of a long settled turn folding and unfolding in a non-default mode. Also say in the PR description why skipping the animation is acceptable there.

Notes

  • The <!-- no-visual-delta --> marker is wrong for this PR. Both the copy and the fold behaviour change on screen.

[UX-REVIEWED] 7b1fda8

Description read

[DESCRIPTION-READ] 9d549df1da917c501ecaec1c628baea56d032d3360e143d07a43e0c660fed0f5

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 7b1fda8da76ee588d713289180d718052c1e25a7 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: each item is a cherry-pick of a fix already merged on main, and each one has a linked issue or a test that pins it.

Notes

What this change ships

Inventory (10 items) — 9 justified

Intent: Bring eleven user-facing 0.12.0 fixes, plus one prerequisite, from main onto release/0.12.0. This is a FIX. The change has 12 items; the two not listed are #31107 (a non-UTF-8 record reads as unreadable) and #31065 (Node is put on PATH during update). Both are justified.

  1. The agent now uses non-blocking spawn_run for delegation by default, so chat no longer blocks — inherited (already on main)
  2. Your own WhatsApp number in allowed_wa_ids no longer reads as "ambiguous" — justified
  3. A non-string ingest-text name no longer returns a 500 — justified
  4. The MCP pre-install counts now use real plurals — justified
  5. "Update now" no longer says "Already up to date" when every install failed — justified
  6. The snapshot command works on a store made read-only by file permissions — justified
  7. Changing the embedding model refuses cleanly when config memory is not an object — justified
  8. The channel token check goes through the channel's proxy — justified
  9. An app's Open works under the installed Linux service — justified
  10. Settled turns unmount their folded tool pills in every mode, and the old "stay mounted" test pins are reversed under fix(chat): stop settled turns keeping every folded tool pill mounted #31081 — justified

[FIRST-PRINCIPLES-REVIEWED] 7b1fda8

Description read

[DESCRIPTION-READ] 1933959ea2c6c6891bec4131ea55eebbcc56b79eb8f568d03c10c8d56c40aaf4

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 7b1fda8da76ee588d713289180d718052c1e25a7 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 7b1fda8

Verdict parsed from the review's SHA-scoped output markers for commit 7b1fda8da76ee588d713289180d718052c1e25a7.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 7b1fda8da76ee588d713289180d718052c1e25a7 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 7b1fda8da76ee588d713289180d718052c1e25a7 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 7b1fda8

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 7b1fda8da76ee588d713289180d718052c1e25a7 false-positive: <reason, 20 to 500 characters>

@buluoray
buluoray merged commit a0b61da into release/0.12.0 Nov 8, 2026
19 of 31 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-wide-6 branch November 8, 2026 08:13
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants