Repository navigation
fix: backport 0.12.1 fast batch v2b-3 (20 fixes, 4 docs/tests conflicts resolved) - #32991
Conversation
A command that writes a raw disk with no input file was allowed while the deny list claimed to cover it. It is refused now; ordinary file writes, searches and commit messages that quote it stay allowed. (cherry picked from commit 7328a22)
…#30848) A store made read-only by file permissions (chmod a-w), not by a read-only mount, failed kirocrew snapshot with "attempt to write a readonly database" while the same layout on a read-only mount gave rc 0. The source read already handled the read-only case: a closed WAL database that SQLite cannot open mode=ro is read immutable. The failure was on the DESTINATION. The staging tree walk copies each file with the SOURCE file's mode, so the byte copy of a 0o444 store database is itself 0o444, and the read-write open that writes the consistent copy over it is refused. On a read-only mount the files keep an ordinary mode, so that copy stays writable. Restore owner write on the staged copy before the consistent copy overwrites it. The copy is this process's own file in its private staging tree; the live store is never touched. Covered for WAL and delete journal modes. Co-authored-by: kirocrew-agent <agent@kirocrew.local> (cherry picked from commit 9694b24)
…1052) On a host that reaches the internet only through HTTPS_PROXY, saving a new Discord, Telegram or Webex bot token reported the service as unreachable and stored the token unverified, while the running channel connected fine. The token checks opened a plain aiohttp session, which ignores the proxy environment, and dialed directly. Each check now passes the proxy its own channel client uses: the Discord and Webex clients' _resolve_proxy, and for Telegram the client's forward-proxy rule, which skips the proxy for a loopback API base so the token never leaves the machine. The messaging spec names the rule for each save route. Part of #20185 (cherry picked from commit 81d35e1)
…0992) An app's Open action decided "remote" from the gateway's own environment only. The installed Linux service is a system unit, so its environment never names a display server, and every Open on a desktop host answered "Kiro Crew is running remotely" instead of launching. When the gateway names no display, ask the desktop session the user's systemd manager names, the same checked lookup the file manager already uses, and launch when it is live. The launcher gets that session's display, X cookie and desktop name; the session never supplies a bus address, so the child's bus reach is unchanged. (cherry picked from commit 0f93202)
…31081) With "Show Thinking Inline" off (the default), a finished turn folds its working steps behind "Worked through N steps", but every folded tool pill stayed mounted: hidden at zero height, still in the DOM and still subscribed to the store. A turn with 100 tool calls kept about 2,000 hidden elements, and the transcript keeps several such turns mounted, so the chat page's DOM grew with every tool-heavy turn. A settled fold now drops the content of its folded tool rows in every fold mode, as the fold already did with "Show Thinking Inline" on. The row element stays, so opening the fold mounts the pills again; rows that can still go live (running, an MCP App, a pill the user opened) keep their content as before. Part of #23281 (cherry picked from commit 323c4f6)
…e port (#31018) When the browser cannot reach a remote crew pane's port, the pane error now prints one ssh -L line with every crew pane port, so one paste fixes every pane instead of one failure per crew. The dashboard port stays out: the browser sees only its local end, so a same-number forward for it could aim at the wrong gateway port. Closes #31012 (cherry picked from commit 2327f14) Co-author on main: Bolin Chen
…31829) A Spec Builder delete whose transcript archive fails, and Create's orphan recovery when a worker outlives its cancel, put the popped slot back under its key unconditionally. Between the pop and that put-back the key is free, so any opener can mint a new slot under it, and the put-back then overwrote that live slot. Put the slot back only while the key is still free, as close_slot and the idle sweep already do. (cherry picked from commit 923189f)
…ow (#31621) An app's ChatEmbed reads the agent's ask_question card by polling GET /api/chat/slots/{slot}/question; it is sent no question_card frame. open_agent_ask counted only dashboard sockets, so with no dashboard tab connected (an app in its own window) the ask was withdrawn at once and the agent fell back to plain text before the embed could poll it. Each read of that route that passes its existing checks now stamps the slot, and an ask that reaches no socket is kept while that stamp is at most 20 s old (twice the embed's slowest poll). Writer and reader use the coordinator's one clock, and the stamp lives on the slot, so it goes away with it. Closes #25379 (cherry picked from commit 90621cc)
…31789) A file-picker debounce timer armed for an earlier query (the '' a pick leaves behind) could fire after a newer query had committed but before the effect cleanup cleared it. Publishing that stale query moved the search key off the newer query's in-flight fetch, cancelling it, so the old root's placeholder rows showed as settled and a click relativized against the wrong project. The timer now publishes only the query that is still current. (cherry picked from commit a04855d)
Co-authored-by: w <w@k.local> (cherry picked from commit 4c8274f)
) taskq_settle built result_ref by calling agent_dir_for_display, which resolves the run directory with two realpath calls. That ran on the event loop for every finished subagent, even though the finish itself is posted to the task-store writer thread. On Windows realpath opens every path part, so a busy disk stalled the loop for tens of seconds and the loop-stall watchdog ended the gateway. The path is now built inside the job that runs the finish, so the posted path does it on the writer thread. The row_settled path, which never writes the row, no longer builds it at all. Closes #31768 (cherry picked from commit 9a9b540)
…30516) Importing a config in Replace mode, deleting or dismissing a skill, dismissing all pending skills, and deleting a steering file asked through the browser-native confirm(). In the desktop app that is an OS dialog that blocks the renderer, and on Windows the window can stop taking keyboard input after it closes until it is re-activated (#15976). The Portability, Skills and Steering tabs now ask through the in-app useConfirm dialog. The title is a short action label and the unchanged question is the dialog body, because Modal truncates a title to one line. Each action captures its target before it waits and acts only on a true answer: the chosen import file, mode and memory choice, the skill key, the candidate and its reviewed digest, the candidate queue shown when the question opened, and the steering file with its slot and project. Steering deletion keeps invalidating every steering listing and keeps evicting every cached copy of a deleted user file. For a workspace file it now evicts only the captured project's copies, so another project's file with the same name keeps its cache. The query client sets staleTime: Infinity, so an entry left in the cache is not refetched on its own. Switching the Skills tab to the budget view, including through browser history, or the owning candidate row disappearing, cancels its pending question. Remove the three files from the native-dialog allowlist. Part of #15976 (cherry picked from commit c6d7c36) Co-authored-by: abirkel <34585063+abirkel@users.noreply.github.com>
…32090) kiro_default, kiro_planner and kiro_guide are built into kiro-cli, so no spec file defines them, and a KAS session for one was refused as a missing agent definition with no way forward. KAS has no safe match: its own closest modes decide some tool calls without asking Crew. The KAS harness now refuses them with a reason that names the agent as a kiro-cli built-in and names Kiro Crew's default agent to pick instead. An app that declares the same name keeps its app-aware refusal. Fixes #32006 Co-author on main: Joe Guo (cherry picked from commit c6da224)
…31970) A bounded slot-detail read served the disk copy of every row it matched to the live window by id, so an in-place edit the save had not flushed yet (a variant switch whose save failed and waits for the next flush) repainted the text the user had just switched away from. The no-limit read serves the window and showed the right text, so the two disagreed. The id walk now serves the window's copy of a row it matched, when the id appears once in the disk region; a repeated caller-supplied id keeps the disk copies. Rows disk holds that the window does not (another writer's append) stay where disk put them, so row counts, total and next_before do not change. Part of #7526 (cherry picked from commit fd51cbc)
The command palette's Skills tab listed the unscoped catalog while a $token only expands for a skill in the chat agent's own skill:// mapping, so the palette could insert a token that is sent as literal text. With a chat open it now asks /api/skills with that chat's session key and agent (the default template for a chat with none), as the $ picker does, leaves out a project skill the operator has not trusted, and keys its result cache on that scope so another chat's list is never served. The spec sentence that still called $-token expansion global is corrected. Closes #6027 (cherry picked from commit 959bc04) Co-author on main: Bolin Chen
On a crewmate's private store, consolidation saves a changed fact as a proposal for the owner. propose_conflict reused a pending row only when the source matched, but consolidation proposes as consolidation:<session> with a per-span source_ref and a fresh confidence, so every session filed the same proposal again and one record collected dozens of them. A pending proposal is now reused when it makes the same change at the same base revision and operation, with provenance (source, confidence, source_ref, observed_at and the row's updated_at clock) set aside. Part of #29663 (cherry picked from commit b42bb2d)
Laya's local server refuses a Choice of more than 100 options and a request whose options add up to more than 512, and the browser point sent up to 200 per Choice, so on Laya a target-only op ended as needs_ref and the reflex loop got no answer on a busy page. Cap the pick Choice and each reflex target head at 100 options for every provider, as skills.select already does. The reflex cap counts options rather than elements, since a dropdown row adds up to 50, and a dropdown is offered whole or not at all, so a reflex request carries at most 465 options. Closes #30973 (cherry picked from commit 136d7a2)
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This is a backport of twenty fixes already merged on What this change shipsInventory (10 items) — 10 justifiedIntent: give 0.12.x users twenty fixes that are already on
[FIRST-PRINCIPLES-REVIEWED] 8f23b55 Description read[DESCRIPTION-READ] 339d0d5be6a3262feaf98923dcd37795383209bd5050a20d7b1e289cd33c6311 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing screenshots of the user-visible changes. No image was supplied, so the blind read was not performed, and "the main PRs show it" is not evidence this lane can admit. Evidence gaps
All five could come from re-attaching the source PRs' images to this description, which is the only revision this lane reviews. Notes
[UX-REVIEWED] 8f23b55 Description read[DESCRIPTION-READ] 20b3fac01ecb753c8164f01f7203b46f18d1497ec051f6ce779f5eb090acef10 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)Design-level review of Design-Verdict: PASS cannot evaluate: missing a screenshot of the in-app confirm dialogs and the Knowledge upload refusal as they render on BlockersNo rendered evidence of this revision for the reshaped Settings and Knowledge surfaces Notes
[DESIGN-REVIEWED] 8f23b55 Description read[DESCRIPTION-READ] e87d1976c945e7a1d850bbfc8f917181a8a09afe9fd001f6347cb8bc6239c374 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Security Scope Review -- ✅ PASSWhich legitimate operations does Verdict basis: adjudicated, zero confirmed regressions. Security scope review -- adjudicated candidates
No candidate flipped from allowed to refused. Scope-Verdict: PASS Reason: Both tightenings are in the shell deny composite, so the classifier can check them. No script-confirmed regression was handed to this review. One overlap is deliberate and is not written as a row: on posix, an ordinary push with an unquoted variable before the subcommand (a worker writing TIGHTENING: Two mechanisms got stricter. ADJUDICATED: 27 candidates, 0 confirmed newly-refused PLATFORM COVERAGE:
UNADJUDICATED: The deliberate overlap was left out of the candidates on purpose. Writing it as a row would admit the threat shape:
[SCOPE-REVIEWED] 8f23b55 |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: Bring twenty fixes for problems a 0.12.0 user can hit, merged on
mainafterv0.12.0, ontorelease/0.12.0, one commit each, in a PR of its own.Why it matters
Each fix changes behaviour a 0.12.0 user can run into today. Their code applies to
release/0.12.0cleanly; where a pick conflicted, the conflict was only in a doc, a test, translator notes or a generated index.Not a goal
main; nothing is changed only here.CHANGELOG.mdchange.What changed (motivation → approach → change)
Each main squash commit was cherry-picked with
-xontorelease/0.12.0@19bd79b4a8, in merge order onmain, one commit each. Sixteen applied cleanly and keep their original author. Four conflicted only outside product code and were resolved by hand:A hand-resolved commit is authored by the batch owner, because the commit guard refuses any other author identity, and names the original author in a
Co-authored-by:trailer (or a plain "Co-author on main" line where their address is internal).0b2b1b5837eef2edc01f7328a22fa63446b4492b9694b2482ac0b733210b81d35e178ff7018832c20f932029386303b2cfdd323c4f65ecccd2aafb1a2327f144f9bcd3b51d2e4b5126a6e855d8d9e506923189f0064cbc2d9fb790621cc9d3294157794aa04855dde0a0671a4ce64c8274fc1699250ad05a9a9b54032145bb214c27c6d7c365e38a11573b1dc6da22420880bc423eb0fd51cbcd85d91e6866b8fc1110cbdc0bcf5c56f5959bc047fd03c749a703b42bb2d889a8fd47d53d136d7a22188f23b5585fBackwards compatibility
Compatible: each change is the one already merged on
main, and its compatibility note applies unchanged.Removes nothing: no setting, key or caller is removed.
Tests
Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs
release/*, so the direct test modules were run here: the 20 Python test files these picks touch gave 1,196 passed, 4 skipped and 2 xfailed.tsc -p tsconfig.app.json --noEmitpasses; the 19 vitest files these picks touch gave 469 passed;gen-ui-index --checkandlint:i18npass.mypy src/kiro_crewandscripts/docs-lint.shpass.Manual verification
N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.
Screenshots / video
Why no screenshot: the frontend picks carry the same rendered change as their main PRs, which show it.
Related Issues
Backport to the 0.12 line for 0.12.1 of #30296, #30771, #30848, #31052, #30992, #31081, #31018, #30774, #31829, #31621, #31789, #31985, #31774, #30516, #32090, #31970, #31601, #31949, #32402, #32246.
Sibling sweep
Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.
Pattern harvest
Not generalizable: this PR only carries fixes already on
main. The source PRs have their own harvest.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.