Repository navigation
fix: backport 0.12.1 fast batch v2b-4 (9 user-facing fixes) - #33019
Conversation
Co-author on main: Zejiang Guo (cherry picked from commit 0846b6a)
A reply's last word stays on screen while a tool runs only when it is one plain word ending a sentence. Decide that with an exact check of each character, and pin, for every shape the redactor removes, that a value written right after such a word, with the pause there or at any dot inside the value, never reaches a row, the stream or the saved reply unredacted. (cherry picked from commit a1ff905)
The loader reads a slack.allowed_users entry such as {"user_id": "U1"}
as user U1, but _update_config_list matched only on slack_id. So the
Deny and Remove buttons dropped U1 from the running allowlist and
reported success while config.json kept the entry, and U1 was allowed
again after a restart. The matcher now also matches a user_id key
standing in for an unusable slack_id, for remove and for the
duplicate check on add.
(cherry picked from commit d449b7e)
…32454) load_registry promises that one bad profiles.json cannot 500 every route that reads the registry. Its three reads caught json.JSONDecodeError and UnicodeDecodeError only, so a file nested past the interpreter's recursion limit (RecursionError) or holding a number past the integer digit limit (a plain ValueError) escaped every reader. The locked writer caught ValueError but not RecursionError, so a nested file raised out of a profile save instead of being moved aside. Each read now catches ValueError and RecursionError, and the locked writer sets a nested file aside to <name>.corrupt-<utc> before the save, as it already does for truncated JSON. Builds on #29252. Closes #29089 (cherry picked from commit 32ce0d8)
…32478) The work-ledger rebuild refuses while any session crew-log unit has an unreadable header. The count walked every child of the session root, including the projections/ folder the session tree saves its checkpoint in, so every rebuild on a home with that checkpoint refused with crew_log_incomplete. Skip that folder by name, as the session tree's seed scan already does; a real unit with an unreadable header still refuses. Closes #30321 (cherry picked from commit 535df79)
(cherry picked from commit 87266ea)
Three readers of the agent-writable registry cache directory (the manifest cache, the external registry cache and the clone-failure record) let RecursionError from json.loads escape. A body nested deeply enough to exhaust the decoder's stack then dropped a registry from the App Store listing or ended the store-art prewarm batch, instead of reading as "no record" as every other malformed body does. Each reader's except now lists RecursionError, matching the readers #22300 already guarded. Closes #22359 (cherry picked from commit 94de517)
…32238) An SVG artifact can carry its own stylesheet, and when it was drawn in the viewer or on its library card that stylesheet could change the rest of the dashboard and its printouts. Those stylesheets are now left out, so an SVG styled that way shows without its stylesheet instead. Closes #31600 (cherry picked from commit f26fb97)
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the diff adds or changes no user-visible control or label. The changes are key-repeat guards, focus return after Keep, skipping the mic warm-up, and stripping Notes
[UX-REVIEWED] 137ff18 Description read[DESCRIPTION-READ] c3d844c11f7d92c2be3489315b2dba7375429edb499463eb90e7883910c5b337 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This is a clean backport of nine fixes already merged on Notes
What this change shipsInventory (9 items) — 9 justifiedIntent: give 0.12.x users nine user-facing fixes already on
[FIRST-PRINCIPLES-REVIEWED] 137ff18 Description read[DESCRIPTION-READ] f662ac0027d477d4696cc8a34c941e7a14e9a6757a62674e76daed78ffa6c556 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Clean-pick backport of nine fixes already on Notes
[DESIGN-REVIEWED] 137ff18 Description read[DESCRIPTION-READ] e8912c8d98d81f0e38448dc465b8792fe5b4fc209daf182dee60c8ce50aa0507 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: Bring nine fixes for problems a 0.12.0 user can hit, merged on
mainafterv0.12.0, ontorelease/0.12.0, one commit each, in a PR of its own.Why it matters
Each fix changes behaviour a 0.12.0 user can run into today. Every pick applied to
release/0.12.0cleanly, so the code each one replaces is on release.Not a goal
main; nothing is changed only here.CHANGELOG.mdchange.What changed (motivation → approach → change)
Each main squash commit was cherry-picked with
-xontorelease/0.12.0@2fc09a0f42, in merge order onmain, one commit each. Every pick applied cleanly, and every commit keeps its original author.0846b6a96956cf197a57a1ff905a979eba07fd60d449b7e44f844dabc6a8f05f9fb1cf8095d18b8332ce0d8c09c6dd313c96535df79ba159966d258f87266ea666a105a286cb94de517a9bcedaa6b194f26fb971d0137ff18b86Picks whose co-author trailers carried internal addresses have each trailer rewritten as a plain "Co-author on main: " line, because the commit guard refuses the address.
#30664 and #30861 are left out: review on another release batch found defects in them that also apply to
main, so they wait for fixes there.Backwards compatibility
Compatible: each change is the one already merged on
main, and its compatibility note applies unchanged.Removes nothing: no setting, key or caller is removed.
Tests
Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs
release/*, so the direct test modules were run here: the Python test files these picks touch gave 828 passed.tsc -p tsconfig.app.json --noEmitpasses; the 3 vitest files these picks touch gave 38 passed;lint:i18npasses at the same count as clean release.mypy src/kiro_crewpass.i18n:checkwithout a base reports the same findings class as a cleanrelease/0.12.0on this host, and fewer of them.Manual verification
N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.
Screenshots / video
Why no screenshot: the frontend picks carry the same rendered change as their main PRs, which show it.
Related Issues
Backport to the 0.12 line for 0.12.1 of #31004, #30986, #31304, #30482, #32454, #32478, #32489, #31779, #32238.
Sibling sweep
Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.
Pattern harvest
Not generalizable: this PR only carries fixes already on
main. The source PRs have their own harvest.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.