Repository navigation
fix: double-quote pip specifiers so copied lines work in cmd.exe - #33244
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this changes only the quote character in docs and one UI string, and a test stops single-quoted [DESIGN-REVIEWED] 36d98b9 Description read[DESCRIPTION-READ] d9199f8c04e0f4285ccbd2ad2da764a5a18b412ab6ffca4c5a608e80950d17a6 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The fix works on the real cause: the quote character in every copied line. A test stops new single-quoted lines in the doc trees. Not checked: whether cmd.exe strips the double quotes. The author also did not run it on Windows. Notes
What this change shipsInventory (4 items) — 3 justifiedIntent: Windows users can paste the
[FIRST-PRINCIPLES-REVIEWED] 36d98b9 Description read[DESCRIPTION-READ] 8e41b0177ddd9a50951c9a1c385d3072ded2737f3ee1421c031967f85381b7b2 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS The only visible change, the SageMaker card's install line, appears in shot-01, and the blind reader read it correctly as a warning plus a command to run. [UX-REVIEWED] 36d98b9 Description read[DESCRIPTION-READ] e94ff16addf535ef0c201cf772b576284c773232ab3ed088b1a08ec1950d34a3 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
56201ea to
788069e
Compare
|
self-added: no
[operator: bolichen97] |
buluoray
left a comment
There was a problem hiding this comment.
Approving. Copy-paste pip lines in the shipped guides, the meetings skill, the SageMaker Settings line and the repo docs switch from single to double quotes, because cmd.exe treats a single quote as literal and < as a redirect (website/src/pages/settings/DecisionsProviderPicker.tsx:25, website/eslint.i18n.config.js:772, src/kiro_crew/docs/feishu-integration.md:15). Packages and pins are unchanged, and a new test keeps single-quoted pip lines out of the doc trees (test/test_extras.py:291-307). The Backend Tests shard 6 red comes from main and is fixed there.
The shipped guides, the meetings skill, the Settings SageMaker card and three repository docs gave their install step with single-quoted specifiers. cmd.exe does not treat ' as a quote, so pip received the quotes and rejected the requirement, or a bounded pin redirected on < and pip never ran. Use double quotes, the form extras.quote_spec already returns on Windows; it works unchanged in bash, zsh, cmd.exe and PowerShell because no pin holds $, a backtick or ". A test keeps single-quoted pip lines out of the docs and builtin skills. Closes #32732
788069e to
36d98b9
Compare
Port the Meetings backend and skill changes Kiro Crew made to its built-in copy since this repository was last kept in step: - a note editor id or note image name ending in a newline is refused (kirodotdev/KiroCrew#34534) - a Start that omits agents_enabled keeps the roster the meeting holds (kirodotdev/KiroCrew#28263) - the calendar provider loads on aiohttp 3.9 (kirodotdev/KiroCrew#35292) - filing a task never saves over an unreadable task ledger (kirodotdev/KiroCrew#35846) - a multipart note image upload with no boundary is a 400 (kirodotdev/KiroCrew#36046) - the skill's pip line double-quotes its specifiers (kirodotdev/KiroCrew#33244) - two test-only changes (kirodotdev/KiroCrew#34299, #33539) Each fix comes with the built-in's test; PORTING.md gains one row each. Co-authored-by: KiroCrewCaptain <312312717+KiroCrewCaptain@users.noreply.github.com>
Problem / Motivation
Goal: Every copy-paste
pip installline in the shipped guides, the meetings skill, the Settings SageMaker card and the repository docs works when pasted into cmd.exe, as it already does in bash, zsh and PowerShell.A Windows user who pastes the WhatsApp guide's
pip install 'neonize==0.4.3.post0'into cmd.exe getsERROR: Invalid requirement: "'neonize==0.4.3.post0'". The Feishu linepip install 'lark-oapi>=1.4,<2'never reaches pip at all: cmd.exe reads<as a redirect, prints "The system cannot find the file specified." and leaves a stray file named1.4. The same single-quoted form is in nine more lines.Why it matters
Settings sends users to these guides for channel setup, so on Windows the copied step installs nothing and the channel stays unavailable. A bounded pin is worse than an error: the command fails before pip starts and leaves a file behind. The meetings skill's line is one an agent may run as written.
Not a goal
extras.quote_spec,install_hintorpip_install_command, or any hint the server builds: their output stays byte-identical.bedrock_kb's missing-boto3 error, the SageMaker 409 message body), code comments,setup.cfgcomments and contributor scripts.What changed (motivation → approach → change)
Copied install lines now work in cmd.exe. cmd.exe does not treat
'as a quote, so a single-quoted specifier reached pip with its quotes, or split on<.extras.quote_specalready names the fix: double quotes are the one form cmd.exe and PowerShell both strip, and bash and zsh accept them too because no pin holds$, a backtick or"(test_specifiers_hold_no_powershell_metacharacterspins that). Every copied line uses that form:whatsapp-integration.md,feishu-integration.md,configuration.md(voice),decisions.mdmeetingsbuiltin skillBOTO3_INSTALL), plus its entry in the install-command allowlist ofwebsite/eslint.i18n.config.jsdocs/guides/install.md,docs/reference/kiro-cli/chat/voice.md,docs/architecture/design-notes/profiling.md,docs/system-specs/modules/stt-streaming.mdA test keeps single-quoted
pip installlines out of the docs and builtin skills.Backwards compatibility
Compatible: each line installs the same packages and pins, and in bash, zsh and PowerShell the double-quoted line hands pip the same requirement the single-quoted one did.
Removes nothing: only the quote character changes; every package, pin and the allowlist entry's meaning stay.
Tests
test/test_extras.py::test_docs_never_single_quote_a_pip_specifier: no.mdfile undersrc/kiro_crew/docs/,src/kiro_crew/builtin_skills/ordocs/holdspip install '. It reads the tree throughsource_corpus.repo_files(), so another checkout under the repository is never scanned.website/src/pages/settings/decisionsProviderPicker.test.tsx("says what to install when the gateway has no boto3") expects the double-quoted line.Proof: PROVEN test/test_extras.py::test_docs_never_single_quote_a_pip_specifier (head 36d98b9)
Determinism: the new test passed 20 of 20 runs at
-n0and 10 of 10 at-n 4 --dist loadgroup --max-worker-restart=2besidetest_source_corpus.pyandtest_feishu_config_handlers.py;test_extras.pyin a shuffled order (seed 21074) passed 39 of 39.Manual verification
--dry-run --no-index, hands pip the bare requirement:No matching distribution found for lark-oapi<2,>=1.4, and no file is left in the working folder. The voice line resolves against the installed packages.extras.quote_specstates, and the reporter's control run of the double-quoted WhatsApp line parsed 3 of 3.Screenshots / video
The SageMaker option with no boto3 on the gateway, from this head's built SPA (Settings, Developer, Decisions):
Related Issues
Closes #32732
Sibling sweep
Swept: git grep -n "pip install '"
Sibling: src/kiro_crew/docs/whatsapp-integration.md:14 -- changed here
Sibling: src/kiro_crew/docs/feishu-integration.md:15 -- changed here
Sibling: src/kiro_crew/docs/configuration.md:494-504 -- changed here
Sibling: src/kiro_crew/docs/decisions.md:133 -- changed here
Sibling: src/kiro_crew/builtin_skills/meetings/SKILL.md:110 -- changed here
Sibling: website/src/pages/settings/DecisionsProviderPicker.tsx:25 -- changed here
Sibling: docs/guides/install.md:496-497 -- changed here
Sibling: docs/reference/kiro-cli/chat/voice.md:50 -- changed here
Sibling: docs/architecture/design-notes/profiling.md:52 -- changed here
Sibling: docs/system-specs/modules/stt-streaming.md:14 -- changed here
Sibling: src/kiro_crew/knowledge/connectors/bedrock_kb.py:142 -- not affected -- a server error string, not a copied docs, skill or Settings line (Not a goal)
Sibling: src/kiro_crew/config/sections_channels.py:464 -- not affected -- a docstring, read by maintainers in the source only
Sibling: src/kiro_crew/feishu/client.py:13 -- not affected -- a module docstring, read by maintainers in the source only
Sibling: setup.cfg:179 -- not affected -- comments beside the extras declarations, not copy-paste user text
Sibling: scripts/check_black_formatting.py:197 -- not affected -- contributor tooling output, not shipped user docs
Sibling: scripts/check_per_file_coverage.py:220 -- not affected -- contributor tooling output, not shipped user docs
Sibling: website/src/test/FeishuPanel.test.tsx:174 -- not affected -- a fixture standing in for a server hint the server quotes itself
Sibling: website/scripts/capture-feishu-panel.mjs:114 -- not affected -- a capture fixture standing in for a server hint
Pattern harvest
Rule candidate: lint
Pattern: a copy-paste
pip installline in shipped text single-quotes its specifier, which cmd.exe passes through to pipChecklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)