Repository navigation
test(kas): keep the skill projection installable after kas_cli_settings - #33347
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Test-only change that pins a real import-order regression; nothing blocks. Notes
[DESIGN-REVIEWED] e88f9bc Description read[DESCRIPTION-READ] b372ef32524af84a907acd0683b14f0a91613e6b26068d647f519813ba093520 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
c20a91e to
e88f9bc
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: test (1 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: adds one regression test in test/test_kas_cli_settings.py that imports the modules in a fresh interpreter to prove the skill projection still installs; no product code changes.
Problem / Motivation
Goal: A test that turns red if
kas_cli_settingsgoes back to loading a skill-projection owner without its facade.#33026 imported
_settingsstraight fromskill_projection_parts.inheritance_overlay. A test that patchedkiro_homebefore the facade's first import then left the owners bound to two differentkiro_homeobjects, andskill_projectionrefused to install. Skill scoping fell back to KAS's default trees, and 19 to 32 backend tests went red onmaindepending on test order. #33221 fixed it by importing through the facade, but it added no test.Why it matters
The break showed up only as unrelated backend tests failing on every PR into
main, and only in a given test order. This pins the import order that caused it, so a direct owner import coming back fails one named test instead.Not a goal
kas_cli_settingsor the skill projection; fix(kas): import the settings reader through the skill projection facade #33221 already fixed the code.mainonly.What changed (motivation → approach → change)
test_kas_cli_settings.pygainstest_loading_it_first_leaves_the_skill_projection_installable. It runs the failing import order in a fresh interpreter: importkas_cli_settings, rebindkiro_crew.config.paths.kiro_home, then importkiro_crew.acp.skill_projection, and asserts the child exits 0. A fresh interpreter is needed because the in-process test session has usually loaded the facade already.Backwards compatibility
Compatible: test-only change; nothing shipped changes.
Removes nothing: no setting, route, key or caller is removed.
Tests
main: the new test passes.src/kiro_crew/acp/kas_cli_settings.pyput back to its fix(kas): send kiro-cli's telemetry opt-out to KAS #33026 version (4a75e4cfad): it fails withRuntimeError: kiro_crew.acp.skill_projection: names bound to different objects across the family are ['kiro_home'].test_kas_cli_settings.pywithtest_flake_pattern_ratchet.py: 94 passed. The child timeout usesFALLBACK_TIMEOUT_SECS. black, isort, flake8 and the comment-history gate pass.Proof: not provable -- other: a test-only change; the proof is the new test failing against the pre-#33221 file
Manual verification
N/A — unit coverage sufficient: the change is a test.
Related Issues
Refs #33026, #33221
Sibling sweep
Swept:
grep -rn "skill_projection_parts\." src/kiro_crew --include='*.py'outsideskill_projection_parts/for modules that import a facade owner directlySibling: src/kiro_crew/acp/kas_cli_settings.py -- not affected -- #33221 already imports through the facade
Pattern harvest
Rule candidate: review-prompt
Pattern: a module outside a facade's own package that imports one of its owners directly can split that facade's family bindings under a test patch.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.