Skip to content

test(kas): keep the skill projection installable after kas_cli_settings - #33347

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
crew/slack/kas-family-regression-test
Nov 8, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
crew/slack/kas-family-regression-test

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A test that turns red if kas_cli_settings goes back to loading a skill-projection owner without its facade.

#33026 imported _settings straight from skill_projection_parts.inheritance_overlay. A test that patched kiro_home before the facade's first import then left the owners bound to two different kiro_home objects, and skill_projection refused to install. Skill scoping fell back to KAS's default trees, and 19 to 32 backend tests went red on main depending on test order. #33221 fixed it by importing through the facade, but it added no test.

Why it matters

The break showed up only as unrelated backend tests failing on every PR into main, and only in a given test order. This pins the import order that caused it, so a direct owner import coming back fails one named test instead.

Not a goal

What changed (motivation → approach → change)

  • test_kas_cli_settings.py gains test_loading_it_first_leaves_the_skill_projection_installable. It runs the failing import order in a fresh interpreter: import kas_cli_settings, rebind kiro_crew.config.paths.kiro_home, then import kiro_crew.acp.skill_projection, and asserts the child exits 0. A fresh interpreter is needed because the in-process test session has usually loaded the facade already.

Backwards compatibility

Compatible: test-only change; nothing shipped changes.

Removes nothing: no setting, route, key or caller is removed.

Tests

  • On current main: the new test passes.
  • With src/kiro_crew/acp/kas_cli_settings.py put back to its fix(kas): send kiro-cli's telemetry opt-out to KAS #33026 version (4a75e4cfad): it fails with RuntimeError: kiro_crew.acp.skill_projection: names bound to different objects across the family are ['kiro_home'].
  • test_kas_cli_settings.py with test_flake_pattern_ratchet.py: 94 passed. The child timeout uses FALLBACK_TIMEOUT_SECS. black, isort, flake8 and the comment-history gate pass.

Proof: not provable -- other: a test-only change; the proof is the new test failing against the pre-#33221 file

Manual verification

N/A — unit coverage sufficient: the change is a test.

Related Issues

Refs #33026, #33221

Sibling sweep

Swept: grep -rn "skill_projection_parts\." src/kiro_crew --include='*.py' outside skill_projection_parts/ for modules that import a facade owner directly
Sibling: src/kiro_crew/acp/kas_cli_settings.py -- not affected -- #33221 already imports through the facade

Pattern harvest

Rule candidate: review-prompt
Pattern: a module outside a facade's own package that imports one of its owners directly can split that facade's family bindings under a test patch.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 19:11
@buluoray
buluoray requested a review from Zedmor November 8, 2026 19:11
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision e88f9bcdd0155991cdf210780d9d1778eeee0c0e ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision e88f9bcdd0155991cdf210780d9d1778eeee0c0e touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of e88f9bcdd0155991cdf210780d9d1778eeee0c0e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Test-only change that pins a real import-order regression; nothing blocks.

Notes

  • The test only covers kas_cli_settings. The real problem is broader: any module outside skill_projection_parts/ that imports an owner directly can split the facade's bindings. One static check that those imports go through the facade would cover every importer instead of one.

[DESIGN-REVIEWED] e88f9bc

Description read

[DESCRIPTION-READ] b372ef32524af84a907acd0683b14f0a91613e6b26068d647f519813ba093520

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed e88f9bcdd0155991cdf210780d9d1778eeee0c0e — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] e88f9bc

Verdict parsed from the review's SHA-scoped output markers for commit e88f9bcdd0155991cdf210780d9d1778eeee0c0e.

False positive or not applicable? A repository writer can comment:
/ai-review override fable e88f9bcdd0155991cdf210780d9d1778eeee0c0e false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of e88f9bcdd0155991cdf210780d9d1778eeee0c0e and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] e88f9bc

False positive or not applicable? A repository writer can comment:
/ai-review override gpt e88f9bcdd0155991cdf210780d9d1778eeee0c0e false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
#33026 imported a skill-projection owner directly, so a kiro_home
patched before the facade's first import left the family bound two
ways and the facade refused to install; #33221 fixed it. This runs
that import order in a fresh interpreter, so a direct owner import
coming back turns it red.
@buluoray
buluoray force-pushed the crew/slack/kas-family-regression-test branch from c20a91e to e88f9bc Compare November 8, 2026 21:19
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 8, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 8, 2026 22:02

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (1 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: adds one regression test in test/test_kas_cli_settings.py that imports the modules in a fresh interpreter to prove the skill projection still installs; no product code changes.

@KiroCrewCaptain
KiroCrewCaptain merged commit 35cc4cd into main Nov 8, 2026
97 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the crew/slack/kas-family-regression-test branch November 8, 2026 22:03
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants