Skip to content

fix(worlds): keep an emoji whole on agent nameplates - #33352

Merged
bolichen97 merged 1 commit into
mainfrom
crew/conductor/scenes-r
Nov 8, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
crew/conductor/scenes-r

Conversation

@RohanK6

@RohanK6 RohanK6 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: In Agent Worlds, a desk nameplate or whiteboard card never shows half an emoji from a session name.

The Office, Panda Office, Underwater Lab and Wizard Tower scenes clip a session name to 8 characters for the nameplate (and, in the two offices, the whiteboard card) with a plain UTF-16 slice. When an emoji sits across that cut, half of its surrogate pair is drawn, so "Deploy 🚀 now" shows "Deploy �".

Why it matters

Session names often carry an emoji. Anyone watching Agent Worlds sees a broken glyph on the very label that tells them which desk belongs to which session.

Not a goal

What changed (motivation → approach → change)

Symptom: a broken glyph on nameplates and cards. Cause: name.slice(0, 8) counts UTF-16 units, and can stop between the two halves of an emoji. Change: the six cuts in website/src/pages/scenes/ use sliceCodePoints from website/src/utils/codePoints.ts, the helper the rest of the dashboard already truncates with (#24796), so an emoji is kept whole or left out.

Backwards compatibility

Compatible: only the text drawn on a canvas changes, and only for a name whose 8th unit falls inside an emoji.

Removes nothing: every name that cut cleanly before draws the same text.

Tests

  • website/src/test/OfficeSceneCoverage.test.tsx and website/src/test/PandaOfficeSceneCoverage.test.tsx: keeps an emoji whole when the nameplate and kanban card clip a name seats a running agent named "Deploy 🚀 now" and checks that no text on the overlay holds a lone surrogate and that the nameplate reads "Deploy". Both fail on main (run in a separate main worktree) and pass with the fix, along with the other 162 scene and Worlds tests.
  • Underwater Lab and Wizard Tower have no frame-recording harness; their two sites are the same one-call change.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Rendered the real Office and Wizard Tower scenes with two seated agents ("Deploy 🚀 now", "Release 🎉 notes") from a build of main and from this branch. On main the Office nameplate and kanban card read "Deploy �"; with the fix they read "Deploy".

Screenshots / video

Evidence commit 3dbeebd (not part of the final commit).

Office nameplate, before (main) and after (this branch):

Office nameplate before
Office nameplate after

Wizard Tower nameplate, before (main) and after (this branch):

Wizard Tower nameplate before
Wizard Tower nameplate after

Related Issues

Fixes #33349

Sibling sweep

Swept: git grep -nE ".slice(0, ?[0-9]+)" -- website/src/pages/scenes
Sibling: website/src/pages/scenes/OfficeScene.tsx -- changed here
Sibling: website/src/pages/scenes/PandaOfficeScene.tsx -- changed here
Sibling: website/src/pages/scenes/UnderwaterLabScene.tsx -- changed here
Sibling: website/src/pages/scenes/WizardTowerScene.tsx -- changed here
Sibling: website/src/pages/scenes/mission-control/parts.ts:146 -- not affected -- its pixel font skips any glyph it lacks, emoji included

Pattern harvest

Rule candidate: lint
Pattern: a .slice(0, N) on a display name or label, where sliceCodePoints keeps an emoji whole

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project Apache-2.0 license.

@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners November 8, 2026 19:15
@RohanK6
RohanK6 requested a review from Zedmor November 8, 2026 19:15
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 1018b35a2ce641df90442b18116e8c8ef7f958d7 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing an admissible screenshot of the clipped nameplate and kanban card. The four before/after images point at evidence commit 3dbeebd, which is outside this PR, so the blind read was not performed.

Evidence gaps

  • Office / Panda Office desk nameplates and whiteboard kanban cards (sliceCodePoints(a.name, 0, 8), sliceCodePoints(task, 0, 8)) with an emoji-bearing name such as "Deploy 🚀 now". No admitted screenshot shows them. Fix: attach the Office before/after images to the PR description as github.com/user-attachments assets.
  • Underwater Lab and Wizard Tower nameplates (sliceCodePoints(dv.name, 0, 8), sliceCodePoints(w.name, 0, 8)). No admitted screenshot shows them, and these two scenes have no test harness. Fix: attach the Wizard Tower images, and an Underwater Lab after-shot, as user-attachments assets.

[UX-REVIEWED] 1018b35

Description read

[DESCRIPTION-READ] 987cc5eefab2b1d6887fb44568f84efe1677b1bbc7601d063df81e9ed8fec1b8

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 1018b35a2ce641df90442b18116e8c8ef7f958d7 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: this is a point fix for issue #33349 that reuses the existing helper website/src/utils/codePoints.ts:8 sliceCodePoints. The two Mission Control cuts it leaves alone are excluded under "Not a goal".

What this change ships

Inventory (3 items) — 3 justified

Intent: someone watching Agent Worlds sees a session name on a nameplate or whiteboard card with no broken half-emoji. FIX.

  1. Office and Panda Office desk nameplates keep an emoji whole or leave it out, never half of one. — justified
  2. Office and Panda Office kanban (whiteboard) cards keep an emoji whole when they cut a name. — justified
  3. Underwater Lab and Wizard Tower nameplates keep an emoji whole when they cut a name. — justified

[FIRST-PRINCIPLES-REVIEWED] 1018b35

Description read

[DESCRIPTION-READ] 03888d57bbd7d2ed7545367cf4047ad66eaf495b8944a84a93ed03946fab9176

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 1018b35a2ce641df90442b18116e8c8ef7f958d7 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change reuses the existing sliceCodePoints helper at every split site, and it only fixes the text inside existing labels without adding or reshaping any surface.

Notes

  • The images in the description were not downloaded and typed as evidence. That does not block this PR, because no surface is reshaped. A future scene-layout change would need them.

[DESIGN-REVIEWED] 1018b35

Description read

[DESCRIPTION-READ] b1e1231e4c26a7d7860f0930e35138cd2ceeb3efcf30214c536f834478472355

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 1018b35a2ce641df90442b18116e8c8ef7f958d7 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1018b35

Verdict parsed from the review's SHA-scoped output markers for commit 1018b35a2ce641df90442b18116e8c8ef7f958d7.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 1018b35a2ce641df90442b18116e8c8ef7f958d7 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 1018b35a2ce641df90442b18116e8c8ef7f958d7 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1018b35

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 1018b35a2ce641df90442b18116e8c8ef7f958d7 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/scenes-r branch 2 times, most recently from 3dbeebd to 1d3f6ef Compare November 8, 2026 20:11
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 8, 2026
The Office, Panda Office, Underwater Lab and Wizard Tower scenes clip a
session name to 8 characters for the desk nameplate and the whiteboard
card with a plain UTF-16 slice. An emoji across that cut lost half of
its surrogate pair, so "Deploy 🚀 now" showed "Deploy �".

Each cut now uses sliceCodePoints, the helper the rest of the dashboard
already truncates with, so an emoji is kept whole or left out.
@RohanK6
RohanK6 force-pushed the crew/conductor/scenes-r branch from 1d3f6ef to 1018b35 Compare November 8, 2026 21:30
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 8, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. The four scenes (Office, Panda Office, Underwater Lab and Wizard Tower) clip nameplates and kanban task cards with the existing sliceCodePoints helper instead of String.slice. An eight-character cut no longer splits an emoji into a lone surrogate. Only the clip changes, not the length or the drawing. The two new tests check that no drawn label holds a lone surrogate. The regex in them is test-only, and the product change adds none. All checks are green.

@bolichen97
bolichen97 merged commit e9a44c0 into main Nov 8, 2026
97 checks passed
@bolichen97
bolichen97 deleted the crew/conductor/scenes-r branch November 8, 2026 22:11
buluoray pushed a commit that referenced this pull request Nov 9, 2026
The Office, Panda Office, Underwater Lab and Wizard Tower scenes clip a
session name to 8 characters for the desk nameplate and the whiteboard
card with a plain UTF-16 slice. An emoji across that cut lost half of
its surrogate pair, so "Deploy 🚀 now" showed "Deploy �".

Each cut now uses sliceCodePoints, the helper the rest of the dashboard
already truncates with, so an emoji is kept whole or left out.

(cherry picked from commit e9a44c0)
buluoray pushed a commit that referenced this pull request Nov 9, 2026
The Office, Panda Office, Underwater Lab and Wizard Tower scenes clip a
session name to 8 characters for the desk nameplate and the whiteboard
card with a plain UTF-16 slice. An emoji across that cut lost half of
its surrogate pair, so "Deploy 🚀 now" showed "Deploy �".

Each cut now uses sliceCodePoints, the helper the rest of the dashboard
already truncates with, so an emoji is kept whole or left out.

(cherry picked from commit e9a44c0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent Worlds: nameplates cut an emoji in a session name in half

2 participants