Skip to content

fix: last 0.12.1 batch (24 fixes merged 11-08 16:05-18:56Z) - #33364

Merged
buluoray merged 24 commits into
release/0.12.0from
crew/slack/0.12.1-last
Nov 8, 2026
Merged

buluoray merged 24 commits into
release/0.12.0from
crew/slack/0.12.1-last

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring 24 fixes merged on main on 2026-11-08 (between 16:05 and 18:56 UTC) onto release/0.12.0 for 0.12.1, one commit each, in a PR of their own.

Why it matters

Each fix changes behaviour a 0.12.0 user can hit today. KAS chats name kiro-cli's chat.defaultModel when they do not start on it, keep a shell grant beside a boolean autoAllowReadonly, and re-attempt a timed-out managed MCP server once instead of failing the chat. Agents that opt in to mcp.json get those servers waited for and modelled. Non-Slack channels read the default agent live, and a channel names its owner only from one configured DM target. A folder-installed app is no longer labelled as a registry app. A cross-drive Bot import folder gets the 409 refusal instead of a server error. The rest are focus, reduced-motion, log-level and translation fixes on dashboard pages.

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change.
  • No feature, CI, test-only, docs-only, refactor, perf or internal dev-tooling change.
  • No row that needs a prerequisite feature; the hand-resolved hunks and the rows left out are listed under What changed.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked onto release/0.12.0 @ 2196761088, one commit each in main merge order, with the (cherry picked from commit …) trailer. The repository's leak guard requires the public identity, so every commit is authored as Ray Xu and names its original author on an Original author: line.

# PR Original author main release
1 #33222 name kiro-cli's chat.defaultModel when a KAS chat does not start on it Joe Guo 04fbd9e109 2746a29cc8
2 #32942 send a same-origin Origin on hub-to-peer requests Bolin Chen 3568061617 972970802b
3 #33262 show the accepted log level in every log viewer Rohan Khanderia ec9d3f9aa4 f557bc8efd
4 #32522 hide the app menu bar in the Mochi settings and avatar windows Bolin Chen f7eca77d80 ffe596e7af
5 #32935 read the default agent live on every non-slack channel Bolin Chen b2b235ee76 bbcd82a863
6 #33049 keep the remaining owner-only warnings on the kirocrew chat terminal Zezhen Xu 903b71d4f0 ce9e052aa5
7 #33273 name a channel's owner only from one configured dm target Bolin Chen 7c3dd188e8 cc38ba3cd5
8 #33144 keep two webhooks sentences whole around inline code Bolin Chen e3f7215702 e4afb589ef
9 #33238 format the notifications page counts in the locale's numerals Rohan Khanderia f3bcdeb27f cb3d767c82
10 #33240 keep focus on a hook's Test button while its test runs Rohan Khanderia 95f25ed3df 9e66332cea
11 #21467 tell same-named @ file results apart by their distinguishing parent akushonkamen 5c1585fd4b 3d05500b0b
12 #33243 keep focus on app update buttons while they run Rohan Khanderia 3f6fad4c77 83a8f3a5a0
13 #33247 translate the Artifacts kind filter option prefix Rohan Khanderia c72e5849b4 ffb664565c
14 #33258 translate the session tree's per-turn labels Rohan Khanderia b306a0b022 4b947d53ef
15 #33274 keep a shell grant beside a boolean autoAllowReadonly Bolin Chen 533952af9f c37104ad14
16 #33202 record a local-folder app install as local, not registry Bolin Chen de33aea511 33292188a4
17 #33195 run the mount-source pin scan in a spawned child Raymond Chen 2da9ec838d 16db7005cc
18 #33074 four MCP modelling, pooling and start-up fixes Bolin Chen 57ecf6f27e 07575a9a23
19 #33320 stop the projects planning dots ticking under reduced motion Rohan Khanderia 5dae400e67 9802fc89d9
20 #33190 say why a goal loop paused on failing or declined cycles Bolin Chen 0bca0bcd5a 538752cf4d
21 #33256 keep focus on a site's Remove button while the save runs Rohan Khanderia 7088d8a645 ffb61e5732
22 #33317 match the roster filter against the labels the roster shows Rohan Khanderia 8b8f5e62ab e1ae2a2184
23 #33326 format the import preview's creation time in one sentence Rohan Khanderia 6bdfdfabaa 03f29d3035
24 #33158 answer a cross-drive crewmate import folder with the 409 refusal Bolin Chen 768a29a3f8 88f2cd0d59

Hand-resolved hunks:

One file under .github/ changes: #33074 removes src/kiro_crew/mcp_gateway/backend.py from .github/black-baseline.txt, as on main; black --check passes on that file here.

Left out of this batch:

PR Why
#33275 Its catalog rewrite conflicts in all 13 locale files and ReportProblemModal.tsx on keys added by #31712 (diagnostics plural counts) and #30156 (Security rule count), neither of which is on 0.12. That is a prerequisite chain under a 28-file rewrite, so it waits.

Backwards compatibility

None: each fix keeps its main PR's compatibility notes; nothing here changes stored data or config beyond what those PRs already shipped on main.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the related set ran here: 75 Python test files in three batches, one pytest process at a time with no xdist, with TMPDIR outside ~/.kiro/crew. These are the changed test files plus the related atomic-write, owner-only files, MCP gateway backend, MCP probe, MCP session report, spawn audit, owner DM, channel transport, ssh tunnel, sandbox mount sweep and Bot import route suites: 3,498 passed, 2 skipped, 0 failed on this head (88f2cd0d59).
  • Frontend: vitest on the 21 changed test files, 402 passed; the two Mochi electron tests, 38 passed. check-i18n-strings.mjs and i18n-check.mjs pass. vitest run src/i18n/: 1,193 passed, and navLabels.test.tsx timed out once under load, then passed 8/8 alone; no pick touches it.
  • flake8 passes on the changed Python files.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: the frontend picks carry the same rendered change as their main PRs, which show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #33222, #32942, #33262, #32522, #32935, #33049, #33273, #33144, #33238, #33240, #21467, #33243, #33247, #33258, #33274, #33202, #33195, #33074, #33320, #33190, #33256, #33317, #33326, #33158.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

buluoray and others added 24 commits November 8, 2026 18:52
…start on it (#33222)

KAS reads no cli.json, and carrying chat.defaultModel safely needs a pin
mark on the session handle (#33023). Until then an unpinned KAS chat keeps
main's model behaviour, and the session gets one notice that names the
kiro-cli default model and says how to pick it in Crew.

Original author: Joe Guo
(cherry picked from commit 04fbd9e)
…2942)

Original author: Bolin Chen
(cherry picked from commit 3568061)
The log viewer kept an accepted level change in its own state. The
dashboard's query client never refetches a cached read, so after the
Logs page remounted, or in a second viewer (the Activity panel's Logs
tab, the Developer panel), the selector showed the old level and the
lines were filtered by it while the backend logged at the new one.

The accepted level now goes into the shared level query, so every
viewer and every remount shows and filters by the level in force.

Original author: Rohan Khanderia
(cherry picked from commit ec9d3f9)
…32522)

Original author: Bolin Chen
(cherry picked from commit f7eca77)
…#32935)

The nine non-Slack dispatchers took agent.default_agent from the
config handed in at channel start. The field carries no restart mark
and Slack and the dashboard follow it live, so a dashboard change of
the default reached Discord, Teams, Telegram, Webex, Feishu, iMessage,
WeCom, Weixin and WhatsApp only after a gateway restart, and the
default_template fallback for a removed spec never applied there.

Each dispatcher reads the default at the point of use through
agent_switch_command.LiveDefaultAgent, which goes through
default_template and keeps the last value while the agent section is
discarded, as Slack's default-agent applier does.

A change reaches a conversation when its next conversation starts, as
a dashboard default reaches the next new chat. LiveDefaultAgent.for_route
pins the default a route's conversation first reads in
ConversationState.pinned, and an open conversation keeps it until /new,
an idle or daily reset, or an /agent switch drops the pin. Without the
pin a default changed while a message waited for admission ran the new
agent under the old agent's key, and one changed while a reply ran moved
the key /stop and the busy check derive away from the running turn.
Telegram also reads the agent with the key before admission and hands
it to _run_turn, so a /new during the wait cannot change it. An /agent
reset to the default switches to the live default, compared against
what the current conversation runs.

The agent is part of the session key, so a new conversation can change
bucket. ConversationState takes a bucket_fn (the agent a conversation
runs) and drops the pin and reseeds the counter from the new bucket
before a rotation applies, so a /new lands past all of the new agent's
saved generations. A route with an /agent pick keeps its agent and its
counter. Resetting an /agent pick to a default that names the same agent
now drops the pick instead of answering "Already using" and keeping it.

The per-channel kirocrew fallback constants were unreachable behind
default_template and are removed; the Discord and Telegram test
helpers prime the agent section beside their own.

Original author: Bolin Chen
(cherry picked from commit b2b235e)
…inal (#33049)

Original author: Zezhen Xu
(cherry picked from commit 903b71d)
On WeCom and Teams a configured person's DM target is available only
after they have written to the bot. The owner rule counted only
available targets, so with two configured people the one who had not
written yet was skipped and the other was named the owner.

The rule now counts every configured direct target, available or not,
and names the owner only when there is exactly one and it is
available. That is what the helper, the session-control spec and the
cross-channel owner notice already state. On Teams, an owner DM with
two or more allow-listed people now falls back to the dashboard
notification. The decision is recorded under docs/decisions/.

Original author: Bolin Chen
(cherry picked from commit 7c3dd18)
…33144)

The stored-context source note and the test-request result were each
built from two catalog pieces placed around a <code> element, so no
language could order the sentence its own way: Hindi and Bengali read
verb first, Chinese lost its verb, and French, Portuguese and Russian
got a space before a period and a participle that does not agree with
"session". Each sentence is now one catalog message rendered with
<Trans>, carrying the code element as markup, written in every shipped
catalog. English reads the same.

Closes #32766

Original author: Bolin Chen
(cherry picked from commit e3f7215)
…als (#33238)

Original author: Rohan Khanderia
(cherry picked from commit f3bcdeb)
…3240)

The row's Test button was disabled while a test was in flight, so the
keyboard press that started it lost focus to the page body. It now uses
aria-disabled and aria-busy, as the Rescan button on the same page does;
handleTest's in-flight claim already keeps a second press inert.

Original author: Rohan Khanderia
(cherry picked from commit 95f25ed)
…ng parent (#21467)

* fix(chat): tell same-named @ file results apart by their distinguishing parent

The @ file menu's path sub-line cut at the END of the path, so when one
result set held several same-named files (six README.md under a shared
prefix), the cut landed inside their common parent chain and the rows
read identical down to size and age — a user could pick the wrong file.
Since #21152 ChatEmbed mounts the same menu.

disambiguatedPaths now gives every row of a same-named group the
shortest suffix of parent directories that tells it apart from the
group, head-anchored with an ellipsis (…/core/src/README.md), so the
distinguishing segment is the first thing after the cut and survives
the narrowest menu width; separator-aware for native Windows rows.
Unique-named rows keep the full path, and the row tooltip keeps it
everywhere.

Closes #21162

* fix(chat): swap path separators with replaceAll, not a regex

Review follow-up (bolichen97, 2026-11-05): disambiguatedPaths now uses
exact-string replaceAll for its two single-character swaps. The
screenshot-only commit is dropped from the branch so no PNGs land on main.

---------

Co-authored-by: iamwhatever <iamwhatever@users.noreply.github.com>
Original author: akushonkamen
(cherry picked from commit 5c1585f)
On the Discover Updates list, Update All and the pressed row's Update
took native disabled while their update ran. Update All stays on
screen as the batch's progress label, and a row whose update fails
stays on the list, so disabling the pressed button blurred it to the
body and a keyboard user lost their place. Hold the pressed button
with aria-disabled and refuse a second press in its handler; the rows
nobody pressed stay disabled while anything runs, and Update All is
disabled while a row's own update runs, so a batch cannot post that
app a second time.

Fixes #33236

Original author: Rohan Khanderia
(cherry picked from commit 3f6fad4)
…3247)

The Artifacts page's kind filter labelled each option with an English
literal, `kind: ${k}`, while the tag filter beside it reads its "tag:"
prefix from the catalog. Under German the two dropdowns read
"kind: markdown" next to "Tag: ops".

The option label is now one catalog string, "kind: {{kind}}", with the
word translated in all 12 locales. The kind id itself stays as written,
as the tag names do.

Original author: Rohan Khanderia
(cherry picked from commit c72e584)
An expanded sub-agent node in the Session Breakdown tree labelled each
turn with a hard-coded English "t1", "t2". Every locale showed the
English letter, the number skipped locale formatting, and a screen
reader read a bare "t one". Show a per-locale short mark from the
catalog, which still fits the narrow column, and give assistive tech
the whole word ("Turn 1", in each locale's wording).

Original author: Rohan Khanderia
(cherry picked from commit b306a0b)
On KAS, an agent spec that lists the shell (or `code`) in
`allowedTools` and also sets a boolean `autoAllowReadonly` on its
shell `toolsSettings` entry lost both grants, so every shell and
`code` call prompted. On kiro-cli a shell named in `allowedTools`
runs whatever its `deniedCommands` do not deny, and
`autoAllowReadonly` only adds read-only commands, so it restricts
nothing there.

The `allowedTools` reading now leaves a boolean `autoAllowReadonly`
out of the authored restrictions, as the `allowedCommands` answer
already does. `denyByDefault`, every other key and a non-boolean
value still keep the grant at the prompt, and a `permissions` block
naming a policy bundle is still refused whole.

Fixes #30165

Original author: Bolin Chen
(cherry picked from commit 533952a)
…33202)

An app installed from a folder (`kirocrew app install <dir>` or the
dashboard's install from path) was written with the record default
origin "registry", so its details, `GET /api/apps` and the trust
dialog all claimed it came from the Kiro Crew registry.

install_app records "registry" only when a registry install scoped a
repository, and "local" otherwise. update_app records "registry" when a
registry update replaces a record no built-in owns, so an app first
installed from a folder does not keep "local" once registry code runs
in it.

The trust dialog shows an installed local app as "Source: Local
install", its review note no longer says Kiro Crew lists the app, and
a same-named registry listing no longer lends a local install its
registry name there. The dialog that switches a folder install to its
repository still names the listing, since it trusts the repository.
The new note ships in every catalog.

Builds on #29933.

Original author: Bolin Chen
(cherry picked from commit de33aea)
On Linux the sweep's pin scan of /proc now runs in a fresh interpreter
(python -P -m kiro_crew.sandbox_pin_scan_child keyed|legacy) that writes
the pinned names and the coverage verdict as one JSON line. In the
gateway every /proc syscall of the scan had to take the GIL back, so on
a busy host the scan slowed itself and every other gateway thread.

A child that cannot start, runs past 300 s, crashes, exits non-zero or
replies malformed counts as an incomplete scan with coverage unproven:
the pass reclaims no directory, as an incomplete in-process scan does.

The scan also stops reading another real user's tasks; they cannot bind
a source this uid staged, and they now lower only the host-wide flag.

Other platforms and any other proc root keep the in-process scan.

Closes #33171

Co-authored-by: Raymond Chen <chenmingwei23@users.noreply.github.com>
Original author: Raymond Chen
(cherry picked from commit 2da9ec8)
- Honour includeMcpJson when modelling an agent's MCP servers. An agent
  whose spec opts in to the user's mcp.json now has those servers in the
  set a cron waits for, the unresolved @server ref guard, a sub-agent's
  first prompt and /api/mcp/active, so a slow mcp.json server is waited
  for and no longer reported as declared but not configured.
- Keep an edition MCP server's own command, args and env when a global
  mcp.json entry has the same name. A narrower or args-less global entry
  no longer replaces the edition's tool selection in rebuilt specs, so
  chats keep the tools the edition enables.
- Recreate the gateway's default MCP backend work dir before a spawn
  when it has vanished. Pooled servers no longer fail every cold spawn
  with ENOENT and fall back to per-session exec until a restart; any
  other missing cwd still fails the spawn.
- Re-attempt a timed-out KAS managed MCP server (kirocrew-core,
  kirocrew-cron) once at session start through _kiro/mcp/resetServer.
  A busy host that misses the initialize deadline no longer fails every
  chat; a second failure or any other failure still fails the start.

Fixes #32971
Refs #30915

Original author: Bolin Chen
(cherry picked from commit 57ecf6f)
…on (#33320)

The Projects page planning banner and the run detail's planning overlay
append dots to "Generating execution plan" from a 500 ms interval. That
is JS-driven text, so the global reduced-motion CSS cut never reaches
it, and the line kept ticking for a user who asked for no motion.

Both now read the live preference through `useReducedMotion` and hold
the line still while it is set; the static subtitle below still says
the plan is being built.

Original author: Rohan Khanderia
(cherry picked from commit 5dae400)
A goal loop the service stood down on consecutive_failures (several
cycles in a row failed) or model_refused (the model declined a cycle)
showed only the bare "Paused" line in the warn tone, because the goal
popover's status lookup knew neither reason.

Both reasons now have their own line in every locale and render
through ErrorNotice, with no hand-off beside the unsaved goal fields,
like the other failed-cycle reasons.

Closes #32530

Original author: Bolin Chen
(cherry picked from commit 0bca0bc)
…33256)

The Personal Shopper Sites tab Remove button was disabled while the replace-all save ran. A disabled button leaves the tab order, so a keyboard user who pressed it lost focus to the page, and a failed removal left them nowhere. Mark it aria-disabled while busy; removeSite already refuses the press.

Original author: Rohan Khanderia
(cherry picked from commit 7088d8a)
#33317)

Original author: Rohan Khanderia
(cherry picked from commit 8b8f5e6)
…33326)

The import preview's origin line glued two catalog fragments around the
manifest's raw UTC timestamp, so every language showed an ISO string
like 2026-07-30T15:04:00Z. It is now one key with {date} and {origin}
placeholders, the date formatted with fmtDateTime for the reader's
locale, and the two fragment keys are gone.

Original author: Rohan Khanderia
(cherry picked from commit 6bdfdfa)
…#33158)

On Windows os.path.commonpath raises ValueError for paths on two
drives. The crewmate import's file step compared the resolved skills
folder and the imported-scripts folder with it, so a junction to
another drive escaped as an unhandled error (a 500) instead of the
workspace_link / scripts_dir_link 409 the route promises.

Both checks now go through one local containment test that treats a
path on another drive as outside, the shape the other commonpath
sites in the tree already use. The refusal rule, codes and messages
are unchanged.

Closes #32693

Original author: Bolin Chen
(cherry picked from commit 768a29a)
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 19:27
@buluoray
buluoray requested review from Zedmor and removed request for a team November 8, 2026 19:27
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/sandbox_mount_sweep.py

  • src/kiro_crew/sandbox_pin_scan_child.py

  • No reasoning template for 88f2cd0 yet.

How to clear this check:

  1. The PR author posts the template below as a PR comment, with
    every field filled (N/A needs a reason). Keep the
    Head commit line: it must name the current head SHA.
  2. The check turns green within a minute, with no push.
  3. A new push resets this check: post it again for the new head.

Only the author's comment counts this way. A reviewer can instead
paste the filled template into an "Approve" review on this head.
Merging still needs a reviewer's approval.

## Sensitive change review
- Head commit: 88f2cd0d594537d2bc72bf2d71162ac34add1a62
- What rule changed:
- Before -> after (what was allowed/blocked, now):
- Worst case if wrong (breaks commands / leaks secret / locks user out):
- Evidence checked (which sandbox result proves it):
- No regression:
  - Tools still work (which tools/commands were run, result):
  - Backward compatible (old config / old data / old callers still work, how checked):
  - Existing tests (which suites passed on this head):
- How to undo:

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 88f2cd0d594537d2bc72bf2d71162ac34add1a62 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots. The blind read was not performed because the PR attaches no images, yet it changes several dashboard surfaces users see.

Evidence gaps

  • FilePickerMenu.tsx: @ file results that share a name now show a shortened path like …/core/README.md. Needs a still of a result list with same-named rows.
  • AutoNudgePopover.tsx: two new paused reasons, paused_consecutive_failures and paused_model_refused, now appear as an ErrorNotice. Needs a still of each paused state.
  • PortabilityTab.tsx: the import preview now shows one combined line, "Created: {{date}} | From: {{origin}}". Needs a still.
  • WebhooksPage.tsx: two sentences rewritten around inline code, "Session started…" and "Written by the tool…". Needs stills of both.
  • LogsPage.tsx: the chosen log level now carries across viewers. Needs a still of the Activity or Developer Logs tab showing the new level after a change.
  • NotificationsPage.tsx: counts now use the locale's numerals. Needs a still in a locale that doesn't use Western digits.
  • ArtifactsPage.tsx: the kind filter's option prefix is now translated. Needs a still in a non-English locale.
  • KiroCrewAgentsPage.tsx: the roster filter now matches the labels the roster shows. Needs a still of a filtered roster.
  • TrustAppModal.tsx: a folder-installed app now shows as local instead of registry. Needs a still of the modal for a local-folder install.
  • website/electron/mochi/: the menu bar is now hidden in the Mochi settings and avatar windows. Needs a still of each window.

[UX-REVIEWED] 88f2cd0

Description read

[DESCRIPTION-READ] 1af03be981522bf69999abdfa8063d676448af4cc4d32ebc67f55cc9f451f8cd

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 88f2cd0d594537d2bc72bf2d71162ac34add1a62 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this backports 24 already-merged main fixes one commit each, with every hand-resolved hunk written down. The removed or re-signed helpers (_resolve_agent, _configured_agent, unresolved_server_refs, _guard_unresolved_mcp_refs) have no broken reader left in the tree.

Notes

  • ## Backwards compatibility says "None: …", which matches neither the Removes nothing: form nor the Reader: form. The patch does change signatures on the per-channel _resolve_agent/_configured_agent and the MCP ref guard. Their in-tree callers (telegram pickers/callbacks/turn_engine, discord/webex *_commands, client_start.py, agent_sdk/drivers/acp.py) were checked and still match. Using the required shape would let the next lane confirm that without redoing the grep.
  • The fix(apps): record a local-folder app install as local, not registry #33202 conflict resolution leaves appDetailPageLocalSwitch.ts on the 0.12 side. The origin="local" fix therefore reaches the trust modal and the records but not the detail-page switch. Check that the detail page doesn't still show a local install as registry on 0.12.

[DESIGN-REVIEWED] 88f2cd0

Description read

[DESCRIPTION-READ] 35c40b7aa3d078f306d0289de56b7012cb485793333efca6cd2f4043d11b803b

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 88f2cd0d594537d2bc72bf2d71162ac34add1a62 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This is a backport of 24 fixes already merged on main. Nothing blocks: each item points at its own merged PR. The hand-resolved hunks take less from main than the originals did, not more.

Notes

What this change ships

Inventory (10 items) — 9 justified

Intent: ship 24 fixes already merged on main to 0.12.0 users as 0.12.1 (FIX).

  1. A KAS chat that does not start on kiro-cli's chat.defaultModel names that model — justified
  2. A shell grant survives beside a boolean autoAllowReadonly — justified
  3. A managed MCP server that timed out starting is re-attempted once instead of failing the chat — justified
  4. For an agent that sets includeMcpJson, crons wait for its mcp.json servers and those servers are modelled — justified
  5. Non-Slack channels read the default agent live — justified
  6. A channel names its owner only from one configured DM target — justified
  7. A local-folder app install is recorded as local, not as a registry app — justified
  8. A cross-drive crewmate import folder gets a 409 instead of a 500 — justified
  9. The mount-source pin scan runs in a spawned child on Linux — rides along (perf-shaped)
  10. Dashboard focus, reduced-motion, log-level, locale-numeral and translation fixes across about 12 pages — justified

[FIRST-PRINCIPLES-REVIEWED] 88f2cd0

Description read

[DESCRIPTION-READ] a0c02ee4d9e8925bb565061c133b5e2e64eb5b6c5a4f1d5de7679da03aae4f5c

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 88f2cd0d594537d2bc72bf2d71162ac34add1a62 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 88f2cd0

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 88f2cd0d594537d2bc72bf2d71162ac34add1a62 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 88f2cd0d594537d2bc72bf2d71162ac34add1a62 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 88f2cd0

Verdict parsed from the review's SHA-scoped output markers for commit 88f2cd0d594537d2bc72bf2d71162ac34add1a62.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 88f2cd0d594537d2bc72bf2d71162ac34add1a62 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
@buluoray
buluoray merged commit 3697e8b into release/0.12.0 Nov 8, 2026
19 of 23 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-last branch November 8, 2026 19:54
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant