Repository navigation
fix: 0.12.1 wave 2a (KAS projection/grant/autoApprove #33228, #33344, #33201) - #33389
Conversation
…ne (#33344) The auto improvement setup panel built its current-repository line by gluing a translated "Working on" label in front of the repository name, so every language had to read in English word order. Korean, Japanese, Hindi and other languages that put the object first could not say it naturally. Render the line from one message with a repo slot instead, so each catalog decides where the name goes, and translate it in every shipped language. The repository name stays a component child, never a translated value. Part of #33103 Original author: Bolin Chen (cherry picked from commit 7480905)
#33201) A memory read's Retry, Show more or Load more button lost keyboard focus the moment it was pressed. Each was natively disabled while its read ran, which takes it out of the tab order, and each Retry rendered only while its query held an error, which React Query clears when a query with nothing cached refetches. So the pressed Retry was swapped for a loading card or unmounted with its card, and focus fell to the page. Keep each failure surface up through its retry with queryReadFailed, and mark the busy buttons with aria-disabled plus a click guard, as the memory cards fixed in #32186 do. Covers the memory graph Retry, the vector memory card's Retry and Load more buttons, and the Show more buttons on record history, replaced experiences and seed memory. Original author: Bolin Chen (cherry picked from commit d60b8c9)
- kiro-cli route honours a kept MCP autoApprove list. kiro-cli has no autoApprove field, so a verb governance keeps still prompted while the SEL said it skips the gate. The native skill view now grants each kept verb as an @server/tool ref in allowedTools, through the same strip and ceiling the KAS projection applies; no spec is written. - KAS withholds a gate-closed managed server. A spec Kiro Crew did not write could declare kirocrew-computer with Computer Use off, and every session failed on the 90 s managed MCP readiness timeout. The projection now skips a managed server whose spec gate is closed. - A kirocrew-* entry a user spec keeps in the block launches the managed invocation. A spec copied from kirocrew.json named a payload an upgrade removed, so a key such as timeout made the session start a missing launcher (ENOENT). The KAS hoist and the kiro-cli skill view now swap in the managed command and args and keep other keys. Fixes #33198 Original author: Bolin Chen (cherry picked from commit 012380a)
Sensitive Change ReviewSensitive files changed:
How to clear this check:
Only the author's comment counts this way. A reviewer can instead |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing screenshots. The PR changes the working-on line in every locale and the busy state of the memory Retry and "Show more" buttons, and no image shows either change. Evidence gaps
[UX-REVIEWED] ee9368a Description read[DESCRIPTION-READ] f048a6fe2658d62739f566d6be1971df904d2da3e45701a3535b05a4ec37a14a That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this backports three fixes already merged on Notes
[DESIGN-REVIEWED] ee9368a Description read[DESCRIPTION-READ] 741cecb6104a3d9fb433399d48c3a02664a50078a93ba13d6f368a1a0360bfd8 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This is a backport of three fixes already merged on What this change shipsInventory (7 items) — 7 justifiedIntent: give 0.12.0 users, in 0.12.1, three bug fixes that already landed on
[FIRST-PRINCIPLES-REVIEWED] ee9368a Description read[DESCRIPTION-READ] 4b954f658ff7ac42dce458fbaaa1f758b5a54789d1fa1704436803e68b2c34ef That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Security Scope Review -- ✅ PASSWhich legitimate operations does Verdict basis: adjudicated, zero confirmed regressions. Security scope review -- adjudicated candidates
No candidate flipped from allowed to refused. Scope-Verdict: PASS Reason: The diff changes no shell deny tier. TIGHTENING: KAS MCP server projection ( ADJUDICATED: 14 candidates, 0 confirmed newly-refused PLATFORM COVERAGE: posix and windows rows for the operations around this area: UNADJUDICATED:
[SCOPE-REVIEWED] ee9368a |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: Bring 3 fixes merged on
mainon 2026-11-08 (between 19:28 and 19:53 UTC) ontorelease/0.12.0for 0.12.1, one commit each, in a PR of their own.Why it matters
Each fix changes behaviour a 0.12.0 user can hit today. On KAS, an agent whose spec still lists
kirocrew-computerwhile Computer Use is off no longer fails every session with a 90 s MCP readiness timeout, and akirocrew-*server copied fromkirocrew.jsonstill starts after an upgrade removes the payload it named. On kiro-cli, an owner-kept MCPautoApprovetool runs without a prompt, matching what SEL records. On the dashboard, the memory retry and "show more" buttons keep focus while busy, and each language places the repo name where its grammar wants it in the working-on line.Not a goal
main; nothing is changed only here.CHANGELOG.mdchange.What changed (motivation → approach → change)
Each main squash commit was cherry-picked onto
release/0.12.0@3697e8b0dd, one commit each inmainmerge order, with the(cherry picked from commit …)trailer. The repository's leak guard requires the public identity, so every commit is authored as Ray Xu and names its original author on anOriginal author:line.74809058bff5a1b75e33d60b8c985ffdb565d539012380ad54ee9368adf0Hand-resolved hunks:
src/kiro_crew/acp/kas_agents.py:1795(docstring ofhoist_servers_for_session): keeps 0.12's*reserved_names*paragraph, because 0.12 still has that parameter, and adds this PR's paragraph on managed entries kept in the agent block.maindropped the 0.12 paragraph in fix(acp): carry brace globs and the 120 s MCP start budget on KAS resume #32602, which is not on 0.12.src/kiro_crew/acp/skill_projection_parts/preparation.py:335: adds only_relaunch_reserved_servers.main's adjacent_contested_names,_has_spec_pinand_pinned_sourcecome from feat(agents): pin which same-name spec an agent runs #30040 (spec pins) and are not brought in.The #33228 commit's per-file line counts equal
main's for all 40 files.Backwards compatibility
None: each fix keeps its main PR's compatibility notes; nothing here changes stored data or config beyond what those PRs already shipped on
main.Tests
Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs
release/*, so the related set ran here: the 17 test files fix(kas): three projection, grant and mcp autoapprove fixes #33228 changes plus the KAS session-load, MCP env relay, app MCP session identity, KAS env launch resume and runtime bindings suites, one pytest process with no xdist andTMPDIRoutside~/.kiro/crew: 1,258 passed, 2 failed on this head (ee9368adf0). The 2 failures, intest_folder_steering_provider_dedup.py, fail the same way on the commit before the fix(kas): three projection, grant and mcp autoapprove fixes #33228 pick and on a cleanrelease/0.12.0@fd33b0e1d4(2 failed, 29 passed), so they come from the release branch, not from this batch.check-i18n-strings.mjsandi18n-check.mjspass.vitest run src/i18n/: 1,194 passed.Manual verification
N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.
Screenshots / video
Why no screenshot: the frontend picks carry the same rendered change as their main PRs, which show it.
Related Issues
Backport to the 0.12 line for 0.12.1 of #33344, #33201, #33228.
Sibling sweep
Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.
Pattern harvest
Not generalizable: this PR only carries fixes already on
main. The source PRs have their own harvest.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.