Skip to content

fix: 0.12.1 wave 2b (6 fixes merged 11-08 19:05-19:23Z) - #33396

Merged
buluoray merged 6 commits into
release/0.12.0from
crew/slack/0.12.1-wave2b-batch
Nov 8, 2026
Merged

buluoray merged 6 commits into
release/0.12.0from
crew/slack/0.12.1-wave2b-batch

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring 6 fixes merged on main on 2026-11-08 (between 19:05 and 19:23 UTC) onto release/0.12.0 for 0.12.1, one commit each, in a PR of their own.

Why it matters

Each fix changes behaviour a 0.12.0 user can hit today. A channel thread's parent shows its reply count as replies arrive. The Schedule page's Run and Cancel buttons and the Knowledge pager keep keyboard focus while they work. The Dev Fleet how-to paragraph, the Issue Radar title-change lines, the project scaffolder's nested folder count and the Connections page's shared-grant lists now read correctly in every locale.

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change.
  • No feature, CI, test-only, docs-only, refactor, perf or internal dev-tooling change.
  • No row that needs a prerequisite feature; the hand-resolved hunks and the rows left out are listed under What changed.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked onto release/0.12.0 @ 109d953b86, one commit each in main merge order, with the (cherry picked from commit …) trailer. The repository's leak guard requires the public identity, so every commit is authored as Ray Xu and names its original author on an Original author: line.

# PR Original author main release
1 #33327 keep three sentences whole around a styled name Zezhen Xu 8d5c1895e0 194d71de11
2 #33257 count the nested sub-folders in each language Rohan Khanderia e125862432 a3840ae863
3 #33314 show a thread reply count on its parent as it arrives Rohan Khanderia c4f4ce3943 77340ae1fe
4 #33316 keep focus on a job row's Run and Cancel while they run Rohan Khanderia 88ba8b7db3 34c0c1fca9
5 #33259 keep focus when a knowledge pager button disables Rohan Khanderia e48fe0ec03 ba0bc4958e
6 #33340 list shared-grant entries as a locale list on connections Rohan Khanderia a398062bc0 eb4c47ebc7

Hand-resolved hunks:

Files left out of the picks: the screenshot capture helpers website/capture/channel-live-reply-count.html, website/capture/channel-live-reply-count.tsx and website/scripts/capture-channel-live-reply-count.mjs (from #33314) and website/scripts/capture-33210-styled-name-sentences.mjs (from #33327). They only produced the main PRs' screenshots and ship nothing.

One file under .github/ changes: #33316 removes src/hooks/useCronActions.ts from .github/coverage-baselines/frontend.txt, as on main.

Left out of this batch:

PR Why
#33324 Opus 5.5 review: queue_drain.py:1103 in core names Spec Builder's spec_decision_delivery_id(s) meta keys, against no-new-builtin-apps. It waits for 0.12.2.
#33073 Its kas_agents.py / kas_permissions.py hunks call canonical_tools_settings, as_authored, projection_accepts and trusted_agents_withheld, which exist only on main. That is a wide KAS prerequisite chain, so it waits.
#33325 It edits CrewmateStarButton.tsx, which the feature #30958 added on main and 0.12 does not have.
#33125 31 files (+1,498) with a new env_node_pins module and eight source conflicts in env.py, service/common.py and service/linux_install.py. Too wide for a backport batch.

Backwards compatibility

None: each fix keeps its main PR's compatibility notes; nothing here changes stored data or config beyond what those PRs already shipped on main.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • The six picks change no Python, so no backend suite applies.
  • Frontend on this head (eb4c47ebc7): vitest on the 8 changed test files, 265 passed. vitest run src/i18n/: 71 files, 1,197 passed. check-i18n-strings.mjs and i18n-check.mjs (I18N_BASE_REF=109d953b86) pass.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: the frontend picks carry the same rendered change as their main PRs, which show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #33327, #33257, #33314, #33316, #33259, #33340.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 20:27
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 8, 2026 20:27
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of eb4c47ebc7c05b98fcfd758b40d08022d9bc8a1c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots. The diff changes visible UI: the Schedule row's Run/Cancel busy state, a thread's live reply count, and reflowed copy in many locales. The PR attaches no image, so no blind read ran.

Evidence gaps

  • Schedule job row, busy state. Run and Cancel now show a centred Loader2 spinner over a hidden label where they used to show '...'. Need a screenshot of a row in each busy state, light and dark theme.
  • Channel thread parent. The "N replies" button now counts up as replies arrive. Need before/after screenshots of one parent after a live reply.
  • Dev Fleet how-to paragraph. Now one row_actions_how_to sentence, with bold "Pull & build", "Pod", "Rebase" and "Prune" inside it. Need a screenshot in English and in one non-English locale, such as de.
  • Issue Radar title-change line. Now changed_the_title_from_to with <who/> … <from/> → <to/>. Need a screenshot of the line on an issue and on a PR.
  • Project scaffolder nested-folder count. Now plural (_one/_other). Need a screenshot showing n=1.
  • Connections shared-grant entries. Now joined with fmtList. Need a screenshot of a card with 2 or more entries.
  • The note "the main PRs show it" doesn't close these gaps. Images linked from other PRs aren't evidence for this revision, so attach them here.

Notes

  • The de and bn how-to copy changes the form of address: German goes from "Sie" to "du", and Bengali goes from the formal "করুন" to the informal "করো". Check that each now matches the address form those locales use on sibling pages.

[UX-REVIEWED] eb4c47e

Description read

[DESCRIPTION-READ] 2478b031ea62c48cd1eda6b125af5115fd2f1475df9c5d870638938e139cfd96

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of eb4c47ebc7c05b98fcfd758b40d08022d9bc8a1c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: these are six clean cherry-picks of fixes already merged on main. No code outside the patch still reads the retired i18n keys.

Notes

  • The title says "7 fixes", but the Goal line and the table list six. Fix the title so the 0.12.1 release notes count them correctly.

[DESIGN-REVIEWED] eb4c47e

Description read

[DESCRIPTION-READ] 535f2b7dac1cb4fc24757d3d6978b25122033e58751d88af9b647a7ce5bd1ca7

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of eb4c47ebc7c05b98fcfd758b40d08022d9bc8a1c — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Six fix backports from main, each with its own test; no added rider or product-shape change. The title says "7 fixes" while the Goal and table list six.

Notes

  • Item 0 — framing: title "0.12.1 wave 2b (7 fixes …)" vs Goal "Bring 6 fixes merged on main"; the diff carries six. Subtraction: drop "7" from the title.

What this change ships

Inventory (8 items) — 8 justified

Intent: ship six fixes already merged on main to 0.12.0 users in 0.12.1, so this is a FIX (backport).

  1. The Dev Fleet how-to paragraph is now one translated sentence per locale — justified
  2. The Issue Radar "changed the title from → to" line is now one translated sentence on issues and PRs — justified
  3. The Project Scaffolder nested-folder count now uses plural forms ("1 possible sub-folder") — justified
  4. A thread parent's reply count now goes up live as replies arrive, without double-counting — justified
  5. The Schedule row's Run and Cancel keep keyboard focus and show a spinner instead of "..." while busy — justified
  6. The Knowledge pager moves focus to the other button when the pressed one becomes disabled (new usePagerFocus, 2 consumers) — justified
  7. The Connections shared-grant names now read as a locale list ("a, b, and c") instead of a comma join — justified
  8. useCronActions.ts is removed from the frontend coverage baseline, as on main — justified

[FIRST-PRINCIPLES-REVIEWED] eb4c47e

Description read

[DESCRIPTION-READ] bde53f193421b3603903e636cd972811978d111743a97a88afe2bdbbf28a5154

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of eb4c47ebc7c05b98fcfd758b40d08022d9bc8a1c and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] eb4c47e

False positive or not applicable? A repository writer can comment:
/ai-review override gpt eb4c47ebc7c05b98fcfd758b40d08022d9bc8a1c false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed eb4c47ebc7c05b98fcfd758b40d08022d9bc8a1c — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] eb4c47e

Verdict parsed from the review's SHA-scoped output markers for commit eb4c47ebc7c05b98fcfd758b40d08022d9bc8a1c.

False positive or not applicable? A repository writer can comment:
/ai-review override fable eb4c47ebc7c05b98fcfd758b40d08022d9bc8a1c false-positive: <reason, 20 to 500 characters>

The Dev Fleet how-to paragraph and the Issue Radar issue and pull-request title-change lines were glued from catalog fragments around styled spans, so ja/ko/hi/bn read them in English word order. Each sentence is now one catalog message carrying the styled parts as <Trans> markup. English output is unchanged.

Fixes #33210

Original author: Zezhen Xu
(cherry picked from commit 8d5c189)
#33257)

Original author: Rohan Khanderia
(cherry picked from commit e125862)
#33314)

When an agent or another client replied in a thread, the server raised
the parent message's reply count but broadcast only the reply. The page
appended the reply and left the parent untouched, so a message that
just got its first reply showed no "1 reply" button, and one that had
replies kept its old count, until the channel was read again.

The socket handler now adds one to the parent's count when a reply
lands. A message the page already holds (a channel read that raced the
event) is skipped, so it is neither shown nor counted twice.

Original author: Rohan Khanderia
(cherry picked from commit c4f4ce3)
#33316)

A job row's Run and Cancel buttons took a native disabled and the
label "..." while their request was out. The keyboard press that
started it blurred focus to the page, so a refused run or cancel left
the reader nowhere, and a screen reader announced the busy button as
dots, in every language.

They now stay focusable with aria-disabled and aria-busy, keep their
label as the accessible name, show a spinner over it while busy (the
button keeps its width, so the row does not shift), and ignore a
second press. A paused job's Run keeps its native disabled.

Original author: Rohan Khanderia
(cherry picked from commit 88ba8b7)
…3259)

On the Knowledge page, both pagers (a source group's and the flat
search results') disable Next on the last page and Prev on the first,
so paging onto that edge, by button or by the arrow-key shortcut,
dropped keyboard focus to the page body. A shared usePagerFocus hook
now moves focus to the other pager button once the new page renders,
waiting when the pager is re-drawn while that page loads.

Original author: Rohan Khanderia
(cherry picked from commit e48fe0e)
…33340)

The Connections page named the MCP entries that share a provider's
stored sign-in with a hard-coded English ", " join, both in the card's
"Before you disconnect" tip and in the note after a Disconnect that
kept the grant. Japanese and Chinese read an English comma between the
names, and English never got its "and". Format both lists with the
shared fmtList helper, so each locale joins the names its own way.

Original author: Rohan Khanderia
(cherry picked from commit a398062)
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
@buluoray
buluoray force-pushed the crew/slack/0.12.1-wave2b-batch branch from ac76f8c to eb4c47e Compare November 8, 2026 20:42
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 8, 2026
@buluoray buluoray changed the title fix: 0.12.1 wave 2b (7 fixes merged 11-08 19:05-19:22Z) fix: 0.12.1 wave 2b (6 fixes merged 11-08 19:05-19:23Z) Nov 8, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 8, 2026
@buluoray
buluoray merged commit 82d8a31 into release/0.12.0 Nov 8, 2026
30 of 33 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-wave2b-batch branch November 8, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: checking Automated validation is still running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant