Skip to content

fix: 0.12.1 late batch 2 (6 fixes merged 11-09 01:56-03:49Z) - #33675

Merged
buluoray merged 5 commits into
release/0.12.0from
crew/slack/0.12.1-late2
Nov 9, 2026
Merged

buluoray merged 5 commits into
release/0.12.0from
crew/slack/0.12.1-late2

Conversation

@buluoray

@buluoray buluoray commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring 6 fixes merged on main on 2026-11-09 onto release/0.12.0 for 0.12.1, one commit each, in a PR of their own.

Why it matters

Each fix changes behaviour a 0.12.0 user can hit today: a quiet meeting that keeps reopening its transcription socket, a diagnostics snapshot that accepts nan/inf written as text, artifact sync buttons that drop keyboard focus, browser harness, AppArmor and scratch sweep faults, the hook, approval, floor and sandbox faults in #33299, and a folder whose default agent picker does not list the project's own agents.

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change.
  • No prerequisite feature: where a conflict came from a feature 0.12 does not have, only the PR's own lines were carried, and a PR that needed the feature itself is left out (below).

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with git cherry-pick -x onto release/0.12.0 @ 8e30b9d6c0, one commit each, in main merge order. The repository's leak guard refuses a commit whose author email is not the public one, so the three picks that needed a hand-resolved commit are authored as Ray Xu and name their original author on an Original author: line.

# PR Original author main release What users hit
1 #33516 Bolin Chen c453394a2d d3ef1bf5c8 A quiet meeting opens a new transcription socket instead of keeping one
2 #31529 rohnkum 18a5075801 3dc67949cd A diagnostics snapshot window accepts nan and inf written as text
3 #33455 Raymond Chen 9b9ad79704 4ea21560bb Artifact sync buttons lose keyboard focus while they run
4 #33386 Bolin Chen e623a4d11b 0bcd361df2 Browser harness, AppArmor profile and scratch sweep faults
5 #33299 Bolin Chen db396f8964 b95590f8ae Hook, approval, argv floor and sandbox faults; an RLIMIT_AS cap that stops Node tools starting gets a warning
6 #32008 Bolin Chen 871d3313d7 79cad72567 A folder's default agent picker does not list the folder project's own agents

Hand-resolved hunks:

Left out of this batch:

PR Why
#33380 Conflicts in cron_inject.py, snapshot.py and snapshot_build.py (18 files, +1,384). The cron_inject.py hunk adds a session_key parameter that belongs to the per-run cron tab feature (#31139), which 0.12 does not have, and snapshot.py rewrites the retention guard. Too wide to hand-port, so it waits. Re-tried on 1c9a9917be: the same four files conflict, and 0.12 still has no session_key on that function.

Backwards compatibility

Compatible: each fix keeps its main PR's compatibility notes; nothing here changes stored data or config beyond what those PRs already shipped on main.

Removes nothing: every commit is a fix already reviewed and merged on main.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

Run on this head (79cad72567, rebased onto 8e30b9d6c0) in a clean Python 3.12 venv (uv pip install -e . --group dev, PYTHONNOUSERSITE=1), one file at a time, no xdist:

  • Backend: all 16 changed test files pass (981 tests), including test_security_gate_liveness.py (10), test_resource_limits_address_space.py (13), test_unreadable_mcp_identity_refusal.py (9), test_agent_execution_catalog.py (80), test_denied_commands_security_ssh_self.py (255) and test_service_apparmor.py (60).
  • Frontend: vitest on the 4 changed test files, 252 passed. tsc -b --force reports no errors.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: the frontend picks carry the same rendered change as their main PRs, which show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #33516, #31529, #33455, #33386, #33299, #32008.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 9, 2026 04:05
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 9, 2026 04:05
@buluoray
buluoray force-pushed the crew/slack/0.12.1-late2 branch from 4e7f1ba to 6dcf81a Compare November 9, 2026 04:10
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Security Scope Review -- 🔴 could not complete (fails closed)

No scope verdict for 6dcf81a19caf207da42b7f561133a10921b3ce6f (the candidate stage failed). This lane fails CLOSED: an unmeasured tightening must not read as "nothing newly refused". See the job logs, then re-run -- or record /ai-review override scope 6dcf81a19caf207da42b7f561133a10921b3ce6f <class>: <reason> if a human has judged the scope by hand.

@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🔴 BLOCK

Premise-level review of f046ff6dd8d5cd32610288a5bbb4d149feabae1e — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: BLOCK

The description says six fixes ship, including #33299, but the diff carries five. None of #33299's code, tests or line-budget raise is in this head, so the release notes would claim a fix 0.12.1 does not contain.

What this change ships

Inventory (6 items) — 5 justified

Intent: bring six fixes already merged on main into 0.12.1. This is a FIX (a backport).

  1. A quiet meeting keeps its transcription socket instead of reopening it (fix(meetings): keep a quiet meeting on one transcription socket #33516) — justified
  2. A diagnostics snapshot window refuses nan/inf written as text (fix(diag): refuse nan and inf written as text in a snapshot window #31529) — justified
  3. Artifact sync buttons keep keyboard focus while they run (fix(a11y): keep focus on artifact sync buttons while they run #33455) — justified
  4. The AppArmor profile now covers the launcher in every crew-venv-* tree, and the browser harness and scratch sweep faults are fixed (fix(platform): five browser harness, apparmor and scratch sweep fixes #33386) — justified
  5. A folder's Default agent picker lists its project's agents through ?project_path= (fix: list a folder project's own agents in its default agent picker #32008) — justified
  6. Hook, approval, argv floor and sandbox fixes, plus a warning for an RLIMIT_AS cap (fix(security): five hook, approval, floor and sandbox fixes #33299) — claimed in the description, absent from the diff

Blockers

Description claims a backport the diff does not carry — framing contradicted by the diff

Trigger: the table row reads "#33299 … Hook, approval, argv floor and sandbox faults; an RLIMIT_AS cap that stops Node tools starting gets a warning". The description also says cli_config.py "adds only the PR's _warn_if_address_space_capped" and that _PACKAGE_LINE_BUDGET was "raised … to 34,985". The diff touches 35 files, none of them cli_config.py or test_security_gate_liveness.py. Grepping for _warn_if_address_space_capped finds 0 hits. The head still has _PACKAGE_LINE_BUDGET = 34_936, and test_resource_limits_address_space.py and test_unreadable_mcp_identity_refusal.py do not exist, yet the Tests section reports them passing (13 and 9 tests).

Outcome: 0.12.1 would be described as fixing the #33299 hook, approval and sandbox faults while still shipping them, and the test results in the description were not run on this head.

Subtraction: remove #33299 from the Goal's count, the table, the hand-resolved hunks and the Tests section. Alternatively, a maintainer amends the frozen Goal once the missing commit is restored.

Clears when: the description no longer claims #33299 or its tests, or the head's diff contains #33299's changes.

[FIRST-PRINCIPLES-REVIEWED] f046ff6

Description read

[DESCRIPTION-READ] 3871a92935e7aeb1742a9cdf533e61d002533bd77b8ccbfe3500204f7f0bdbef

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

bolichen97 and others added 4 commits November 9, 2026 05:20
A meeting's stall watchdog treated 20 s without a server frame as a
wedged socket, but after `ready` the server sends a frame only on
speech or an error. A quiet room closed the socket, released the
microphone and opened both again every 20 to 25 s while the header
kept saying Live.

After `ready`, audio the socket keeps taking now counts as a sign of
life. Audio that backs up, or stops coming because the microphone went
away, still reconnects.

Part of #33304

(cherry picked from commit c453394)
…31529)

Recorder.query checked since, until, around and radius for nan and infinity only when they arrived as numbers. The debug snapshots route passes the raw query-string text, so since=nan or radius=inf parsed through float() unchecked. The query then returned an empty or whole-retention window, and the 200 reply held a bare NaN that is not valid JSON.

_parse_duration and _parse_instant now pass the value parsed from text through _finite as well. A non-finite value is refused with a ValueError that names the field, which the route answers as a 400.

Closes #31526

(cherry picked from commit 18a5075)
The Snapshot to publish, Pull latest and Overwrite remote buttons on the
artifact detail page took a native disabled while their action ran. A
disabled button leaves the tab order, so pressing one from the keyboard
dropped focus to the page body until the action finished.

Each busy button now goes aria-disabled (and aria-busy) with a press guard
instead of native disabled, matching the remote artifacts Load more button.
It stays focusable, keeps the focus it held, ignores a second press while
busy, and keeps the same visual disabled styling.

Co-authored-by: kirocrew-agent <agent@kirocrew.local>
(cherry picked from commit 9b9ad79)
…#33386)

- Browser Install copies the lock's distributions from a runtime that
  already ships browser-harness, cdp-use and fetch-use at the lock's
  pins into a fresh venv in the sealed prefix (checked by the venv's
  own interpreter), so a host with no reachable index or an expired
  index login can still enable the browser, and a later edit or prune
  of the runtime tree cannot change the driver. Other runtimes keep
  the hash-pinned pip install.
- The harness installer sets PIP_CONFIG_FILE to the null device, so an
  index-url in the owner's pip.conf (such as a private index whose
  login expired) no longer answers 401 for every locked wheel; the
  lock's hashes still pin every file.
- A finished harness venv whose base Python was pruned (as a runtime
  manager does with old versions) is re-pointed at the gateway's
  interpreter with venv --upgrade instead of cleared, so the repair
  needs no index. A venv filled from a runtime copy is still rebuilt.
- service install attaches the kirocrew-userns AppArmor profile to
  <parent>/crew-venv-*/bin/kirocrew for a managed-venv launcher, so the
  profile stays attached after every update and the sandbox no longer
  fails closed until service install is re-run.
- The hourly scratch sweep keeps a tree a live process still uses
  through a scratch export, its cwd or an open descriptor, so a runtime
  swap no longer deletes a surviving tool's TMPDIR under it.

Fixes #33342

Original author: Bolin Chen
(cherry picked from commit e623a4d)
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of f046ff6dd8d5cd32610288a5bbb4d149feabae1e and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f046ff6

False positive or not applicable? A repository writer can comment:
/ai-review override gpt f046ff6dd8d5cd32610288a5bbb4d149feabae1e false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed f046ff6dd8d5cd32610288a5bbb4d149feabae1e — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] f046ff6

Verdict parsed from the review's SHA-scoped output markers for commit f046ff6dd8d5cd32610288a5bbb4d149feabae1e.

False positive or not applicable? A repository writer can comment:
/ai-review override fable f046ff6dd8d5cd32610288a5bbb4d149feabae1e false-positive: <reason, 20 to 500 characters>

@buluoray
buluoray force-pushed the crew/slack/0.12.1-late2 branch from 6dcf81a to 79cad72 Compare November 9, 2026 05:25
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Sensitive Change Review

  • No sensitive path changed; nothing to check.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of f046ff6dd8d5cd32610288a5bbb4d149feabae1e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots. The PR attaches no image, so the blind read was not performed, yet it changes the folder modal's agent picker, adds an inline error with a Retry link, and restyles the busy state of the artifact sync buttons.

Evidence gaps

  • Folder settings modal, Default agent picker: the list now shows the folder's own project agents (folderAgentOptions(agents)). No screenshot shows it. Closed by a still of the open picker on a folder whose directory has its own agents, with a project agent visible in the list.
  • Folder settings modal, roster failure: when the list fails to load, the new folder-config-agents-error notice (components.agentSelector.roster_load_failed) appears with a Retry link. No screenshot shows it. Closed by a still of the failed state under the Default agent field.
  • Artifact detail page, sync banner busy state: while they run, Snapshot, Pull latest and the overwrite button now use aria-disabled:opacity-30 aria-disabled:cursor-not-allowed instead of disabled. No screenshot shows it. Closed by a still of the banner with one action running.
  • The description's "no-visual-delta" reason ("the frontend picks carry the same rendered change as their main PRs, which show it") cannot close these gaps. Images on other PRs are not evidence for this revision. Attach the screenshots from fix: list a folder project's own agents in its default agent picker #32008 and fix(a11y): keep focus on artifact sync buttons while they run #33455 to this PR's description.

[UX-REVIEWED] f046ff6

Description read

[DESCRIPTION-READ] 1b2fc892cacf44e5b269f911e3ed870c5014e035a02a60e56f2376a5d1f20aa5

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

Design-level review of f046ff6dd8d5cd32610288a5bbb4d149feabae1e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

The diff carries five of the six fixes it claims: #33299 is missing entirely, yet the description lists it as backported, hand-resolved and tested.

Blockers

#33299 is in the description but not in the diff
Trigger: the description lists "#33299 | … | b95590f8ae | Hook, approval, argv floor and sandbox faults; an RLIMIT_AS cap … gets a warning" and describes hand-resolved hunks in src/kiro_crew/cli_config.py and test/test_security_gate_liveness.py.
Outcome: neither file is in the patch, no added line mentions RLIMIT_AS, max_address_space, the unreadable-identity rewrite or _PACKAGE_LINE_BUDGET, and test_resource_limits_address_space.py and test_unreadable_mcp_identity_refusal.py are not in the tree → a 0.12.1 release prepared from this PR says the hook, approval, floor and sandbox fixes shipped → 0.12.0 users keep hitting those faults, and the "981 tests pass" proof does not describe this head.
Fix: add the b95590f pick (the branch was probably rebuilt after the rebase onto 8e30b9d and lost it), or move #33299 to the "Left out" table with the reason.
Clears when: the diff contains #33299's cli_config.py, security.md and test hunks with the test files present, or the description stops claiming #33299.

Notes

  • FolderConfigModal.tsx adds a new inline roster-error notice with a Retry button, and the evidence list has no image. Screenshots on the main PRs don't count as evidence for this revision, so attach one before the next run.
  • Of the 6 commits the description claims, only f046ff6 (fix: list a folder project's own agents in its default agent picker #32008) could be checked by commit message in this shallow clone. Check that the other picks are on the branch too.

[DESIGN-REVIEWED] f046ff6

Description read

[DESCRIPTION-READ] 62774b0ab6dce6458b6ede474f05d3ed9de29eb0f3ec47607e4eccf87aaf899e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

…32008)

The folder settings modal built its Default agent options from the
active chat's roster, and the agent catalog scoped project agents only
by the requesting chat. A folder's project directory is no chat's yet,
so the agents in its .kiro/agents were never offered.

The catalog now takes ?project_path= from the owner when the request
names no chat. The path goes through the shared file-path screen first,
so an untrusted UNC share is refused before anything resolves it, then
through the check a folder's project_dir gets on save; a path that
fails lists the global templates only. The modal reads the roster for
its typed or inherited directory once the path stops changing.

Closes #10106

Original author: Bolin Chen
(cherry picked from commit 871d331)
@buluoray
buluoray force-pushed the crew/slack/0.12.1-late2 branch from 79cad72 to f046ff6 Compare November 9, 2026 05:38
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 9, 2026
@buluoray
buluoray merged commit d684523 into release/0.12.0 Nov 9, 2026
19 of 23 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-late2 branch November 9, 2026 05:59
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants