Repository navigation
fix: 0.12.1 late batch 2 (6 fixes merged 11-09 01:56-03:49Z) - #33675
Conversation
4e7f1ba to
6dcf81a
Compare
Security Scope Review -- 🔴 could not complete (fails closed)No scope verdict for |
First Principles Review (Opus 5.5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK The description says six fixes ship, including #33299, but the diff carries five. None of #33299's code, tests or line-budget raise is in this head, so the release notes would claim a fix 0.12.1 does not contain. What this change shipsInventory (6 items) — 5 justifiedIntent: bring six fixes already merged on
BlockersDescription claims a backport the diff does not carry — framing contradicted by the diff Trigger: the table row reads "#33299 … Hook, approval, argv floor and sandbox faults; an Outcome: 0.12.1 would be described as fixing the #33299 hook, approval and sandbox faults while still shipping them, and the test results in the description were not run on this head. Subtraction: remove #33299 from the Goal's count, the table, the hand-resolved hunks and the Tests section. Alternatively, a maintainer amends the frozen Goal once the missing commit is restored. Clears when: the description no longer claims #33299 or its tests, or the head's diff contains #33299's changes. [FIRST-PRINCIPLES-REVIEWED] f046ff6 Description read[DESCRIPTION-READ] 3871a92935e7aeb1742a9cdf533e61d002533bd77b8ccbfe3500204f7f0bdbef That sha256 names the PR description this verdict read. Recompute it with |
A meeting's stall watchdog treated 20 s without a server frame as a wedged socket, but after `ready` the server sends a frame only on speech or an error. A quiet room closed the socket, released the microphone and opened both again every 20 to 25 s while the header kept saying Live. After `ready`, audio the socket keeps taking now counts as a sign of life. Audio that backs up, or stops coming because the microphone went away, still reconnects. Part of #33304 (cherry picked from commit c453394)
…31529) Recorder.query checked since, until, around and radius for nan and infinity only when they arrived as numbers. The debug snapshots route passes the raw query-string text, so since=nan or radius=inf parsed through float() unchecked. The query then returned an empty or whole-retention window, and the 200 reply held a bare NaN that is not valid JSON. _parse_duration and _parse_instant now pass the value parsed from text through _finite as well. A non-finite value is refused with a ValueError that names the field, which the route answers as a 400. Closes #31526 (cherry picked from commit 18a5075)
The Snapshot to publish, Pull latest and Overwrite remote buttons on the artifact detail page took a native disabled while their action ran. A disabled button leaves the tab order, so pressing one from the keyboard dropped focus to the page body until the action finished. Each busy button now goes aria-disabled (and aria-busy) with a press guard instead of native disabled, matching the remote artifacts Load more button. It stays focusable, keeps the focus it held, ignores a second press while busy, and keeps the same visual disabled styling. Co-authored-by: kirocrew-agent <agent@kirocrew.local> (cherry picked from commit 9b9ad79)
…#33386) - Browser Install copies the lock's distributions from a runtime that already ships browser-harness, cdp-use and fetch-use at the lock's pins into a fresh venv in the sealed prefix (checked by the venv's own interpreter), so a host with no reachable index or an expired index login can still enable the browser, and a later edit or prune of the runtime tree cannot change the driver. Other runtimes keep the hash-pinned pip install. - The harness installer sets PIP_CONFIG_FILE to the null device, so an index-url in the owner's pip.conf (such as a private index whose login expired) no longer answers 401 for every locked wheel; the lock's hashes still pin every file. - A finished harness venv whose base Python was pruned (as a runtime manager does with old versions) is re-pointed at the gateway's interpreter with venv --upgrade instead of cleared, so the repair needs no index. A venv filled from a runtime copy is still rebuilt. - service install attaches the kirocrew-userns AppArmor profile to <parent>/crew-venv-*/bin/kirocrew for a managed-venv launcher, so the profile stays attached after every update and the sandbox no longer fails closed until service install is re-run. - The hourly scratch sweep keeps a tree a live process still uses through a scratch export, its cwd or an open descriptor, so a runtime swap no longer deletes a surviving tool's TMPDIR under it. Fixes #33342 Original author: Bolin Chen (cherry picked from commit e623a4d)
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
6dcf81a to
79cad72
Compare
Sensitive Change Review
|
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing screenshots. The PR attaches no image, so the blind read was not performed, yet it changes the folder modal's agent picker, adds an inline error with a Retry link, and restyles the busy state of the artifact sync buttons. Evidence gaps
[UX-REVIEWED] f046ff6 Description read[DESCRIPTION-READ] 1b2fc892cacf44e5b269f911e3ed870c5014e035a02a60e56f2376a5d1f20aa5 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)Design-level review of Design-Verdict: PASS The diff carries five of the six fixes it claims: #33299 is missing entirely, yet the description lists it as backported, hand-resolved and tested. Blockers#33299 is in the description but not in the diff Notes
[DESIGN-REVIEWED] f046ff6 Description read[DESCRIPTION-READ] 62774b0ab6dce6458b6ede474f05d3ed9de29eb0f3ec47607e4eccf87aaf899e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
…32008) The folder settings modal built its Default agent options from the active chat's roster, and the agent catalog scoped project agents only by the requesting chat. A folder's project directory is no chat's yet, so the agents in its .kiro/agents were never offered. The catalog now takes ?project_path= from the owner when the request names no chat. The path goes through the shared file-path screen first, so an untrusted UNC share is refused before anything resolves it, then through the check a folder's project_dir gets on save; a path that fails lists the global templates only. The modal reads the roster for its typed or inherited directory once the path stops changing. Closes #10106 Original author: Bolin Chen (cherry picked from commit 871d331)
79cad72 to
f046ff6
Compare
Problem / Motivation
Goal: Bring 6 fixes merged on
mainon 2026-11-09 ontorelease/0.12.0for 0.12.1, one commit each, in a PR of their own.Why it matters
Each fix changes behaviour a 0.12.0 user can hit today: a quiet meeting that keeps reopening its transcription socket, a diagnostics snapshot that accepts
nan/infwritten as text, artifact sync buttons that drop keyboard focus, browser harness, AppArmor and scratch sweep faults, the hook, approval, floor and sandbox faults in #33299, and a folder whose default agent picker does not list the project's own agents.Not a goal
main; nothing is changed only here.CHANGELOG.mdchange.What changed (motivation → approach → change)
Each main squash commit was cherry-picked with
git cherry-pick -xontorelease/0.12.0@8e30b9d6c0, one commit each, inmainmerge order. The repository's leak guard refuses a commit whose author email is not the public one, so the three picks that needed a hand-resolved commit are authored as Ray Xu and name their original author on anOriginal author:line.c453394a2dd3ef1bf5c818a50758013dc67949cdnanandinfwritten as text9b9ad797044ea21560bbe623a4d11b0bcd361df2db396f8964b95590f8aeRLIMIT_AScap that stops Node tools starting gets a warning871d3313d779cad72567Hand-resolved hunks:
docs/guides/install.md(the AppArmor paragraph): keeps release's text, which now carries the restart-warning sentences from fix(install): name the restart command after a re-run under a gateway #30033, and replaces only the AppArmor lines the PR rewrote. The paragraph now matchesmainbyte for byte.docs/system-specs/modules/security.md(two field-scoped scan paragraphs): takes the PR's rewrite of the unreadable-identity sentence; keeps 0.12's text for the second paragraph, which the PR did not change.src/kiro_crew/cli_config.py(theconfig setwrite without an overlay): keeps 0.12's_warn_if_bot_name_altered(key, parsed)and adds only the PR's_warn_if_address_space_capped(key, parsed)after it.main's overlay-shadow check around that call comes from another change and is not brought in.ResourceLimitsConfigandmax_address_space_mbalready exist on 0.12.test/test_security_gate_liveness.py(_PACKAGE_LINE_BUDGET): 0.12's budget 34,936 raised by the PR's 49 lines to 34,985, with the PR's own comment. Measured: the package is 34,985 lines on this branch.src/kiro_crew/dashboard/handlers/agent_catalog.py(two import blocks): keeps 0.12'sthreading,timeandconfig.pathsimports and adds the PR'sosandchat_folders_paths._validate_project_dirimports.docs/system-specs/modules/learn-cron-dashboard.md(the Chat Folders paragraph): keeps 0.12's paragraph and inserts only the PR's sentence on the modal's agent options.Left out of this batch:
cron_inject.py,snapshot.pyandsnapshot_build.py(18 files, +1,384). Thecron_inject.pyhunk adds asession_keyparameter that belongs to the per-run cron tab feature (#31139), which 0.12 does not have, andsnapshot.pyrewrites the retention guard. Too wide to hand-port, so it waits. Re-tried on1c9a9917be: the same four files conflict, and 0.12 still has nosession_keyon that function.Backwards compatibility
Compatible: each fix keeps its main PR's compatibility notes; nothing here changes stored data or config beyond what those PRs already shipped on
main.Removes nothing: every commit is a fix already reviewed and merged on
main.Tests
Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs
Run on this head (
79cad72567, rebased onto8e30b9d6c0) in a clean Python 3.12 venv (uv pip install -e . --group dev,PYTHONNOUSERSITE=1), one file at a time, no xdist:test_security_gate_liveness.py(10),test_resource_limits_address_space.py(13),test_unreadable_mcp_identity_refusal.py(9),test_agent_execution_catalog.py(80),test_denied_commands_security_ssh_self.py(255) andtest_service_apparmor.py(60).tsc -b --forcereports no errors.Manual verification
N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.
Screenshots / video
Why no screenshot: the frontend picks carry the same rendered change as their main PRs, which show it.
Related Issues
Backport to the 0.12 line for 0.12.1 of #33516, #31529, #33455, #33386, #33299, #32008.
Sibling sweep
Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.
Pattern harvest
Not generalizable: this PR only carries fixes already on
main. The source PRs have their own harvest.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.