Skip to content

fix: backport 5 user-facing fixes to 0.12.1 (batch late-3) - #33725

Merged
buluoray merged 5 commits into
release/0.12.0from
crew/slack/0.12.1-late3
Nov 9, 2026
Merged

buluoray merged 5 commits into
release/0.12.0from
crew/slack/0.12.1-late3

Conversation

@buluoray

@buluoray buluoray commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Ship 5 user-facing fixes that merged to main after the 0.12 cut to 0.12.1 users.

Each fix is a bug that 0.12 users can hit today. Each one cherry-picks onto release/0.12.0 with no conflict.

Why it matters

0.12 users keep hitting these bugs until a patch release carries them. A single bad stored vector breaks episodic memory. A kept subagent run with a bad timestamp is lost. A failed WhatsApp image upload gives no reason. A region name with non-ASCII digits is accepted, and a NUL byte breaks a Telegram reply.

Not a goal

  • No change written for release: every commit is a git cherry-pick -x of the main merge commit, unchanged.
  • No fix beyond these 5. Other main fixes go in their own batches.
  • No CI, test-only, docs-only or dev-tooling commits.

What changed (motivation → approach → change)

The 5 fixes are applied in main merge order, one cherry-pick -x of each main merge commit, on release/0.12.0 at 8e30b9d6c0, which is the head after #33574 (s3b1) merged.

# PR Main merge commit What users hit
1 #33645 4a918862de one undecodable episodic vector made the FAISS index load fail
2 #33641 4a6b1e6281 a kept subagent run whose state stamp was not a finite number was dropped
3 #33646 60d72b9aa2 WhatsApp did not say why an image was not sent when its upload failed
4 #33642 0207374048 an AWS region name with non-ASCII digits was accepted
5 #33649 813da15dd4 a NUL byte in a reply broke the Telegram render

Dropped: none. All 5 picked cleanly in order, and none failed its tests.

Backwards compatibility

Compatible: each commit is the main commit unchanged, already reviewed and merged there. Each main PR states its own compatibility. The only stricter check is #33642's region validator, and every ASCII region name that passed before still passes.

Removes nothing: no field, API, key or config is removed. #33642 refuses a region with a non-ASCII digit only when a record is written or edited, and such a region could never reach AWS. Stored records still load.

Tests

Run on this branch at 50c0fb3edb, in a clean Python 3.12 venv (uv venv -p 3.12, uv pip install -e . -r pyproject.toml --group dev), with env -u KIROCREW_NATIVE_SKILL_PROJECTION PYTHONNOUSERSITE=1 and one pytest run per file:

  • test/test_continuable_followups.py: 24 passed
  • test/test_instances_ssm.py: 133 passed
  • test/test_telegram_renderer_nul.py: 6 passed
  • test/test_vector_memory_embedding_lifecycle.py: 46 passed, 8 skipped
  • test/test_whatsapp_turn_renderer.py: 40 passed

No file under website/ changed, so vitest and tsc were not run.

Proof: not provable -- other: a cherry-pick batch of already-merged main fixes, each proven in its own main PR

Manual verification

N/A: each fix was verified in its own main PR, and this batch carries them unchanged.

Related Issues

0.12.1 backport batch late-3: #33645, #33641, #33646, #33642, #33649.

Checklist

  • Each commit is a cherry-pick -x of a main commit with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

…33645)

The FAISS rebuild and the promotion pass both read every stored
episodic vector. The rebuild decoded a blob before checking its width,
so a blob that is not a whole number of float32s raised and stopped the
whole rebuild, leaving the rows after it out of vector search. Promotion
clustering raised the same way on such a blob, and on two vectors of
different widths, so one odd row ended every promotion pass.

Check the rebuild's width on the bytes, as the episodic scoring set
already does, and have clustering leave a vector it cannot compare out
of every cluster. Every input that worked before gives the same result.

(cherry picked from commit 4a91886)
…er (#33641)

After a restart the conversation registry is rebuilt from each kept
run's state.json, reading its age from `float(updated_at)`. A string
or an int past float range raised, so the run was skipped and its
conversation was never re-registered for the TTL sweep. `-inf` was
read as a time and aged the conversation past its TTL, so the first
sweep released it.

The stamp is now read through `_finite_time`, the reader the tombstone
code already uses, with `started` as the fallback; a stamp that is
not a finite number reads as age 0. `_finite_time` itself returns 0.0
for an int past float range instead of raising.

(cherry picked from commit 4a6b1e6)
…33649)

The Telegram renderer holds code spans and fences behind NUL<index>NUL
placeholders while it converts Markdown and strips horizontal rules.
Reply text that already carried that shape, such as tool output with
raw NUL bytes the agent echoed, was read back as a placeholder. An
index past the stash raised IndexError, which aborted the streamed
chunk or the final seal, and an index inside it copied a code span
into the wrong place.

Drop NUL from the text before stashing. Telegram shows no NUL, so the
reply looks the same. md_to_telegram_html_safe drops it before the
credential scan too, so a key a NUL cuts in two is rejoined before
the scan reads it, not after.

(cherry picked from commit 813da15)
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 9, 2026 05:27
@buluoray
buluoray requested review from Zedmor and removed request for a team November 9, 2026 05:27
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 50c0fb3edbdf9fe5df1dfe497282edd6419c1b03 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 50c0fb3edbdf9fe5df1dfe497282edd6419c1b03 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check. Each of the five cherry-picks fixes a defect that a test added in this PR shows failing on base, and the Goal covers all five.

What this change ships

Inventory (7 items) — 7 justified

Intent: give 0.12 users five bug fixes that already merged to main, through a 0.12.1 patch. FIX.

  1. Episodic memory index skips a stored vector that can't be decoded and keeps loading the rest — justified
  2. Memory promotion clustering leaves out vectors that are cut short or a different width, instead of failing the whole pass — justified
  3. A kept subagent run whose timestamp isn't a finite number is kept, using its start time — justified
  4. A timestamp too large to convert to a float reads as absent instead of raising — justified
  5. When an image upload fails, WhatsApp's "Not sent" note now gives the reason — justified
  6. An instance's AWS region with non-ASCII digits is refused, both in validation and in the stored record — justified
  7. A NUL byte in a Telegram reply is dropped (after the credential scan), so the render no longer breaks or misplaces code spans — justified

[FIRST-PRINCIPLES-REVIEWED] 50c0fb3

Description read

[DESCRIPTION-READ] 8c54694fe56ed89906b381528c8187dfa6a21b2aea558b266b47730194875481

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 50c0fb3edbdf9fe5df1dfe497282edd6419c1b03 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: five small cherry-picks of fixes already merged to main, each with tests, and the one stricter check (the region validator) runs only on add or edit, not when stored records load.

Notes

  • A stored instance whose aws_region has a non-ASCII digit still loads, since Instance.from_dict does not validate. But any later edit runs validate() on the whole record, so that record can't be edited until its region is fixed. Such a region never worked against AWS, so the cost is small.

[DESIGN-REVIEWED] 50c0fb3

Description read

[DESCRIPTION-READ] 749c89f7046a0be6bc9417561168db656468692171fe646bf8312853c527ad15

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 50c0fb3edbdf9fe5df1dfe497282edd6419c1b03 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 50c0fb3

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 50c0fb3edbdf9fe5df1dfe497282edd6419c1b03 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 50c0fb3edbdf9fe5df1dfe497282edd6419c1b03 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 50c0fb3

Verdict parsed from the review's SHA-scoped output markers for commit 50c0fb3edbdf9fe5df1dfe497282edd6419c1b03.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 50c0fb3edbdf9fe5df1dfe497282edd6419c1b03 false-positive: <reason, 20 to 500 characters>

@buluoray
buluoray merged commit d14a1d4 into release/0.12.0 Nov 9, 2026
21 of 26 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-late3 branch November 9, 2026 05:41
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants