Repository navigation
fix(crew-window): frame each notice once and keep the scrollbar clear - #33735
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: each item maps to a defect in #33698, and the measurement uses the existing shared hook instead of a new copy. What this change shipsInventory (6 items) — 6 justifiedIntent: in the crew chat window, each notice has one frame and the composer leaves the scrollbar visible. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 90a8460 Description read[DESCRIPTION-READ] bd226c31b3491a624e75453eac29d24eb6b104e205ad6f1de7db6c2e69404bbd That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The change only moves notices and the dock, with no new controls or copy, and all six screenshots cover the before and after states. Notes
[UX-REVIEWED] 90a8460 Description read[DESCRIPTION-READ] 1bfe4cf9bb684bf1a1f3becd4a94b1c8c129cbfe5d28da881ef5858ebd709c90 That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
The crew window's notices column put every notice on one glass chip, so an error card drew a second frame around its own, and the chip's mount condition was a hand-kept copy of each notice's render condition. Card notices now stand alone, as the local dock's refused-press notice does, and one list of condition and line pairs both mounts and fills the chip that the frameless lines share. The dock takes the shared useComposerDockMetrics measurement in place of its own ResizeObserver, so it stops short of the transcript's scrollbar gutter and the composer's shelf fade no longer paints over the thumb. Closes #33698
|
Rebased: main moved in test/test_chat_resume_all.py since this head's CI ran (359e4ef -> aa08664); CI re-running on 90a8460. The patch is unchanged. The previous round's red checks came from GitHub 504s during runner setup: Design Review and Flake Pattern Ratchet never ran their review or ratchet step, and Await Fast Gate and Coverage Gate failed closed behind them. |
bd73ac3 to
90a8460
Compare
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the notices chip now mounts from the same list that fills it, and the dock uses the measurement the other two hosts already share. [DESIGN-REVIEWED] 90a8460 Description read[DESCRIPTION-READ] abb5879e8edf2180380d489b3680fb2b67ab6e55af3c5ffeefbbb20c66a83fe8 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Reviewed on head 90a8460. Every card notice (unreachable, action refused, picker refused, mode refused) still renders in the same column, on the same condition and in the same order. The glass chip now mounts only for the five frameless lines, from the same noticeLines list that fills it. The dock gutter now comes from the shared useComposerDockMetrics hook with right: dockGutter, which is the same shape the two local hosts use. We traced each new test against the production change: the card off chip test and the 6px gutter test fail on the parent, and the offline line and effort options tests fail if their entry is dropped. Nothing touches a security, auth or backend surface.
Done well: one list both mounts and fills the chip, so the old hand kept hasNotice copy can no longer drift. The local ResizeObserver is gone and the window reuses the hook that already exists.
- Optional: in the dock shape test, add
expect(dock.children[1]).toHaveClass('relative', 'z-10', 'dock-inert')so the stacking context that draws the.glass-shelf::beforefade stays pinned. - Optional: in the unreachable send test, assert that the notices column has no
.liquid-glasswhen only the card shows. - Optional: reword the "No hand-off" comment in
noticeLinesso it plainly covers all three read failure entries.
…#33735) The crew window's notices column put every notice on one glass chip, so an error card drew a second frame around its own, and the chip's mount condition was a hand-kept copy of each notice's render condition. Card notices now stand alone, as the local dock's refused-press notice does, and one list of condition and line pairs both mounts and fills the chip that the frameless lines share. The dock takes the shared useComposerDockMetrics measurement in place of its own ResizeObserver, so it stops short of the transcript's scrollbar gutter and the composer's shelf fade no longer paints over the thumb. Closes #33698 (cherry picked from commit 5a9b9b3)
…#33735) The crew window's notices column put every notice on one glass chip, so an error card drew a second frame around its own, and the chip's mount condition was a hand-kept copy of each notice's render condition. Card notices now stand alone, as the local dock's refused-press notice does, and one list of condition and line pairs both mounts and fills the chip that the frameless lines share. The dock takes the shared useComposerDockMetrics measurement in place of its own ResizeObserver, so it stops short of the transcript's scrollbar gutter and the composer's shelf fade no longer paints over the thumb. Closes #33698 (cherry picked from commit 5a9b9b3)
Problem / Motivation
Goal: In the crew chat window, every notice above the composer has exactly one frame, the glass chip behind the frameless notices can no longer disagree with what it shows, and the composer dock leaves the transcript's scrollbar uncovered.
Three defects #23930 left in
website/src/pages/chat/crew-window/CrewChatWindow.tsx(issue #33698):hasNotice, a hand-kept copy of every notice's render condition. Two of the notices it gated, the offline line and the effort-options failure, had no test, so dropping either clause stayed green.Why it matters
Everyone who chats with a connected crew sees the doubled frame on every failed send or refused pick, the moment the window most needs to read clearly. A notice added to the chip later could silently never show. Where scrollbars are classic (Windows, Linux), the bottom of the transcript's scrollbar hides behind the composer, which is where the thumb sits whenever the conversation is at its end.
Not a goal
temp-screenshots/crew-window-dock/from main:docs/ci/ci-and-reviews.mdgives that to the merging maintainer.ErrorNotice,Glass, or the local docks (ComposerDockView,ChatPane).What changed (motivation → approach → change)
The crew window's notices column and dock now follow the local dock's own rules instead of a copy of them.
hasNotice, a hand-kept copy of nine render conditions[condition, line]pairs (noticeLines) both mounts the chip and fills itResizeObserverand spanned the scrollbar columnuseComposerDockMetrics(scrollerRef), the local hosts' measurement, and stops short of the gutter withright: dockGutterwebsite/docs/page-layout.mdand the header ofwebsite/src/pages/chat/composerDockMetrics.tsname the crew window as the third host of the floating dock.Backwards compatibility
Compatible: a layout change inside the crew window only; every notice still shows on the same condition, in the same column and the same order.
Removes nothing: the card notices move out of the chip, not out of the column, and
hasNoticeand the localResizeObserverwere private to the component.Tests
website/src/test/CrewChatWindow.test.tsx:rightis6px. Red on the parent.noticeLines.Proof: not provable -- frontend test (prove.py runs Python only)
Determinism: the five tests green 20 of 20 runs on their own; the whole file green 10 of 10 runs beside
CrewWindowGuard.test.tsxandcomposerHost.crewWindowTranscript.test.tsx; the whole file green in 3 of 3 shuffled orders (--sequence.shuffle, seeds 13128, 28809 and 26017).Manual verification
The frames below come from a Playwright harness against the built SPA with every
/apiroute answered from fixtures: "before" from main's component, "after" from this branch. The harness also measured each scene. Before, the card sat on a glass pane and the dock's right edge met the scroller's over a 6px gutter; after, no card sits on glass and the dock stops 6px short of the scroller's edge.Screenshots / video
A refused rewind, after: the refused card is its own one frame, and the rewind line keeps the chip.
The same scene before: the card's border inside the chip's frame, with the rewind line on the same chip.
The bottom-right corner at the end of a long transcript, thumb shown as while scrolling. Before, the shelf fade under the composer hides the bottom of the thumb; after, the thumb reaches the bottom edge.
More frames
An unreachable send, after: one card and no chip.
The window while its version read is out: the offline readout on the chip, unchanged by this PR.
Related Issues
Closes #33698
Follows #23930. Open #32016 edits the rewind line's Cancel button in
CrewChatWindow.tsx, the block this PR moves intonoticeLines, so whichever lands second rebases that one block.Sibling sweep
Swept: git grep -n "<Glass" -- 'website/src/*.tsx', then every pane checked for a card (non-inline) ErrorNotice inside it
Sibling: website/src/components/milestones/MilestonesSheet.tsx:244 -- not affected -- its notice is the inline variant, which draws no frame
Sibling: website/src/components/notifications/NotificationBanner.tsx:509 -- not affected -- its notice is the inline variant, which draws no frame
Swept: git grep -n "paddingBottom: dockH" -- website/src
Sibling: website/src/components/ChatPane.tsx:735 -- not affected -- already takes useComposerDockMetrics with right: dockGutter
Sibling: website/src/pages/chat/page/messageActions.ts:43 -- not affected -- the main chat's dock, already on the shared hook
Pattern harvest
Not generalizable: all three defects came from one host's hand-made copy of the local dock (a chip around every notice, a hand-kept mount condition, its own measurement), and the sweep found no other host carrying any of them.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)