Repository navigation
fix: backport 4 user-facing fixes to 0.12.1 (batch late-4) - #33742
Conversation
The recovery ladder's first rung reads every tool result for the gateway's capacity refusal and its recoverable markers, and a turn whose last result matches is retried with a "lack of gateway capacity" notice. A short result from a call that succeeded, such as a search that prints "BackendGone" or "-32001", matched too, so a normal turn was retried up to three times. The stub and the gateway send a refusal as a JSON-RPC error, which the harness reports as a failed call, so skip results that completed or are still streaming. (cherry picked from commit fb1cdd6)
An install that hit #29225 keeps a marker that matches the pin and a venv, so provisioning skipped both the fetch and the venv build and the banner never offered it. `uv run --frozen` then installs the rewritten lock exactly and the sdpm server still fails to start. The engine now also counts as installed only while its mcp-local/uv.lock hashes to the lock inside the pinned archive (ENGINE_LOCK_SHA256). A drifted tree reads as not installed, so the banner offers provisioning again and that run re-fetches the tree and rebuilds the venv with `uv sync --frozen`. Closes #31183 (cherry picked from commit 1d2cc02)
…33451) The MD Notebook Sync button and the Settings access-token Save button set native disabled while their own request runs. A disabled button leaves the tab order, so a keyboard user who presses one loses focus to the page body until the request settles. Use aria-disabled (plus aria-busy) and a busy guard in the click handler instead of native disabled, matching the pattern the clone/attach button already uses. Focus stays on the pressed button and a second press is ignored while the first request is in flight. The muted look and cursor stay in the existing inline styles; the Save button keeps its native empty-field disable. The two confirm-row buttons (remove-vault confirm, clear-token) unmount when their request finishes, so they are left for a separate change. Co-authored-by: kirocrew-agent <agent@kirocrew.local> (cherry picked from commit f2e2089)
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Four already-merged fixes, cherry-picked to the release branch. Each one is at mechanism level and has a test or a linked issue behind it. No defaults or product shape change. Notes
What this change shipsInventory (6 items) — 5 justifiedIntent: give 0.12.1 users four bug fixes that already merged to main. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] bdc5393 Description read[DESCRIPTION-READ] 92034a490656dcd0062feb77f5a87f0c6af56388558688fefddd9bbcf36c14ef That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: each of the four backports is scoped to the fix it ports. The only thing removed is the internal Notes
[DESIGN-REVIEWED] bdc5393 Description read[DESCRIPTION-READ] 0348abf61faf3f8c42e14307b98ec1acfb934778c2a91fc1e23c25d0de0ab0e9 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The popover now draws above the subagent bar, and no new strings are added. Shots 1/4 show the fix and shots 2/6 show the old bug. The md-notebook busy-focus fix changes nothing on screen. Notes
[UX-REVIEWED] bdc5393 Description read[DESCRIPTION-READ] 6b614c59dda3c461313abaa3858813ed964c24ad80e393c82f0afd98d6c435e4 That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: Ship 4 user-facing fixes that merged to main after the 0.12 cut to 0.12.1 users.
Each fix is a bug that 0.12 users can hit today. Three cherry-pick onto
release/0.12.0with no conflict; one needed a small hand-port, listed below.Why it matters
0.12 users keep hitting these bugs until a patch release carries them. A KAS tool result that only mentions a refusal is read as a gateway refusal. A pptx-maker engine whose
uv.lockwas rewritten never repairs (#31183). Keyboard focus drops off the md-notebook Sync and Save buttons while they run. The subagent bar covers the context-usage popover.Not a goal
git cherry-pick -xof the main merge commit; the one hand-port keeps release's own code and applies only that fix's change.What changed (motivation → approach → change)
The 4 fixes are applied in the order given, one
cherry-pick -xof each main merge commit, onrelease/0.12.0atd684523f65.fb1cdd61cd1d2cc02c85uv.lockwas rewritten was never repaired (fixes #31183)f2e2089facacce269a1bHand-resolved hunks (#31305). Main's version of the context-usage control carries two props release does not have,
contextUnknown(from #32831) andcacheSlot(from #31501). Each conflict keeps release's side and applies only #31305's own change:website/src/components/ChatInput.tsx<ContextUsageControl …/>callctxWrapRef; keep release's props (nocontextUnknown,cacheSlot)website/src/components/chat-input/ContextShelf.tsxContextUsageControlsignaturectxWrapRef; keep release's propswebsite/src/components/chat-input/ContextShelf.tsx{...press}andonClickguard; keep release'scontextTip(effectivePct)website/src/test/ChatInputCoverage.test.tsxcontextUnknowntestsThe popover component and
keepFocusOffTriggerthat #31305 relies on are already on release.Prerequisites not picked:
Dropped: none.
#31305's commit is authored
Ray Xu <buluoray@gmail.com>, the identity Ray's earlier release picks use (#30903, #30946, #30644), so the repo's leak-guard hook accepts it.Backwards compatibility
Compatible: three commits are the main commit unchanged, already reviewed and merged there; the fourth applies only #31305's change to release's own component. Each main PR states its own compatibility.
Removes nothing: no field, API, key or config is removed. #31305 replaces the popover's hand-rolled outside-click listener with the shared Popover's own dismissal.
Tests
Run on this branch at
bdc5393914.Backend, in a clean Python 3.12 venv (
uv venv -p 3.12,uv pip install -e . -r pyproject.toml --group dev), withenv -u KIROCREW_NATIVE_SKILL_PROJECTION PYTHONNOUSERSITE=1and one pytest run per file:test/test_pptx_maker_engine.py: 50 passedtest/test_pptx_maker_engine_source.py: 76 passedtest/test_recovery_l1_chat_runner.py: 60 passedFrontend, one vitest run per file:
src/test/ChatInputCoverage.test.tsx: 78 passedsrc/test/agentSwitchNotice.pairedSurfaces.test.tsx: 5 passedsrc/test/mdNotebookSettingsBusyFocus.test.tsx: 1 passedsrc/test/pressActivationDropdowns.test.tsx: 21 passedtsc -p tsconfig.app.json --noEmit: cleanProof: not provable -- other: a cherry-pick batch of already-merged main fixes, each proven in its own main PR
Manual verification
N/A: each fix was verified in its own main PR; this batch carries them unchanged except for #31305's prop-only hand-port above.
Screenshots / video
From #31305's main PR; the portal change here is the same.
More from #31305
#33451 keeps focus on a busy button and changes no pixel.
Related Issues
0.12.1 backport batch late-4: #33640, #33679, #33451, #31305. Fixes #31183 on the release line through #33679.
Sibling sweep
Siblings: none -- a backport batch; each pick's own PR carried its sweep
Pattern harvest
Not generalizable: a release backport batch, not a new defect fix.
Checklist
cherry-pick -xof a main commit with a Conventional Commits titleContribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.