Skip to content

docs(rfc): mark crewmate harness follows Settings partial - #33746

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
docs/rfc-crewmate-harness-accepted
Nov 9, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
docs/rfc-crewmate-harness-accepted

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record that the owner accepted docs/request-for-change/rfc-crewmate-harness-follows-settings.md on 2026-11-09.

The RFC still says status: draft. The owner decided the direction on 2026-11-04, and the implementation PRs have merged: #29442 (RFC), #30116 (revision), #29509 (Bot harness follows Settings), #29498 (picker), #29490 (Codex worker chats), #29495 (KAS disabledTools), #32849 (layered Agent Harness page), #33540 (bell note names exact items).

Why it matters

The First Principles lane reads an RFC's status field from the base commit as the record of a product-shape decision. While this RFC says draft, later PRs inside its shape have no recorded decision to trace to, and readers of the index see a design marked as unaccepted although it shipped.

Not a goal

  • No code changes.
  • No change to the design text beyond the status header.

What changed (motivation → approach → change)

Owner accepted the RFC on 2026-11-09 → README's accepted means "nothing built yet", but eight PRs have merged, so each section 7 phase was checked against origin/main 0cc173d74a → partial, with the open phases named.

  • Front matter: status: partial, last-audited: 2026-11-09, audited-at: 0cc173d74a, doc-pr: 29442, implementation-prs lists the merged code PRs.
  • Status bullet: accepted on 2026-11-09 by the owner; keeps the direction and O1 to O5 sentences; lists the merged PRs and names each phase as done or open.
  • One new bullet records the owner's 2026-11-09 decision: single-tool switches on a harness that cannot honour them stay warning-only. No Crew-side gateway filtering, and no blocking of the toggle for now.
  • The README index row for this RFC now says partial and names the open phases.

Phase check at 0cc173d74a:

Phase On main Evidence
1 resolver yes, except the kirocrew doctor advisory row #29509: _read_backend_choice, inherited_harness_source; no doctor row for a stored agent.member_acp_backend in cli_doctor.py / doctor_checks/
2 refusal text open mate_worker.py:986, dashboard/chat_turn/turn_failures.py:570, config/loader_builders.py:569 still say to set agent.member_acp_backend
3 picker yes, except the dialog field and inherited_reason #29498 / #29509: preview flag removed, list narrowed; CrewEditorNextDialog.tsx has no harness field; no inherited_reason in src/
4 Settings line and notices yes #29509 (crewmate_harness_notice.py, AgentBackendTab.tsx crewmate-harness line), #32849, #33540
5 Codex workers yes #29490 (test/fixtures/acp_frames/codex/worker-kit-live.jsonl)
6 pin to KAS yes #29509 (kas_pin_harnesses, _note_pin_fallback in crewmate_harness.py)
7 model follows harness partial save checks use the effective harness (judges_a_model_edit, kiro_spelling_applies); start-time drop of an invalid own model and the editor note not found

Backwards compatibility

Compatible: docs only; no code, config or contract changes.

Removes nothing: the diff edits two Markdown files' status text and takes nothing away.

Tests

Proof: not provable -- docs or config only

scripts/docs-lint.sh: all documentation checks passed.

Manual verification

All eight PRs above read as MERGED into main via gh pr view.

Related Issues

Refs #21910

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 9, 2026 06:21
@iamwhatever
iamwhatever requested a review from Zedmor November 9, 2026 06:21
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 2210fe02f3720befa284144231aa2fa10c3ba3e0 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 2210fe02f3720befa284144231aa2fa10c3ba3e0 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 2210fe02f3720befa284144231aa2fa10c3ba3e0 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a docs-only status flip, the phase audit is spelled out, and it removes no readers.

Notes

  • The new "Decided 2026-11-09 … warning-only" bullet adds an owner decision beyond the status header, which is more than ## Not a goal allows. It is disclosed under "What changed", but naming the owner (as the other index rows do) would make it traceable.

[DESIGN-REVIEWED] 2210fe0

Description read

[DESCRIPTION-READ] d3980598177f692110f4a9300399b9e7401566f6cac12cd84d55f7ef0c1aa17c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 2210fe02f3720befa284144231aa2fa10c3ba3e0 — this comment is updated in place on each push.

Review details

Docs-only change, no candidates. Nothing to ground.

No findings.

[OPUS-REVIEWED] 2210fe0

Verdict parsed from the review's SHA-scoped output markers for commit 2210fe02f3720befa284144231aa2fa10c3ba3e0.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 2210fe02f3720befa284144231aa2fa10c3ba3e0 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 2210fe02f3720befa284144231aa2fa10c3ba3e0 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 2210fe0

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2210fe02f3720befa284144231aa2fa10c3ba3e0 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 9, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at 61fff50. This PR records an RFC decision, so I'm leaving a brief rather than an approval; the owner signs off on it.

What it does: It flips rfc-crewmate-harness-follows-settings.md from draft to accepted (2026-11-09) in both the front matter and the README index row. It fills doc-pr: 29442 and implementation-prs with the six merged code PRs. It also records one new owner decision: single-tool switches on a harness that can't honour them stay warning-only, with no gateway-side filtering and no blocked toggle for now.

Pros: The status now matches what has merged. The First Principles lane reads the RFC's status from the base commit, so this stops it from treating the merged harness work as undecided.

Cons / check: The warning-only rule is a new decision, not just a status flip. It should match what the owner actually said on 2026-11-09. implementation-prs leaves out #30116, which is correct because that PR revised the doc, not the code.

Tech debt: None added. The warning-only rule is a deliberate "for now", so a later RFC amendment will be needed if filtering is ever wanted.

CI: PR Hygiene failed at 06:22 and passed on the same head at 06:32. All other checks are green. Docs only, no code and no regex.

@iamwhatever
iamwhatever force-pushed the docs/rfc-crewmate-harness-accepted branch from 61fff50 to 42debaa Compare November 9, 2026 07:14
@iamwhatever iamwhatever changed the title docs(rfc): mark crewmate harness follows Settings accepted docs(rfc): mark crewmate harness follows Settings partial Nov 9, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 9, 2026
The owner accepted the RFC on 2026-11-09. Set status to partial and name which section 7 phases are on main and which are open, record the merged implementation PRs, and record the owner's decision that single-tool switches on harnesses that cannot honour them stay warning-only.

Refs #21910
@iamwhatever
iamwhatever force-pushed the docs/rfc-crewmate-harness-accepted branch from 42debaa to 2210fe0 Compare November 9, 2026 11:08
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 9, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 9, 2026 12:48

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this head against current main. The audit sha 0cc173d74a is an ancestor of main. All eight cited PRs (#29442, #30116, #29509, #29498, #29490, #29495, #32849, #33540) are merged. The open items are still open: config/loader_builders.py still tells a person to set agent.member_acp_backend, and inherited_reason is absent from src/ and website/src/. The front matter (doc-pr, implementation-prs, audited-at) matches the README row. A maintainer signed off the design.

The status is accurate. The PR picks partial over accepted and names every open phase item by file. That matches the README status vocabulary.

Optional:

  • The "stay warning-only" bullet (RFC line 18 and the README row) does not say which layer it covers. On main, the editor warns at save time, and session start still refuses with capability_tool_limits_unsupported. One clause saying the start-time refusal is unchanged would stop a later PR from citing this bullet to drop it.
  • Sibling rows name who decided and where. Naming the owner and the place of the 2026-11-09 decision here would make it traceable the same way.

@KiroCrewCaptain
KiroCrewCaptain merged commit fe47d30 into main Nov 9, 2026
99 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the docs/rfc-crewmate-harness-accepted branch November 9, 2026 12:48
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants