Skip to content

feat(lts): ship the LTS edition from lts-v* tags on its own lts channel - #33804

Merged
iamwhatever merged 1 commit into
mainfrom
lts-release-legs
Nov 9, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
lts-release-legs

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: An lts-vX.Y.Z tag builds, signs and publishes the Kiro Crew LTS edition on its own lts channel, under its own names, with no change to the v* release.

Part of #32858. #32882 gave LTS builds the lts update channel (RFC crew-lts-edition D11), but nothing publishes to it. Today the only release path is release.yml on v* tags, which builds the oss edition and writes the oss feeds. An LTS user has no published build to install or update to.

Why it matters

Without release legs, LTS exists only as hand-run local builds. Users cannot install it from the CDN, the desktop app cannot auto-update, and cli.sh --channel lts has nothing to fetch. Shipping LTS through hand-built artifacts would also bypass the signing and notarization the oss release goes through.

Not a goal

  • Running a release or pushing a tag. This PR adds the workflow; the first lts-v* tag is a separate, owner-run step (see the pre-release checklist below).
  • A Docker image or a GitHub release for LTS (owner decision: skip both).
  • New secrets, a new signing identity, or CDK changes. The LTS legs reuse the existing signing and publish setup.
  • Changing what release.yml (v*) builds or publishes.
  • Editing the RFC. D11's sentence that LTS "has no lane until then" is now stale. That is a doc follow-up, not part of this code PR.

What changed (motivation → approach → change)

Approach: reuse the build, sign and publish workflows release.yml already calls. One new edition input goes through the build workflows, and every LTS-only name is keyed on channel == 'lts'. A separate release-lts.yml (owner decision) keeps v* untouched. A test pins that release.yml passes no edition and never publishes lts.

Release

  • New .github/workflows/release-lts.yml: runs only on lts-v* and maps lts-vX.Y.Z to X.Y.Z (other shapes refused). It runs the release-candidate tests, builds with edition: lts, and publishes 11 legs (CLI, six Linux, Windows, three macOS) on lts. It shares the release-publish queue with release.yml.
  • build-wheel.yml, build-desktop.yml, build-windows.yml: edition input (default oss) and KIROCREW_BUILD_EDITION env. The wheel is renamed kirocrew-lts, including the self-referencing voice extra.
  • publish-cli.yml, publish-linux.yml, publish-windows.yml, sign-and-notarize.yml: on lts, the stems are kirocrew_lts, KiroCrew-LTS and KiroCrew-LTS-Setup, written only under feed/lts/, cli/lts/ and desktop/lts/.
  • packaging/build-desktop.sh: LTS is a side-by-side "KiroCrew LTS" app with its own Windows app ID and NSIS GUID. It refuses a nightly version. The Windows app ID is derived, not written out: website/electron/package.json build.appId plus .lts, which today is com.amazon.kiro.crew.lts. main.js claims the same ID at run time (production ID plus .lts). The NSIS GUID fec201a5-e96c-5955-8d08-750be2d446a1 is UUID v5 of that ID, and packaging.test.js pins all three.
  • scripts/check_feed_advance.py, scripts/ci/runner_watchdog.py, packaging/signing/cli-manifest.py, cli.sh: know lts and kirocrew_lts.
  • Install smokes: a signed-out LTS build refuses to start by design, and CI has no sign-in. smoke-macos-install.sh and smoke-windows-install.ps1 therefore assert the refusal (LTS boot refused, no /api/health). The mac bounded() keeps the child's exit status in BOUNDED_STATUS.

Client

  • /api/health (loopback only) returns edition, and instance-guard.js gains an lts family. An LTS shell no longer adopts an oss gateway on the shared port, and the reverse prompts. When the other edition's gateway has no app window, the app never adopts or kills it. A new native dialog asks the user to stop that gateway: "Run this command in Terminal:" then kirocrew stop --port <port> (family-takeover.js). On macOS a gateway whose app has quit (an orphan, main's orphanedHolderPid) is offered main's orphan stop instead, and only a launchd job gets the note that a service may restart it.
  • feed-lane.js passes the required channel into resolveChannel, so an LTS app does not auto-download an older lts release.
  • src/kiro_crew/release_channel.py distribution_name() is kirocrew-lts only when that distribution is installed, else kirocrew (the desktop backend installs the unrenamed tree). src/kiro_crew/skills_discovery.py reads it.
  • Removes feat(lts): follow only the edition's own lts update channel (RFC D11) #32882's temporary "lts has no published builds yet" guard, since lts is now published.

Docs: docs/build/release.md gains "LTS edition releases" with the checklist below.

Pre-release checklist and known gaps

Owner-only repo settings, needed before the first lts-v* tag. The order matters:

  1. Tag ruleset release-tags-admin-only (id 19310912): add refs/tags/lts-v*. Today it covers only refs/tags/v*.
  2. Only then, environment prod deployment policy: add tag lts-v*. Today it allows only branch main and tag v*.

The other order leaves a window where prod admits lts-v* while anyone with push access can still create that tag.

Known gaps (accepted, low risk):

  • Until the first LTS release publishes feed/lts/, an LTS update check reports a failed fetch.
  • cli.sh --channel lts over an oss pipx install leaves the oss venv, and the kirocrew link moves to LTS.
  • The LTS CLI manifest is signed with the tagged commit's packaging/MIN_VERSION.
  • A pending run in the shared release-publish group can be cancelled by the other edition's tag.
  • check_feed_advance.py has no lts-v* tag evidence, so an older LTS publish job re-run within the feed's 300 s cache window could roll the feed back. Re-running the newer job advances it again. Nightly accepts the same exposure.
  • A local make wheel EDITION=lts install upgraded with plain pip would gain kirocrew-lts beside kirocrew. No published artifact reaches this state.

Backwards compatibility

Compatible: every new workflow input defaults to the oss value, and release.yml is unchanged (pinned by test_release_lts_workflow.py). /api/health only gains a field. A gateway without edition reads as oss.

Reader: src/kiro_crew/dashboard/handlers/updates_check.py:_check_release_feed -- app -- the lts feed is published by this PR; covered by test/test_dashboard_updates_coverage.py
Reader: src/kiro_crew/cli_server_update.py:server update path -- chat -- lts now resolves a real wheel URL; test/test_update_wheel_dispatch.py
Reader: src/kiro_crew/platform/update_capability.py:remediation -- app -- returns the normal wheel command for lts; test/test_update_capability.py
Reader: src/kiro_crew/platform/update_layout.py:non_managed_pip_upgrade_command -- app -- returns the lts pinned command; test/test_update_capability.py
Reader: src/kiro_crew/dashboard/handlers/updates.py:channel_is_published re-export -- app -- no remaining importer on main or HEAD (git grep)
Reader: website/src/pages/settings/AboutPanel.tsx:unpublishedNotice -- crew page -- lts shows the normal update row; AboutPanel.channelSwitcher.test.tsx
Reader: website/src/pages/settings/AboutPanelGatewayUpdate.tsx:unpublishedNotice prop -- crew page -- prop removed with its only caller; AboutPanel.gatewayChannelRestart.test.tsx
Reader: website/src/i18n/locales/*.json:automatic_updates_unavailable_channel_unpublished -- crew page -- key removed with its only use; i18n gate clean

Tests

  • test/test_release_lts_workflow.py (new): lts-v*-only trigger, shared queue, tag→version map and refused shapes, every leg on lts with edition: lts, no Docker or GitHub release, tests run before publishing, release.yml untouched, lts-only names gated on the channel, the wheel rename step run against the real pyproject.toml/setup.cfg (no extra left naming kirocrew), smokes pinned to the real LTS boot refused log text, distribution_name() fallback.
  • test/test_api_health.py: edition is oss by default and lts on an LTS build.
  • website/electron/test/instance-guard.test.js: lts family; LTS shell over an oss gateway prompts, oss over LTS prompts, LTS over LTS reuses, a missing edition reads as oss.
  • website/electron/test/auto-update-policy-channel.test.js: an LTS build at 0.14.0 is not auto-downloaded to 0.13.0. It fails with the feed-lane.js fix reverted.
  • Updated: test_publish_feed_contract.py, test_windows_signing_contract.py, test_ci_runner_watchdog_workflows.py, packaging.test.js, store-rename-migration.test.js (exact KNOWN_CHANNELS pin now includes lts), and the guard tests removed with the guard.

Manual verification

  • A signed-out LTS kas status was run locally with the edition stamped: exit 1 and LTS boot refused, the text the smokes assert.
  • The mac smoke's bounded() was run in a bash harness: exit 1, exit 0 and a timeout (124) all report correctly.
  • Not run: smoke-windows-install.ps1 has no local PowerShell parse check (no pwsh here). A real lts-v* release has not run and must not run until the checklist above is done.

Screenshots / video

The new native dialog in website/electron/runtime/gateway/family-takeover.js. An oss app shows it when it finds an LTS gateway with no app window on the shared port (and the other way round). Captured on this head: the real module and Electron's real native dialog (Linux GTK, Electron 44.9.1, Xvfb with openbox) inside a container. Only the port probes are stubbed so the port never frees, and the clicks are scripted (Retry, Retry, Retry, OK). The capture script is in a PR comment.

Background service, round 1 prompt:

service round 1

Retry round (the port is still held):

service retry round

Cancelled-launch error after the last retry:

service cancelled launch

The other frontend change removes the LTS-only "no published builds yet" notice from Settings > About > Updates. An LTS build cannot open that view here without an organisation sign-in, so there is no shot of it; an oss build renders it unchanged.

Related Issues

Part of #32858.

Closes #32859: an LTS desktop app no longer attaches to an oss gateway on the shared port.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 9, 2026 08:31
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of ce6d75fafc1156850eba31152ab789bc924a4bde — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The blind reader understood the dialog's main control, "I stopped it — Retry", rated it "sure", and would use it. The screenshots cover all three dialog states.

Notes

  • "Stop the Kiro Crew LTS gateway" (family-takeover.js): the blind reader said "no idea what a gateway is." Name the thing the user recognises, e.g. "Stop the Kiro Crew LTS server running in the background," and keep the command as the way to do it.
  • "Run this command in Terminal: kirocrew stop --port 5476": the reader "would not" type it ("typing commands feels risky"). A native message box gives no copy button, so the user has to retype the command by hand. Add a "Copy command" button to the dialog, which also shows the user they're on the expected path.
  • Shot-03's final dialog has the same heading as the retry round, "Kiro Crew LTS is still running.", and no window title. The reader noticed both. Use a heading that says the outcome, e.g. "Kiro Crew didn't open," and keep the title ${other.displayName} is running from the earlier rounds.

[UX-REVIEWED] ce6d75f

Description read

[DESCRIPTION-READ] fa58bea62d3b639fa2f2c8324bbc760ffb45adbb286149b38ee2e990a619c908

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of ce6d75fafc1156850eba31152ab789bc924a4bde — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. The accepted RFC crew-lts-edition (D11) already covers the lts lane, and the removed guard said itself that it should be dropped once lts publishes.

What this change ships

Inventory (10 items) — 10 justified

Intent: let LTS users install and auto-update a signed LTS build from its own lts channel. ADDITION.

  1. An lts-vX.Y.Z tag builds, signs and publishes the LTS edition on lts (release-lts.yml) — justified
  2. The build workflows take an edition input, defaulting to oss, which keeps v* releases unchanged — justified
  3. LTS artifacts publish under their own names (kirocrew_lts, KiroCrew-LTS) and only under lts/ paths — justified
  4. The LTS desktop app installs side by side as "KiroCrew LTS", with its own Windows app ID and GUID — justified
  5. /api/health on loopback now reports edition — justified
  6. An LTS shell never adopts an oss gateway, and the reverse prompts — justified
  7. A gateway with no app window from the other edition gets a "run kirocrew stop" dialog — justified
  8. The "lts has no published builds yet" guard is removed from the CLI, the dashboard and the About panel — justified
  9. The installed distribution name resolves to kirocrew-lts for version and skill lookup — justified
  10. The install smokes assert that a signed-out LTS build refuses to start — justified

[FIRST-PRINCIPLES-REVIEWED] ce6d75f

Description read

[DESCRIPTION-READ] 350ee9b5ebbb94cd820bda5c80df97c81ab92543661e0acad9885eb448256a16

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of ce6d75fafc1156850eba31152ab789bc924a4bde — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the lts release is a separate workflow, the oss defaults are unchanged, and nothing in the tree still reads the removed unpublished-channel guard.

Notes

  • The shared release-publish concurrency group keeps only one pending run. An lts-v* tag can therefore cancel a queued v* release, and the reverse. This is listed as an accepted gap, and a re-run recovers it. Still, the owner checklist in docs/build/release.md should say to check that no v* publish is waiting before pushing an lts-v* tag.

[DESIGN-REVIEWED] ce6d75f

Description read

[DESCRIPTION-READ] fbb115f6e65d648b58f6ce61f4b243e7179d8d0325cf06579292f169f7223c9c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of ce6d75fafc1156850eba31152ab789bc924a4bde and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ce6d75f

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ce6d75fafc1156850eba31152ab789bc924a4bde false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed ce6d75fafc1156850eba31152ab789bc924a4bde — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ce6d75f

Verdict parsed from the review's SHA-scoped output markers for commit ce6d75fafc1156850eba31152ab789bc924a4bde.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ce6d75fafc1156850eba31152ab789bc924a4bde false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 9, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 9, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 9, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 9, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 9, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 9, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

UX Review on daf1157 (BLOCK): fixed on head 339a78a, and the screenshots in the body were re-captured from it.

  • Blocker (where to run the command, two nouns): the dialog now uses the stuck-gateway dialog's wording. "Run this command in Terminal:" is on its own line, with kirocrew stop --port <port> on the next. It names one thing throughout: "Stop the Kiro Crew LTS gateway". A launchd service keeps only the note that the service may restart it.
  • Note 1 (retry round looks the same): from round 2 the heading reads "Kiro Crew LTS is still running."
  • Note 2 ("cancelled" after the retry limit): that box shows only when the retries run out, since Cancel returns earlier. It now reads "Kiro Crew LTS kept running, so this launch stopped."
  • Note 3 (heading wording): not changed. That heading is shared with the existing nightly/production takeover dialogs, so a rewording belongs in its own change.

CodeQL / Analyze (javascript-typescript) on the old head failed on a GitHub API rate limit (2026-11-09 17:06:31 UTC), not on an alert. It reruns with this push.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 9, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Opus 5.5 Review on 339a78a (BLOCK, src/kiro_crew/cli_desktop.py:43): fixed on head 1e3d44c. PRODUCT_NAMES now includes the LTS product name and PACKAGE_NAMES includes kirocrew-desktop-lts, and the sync comment names the LTS overrides in packaging/build-desktop.sh. test/test_cli_desktop.py probes the LTS directories on macOS, Linux and Windows. Its sync test now checks every override name against build-desktop.sh.

Backend Tests (3.12, 6) on the old head failed in test/test_dashboard_server_composition_contract.py::test_the_lazy_imports_stay_inside_the_functions_that_need_them (assert 144 == 143). That test fails the same way on main's tip (ad55351). #33854 and #33687 each added a lazy import, but only one count bump landed. The main fixes are open as #34012 and #34014, so it is not fixed here.

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

This follows up my earlier review of 8ad61ec. Here is where each item stands on head 1e3d44c:

  • UX evidence for the new takeover dialog: fixed. The body now shows the round 1 prompt, the retry round, the cancelled-launch error and the macOS orphan wording. They were captured from 339a78a, family-takeover.js has not changed since then, and the UX lane passed on that head.
  • Orphan vs service wording on macOS (optional): done. holder-decision.js runs the launchdJobPids check first, and the dialog names kirocrew stop --port <port>.
  • Order of the owner settings (optional): done. docs/build/release.md and the body put the tag ruleset first and explain why the order matters.
  • Closes #32859 (optional): done.

Nothing from that review still stands, and this review found no blocking defect on this head. The wheel stem and the channel agree at every writer and reader (build-wheel, publish-cli, cli-manifest.py, cli.sh, wheel_engine.py). An oss build cannot reach the lts feed. release.yml is untouched. Until the owner settings change, a new lts-v* tag stops at the prod environment.

I cannot approve yet. PR Readiness failed on this head. 10 check runs failed, including every AI review lane, PR Policy and the readiness signal, and none of them has re-run. They look like the shared GitHub API rate limit, not a code problem, so they need a re-run. A maintainer also needs to review this PR by hand. It adds a tag-triggered workflow that signs and publishes under prod, and it changes which gateway a desktop app adopts across editions.

Optional:

  • The ownEdition: readBakedEdition() argument at holder-decision.js:309 and reconnect.js:95 is what applies the Enterprise desktop app can attach to an oss gateway on the shared port #32859 fix, and no test covers it. If you remove it at both sites, the Electron suite stays green. A source pin like the one in edition.test.js would close this. So would a harness case that runs an LTS shell against an oss gateway.
  • instance-guard.js:178-179 still returns reuse when the port owner is unknown or none (for example, a host with no lsof). In that case an LTS app can still adopt an oss gateway. You could refuse in that case when the editions differ, or narrow the Enterprise desktop app can attach to an oss gateway on the shared port #32859 claim to identified owners.
  • Four Reader: lines say the lts update paths are tested in test_update_capability.py, test_update_wheel_dispatch.py and test_dashboard_updates_coverage.py. Those files have no lts test on this head. If you turn the deleted unpublished-channel tests into positive lts cases, the claim becomes true.

@KiroCrewCaptain
KiroCrewCaptain dismissed their stale review November 9, 2026 18:44

Withdrawn: every item in this review is fixed or answered on the current head (see the follow-up comment). Other holds on this PR are listed there.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 9, 2026
release-lts.yml runs on lts-vX.Y.Z tags only (release.yml stays v*-only)
and calls the same build, sign and publish workflows with edition lts and
channel lts. It writes only feed/lts/, cli/lts/ and desktop/lts/, under the
LTS file stems (KiroCrew-LTS, kirocrew_lts). The desktop app is a
side-by-side KiroCrew LTS app on the nightly pattern with the shared mac
appId; the wheel is the kirocrew-lts distribution; no Docker image and no
GitHub release. Every new workflow input defaults to oss, so v* releases
are unchanged. The client now knows the lts lane (desktop, cli.sh, wheel
engine, signed manifest), so the temporary 'lts has no builds yet' guard
from the D11 change is removed.
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 9, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Required changes for the LTS version publish. Merge first

@iamwhatever
iamwhatever merged commit 53f18cd into main Nov 9, 2026
105 of 116 checks passed
@iamwhatever
iamwhatever deleted the lts-release-legs branch November 9, 2026 22:16
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enterprise desktop app can attach to an oss gateway on the shared port

2 participants