Skip to content

fix: keep memory.db locks and read office-held files in the viewer - #33918

Merged
bolichen97 merged 1 commit into
mainfrom
fix/sweep-dec-file-io
Nov 10, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/sweep-dec-file-io

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Viewing or searching files in the dashboard never splits the gateway's memory database, and on Windows a document open in Word or Excel opens in the file viewer instead of failing with HTTP 500.

This PR bundles two dashboard file viewer fixes, one per defect in #33880:

  1. A viewer read drops the gateway's memory.db locks (Linux, macOS). The gateway keeps <data home>/memory.db open in WAL mode through its memory store. The dashboard file routes (/api/file-read, /api/file-raw, /api/file-download, /api/file-stream, /api/file-watch and the Python walk of /api/file-grep) opened that file or its -wal / -shm with a plain descriptor inside the gateway and then closed it. On POSIX that close releases every record lock the process holds on the file, so the gateway kept writing with no lock another process could see. The next process to open and close the database could then delete the -wal the gateway still wrote through, and the database split.
  2. A document open in Word or Excel answers HTTP 500 (Windows). The viewer opened files with the C runtime open, which never grants delete sharing. Word and Excel hold every open document with delete access, so each viewer route answered 500 read_failed for a .docx or .xlsx open in either app, and /api/file-watch stopped refreshing the tab.

Why it matters

Not a goal

  • Removing trees that hold read-only directories on Linux and macOS (rmtree_force): fix(platform): remove trees holding read-only directories on POSIX #30455 carries that fix, so it is not bundled here.
  • Changing what the agent's own file tools can read: Global V1's file-tool behavior stays as it is.
  • Named member stores: memory_stores/ is already on the sensitive-path floor.
  • Reading a file whose holder shares nothing: that program still refuses the open, and the viewer now says so.
  • Windows file search inside a document Word or Excel holds: the Python document search (file_api/grep.py) still leaves that one document out of its results.

What changed (motivation → approach → change)

The file viewer no longer opens the gateway's live memory database, so viewing or searching the data home cannot split it. On Windows the viewer opens a document the same way whether or not Word or Excel has it open, because it asks Windows for the sharing those apps require.

Fix Root cause Change
Memory database locks Closing any descriptor of a file on POSIX releases every record lock the process holds on it The file routes refuse the live store files before any open
Office-held files The C runtime open grants no delete sharing Open through CreateFileW sharing read, write and delete; a holder that shares nothing gets 503 file_busy

Memory database locks. _is_live_memory_store_file in dashboard/file_api/pinned_io.py compares a path by file identity with memory.db and its -wal, -shm and -journal, so a case variant on a case-insensitive volume matches too. _open_checked_file, the shared open step behind file-read, file-raw, file-download, file-stream, file-sheet and the office previews, refuses a match as sensitive_path (HTTP 400) before opening it. /api/file-watch (file_api/transfer.py) refuses the same files before its poll loop, and the Python engine in file_api/grep.py skips them without opening them. The memory CLI commands keep their ordinary open: it reads and writes through SQLite, and sqlite_wal.keep_wal_on_close already stops their close from deleting the -wal (the repro below shows learn list and memory export beside a live gateway commit nothing and leave no split).

Office-held files. _open_rb_nofollow keeps its Windows lstat link and reparse-point check, then opens with platform_compat.open_file_for_shared_read (platform_compat_files.py, forwarded by platform_compat.py); on POSIX that helper is a plain read-only open. It replaces the log reader's open_log_file_for_tail, the same open under a log-only name, and kirocrew logs (cli_server.py) calls it directly. A sharing or lock violation (winerror 32 or 33) logs one warning and answers 503 file_busy, "the file is open in another program; close it there and retry" (_FILE_BUSY_ERROR in handlers/files.py), on file-read (file_api/editor.py), file-raw, file-download, file-stream, file-sheet (file_api/sheet.py), file-office-preview (file_api/office_preview.py) and the office-slides routes (handlers/office_slides.py). /api/file-watch reads each change through the helper.

The specs say the same: security.md (the file API refuses the live store), learn-cron-dashboard.md (the Windows busy answer) and platform-compat.md (the shared-read helper in place of the log-tail row).

Backwards compatibility

Breaking: the dashboard file routes (file-read, file-raw, file-download, file-stream, file-sheet, file-office-preview, the office slides and file-watch) refuse <data home>/memory.db and its -wal, -shm and -journal with 400 sensitive_path, and the Python file-grep walk leaves them out of its results. Writer sweep on origin/main @ da1c9b0: no code in the repository requests these paths through the file API; a person could reach them only by opening one in the file browser, which now shows the refusal every sensitive path shows. A raw copy of a live WAL database is not a consistent snapshot anyway; kirocrew memory backup, memory export and the state export read it through SQLite. A Windows sharing violation answered 500 read_failed and answers 503 file_busy; both are failures to every reader below. On POSIX the new open helper is the same read-only open as before. platform_compat.open_log_file_for_tail is gone; its one caller now calls open_file_for_shared_read, the same open.

Reader: website/src/components/useMarkdownPanelDisk.ts:useMarkdownPanelDisk -- chat -- reads /api/file-read and /api/file-watch for a file the user opens; a 400 or a 503 lands in its failed state, as every non-404 refusal does -- test_memory_db_descriptor_locks.py::test_the_file_api_refuses_the_live_memory_db_and_keeps_its_locks
Reader: website/src/components/FileRenderers.tsx:SheetViewer -- chat -- reads /api/file-sheet for a user's spreadsheet, never the data home's memory.db, and treats the 503 as the failure the 500 was -- test_file_viewer_windows_shared_read.py::test_a_holder_that_shares_nothing_answers_busy_and_names_the_cause
Reader: website/src/apps/md-notebook/utils.ts:resolveNoteImageSrc -- app -- asks /api/file-raw only for images under the notebook's vault
Reader: src/kiro_crew/portability_stream.py:_add_sqlite_member -- release -- the state export reads memory.db through the SQLite backup API, not the file API
Reader: src/kiro_crew/cli_commands_memory.py:_memory_verb -- release -- memory export reads memory.db through SQLite, not the file API
Reader: src/kiro_crew/cli_server.py:_tail_log_file -- release -- kirocrew logs opens the log with open_file_for_shared_read, the open open_log_file_for_tail forwarded to -- test_windows_logs_and_diagnostics.py::test_follow_allows_real_writer_rollover

Tests

Fix Tests What they lock in
Memory database locks test/test_memory_db_descriptor_locks.py file-read, file-raw, file-download, file-stream and file-watch refuse the live memory.db, -wal and -shm while the store's locks stay held; another database in the data home still reads; the Python grep walk keeps the locks
Office-held files test/test_file_viewer_windows_shared_read.py the Windows open asks CreateFileW for read, write and delete sharing; a .docx held by Word and an .xlsx held by Excel read as when closed on file-read, file-office-preview and file-download; a holder that shares nothing answers 503 file_busy on every route; file-watch streams an Office-held document
Inventories and the log reader test/test_platform_compat_refactor_facade.py, test/test_windows_logs_and_diagnostics.py the facade forwards open_file_for_shared_read and no longer open_log_file_for_tail; kirocrew logs reads through the shared-read open, including across a real writer rollover

Runs on a Linux DevSpace (Python 3.12) on 2189d9a9e297, on main da1c9b0:

  • 32 related test files (the changed ones above, the dashboard file-route files, the vector-memory WAL split file, the learn and memory CLI files and the platform_compat files) at -n 4 --dist loadgroup --max-worker-restart=2: 2106 passed, 19 skipped, 3 failed. The 3 are test/test_file_grep.py::TestEngines::test_ripgrep_reports_the_same_shape, TestEngines::test_both_engines_answer_one_tree_identically and TestHelpers::test_the_sensitive_globs_are_derived_from_the_shared_fence; they fail the same way on a clean main da1c9b0 on that host, so they come from the host, not this diff. The skips are Windows-only tests.
  • check_black_formatting.py, check_subprocess_encoding.py, isort, flake8, mypy --platform linux src/kiro_crew, check_comment_history.py, check_brand_name.py, check_file_line_cap.py, docs-lint.sh, the harness-parity check and the flake-pattern ratchet: each exits 0.
  • The full backend, frontend and Electron suites run in CI.

Determinism (testing-conventions D12): the three changed test files (test_memory_db_descriptor_locks.py, test_windows_logs_and_diagnostics.py, test_platform_compat_refactor_facade.py) passed 20/20 runs at -n0, 10/10 at -n 4 --dist loadgroup --max-worker-restart=2 beside test_file_viewer_windows_shared_read.py and test_vector_memory_wal_split.py, and in a seeded shuffled order (seed 22326). test_file_viewer_windows_shared_read.py passed 20/20 at -n0, 10/10 at -n 4 and one shuffled run on 987b67f6fa48; this head carries its code unchanged.

A repro script for each defect ran on that host against a detached worktree at 2189d9a9e297 and at main da1c9b0, with no process left behind:

  • Memory database locks (a real isolated gateway, the host's sqlite3): GET /api/file-read on the live memory.db answered 400, the gateway still held its shared lock on memory.db and on the -shm afterwards, the -wal survived a sqlite3 read, and a fresh reader saw the memory the gateway saved after it. Exit 0 here; on main the lock drops and the database splits (exit 1). learn list and memory export run against the live gateway first and open memory.db read-write, as on main; the split check after them stays clean. The script's third check, that those two verbs open O_RDONLY, is dropped because this PR no longer changes them.
  • CLI reads beside a live store: learn list and memory export through the ordinary init(), beside a store holder that keeps or has already dropped its memory.db lock, commit nothing, keep the same -wal file and leave the holder's locks, and the holder's next row reaches a fresh reader. A control without keep_wal_on_close splits.
  • Office-held files (a real isolated gateway, with a Windows CreateFileW share-mode shim on Linux): a .docx held by Word and an .xlsx held by Excel answered 200 on file-read, file-office-preview and file-sheet, and a .csv held with no sharing answered 503 file_busy. Exit 0 here, 1 on main. Real Windows was not run.

Rebased onto main after review; patch unchanged: git range-diff shows 2189d9a9e297 = 52d47fe4adbf = dba203d (on main e577c9a, then 04c99b7). On 52d47fe4adbf the 32 related test files ran again (2107 passed, 19 skipped, the same 3 host failures), with docs-lint.sh; prove.py ran again on dba203d. Main moved in no file this PR changes between them.

Semgrep did not run on that host; CI's SAST job scans this head.

Proof: PROVEN test/test_file_viewer_windows_shared_read.py::test_the_windows_open_shares_read_write_and_delete, test/test_file_viewer_windows_shared_read.py::test_a_document_open_in_office_reads_as_when_closed[/api/file-read-report.docx-holder0], test/test_file_viewer_windows_shared_read.py::test_a_document_open_in_office_reads_as_when_closed[/api/file-office-preview-report.docx-holder1], test/test_file_viewer_windows_shared_read.py::test_a_document_open_in_office_reads_as_when_closed[/api/file-download-budget.xlsx-holder2], test/test_file_viewer_windows_shared_read.py::test_a_holder_that_shares_nothing_answers_busy_and_names_the_cause[/api/file-read-notes.csv] (head dba203d)

Manual verification

The two repro scripts above drove a real isolated gateway through its dashboard API and the kirocrew CLI. The Windows open was checked through a share-mode shim, not on a Windows host.

Screenshots / video

N/A: the diff changes no file under website/; the viewer shows its existing error state for the refused and busy answers.

Related Issues

Fixes #33880

Sibling sweep

Swept: git grep -nE 'MEMORY_DB_FILE|"memory.db"' -- src/kiro_crew
Swept: git grep -nE "os.open(|safe_read_prefix(" -- src/kiro_crew/dashboard/file_api src/kiro_crew/dashboard/handlers/office_slides.py
Sibling: src/kiro_crew/dashboard/file_api/pinned_io.py -- changed here
Sibling: src/kiro_crew/dashboard/file_api/transfer.py -- changed here
Sibling: src/kiro_crew/dashboard/file_api/grep.py -- changed here
Sibling: src/kiro_crew/cli_commands_memory.py -- not affected -- opens memory.db through SQLite with keep_wal_on_close, never a raw descriptor in the gateway's process
Sibling: src/kiro_crew/portability_stream.py:168 -- not affected -- copies memory.db through the SQLite backup API, which keeps SQLite's own per-file lock bookkeeping
Sibling: src/kiro_crew/memory_backup.py:587 -- not affected -- hashes the staged copy, or the live file only in the startup restore pass before the store opens
Sibling: src/kiro_crew/diagnose_probes.py:583 -- not affected -- reads memory.db through a SQLite connection opened mode=ro
Sibling: src/kiro_crew/dashboard/handlers/office_slides.py:309 -- not affected -- reads the gateway's own rendered-slides cache, which no Office app holds

Pattern harvest

Rule candidate: review-prompt
Pattern: code inside the gateway opens and closes a raw descriptor of a SQLite file the same process holds open, which on POSIX drops every record lock SQLite took on it

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 9, 2026 14:53
@bolichen97
bolichen97 requested a review from Zedmor November 9, 2026 14:53
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision dba203df5a76a401228e7d69dc37ba39660eccad touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of dba203df5a76a401228e7d69dc37ba39660eccad — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. Both defects are fixed at the shared open prefix, and every reader of the removed paths is listed in the description.

Notes

  • The refusal only protects memory.db. The same POSIX lock-release split can hit any other WAL database the gateway keeps open under the data home (for example the sqlite_wal-backed stores in autonudge_judge.py and the app storage modules). A follow-up could swap the hard-coded name check for a registry of databases the process holds open.

[DESIGN-REVIEWED] dba203d

Description read

[DESCRIPTION-READ] 9c544dade5af6130dc27d93286bea8789f2814b942a24fec8b9663b812546bd4

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of dba203df5a76a401228e7d69dc37ba39660eccad — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Each item traces to one of the two defects in #33880, and every change sits at the code that caused it: the in-process open, and the CRT share mode.

What this change ships

Inventory (8 items) — 8 justified

Intent: let a user view or search files in the dashboard without splitting the gateway's memory database, and on Windows open a document that Word or Excel has open. FIX.

  1. Viewer routes (read, raw, download, stream, sheet, office previews) refuse memory.db and its -wal, -shm and -journal with 400 sensitive_path — justified
  2. /api/file-watch refuses the same files before it starts polling — justified
  3. The Python file-grep walk skips those files without opening them — justified
  4. On Windows, a document open in Word or Excel now opens in the viewer instead of failing with 500 — justified
  5. A holder that shares nothing now gets 503 file_busy with "close it there and retry" on every viewer route, instead of 500 — justified
  6. On Windows, file-watch keeps refreshing a tab whose document is held open by Office — justified
  7. open_log_file_for_tail is renamed to open_file_for_shared_read; it now has 3 callers (cli_server, pinned_io, transfer) — justified
  8. A busy open logs one warning that names the cause, with no traceback — justified

[FIRST-PRINCIPLES-REVIEWED] dba203d

Description read

[DESCRIPTION-READ] 5c03659f489640456c108e66ccdb71eae9f4b1a532fbf6a107c75dde4a6d163d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed dba203df5a76a401228e7d69dc37ba39660eccad — this comment is updated in place on each push.

Review details

I ran all six candidates through the falsification pass and none survived, so the PR passes.

No findings.

[OPUS-REVIEWED] dba203d

Verdict parsed from the review's SHA-scoped output markers for commit dba203df5a76a401228e7d69dc37ba39660eccad.

False positive or not applicable? A repository writer can comment:
/ai-review override fable dba203df5a76a401228e7d69dc37ba39660eccad false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of dba203df5a76a401228e7d69dc37ba39660eccad and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] dba203d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt dba203df5a76a401228e7d69dc37ba39660eccad false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 enabled auto-merge (squash) November 9, 2026 15:17
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 9, 2026
@bolichen97
bolichen97 force-pushed the fix/sweep-dec-file-io branch from 2111bcd to fa2aaf7 Compare November 10, 2026 05:21
@bolichen97

bolichen97 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor Author
  • Read-only initialization bypasses memory-file permission repair span=62e518ca3349

fixed in fa2aaf7: init_for_read now runs the ordinary open's owner-only lockdown before its mode=ro connect: make_owner_only_dir on the store directory, then _restrict_memory_files on memory.db, -wal, -shm and the FAISS files, each by path (_init_database in vector_memory_lifecycle.py).
The read path still skips prepare_owner_only_sqlite, the WAL switch, migrations, the backfill and every FAISS write, and keeps mode=ro.
No second pass follows the connect: a -wal or -shm the read creates takes the now owner-only database's mode on POSIX and the directory's inheritable owner-only DACL on Windows.
Regression: test_memory_db_descriptor_locks.py::test_a_read_only_verb_still_restricts_an_existing_memory_db_to_its_owner (learn list, memory list, export, carve; sidecars present, or created by the read) passes 8/8 at fa2aaf7 and fails 8/8 with that hunk reverted (0644 where 0600 is expected).

@bolichen97
bolichen97 force-pushed the fix/sweep-dec-file-io branch from fa2aaf7 to 14b6eaf Compare November 10, 2026 05:33
buluoray
buluoray previously approved these changes Nov 10, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on 14b6eaf. Both blockers from the 2111bcd review are fixed. The _EmptyVectorStore stub now has init_for_read, so the 4 export tests pass. init_for_read now runs the owner-only lockdown (make_owner_only_dir and _restrict_memory_files, both by path, no SQLite descriptor) before the mode=ro connect, which answers the GPT ACL finding without reopening the lock-drop issue. A new 8-case test proves it. Every guard is mutation-proven. Decisive lines: test/test_memory_markdown_read.py:68, src/kiro_crew/vector_memory_lifecycle.py:504-507, src/kiro_crew/vector_memory_lifecycle.py:508, src/kiro_crew/dashboard/file_api/pinned_io.py:295

- Dashboard file reads and searches no longer drop the gateway's
  memory.db SQLite locks, a close that could split the memory database.
- The Windows file viewer reads a document Word or Excel holds open
  (delete-sharing open) instead of answering HTTP 500; busy is 503.
@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: a second, read-only open path for the CLI read verbs (init_for_read, _opening_for_read and two mode=ro connects)
resolution: removed

  • CLI read-only open rides along with a fix that is already complete span=364ab608000b

fixed in dba203d: init_for_read, _opening_for_read and both mode=ro branches are gone; learn list and memory list, export and carve call init() again, and those files, their tests and the memory-skills-hooks.md rows match origin/main byte for byte.
No defect of a read-write CLI open was found with keep_wal_on_close applied: beside a store holder that keeps or has already dropped its memory.db lock, plain-init() learn list and memory export commit nothing, keep the same -wal inode, leave the holder's locks, and its next row is visible to a fresh reader. The unprotected control (no keep_wal_on_close) splits.
Against a real isolated gateway, the same two verbs (now opening O_RDWR), then a viewer read and a sqlite3 read: the gateway keeps its lock and its next memory reaches a fresh reader. The same run on main da1c9b0 drops the lock and splits.
Main already pins the class: test_vector_memory_wal_split.py::test_another_process_close_keeps_the_wal_a_lockless_writer_uses.

@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: open_log_file_for_tail kept as a forwarding alias of open_file_for_shared_read
resolution: removed

  • Two public names for one open span=21686c1dd042

fixed in dba203d: the open_log_file_for_tail wrapper, its TYPE_CHECKING forward in platform_compat.py, its facade-inventory entry and its platform-compat.md row are gone; cli_server.py _tail_log_file calls platform_compat.open_file_for_shared_read, and the one remaining row says a log reader uses it so the writer can rotate by rename.
The log-tail tests (test_windows_logs_and_diagnostics.py) patch and exercise open_file_for_shared_read now, the real writer rollover included.
git grep open_log_file_for_tail prints nothing; a check that the facade has no public name whose whole body forwards to another exits 0 at the new head and 1 at 14b6eaf.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 10, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on dba203d. Compared with 14b6eaf, this head removes two things. The first is the CLI read-only open (init_for_read, _opening_for_read, both mode=ro connects and their tests). The second is the open_log_file_for_tail alias, whose one caller and its tests now call open_file_for_shared_read directly. Both answer First Principles findings. The CLI verbs go back to main's init(), which already sets keep_wal_on_close (vector_memory_lifecycle.py:497), so dropping the CLI half adds no data-loss path. The dashboard memory.db refusal, which is the actual lock-drop fix, is unchanged and mutation-proven again. Decisive lines: src/kiro_crew/dashboard/file_api/pinned_io.py:295, src/kiro_crew/dashboard/file_api/transfer.py:84, src/kiro_crew/dashboard/file_api/grep.py:485, src/kiro_crew/vector_memory_lifecycle.py:497, src/kiro_crew/cli_server.py:781

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 10, 2026
@bolichen97
bolichen97 merged commit 81d3b14 into main Nov 10, 2026
101 checks passed
@bolichen97
bolichen97 deleted the fix/sweep-dec-file-io branch November 10, 2026 15:10
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 10, 2026
bolichen97 added a commit that referenced this pull request Nov 10, 2026
…33918)

- Dashboard file reads and searches no longer drop the gateway's
  memory.db SQLite locks, a close that could split the memory database.
- The Windows file viewer reads a document Word or Excel holds open
  (delete-sharing open) instead of answering HTTP 500; busy is 503.

(cherry picked from commit 81d3b14)

Backport note: learn-cron-dashboard.md conflicted; kept release's text
(no 'Editing text-backed viewers' paragraph and release's File read
headers wording) and added only the new Windows open-file paragraph.
The open_log_file_for_tail row is removed from the platform_compat
facade inventory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File viewer: a read of memory.db drops the gateway's SQLite locks, and a file open in Word or Excel answers 500 on Windows

2 participants