Skip to content

docs: RFC for Meetings computer-audio capture (#2814) - #33933

Open
gbrunoo wants to merge 1 commit into
kirodotdev:mainfrom
gbrunoo:rfc/meetings-computer-audio
Open

gbrunoo wants to merge 1 commit into
kirodotdev:mainfrom
gbrunoo:rfc/meetings-computer-audio

Conversation

@gbrunoo

@gbrunoo gbrunoo commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Design document for #2814 (capture computer audio alongside the microphone in the Meetings app), filed through the request-for-change process as asked in the issue thread on 2026-11-05. Docs only, no code.

The RFC proposes answers to the three maintainer questions the issue leaves open:

  • Q1, platforms: any Chromium browser that returns a system-audio track (Chrome/Edge 141+ on macOS 14.2+ and Windows, verified), plus the Electron shell on Windows through loopback. The Electron shell on macOS is out of scope: Chromium under Electron has no system-audio capture there (desktopCapturer: Use ScreenCaptureKit API to enable capturing loopback audio on macOS electron/electron#47490), so the app points the user to a browser instead.
  • Q2, unsupported platforms: show the option wherever getDisplayMedia exists and report capability after the picker runs, because the only reliable signal is whether the returned stream carries an audio track (the same call returns audio or not depending on a toggle inside the picker). Hide it only where the API is absent; show it disabled with the browser alternative where the platform is known not to deliver audio.
  • Q3, consent: per start, never persisted, with a persistent indicator of the active sources and failure states that pause the meeting instead of silently continuing microphone-only.

Phase 1 mixes the two sources in the Web Audio graph ahead of the existing pcm-worklet, so /api/ws/stt, the server and the providers stay unchanged, and no audio is written to disk. Phase 2 adds Windows loopback in display-media.js behind isTrustedRequest. Phase 3 (optional) keeps the sources apart for You / Others labels.

Evidence

The platform table in the RFC comes from a standalone Kiro Crew app I built that captures both tracks from the dashboard page (macOS 26.7, Chrome 156, Kiro Crew desktop shell, 2026-11-09): Chrome with "Entire Screen" and "Share system audio" delivers an audio track that transcribes; Chrome with the toggle off returns video only with no error; the Electron shell returns video only (callback({ video: source })).

Relation to open PRs

#5738 and #7196 each picked answers to the same questions; both persist mixed audio to audio.wav or degrade to microphone-only on failure, which #2814 rules out. The RFC names them under Motivation so the feature is not implemented twice.

Checklist

  • scripts/docs-lint.sh passes (symbol citations, index row added to docs/request-for-change/README.md)
  • scripts/check_brand_name.py passes
  • Front matter per docs/request-for-change/README.md; doc-pr to be set to this PR's number once known

Closes nothing; tracks #2814.

@gbrunoo
gbrunoo requested review from a team and KiroCrewCaptain as code owners November 9, 2026 15:20
@gbrunoo
gbrunoo requested a review from tim-finnigan November 9, 2026 15:20
@github-actions github-actions Bot added the fork Pull request from a fork (external contributor) label Nov 9, 2026
Proposes answers to the three maintainer questions left open in kirodotdev#2814
(platform scope, capability reporting, consent boundary), backed by
measurements of getDisplayMedia system audio in Chrome and in the
Electron shell, and a phased plan whose first phase mixes the computer
audio with the microphone ahead of the existing worklet so the STT
protocol and the server stay unchanged. Records the Electron-on-macOS
gap (electron/electron#47490) as out of scope and names the two open
PRs (kirodotdev#5738, kirodotdev#7196) that conflict with the issue's premises.
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 9, 2026
@gbrunoo
gbrunoo force-pushed the rfc/meetings-computer-audio branch from e8439cf to 843ff82 Compare November 9, 2026 15:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant