Repository navigation
Conversation
Proposes answers to the three maintainer questions left open in kirodotdev#2814 (platform scope, capability reporting, consent boundary), backed by measurements of getDisplayMedia system audio in Chrome and in the Electron shell, and a phased plan whose first phase mixes the computer audio with the microphone ahead of the existing worklet so the STT protocol and the server stay unchanged. Records the Electron-on-macOS gap (electron/electron#47490) as out of scope and names the two open PRs (kirodotdev#5738, kirodotdev#7196) that conflict with the issue's premises.
gbrunoo
force-pushed
the
rfc/meetings-computer-audio
branch
from
November 9, 2026 15:20
e8439cf to
843ff82
Compare
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design document for #2814 (capture computer audio alongside the microphone in the Meetings app), filed through the request-for-change process as asked in the issue thread on 2026-11-05. Docs only, no code.
The RFC proposes answers to the three maintainer questions the issue leaves open:
desktopCapturer: UseScreenCaptureKitAPI to enable capturing loopback audio on macOS electron/electron#47490), so the app points the user to a browser instead.getDisplayMediaexists and report capability after the picker runs, because the only reliable signal is whether the returned stream carries an audio track (the same call returns audio or not depending on a toggle inside the picker). Hide it only where the API is absent; show it disabled with the browser alternative where the platform is known not to deliver audio.Phase 1 mixes the two sources in the Web Audio graph ahead of the existing
pcm-worklet, so/api/ws/stt, the server and the providers stay unchanged, and no audio is written to disk. Phase 2 adds Windows loopback indisplay-media.jsbehindisTrustedRequest. Phase 3 (optional) keeps the sources apart forYou/Otherslabels.Evidence
The platform table in the RFC comes from a standalone Kiro Crew app I built that captures both tracks from the dashboard page (macOS 26.7, Chrome 156, Kiro Crew desktop shell, 2026-11-09): Chrome with "Entire Screen" and "Share system audio" delivers an audio track that transcribes; Chrome with the toggle off returns video only with no error; the Electron shell returns video only (
callback({ video: source })).Relation to open PRs
#5738 and #7196 each picked answers to the same questions; both persist mixed audio to
audio.wavor degrade to microphone-only on failure, which #2814 rules out. The RFC names them under Motivation so the feature is not implemented twice.Checklist
scripts/docs-lint.shpasses (symbol citations, index row added todocs/request-for-change/README.md)scripts/check_brand_name.pypassesdocs/request-for-change/README.md;doc-prto be set to this PR's number once knownCloses nothing; tracks #2814.