Skip to content

feat(terminal): add an opt-in ctrl+c / ctrl+v copy and paste setting - #33979

Merged
bolichen97 merged 1 commit into
mainfrom
fix/33285-terminal-ctrl-copy-paste
Nov 19, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/33285-terminal-ctrl-copy-paste

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On Windows and Linux, a user can turn on a terminal setting so Ctrl+C copies selected text and Ctrl+V pastes, while Ctrl+C with nothing selected still stops the running command.

In the dashboard terminal on Windows and Linux, Ctrl+C always interrupts and Ctrl+V reaches the shell as a raw ^V, so copy and paste need Ctrl+Shift+C / Ctrl+Shift+V or the selection toolbar. A reporter also saw a pasted command arrive in zsh as ^[[200~cp ... and fail with bad pattern. That is the stray ^V: zsh reads it as quoted-insert, so it takes the next paste's opening bracketed-paste ESC as a literal character. On zsh 5.9, ^V followed by a bracketed paste of cp a b and Enter prints zsh: bad pattern: ^[[200~cp.

Why it matters

People who come from Windows Terminal or the VS Code terminal press Ctrl+C and Ctrl+V by habit. Today the copy does nothing or kills the running command, and a Ctrl+V before a paste breaks the pasted command, which then fails or has to be retyped. That is risky for the setup commands the agent hands out, many of which edit config files.

Not a goal

What changed (motivation → approach → change)

Windows and Linux users expect Ctrl+C to copy a selection and Ctrl+V to paste, as Windows Terminal and the VS Code terminal do, but this terminal hands both keys to the shell. Settings → Display → Terminal gains Ctrl+C and Ctrl+V copy and paste. It is off by default and saved per browser next to Copy on select in the mc-terminal-font store; only a stored literal true turns it on. macOS does not get it: the panel does not draw it, the Settings search and Search Everywhere do not list it, and the agent's find_ui answer says it needs Windows or Linux, so neither a search result nor a find_ui answer leads to a page without the switch.

With it on, the terminal's own key handler answers two keys:

Key Selection What happens
Ctrl+C some text selected copies it through the same native copy route Ctrl+Shift+C uses, then clears the selection so the next Ctrl+C interrupts
Ctrl+C nothing selected reaches the shell as the interrupt, as before
Ctrl+V either xterm sends no ^V; the browser's own paste reaches xterm's paste listener

So with the setting on, Ctrl+V no longer reaches any program in the terminal: vim's block select, nano's page down and emacs's scroll need it off.

A key matches on the letter it types, and on the physical key only for a non-Latin layout, so on Dvorak the key at QWERTY's C keeps its own Ctrl+J. The find chord already followed that rule; it is now one helper, isChordLetter in terminalFullscreen.ts, that both use. The toggle sits in DisplayPanel.tsx, the macOS check both searches share in settingsSearchCore.ts, the stored field in useTerminalFont.ts, the key branch in TerminalCompletion.tsx, and the not_macos condition find_ui reports in website/src/uiLocations/ (conditions.ts, descriptors.ts); the regenerated settings-registry.generated.json, settingsRegistry.gen.ts and ui-index.generated.json and every catalog in website/src/i18n/locales/ carry the new toggle.

Backwards compatibility

Compatible: the setting defaults off and a stored preference without the new field loads as off, so every terminal behaves as before until the user turns it on.
Removes nothing: the change adds one setting and the key branch behind it.

Tests

  • website/src/test/TerminalCompletion.test.tsx: with the setting on, Ctrl+C with a selection copies, clears it and is consumed, and the next Ctrl+C passes through; Ctrl+C with no selection passes through; Ctrl+V is kept from xterm without cancelling the event; a remapped Latin layout matches the typed letter and a Cyrillic layout the physical key. With it off, both keys reach xterm unchanged. Three of these fail on the base TerminalCompletion.tsx.
  • website/src/test/useTerminalFont.test.ts: the field persists, a fresh load reads only a literal true as on, and reset clears it.
  • website/src/components/commandPalette/settingsSearchGovernance.test.ts: the search withholds the setting when the platform is macOS and offers it otherwise; it fails with the macOS line removed from settingEntryOffered.
  • test/test_find_ui.py: find_ui answers the setting with the not_macos condition; it fails on the index generated without it.

Manual verification

  • Real product, real keys, on Ubuntu 24.04.5 LTS (kernel 7.0.0-1014-aws): the SPA built from this patch on main at d80be9d7b6 (the later rebase onto current main changed neither the terminal's key handler nor the Display settings page), served by an isolated gateway (a temporary KIROCREW_HOME, a free loopback port, no crons), the terminal at /popout/terminal on a real bash pty, and Playwright 1.58.2 pressing the keys in headless Chromium with clipboard access. Every byte the dashboard sent to the pty was recorded at the terminal WebSocket.
    • Off (the default): Ctrl+C on a selection sent \x03 and left the clipboard alone; Ctrl+V sent \x16.
    • On: Ctrl+C on the selected SELWORD put it on the clipboard and sent nothing to the shell; the next Ctrl+C sent \x03; Ctrl+V sent ESC[200~CLIPTXT ESC[201~ (bash had turned bracketed paste on) and no \x16.
    • Clicking the toggle in Settings → Display → Terminal turns it on. With navigator.platform reported as MacIntel, the row is not drawn and the Settings search for Ctrl+V copy answers "No matching settings"; on Linux the same search lists the toggle.
    • find_ui for Ctrl+C and Ctrl+V copy and paste, through the guide tool's own mcp_guide._find_with_live with the isolated gateway, returns the row with its route unchanged and the not_macos condition, "the dashboard is open on Windows or Linux, not on a Mac (where Cmd+C and Cmd+V already copy and paste)"; plain ui_index.find_ui for the id display.copy-on-select still returns Copy on select with no condition.
  • The zsh cause: on zsh 5.9 in a pty, a bracketed paste of cp a b runs cp, while ^V followed by the same paste prints zsh: bad pattern: ^[[200~cp.
  • Determinism: the three changed frontend test files ran 5 times in a row green, then once in shuffled order (--sequence.shuffle --sequence.seed=33285) green, 151 tests; test/test_find_ui.py ran 5 times in a row green, then once with its 180 tests in reversed order green.
  • Not run: the Windows and Linux desktop app. There, the Edit menu also binds Ctrl+V; the renderer's own paste marks the key handled, so the menu should not paste a second time, but that was not tried on a real desktop build.

Screenshots / video

Settings → Display → Terminal and the Settings search, captured with scripted Playwright (headless Chromium, 1440×900) from that same build served by an isolated gateway.

Off, the default (dark):

Terminal settings with the new toggle off

On (dark), and its hint on hover:

Terminal settings with the new toggle on

The toggle's hint text shown on hover

On (light):

Terminal settings with the new toggle on, light theme

macOS (navigator.platform set to MacIntel): the row is not drawn.

Terminal settings on macOS without the toggle

Settings search for Ctrl+V copy: listed on Linux, not listed on macOS.

Settings search listing the new toggle on Linux

Settings search on macOS with no matching setting

Related Issues

Closes #33285

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of acb7bcc9ca58f7463664581635f008e7ecaa0b39 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The setting is opt-in and off by default, and it answers a linked report (#33285). Every surface it adds has a real consumer: isChordLetter is used for three letters, and the not_macos condition is used by the new row.

What this change ships

Inventory (9 items) — 9 justified

Intent: a Windows or Linux user can copy with Ctrl+C and paste with Ctrl+V in the dashboard terminal without breaking Ctrl+C as an interrupt. This is an ADDITION.

  1. A new "Ctrl+C and Ctrl+V copy and paste" switch in Settings → Display → Terminal, off by default — justified
  2. With it on, Ctrl+C copies selected text and then clears the selection, so the next Ctrl+C interrupts — justified
  3. With it on, Ctrl+V pastes from the browser instead of sending ^V to the shell — justified
  4. With nothing selected, Ctrl+C still interrupts the running command — justified
  5. The switch is not drawn on macOS — justified
  6. Settings search and Search Everywhere leave the setting out on macOS — justified
  7. find_ui answers with a "not on a Mac" condition for this setting — justified
  8. A new ctrlCopyPaste preference saved per browser in the mc-terminal-font store — justified
  9. The find chord's letter matching now goes through one shared helper (isChordLetter) that handles F, C and V — justified

[FIRST-PRINCIPLES-REVIEWED] acb7bcc

Description read

[DESCRIPTION-READ] 9883d52dba38089f3993296593247a315c128a3b36857e428ac99775c2282944

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of acb7bcc9ca58f7463664581635f008e7ecaa0b39 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the setting is opt-in and off by default, it is stored per browser, it takes nothing away, and screenshots of this revision are attached.

Notes

  • The desktop app on Windows and Linux was not tested. Its Edit menu also binds Ctrl+V, so a double paste there is still possible. Check it on a real desktop build before relying on the claim that "the menu should not paste a second time".
  • The key branch in TerminalCompletion.tsx checks only getTerminalFont().ctrlCopyPaste, not !isMac. Only the panel and the search apply the macOS rule. If the stored flag is true on a Mac, Ctrl+V silently stops reaching the shell, and no visible switch exists to turn it off. Adding !isMac to that branch would close this.

[DESIGN-REVIEWED] acb7bcc

Description read

[DESCRIPTION-READ] c3e5335a8f56967104097b0c01244c93cacecc595f038f4f4aea3247169d85ef

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of acb7bcc9ca58f7463664581635f008e7ecaa0b39 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The blind reader saw the new toggle in every state: off, on, the hover hint, light theme, the macOS hide and search. They read it correctly and said they would use it.

Notes

  • The hint terminal_ctrl_copy_paste_desc says "Ctrl+V pastes instead of reaching the shell". The blind reader said "'reaching the shell' don't mean much to me". It also leaves out the real cost the PR names: vim, nano and emacs lose Ctrl+V. Suggested wording: "Ctrl+V pastes, so programs like vim and nano no longer receive it."
  • The blind reader couldn't tell how this row differs from "Copy on select" just above it, or what happens with both on. The hint could add that the two work together.

[UX-REVIEWED] acb7bcc

Description read

[DESCRIPTION-READ] 9cf67d5c56745b957457fce4b7cdbc525a1a071bffe38580e1dda96f227bf96e

That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed acb7bcc9ca58f7463664581635f008e7ecaa0b39 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] acb7bcc

Verdict parsed from the review's SHA-scoped output markers for commit acb7bcc9ca58f7463664581635f008e7ecaa0b39.

False positive or not applicable? A repository writer can comment:
/ai-review override fable acb7bcc9ca58f7463664581635f008e7ecaa0b39 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings (all downgraded on adjudication)

GPT 6.1 flagged blocking issues on acb7bcc9ca58f7463664581635f008e7ecaa0b39; Opus 5.5 adjudication downgraded every one of them. Downgraded: the remedy each one needs is disproportionate to the harm it prevents. Adjudication downgraded all 1 blocking finding(s): the remedy each one requires is disproportionate to the harm it prevents.

This comment is updated in place on each push.

Review details

BLOCKING -- website/src/components/TerminalCompletion.tsx:551 -- Apply shortcut changes to already-open terminal popouts

if (e.ctrlKey && !e.shiftKey && !e.metaKey && !e.altKey && getTerminalFont().ctrlCopyPaste) {
Trigger: Open a terminal popout with the setting off, enable it in the main dashboard, then press Ctrl+C with terminal text selected. DisplayPanel calls setTerminalCtrlCopyPaste, which updates only that window’s module state; the popout’s handler still reads false because useTerminalFont never adopts cross-window storage changes.
Outcome: Ctrl+C interrupts the running command instead of copying despite the enabled setting; Ctrl+V retains its shell behavior until the popout reloads.
Anchor: defect
Fix: Adopt mc-terminal-font storage changes in useTerminalFont and notify subscribers without writing the adopted state back.
Sites: The Ctrl+V branch at website/src/components/TerminalCompletion.tsx:557 and the setting row in other already-open dashboards at website/src/pages/settings/DisplayPanel.tsx:1103 read the same stale state.

[BLOCK-MERGE-DOWNGRADED] acb7bcc
[GPT-REVIEWED] acb7bcc

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

F1 — LOW. The failure needs a terminal popout opened before the setting is turned on. The store reads localStorage only once, when the module loads (website/src/hooks/useTerminalFont.ts:107). set() updates and notifies only the window it runs in (useTerminalFont.ts:112-123), and nothing listens for storage events. That gap already exists on the base branch for every setting in this store (font size, cursor style, copy-on-select), so it isn't new. The handler checks the stale flag at website/src/components/TerminalCompletion.tsx:551, so Ctrl+C keeps its usual shell interrupt, the same as before this setting existed. The user can see it, and reloading the popout fixes it through loadPersisted() (useTerminalFont.ts:81-107).
The real fix is a cross-window storage-event sync for the whole store that adopts the new state without writing it back, which is a new mechanism for every setting this PR doesn't own. That costs more than a stale opt-in shortcut in an already-open popout.

[ADJUDICATION] acb7bcc9ca58f7463664581635f008e7ecaa0b39 total=1 uphold=0 downgrade=1
DOWNGRADE F1 website/src/components/TerminalCompletion.tsx:551 reason=disproportionate-remedy
[GPT-ADJUDICATED] acb7bcc9ca58f7463664581635f008e7ecaa0b39

False positive or not applicable? A repository writer can comment:
/ai-review override gpt acb7bcc9ca58f7463664581635f008e7ecaa0b39 false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 enabled auto-merge (squash) November 9, 2026 17:18
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 9, 2026
buluoray
buluoray previously approved these changes Nov 9, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at ebdff0e. Adds an opt-in Ctrl+C / Ctrl+V copy-paste toggle in Settings > Display > Terminal, hidden on macOS (website/src/pages/settings/DisplayPanel.tsx:999-1008). It is off by default and only a stored literal true turns it on (website/src/hooks/useTerminalFont.ts:87, :100). Ctrl+C with no selection, or with the setting off, still reaches the shell as the interrupt (website/src/components/TerminalCompletion.tsx:551-558). GPT, Opus, Design and UX pass on this head. The reds are the main-wide lazy-import count (#34010) and an Analyze (javascript-typescript) run that ended with "CodeQL job status was configuration error", not a finding.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 9, 2026
@bolichen97
bolichen97 force-pushed the fix/33285-terminal-ctrl-copy-paste branch from ebdff0e to 7c66d94 Compare November 10, 2026 05:20
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in src/kiro_crew/docs/ui-index.generated.json, src/kiro_crew/docs/settings-registry.generated.json, website/src/components/commandPalette/settingsRegistry.gen.ts, docs/feature-map/README.md and the locale catalogs since this head went green (2b5cfe3 -> 3467dd6); CI re-running.

The generated find_ui index conflicted with main, so it was rebuilt with npm run gen:ui on the new base; every hand-written file's change is the same as on the reviewed head. The new base also carries #34010, the lazy-import count fix for the test_the_lazy_imports_stay_inside_the_functions_that_need_them failure this head's Backend Tests shard 6 hit on main.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 10, 2026
@bolichen97
bolichen97 force-pushed the fix/33285-terminal-ctrl-copy-paste branch from 7c66d94 to 42a5e0c Compare November 11, 2026 12:27
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in src/kiro_crew/docs/ui-index.generated.json, src/kiro_crew/docs/settings-registry.generated.json, website/src/components/commandPalette/settingsRegistry.gen.ts, website/src/components/commandPalette/settingsSearchGovernance.test.ts, docs/feature-map/README.md and the locale catalogs since this head went green (3467dd6 -> 8ae0a1d); CI re-running.

GitHub reported the branch as conflicting: the generated find_ui index conflicted with main, so it was rebuilt with npm run gen:ui on the new base. The same push carries the fix for the macOS settings-search finding (its disposition is posted separately); every other file's change is the same as on the reviewed head.

[operator: bolichen97]

@bolichen97

bolichen97 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor Author
  • Exclude the unavailable setting from macOS search results span=1a576a58dd45

fixed in 42a5e0c: settingEntryOffered in settingsSearchCore.ts now returns !isMac for display.ctrl-c-and-ctrl-v-copy-and-paste, the same isMac check that keeps the row out of DisplayPanel.tsx on macOS.
Every surface that searches the settings registry goes through that check: the Settings search box, Search Everywhere (full search and the per-tab list) and the command bar, so no macOS search result leads to a page without the switch.
settingsSearchGovernance.test.ts mocks the platform: with macOS the entry is withheld and with any other platform it is offered; the test fails with the macOS line removed.

[operator: bolichen97]

@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 11, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 13, 2026
@bolichen97
bolichen97 force-pushed the fix/33285-terminal-ctrl-copy-paste branch from 833b247 to 2e83244 Compare November 13, 2026 04:22
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/feature-map/README.md, src/kiro_crew/docs/ui-index.generated.json, src/kiro_crew/docs/settings-registry.generated.json, website/src/components/commandPalette/settingsRegistry.gen.ts and the locale catalogs since this head went green (4de745e -> 27e9359); CI re-running.

The generated find_ui index conflicted with main, so it was rebuilt with npm run gen:ui on the new base; every hand-written file's change is the same as on 833b247. That head's reds were not about this change: the CodeQL upload hit a CI rate limit, and Backend Tests (3.12, 7) failed only test_the_scan_is_linear_not_quadratic, the wall-clock flake tracked in #28212 (also seen on main).

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 13, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 13, 2026
@bolichen97
bolichen97 force-pushed the fix/33285-terminal-ctrl-copy-paste branch from 2e83244 to d9bf929 Compare November 13, 2026 09:25
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in src/kiro_crew/docs/ui-index.generated.json, src/kiro_crew/docs/settings-registry.generated.json, website/src/components/commandPalette/settingsRegistry.gen.ts, website/src/components/commandPalette/settingsSearchCore.ts and the locale catalogs since this head went green (27e9359 -> 6149be8); CI re-running.

GitHub reported the branch as conflicting, only in the generated find_ui index: main's copy was taken and npm run gen:ui re-run on the new base. Every other file's change is the same as on 2e83244; only the index's input_digest differs. The previous head's reds were not about this change: the CodeQL upload hit a CI rate limit, and Backend Tests (3.12, 7) lost an xdist worker inside test/test_transcribe.py (recorded on #36406), which also failed Coverage Gate.

This head was re-checked on Linux (Ubuntu 24.04) against the real dashboard with an isolated gateway. The setting off leaves Ctrl+C and Ctrl+V as before. With it on, Ctrl+C copies and clears a selection, Ctrl+C with nothing selected still interrupts, and Ctrl+V pastes with no ^V (bracketed when the program asks). On macOS the row is hidden. The screenshots in the description are recaptured from this head.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 13, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Re-sync budget reset: this PR conflicts with main again (docs/feature-map/README.md and the generated src/kiro_crew/docs/ui-index.generated.json), and its head's only reds are main's: Source Gates' docs lint flagged docs/request-for-change/rfc-app-agent-tools-third-party-grant.md as unreachable, which main has since linked from its README, and Await Fast Gate / Coverage Gate failed as a cascade of that. It is inside its 48-hour watch window; one re-sync onto current main.

[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/feature-map/README.md, src/kiro_crew/docs/settings-registry.generated.json, src/kiro_crew/docs/ui-index.generated.json, website/src/components/commandPalette/settingsRegistry.gen.ts, website/src/components/commandPalette/settingsSearchCore.ts, website/src/components/commandPalette/settingsSearchGovernance.test.ts, website/src/pages/settings/DisplayPanel.tsx, website/src/utils/terminalFullscreen.ts and the locale catalogs since this head went green (6149be8 -> ce21fa1); CI re-running.

The old head conflicted with main in docs/feature-map/README.md, src/kiro_crew/docs/ui-index.generated.json, settingsSearchCore.ts and settingsSearchGovernance.test.ts. Main's own lines at the spots this change edits are kept beside the new ones (settingEntryOffered and the governance test's GOVERNED_IDS). The generated files are main's with this change's entries added; npm run gen:ui and npm run gen:settings rewrite nothing on the new head. The edit to docs/feature-map/README.md is dropped: that map's gate fires only when a page, handler or route is added or removed, and this change only edits existing files.

The new head also carries one addition: the agent's find_ui answer says the toggle needs Windows or Linux (a not_macos condition in website/src/uiLocations/), pinned by test/test_find_ui.py. The description is updated to match. The panel row, key handler and stored setting are the same as in the captured build, so the screenshots in the description still show this head.

[operator: bolichen97]

@bolichen97

bolichen97 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] Re-sync note for head d9bf929. It answers no review finding, so it is a plain note, not a review disposition.

Dropped the non-required docs/feature-map/README.md edit so a re-sync conflicts only where main and this change touch the same lines; generated files are regenerated, never hand-merged.

  • Removed in 0b1c0b9: the display row edit in docs/feature-map/README.md is gone. scripts/check_feature_map.py fires only when a page, handler or route is added or removed, and this diff only edits existing files.
  • The three counted pushes followed heads whose review lanes failed on CI infrastructure (rate-limited comment posts on 231567a, lanes that ended within a minute of the push on 5acef93) or on round 0's GPT finding on 7c66d94, fixed then; no span recurred.

On Windows and Linux the dashboard terminal sends Ctrl+C to the shell
as an interrupt and Ctrl+V as a raw ^V, so copying and pasting needs
Ctrl+Shift+C / Ctrl+Shift+V or the selection toolbar. The stray ^V also
breaks the next paste in zsh: quoted-insert takes the paste's opening
bracketed-paste ESC literally, so the command arrives as ^[[200~... and
fails.

Settings > Display > Terminal gains "Ctrl+C and Ctrl+V copy and paste",
off by default, stored per browser beside Copy on select. It is not
offered on macOS: the panel does not draw it, the settings search does
not list it, and the find_ui index says it needs Windows or Linux. With
it on, Ctrl+C copies and clears a selection and still interrupts when
nothing is selected, and Ctrl+V is left to the browser's own paste
instead of reaching the shell. The key is matched on the letter typed,
falling back to the physical key only on a non-Latin layout, through one
helper the find chord now shares.

Closes #33285
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in src/kiro_crew/docs/settings-registry.generated.json, src/kiro_crew/docs/ui-index.generated.json, test/test_find_ui.py, website/src/components/commandPalette/settingsRegistry.gen.ts, website/src/components/commandPalette/settingsSearchCore.ts, website/src/components/commandPalette/settingsSearchGovernance.test.ts, website/src/pages/settings/DisplayPanel.tsx, website/src/uiLocations/descriptors.ts and the locale catalogs since this head went green (ce21fa1 -> 910f01f); CI re-running.

What this fixes on the old head:

The change itself is the same patch. Main's OSC 52 terminal copy (#30742) landed in between: the two keys this setting claims never reach the program, so they neither open nor close its copy window, as Ctrl+Shift+C and Ctrl+Shift+V already do not. The screenshots in the description are re-captured in main's grouped Settings layout.

[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Apply shortcut changes to already-open terminal popouts span=81d78c3a9270

Rebutted: the terminal popout is its own window.open window, and the mc-terminal-font store in website/src/hooks/useTerminalFont.ts reads localStorage once at module load and has no storage listener, on main and on this head. Font family, size, cursor style and Copy on select already stay stale the same way in a popout opened before the change.
The new setting keeps that store contract: in the window where it is toggled it applies on the next key press (getTerminalFont() is read inside the key handler at TerminalCompletion.tsx:551), and a popout opened earlier adopts it on reload. Until then that popout keeps today's keys (Ctrl+C interrupts, Ctrl+V reaches the shell), so nothing is lost or sent somewhere new.
Adopting cross-window storage changes is a new sync mechanism for all five settings in the store, outside this PR's goal; the CI adjudicator ruled it LOW for the same reason.

[operator: bolichen97]

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed head acb7bcc. Checked the new terminal key branch: it acts only on keydown, with Ctrl alone and the setting a literal true. Ctrl+C with a selection copies through the existing native copy route and then clears the selection, Ctrl+C with no selection still interrupts, and Ctrl+V is kept from the shell without cancelling the browser paste. The macOS gating is consistent across the settings panel, both settings searches and the find_ui condition. The settings store defaults the new field off and resets it. The four changed frontend test files and the find_ui tests pass locally on this head, and the new tests fail when the feature code is disabled. The open point about an already open popout not seeing the toggle until reload is the store's existing behaviour on main for every terminal setting and fails safe, so nothing blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let the dashboard terminal use standard Ctrl+C and Ctrl+V for copy and paste

3 participants