Repository navigation
Conversation
Clicking option chips joined the draft and each pick with ", ", which
produced "Looks good., Merge it now" and "Merge it now, Show me the
diff". A draft that already ends with punctuation now gets only a
space, a capitalised pick starts a new sentence (". "), and a
lowercase pick keeps ", ". Labels are never re-cased.
First Principles Review (Opus 5.5, fork) —
|
UX Review (Opus 5.5, fork) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing the screenshots of the composer text after picking options. The description's five Evidence gaps
Notes
[UX-REVIEWED] 3d6d5c8 Description read[DESCRIPTION-READ] b9a287b3dd9e69c49025fc3e039c36fcd0d45a1105ec4a6e5432c7ab568adc68 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the separator rule stays inside Notes
[DESIGN-REVIEWED] 3d6d5c8 Description read[DESCRIPTION-READ] 5855c7b5be203be5b31b1835166afe04c63476c18dc5b3f9d03be5dc3a016fab That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
|
Moved to #36085 (same commit, branch now on kirodotdev). |
Problem / Motivation
Goal: Picking several follow-up options fills the composer with text that reads like sentences.
The option chips joined the draft and every pick with
,. Two capitalised picks read "Merge it now, Show me the diff", and a draft that already ended a sentence got a second separator: "Looks good., Merge it now".Why it matters
The composer text is what gets sent. People who type a short note and then click one or more chips have to fix the punctuation by hand before they send.
Not a goal
CR-123,Kiro), so a lowercased first letter would change them.app-sdk/useComposerDraft.ts). It reads picks back from the draft by their,separators, so changing it needs its own change to that read-back. Its single-select path already goes throughfollowUpToggleand gets the new rule.What changed (motivation → approach → change)
renderTailinlib/followUpToggle.tsnow picks the separator before each piece instead of always using,:.!?;:,or…, with optional closing quotes or brackets.,The owned-span model is unchanged: the tail is still rendered from
{ base, options }, so removing a pick re-renders the separators around it and the "user edited the tail" check still compares against the exact rendered text.Backwards compatibility
Compatible. No setting, API or stored state changes. Only the text a chip click writes into the composer changes.
Tests
followUpToggle.test.ts: a draft ending with a period, a question mark, a comma, or a closing quote after a period gets only a space; two capitalised picks join with.; a lowercase pick joins with,; removing the middle of three picks re-renders the separators; a label ending with.gets only a space before the next pick.ChatPage.followUpToggle,ChatPane.followUpOptionsanduseComposerDraft(single-select): expected strings updated to the new separators. The comma-bearing label tests (fix(chat): remove only the complete generated suffix on a ChatPane chip un-toggle #7616 F1) use lowercase labels and keep,.Local gates:
tsc -p tsconfig.app.json, eslint on the changed files, and vitest on the follow-up, composer, ChatEmbed and QuickSend test files all pass.Manual verification
Built SPA in two isolated pods with fake data, one on
mainand one on this branch. One session ends with[OPTIONS: Merge it now | Show me the diff | Run the tests].Screenshots / video
Dark theme, two picks:
Related Issues
N/A: no issue filed.
Checklist