Skip to content

fix(security): let Outlook's own webLink through the link guard - #34034

Merged
bolichen97 merged 1 commit into
mainfrom
crew/slack/owa-item-id-link-guard
Nov 10, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
crew/slack/owa-item-id-link-guard

Conversation

@buluoray

@buluoray buluoray commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Shared-code change: src/kiro_crew/dashboard/chat_turn/segment_flush.py. A streamed reply is redacted per delta, then the segment flush redacts the whole text and withholds the reply if a value a delta removed comes back. A delta that cuts an Outlook link sees only part of its id, which looks like a key, and removes it; the whole text then keeps the intact link, so the flush withheld the ENTIRE reply (GPT finding on this PR, reproduced; it also hit #25599's path links on main whenever a delta held 40+ characters of the id). The flush now stops counting a removed value only when every occurrence of it in the saved text lies wholly inside an Outlook link the final pass keeps (_chat_mail_link_spans, Outlook hosts only), and blanks those links before its "shows more" run check. The containment check walks the value's occurrences and the links with one forward cursor, so a reply repeating a link thousands of times costs occurrences plus links, not their product (GPT finding: the per-occurrence rescan could stall the event loop past the watchdog). Any other occurrence, any other host, or any key outside the link still withholds or masks exactly as before.

Problem / Motivation

Goal: Outlook on the web links that Microsoft Graph returns for a message or an event (webLink) open from a Kiro Crew reply, while a key hidden in or near them is still masked and blocked.

An agent reply with a link to an Outlook on the web draft was blocked by the link guard. The chip said the query has 201 characters (over the 200-char limit) and that part of it looks like a secret, so the full address was not kept and the link could not be opened from the card. The link is Graph's own webLink: https://outlook.office365.com/owa/?ItemID=<id>&exvsurl=1&viewmodel=ReadMessageItem. Reported in the internal Kiro Crew debug channel on 2026-11-09.

Why it matters

Every Graph message, draft and event link has this shape, and its id alone is ~160 characters of base64, so nearly every Outlook link an agent writes from a mail or calendar tool is blocked. A host exemption cannot help: the credential pass masks the id on any host, so the "looks like a secret" part stays.

Not a goal

What changed (motivation → approach → change)

Symptom: Graph's Outlook webLink is blocked and its id masked. Cause: #25599 exempts Outlook item ids only in the path; this route carries the id in the query, so the bare-secret pass masks it, and the exfil gate flags its 201-char, base64-shaped query. Change: recognise this one exact link and judge it with one matcher on both gates.

  • redaction_entropy.py: _chat_mail_link_at reads on into the query only when the path is exactly /owa/. The query must be exactly ItemID=<id>&exvsurl=1&viewmodel=ReadMessageItem or itemid=<id>&exvsurl=1&path=/calendar/item, fields in that order, nothing else (_OWA_WEB_LINK_QUERIES, _outlook_web_link_item). The id passes the same checks as a path id: Exchange prefix, alphabet, length, whole-Exchange-id decode. The no-key-shaped-piece check runs on the whole link. No regex.
  • exfil.py: _exfil_url_warning asks the same matcher (_outlook_web_link_tail) on https with no port. If it matches, only the bytes after the link (a sentence's ., a fragment) stay under the length and base64 heuristics, the way the Slack app-create carve-out keeps its alias. The earlier checks (hard and fixed credentials, the multi-pass decode, heavy percent-encoding) run first and are unchanged.
  • segment_flush.py: _outlook_link_spans, _blank_spans, _only_inside; _kept_removed_values takes the link spans; _whole_text_refusal passes them (see the note at the top).
  • docs/system-specs/modules/security.md: both rules. test_security_gate_liveness.py: _PACKAGE_LINE_BUDGET 35,160 → 35,227, measured. redaction.py: the five new owner names are listed in the facade's TYPE_CHECKING manifest.

Security

This is a narrowed carve-out on the exfil gate, so here is why it is safe. It is keyed to validated bytes, not to the host. The path, the field names and the fixed values are constants, so the only free bytes are the id's. The id must decode as one whole Exchange folder or message entry id. Its free fields are GUIDs and counters, at most 22 bytes each, about 77 bytes in all. That is less than the sub-200-char query any URL may carry past these heuristics today. A 40-char key-shaped piece anywhere in the link (raw, between escapes, decoded) voids the match. Then the link is masked and blocked as before. Any extra field, other order, other value, other path, look-alike host, http or a port also voids it and falls back to the old rules.

Backwards compatibility

Compatible: only this one exact link changes, from blocked to allowed. Every other URL is judged exactly as on main.

Removes nothing: no check, key or path is taken away. One link shape moves from masked to allowed.

Tests

test/test_outlook_web_link_redaction.py (new):

  • test_the_reported_link_trips_both_gates_on_its_own_merits: the reported query is 201 chars, trips the bare-secret pass, and is flagged on another host.

  • test_the_web_link_survives_both_gates: message, event and outlook.office.com links survive redact_credentials, scan_exfiltration_urls and redact_exfiltration_urls in 6 text templates.

  • test_a_key_in_or_near_the_web_link_is_still_blocked: a key as the id, glued after the id or the last field, in an extra field, in a fixed value, in the path or in the fragment is still masked AND still flagged.

  • test_anything_but_the_exact_web_link_is_still_blocked: other host, look-alike host, http, a port, another path, reordered or renamed fields, another value, or a long extra field with no key shape is still flagged.
    test/test_segment_flush_outlook_links.py (new), streamed through the real per-delta removers and the segment flush:

  • test_a_streamed_web_link_is_saved_whole / test_a_streamed_path_link_is_saved_whole: 4, 8, 16, 32 and 64-char deltas, a mid-id cut, and (web link) a cut before &exvsurl; each saves the reply unchanged.

  • test_a_split_secret_in_or_near_an_allowed_link_stays_hidden: a key alone, as the id of an allowed-looking link, glued after an allowed link or after its ., or as the next word, at each delta size; the key never appears in the save.

  • test_a_key_split_after_a_kept_link_is_masked_and_the_link_kept, test_the_reply_is_still_withheld_when_a_removed_value_shows_outside_a_link (inside, outside, inside+outside, straddling the start or the end, no links), test_a_non_outlook_chat_link_gets_no_exemption, test_a_reply_repeating_a_link_costs_occurrences_plus_spans_not_their_product (counts span reads for 2,000 copies; the per-occurrence rescan reads 20,010 and fails it).

  • Mutation-checked: making _only_inside never true, any-occurrence instead of every, dropping the start or end bound, dropping the span blanking, or dropping the Outlook host filter each turns at least one test red.

  • test_the_span_covers_the_query_and_stops_before_a_sentence_end, test_another_routes_query_stays_outside_its_span: span edges; a /mail/ route's query stays outside its span, as on main.

Proof: PROVEN test/test_outlook_web_link_redaction.py::test_the_web_link_survives_both_gates[bare-message], test/test_outlook_web_link_redaction.py::test_the_web_link_survives_both_gates[bare-event], test/test_outlook_web_link_redaction.py::test_the_web_link_survives_both_gates[bare-office-host], test/test_outlook_web_link_redaction.py::test_the_web_link_survives_both_gates[sentence-message], test/test_outlook_web_link_redaction.py::test_the_web_link_survives_both_gates[sentence-event] (head 7e13248)

With only segment_flush.py reverted to main (the rest of the fix kept), 7 of the 57 tests in test/test_segment_flush_outlook_links.py fail; they pass on this head. (prove.py --per-hunk could not run: pytest wrote no report for one mutant.)

Related tests run locally, single process (-n 0): test_outlook_web_link_redaction.py, test_document_link_redaction.py, test_security_exfil_urls.py, test_redaction_blocked_links.py, test_redaction_mirror_parity.py, test_security_gate_liveness.py, test_redaction_allow.py, test_security_oauth_urls.py: 966 passed; the segment-flush, chat_runner composition/coverage, SRI and facade-mirror files: 1206 passed. test_flake_pattern_ratchet.py passed, semgrep diff scan clean, black/isort/flake8/mypy clean.

Determinism: the new file is pure functions on constant inputs (no clock, files, threads or network). 39 passed on each of 3 repeats and once in reversed collection order.

Manual verification

N/A — unit coverage sufficient: the change is two pure functions, and the tests drive the real public redactors on the reported link shape.

Related Issues

Reported on Slack (internal), no GitHub issue. Follows #25599.

Sibling sweep

Swept: git grep -n "_OUTLOOK_HOSTS|_chat_mail_link_at" -- src/
Sibling: src/kiro_crew/security/redaction_entropy.py -- changed here
Sibling: src/kiro_crew/security/exfil.py -- changed here

Pattern harvest

Not generalizable: each link format needs its own closed shape and id check; a general rule for "base64 in a query" is what the gate exists to block.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 9, 2026 18:12
@buluoray
buluoray requested a review from tim-finnigan November 9, 2026 18:12
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Security Scope Review -- ✅ human override accepted

@buluoray overrode this lane for 7e13248262a26aed11c48bae0816171d5186f2ca via /ai-review override (this commit only).

[SCOPE-REVIEWED] 7e13248

@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 9, 2026
@buluoray

buluoray commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Closing and reopening to re-trigger CI: every run on da33347 failed at startup on 2026-11-09 18:13Z from the installation API rate limit, and startup-failed runs cannot be retried.

@buluoray buluoray closed this Nov 9, 2026
@buluoray buluoray reopened this Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/security/exfil.py

  • src/kiro_crew/security/redaction.py

  • src/kiro_crew/security/redaction_entropy.py

  • @bolichen97 approved 7e13248 with a complete reasoning template.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 7e13248262a26aed11c48bae0816171d5186f2ca touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 7e13248262a26aed11c48bae0816171d5186f2ca — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: one matcher on validated bytes decides both gates, the flush change only skips values that sit wholly inside a matched Outlook span, and no other URL changes.

Notes

  • The dashboard's sanitizeExfiltrationUrls (website/src/utils/sanitize.ts) has no matching carve-out. It doesn't run on reply bodies today. If it ever runs on prose that carries these links, those links will be masked again.

[DESIGN-REVIEWED] 7e13248

Description read

[DESCRIPTION-READ] c90885ae796246341a9d003e382c66d026c9658e2c291d3718795677c0cc59f0

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 7e13248262a26aed11c48bae0816171d5186f2ca — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. All three gate changes are needed to open the reported link, and each one reuses the existing _chat_mail_link_at matcher instead of adding a second copy.

What this change ships

Inventory (5 items) — 5 justified

Intent: a person can open the Outlook webLink that Graph returns for a message or event straight from a reply, and a key hidden in or near it is still masked. FIX.

  1. The id in Outlook /owa/?ItemID=… and /owa/?itemid=…&path=/calendar/item links is no longer masked as a secret — justified
  2. The exfil gate no longer flags that exact link's 201-char query; anything glued after the link is still judged — justified
  3. A streamed reply that holds an Outlook link split across deltas is saved whole instead of being withheld; this also covers the fix(security): keep Outlook and Slack links out of the bare AWS secret pass #25599 path links on main — justified
  4. The security spec now describes both carve-outs — justified
  5. The liveness line budget goes from 35,160 to 35,227 — justified

[FIRST-PRINCIPLES-REVIEWED] 7e13248

Description read

[DESCRIPTION-READ] 213a8786d5176ab35ef09a4a9a7b47968d61dc3a0a5925a629781f551a5e8a6a

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 7e13248262a26aed11c48bae0816171d5186f2ca — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 7e13248

Verdict parsed from the review's SHA-scoped output markers for commit 7e13248262a26aed11c48bae0816171d5186f2ca.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 7e13248262a26aed11c48bae0816171d5186f2ca false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 7e13248262a26aed11c48bae0816171d5186f2ca and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 7e13248

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 7e13248262a26aed11c48bae0816171d5186f2ca false-positive: <reason, 20 to 500 characters>

@buluoray
buluoray force-pushed the crew/slack/owa-item-id-link-guard branch from da33347 to c8093e4 Compare November 9, 2026 20:44
@buluoray

buluoray commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

span=ec9ed038f45d
self-added: yes
mechanism: Outlook webLink branch in _exfil_url_warning pushed exfil.py past the 2,000-line cap

fixed in c8093e4: the selection logic and its comment moved into redaction_entropy._outlook_web_link_tail; exfil.py keeps a 2-line branch and is 1,999 lines, no baseline row. scripts/check_file_line_cap.py exits 0 and the 966 related tests pass.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 9, 2026
@buluoray
buluoray force-pushed the crew/slack/owa-item-id-link-guard branch from c8093e4 to b84f2d6 Compare November 9, 2026 21:30
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 9, 2026
@buluoray
buluoray force-pushed the crew/slack/owa-item-id-link-guard branch from b84f2d6 to 8b9372e Compare November 9, 2026 22:03
@buluoray

buluoray commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

span=40b4e3d07714
self-added: no
mechanism: segment flush counted a delta-removed piece of an intact Outlook link as a value coming back and withheld the reply

fixed in 8b9372e: segment_flush._kept_removed_values no longer counts a removed value whose every occurrence in the saved text lies wholly inside an Outlook link the final pass keeps (_outlook_link_spans over _chat_mail_link_spans, Outlook hosts only); those links are blanked before the run check. Any other occurrence still withholds the reply.
Reproduced first with the repo's own _redact_delta / _accumulate_segment_raw / _redact_segment: 64-char deltas and the cut before &exvsurl withheld the reply, for this route and #25599's path route on main.
Tests: test/test_segment_flush_outlook_links.py saves both links whole at 4/8/16/32/64-char deltas and a mid-id cut, and keeps a key hidden alone, as the id, glued after the link, or as the next word. 7 of its 57 tests fail with segment_flush.py reverted to main; each of 5 mutations of the new branch turns a test red.

@buluoray
buluoray force-pushed the crew/slack/owa-item-id-link-guard branch from 8b9372e to 8961c8a Compare November 9, 2026 22:28
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 9, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 9, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 10, 2026
@buluoray

Copy link
Copy Markdown
Contributor Author

/ai-review override scope c3dc90a infra-failure: agent: stale monotonic floor, not a finding. Attempt 3 adjudicated VERDICT: PASS (https://github.com/kirodotdev/KiroCrew/actions/runs/42716562857/job/129549910126) but is held at the failure that attempts 1 and 2 published when GitHub answered "API rate limit exceeded for installation": https://github.com/kirodotdev/KiroCrew/actions/runs/42716562857/job/129500679268 https://github.com/kirodotdev/KiroCrew/actions/runs/42716562857/job/129522626864

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray recorded a infra-failure release (class infra-failure) for the scope AI finding on c3dc90a6d11ff6f42c47da6afac5397c4af81d27.

agent: stale monotonic floor, not a finding. Attempt 3 adjudicated VERDICT: PASS (https://github.com/kirodotdev/KiroCrew/actions/runs/42716562857/job/129549910126) but is held at the failure that attempts 1 and 2 published when GitHub answered "API rate limit exceeded for installation": https://github.com/kirodotdev/KiroCrew/actions/runs/42716562857/job/129500679268 https://github.com/kirodotdev/KiroCrew/actions/runs/42716562857/job/129522626864

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: Security Scope Review. Re-run the lane's latest workflow run for c3dc90a6d11ff6f42c47da6afac5397c4af81d27 manually from the Actions tab.

@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 10, 2026
@buluoray
buluoray force-pushed the crew/slack/owa-item-id-link-guard branch from c3dc90a to 7e13248 Compare November 10, 2026 01:46
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 10, 2026
@buluoray

Copy link
Copy Markdown
Contributor Author

/ai-review override scope 7e13248 infra-failure: agent: rate-limited lane, not a finding. Run 42738125200 adjudicated VERDICT: PASS, then its floor step could not read this head's prior check-runs ("API rate limit exceeded for installation", 3 attempts) and failed closed: https://github.com/kirodotdev/KiroCrew/actions/runs/42738125200/job/129575551378 A rerun would be held at that failure, as on c3dc90a.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray recorded a infra-failure release (class infra-failure) for the scope AI finding on 7e13248262a26aed11c48bae0816171d5186f2ca.

agent: rate-limited lane, not a finding. Run 42738125200 adjudicated VERDICT: PASS, then its floor step could not read this head's prior check-runs ("API rate limit exceeded for installation", 3 attempts) and failed closed: https://github.com/kirodotdev/KiroCrew/actions/runs/42738125200/job/129575551378 A rerun would be held at that failure, as on c3dc90a.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 10, 2026
@Zedmor

Zedmor commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Code change approver recommendation: A person should decide

Automated, not a person, and not a review: a maintainer still decides.

decider-v3c@217fe607 · p_defect 0.12 · router R0 (approves only when p_defect <= 0.12, on changes of at most 400 changed lines) · head 7e13248262 · 454 changed lines

Why: 454 changed lines > 400 (small/medium only).

The PR adds a narrow, validated exemption for Microsoft Graph's Outlook webLink (/owa/?ItemID=<id>&exvsurl=1&viewmodel=ReadMessageItem and the event form). _chat_mail_link_at reads into the query only for an Outlook host with the exact path /owa/. The query must match one of two fixed field lists exactly, the id passes the same Exchange-id decode as a path id, and the check for key-shaped pieces runs on the whole link. Anything that doesn't match returns None, which is what main did for /owa/. The exfil gate uses the same matcher only after its unconditional credential, decode and percent-encoding checks, and the bytes after the link are still checked for length and base64. The segment flush stops counting a removed value only when every occurrence lies wholly inside a kept Outlook span. Its forward-cursor check is correct and linear. Blanking those spans before the "shows more" check drops only bytes the final pass already approved. Tests cover both directions using the real redactors and the streaming path, and all CI test jobs passed. The only red check is Sensitive Change Review, which is waiting on the author's reasoning comment, a process step.

If this recommendation is wrong, reply here; the replies are how the approver is evaluated.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the whole diff at 7e13248: the Outlook webLink route in redaction_entropy.py, its use in exfil.py and redaction.py, the segment flush change in segment_flush.py, the docs and the three test files. Approving. It loosens a false positive on one exact route and adds no new refusal and no regex. The reasoning template below is filled for this head.

Sensitive change review

  • Head commit: 7e13248
  • What rule changed: Outlook's own webLink (/owa/?ItemID=<id>&exvsurl=1&viewmodel=ReadMessageItem, or the event form ?itemid=<id>&exvsurl=1&path=/calendar/item) is kept by the bare-secret pass and judged narrowly by the exfil gate. The segment flush also stops counting a piece of such a link as a removed value coming back.
  • Before -> after (what was allowed/blocked, now): Before, the item id looked like a key and the 201-character query looked like exfiltration, so the link was masked or blocked, and a streamed reply holding it could be withheld whole. Now exactly that route is kept: https, an Outlook host, no port, the fixed path, the fixed fields in the fixed order, and an id that decodes as one whole Exchange id. Any other host, scheme, port, route, field order or extra field is judged as before.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): A secret-shaped value hidden in this one route would pass the length and base64 checks. The id must decode whole with no key-shaped piece, and the hard credential patterns and the heavy percent-encoding check still run on the link. No command is blocked and no one is locked out.
  • Evidence checked (which sandbox result proves it): test_outlook_web_link_redaction.py shows the link surviving both gates in six wrappers, nine cases with a key in or next to the link still blocked, and nine look-alike cases (other host, http, a port, another path, reordered or renamed fields, an extra field) still blocked. test_segment_flush_outlook_links.py shows a streamed link saved whole at several cut points and a key split next to it still hidden.
  • No regression:
    • Tools still work (which tools/commands were run, result): redact_credentials, scan_exfiltration_urls and redact_exfiltration_urls run in the new tests on the link and on keys, with the results above. No command rule or sandbox rule is touched.
    • Backward compatible (old config / old data / old callers still work, how checked): _URL_RE and the other routes are unchanged, and the tests show other routes' queries stay outside the span. The package line budget test is raised by 67 for the new code.
    • Existing tests (which suites passed on this head): 99 of 100 checks pass on this head, including the backend and frontend test shards. The only red check is this one.
  • How to undo: revert this commit. No stored data or config changes.

@bolichen97
bolichen97 merged commit 56ed094 into main Nov 10, 2026
162 of 168 checks passed
@bolichen97
bolichen97 deleted the crew/slack/owa-item-id-link-guard branch November 10, 2026 07:18
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 10, 2026
bolichen97 pushed a commit that referenced this pull request Nov 10, 2026
Backport note: _PACKAGE_LINE_BUDGET is release's 35,048 raised by the same
67 lines (35,115; the package measures 35,114 on this branch).

(cherry picked from commit 56ed094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants