Skip to content

fix: say when a failed frontend build wrote no log - #34047

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
fix/32737-frontend-build-uncaptured-hint
Nov 11, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
fix/32737-frontend-build-uncaptured-hint

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A source-install user whose update's dashboard build fails on Windows is told that no build log was written and how to see the npm output, instead of being pointed at a log that does not exist.

On Windows kirocrew update (and the dashboard Update button and the gateway's auto-apply) opens no build log, by design: the safe open of logs/frontend-build.log needs a pinned directory walk that Windows does not have. When the build then failed, the message was only "Frontend build did not complete — the dashboard still serves the previous bundle", the CLI added "see the log above" with nothing above it, and docs/guides/install.md promised a log file.

Why it matters

A Windows source-install user whose update build fails is sent to a log that does not exist, and nothing tells them the npm output was never kept. Finding the cause means guessing that they must rerun npm ci and npm run build in website\ by hand.

Not a goal

What changed (motivation → approach → change)

A failed build with no log now says so and says how to see the output, and the CLI only points at "the log above" when a log tail was printed above it.

Where Before (no log) After (no log)
FrontendBuildResult.failure_message() in frontend.py (CLI, dashboard progress card, auto-apply) Frontend build did not complete — the dashboard still serves the previous bundle the same, then . No build log was written; run `npm ci` and `npm run build` in website/ to see the npm output
kirocrew update hint in cli_server_update.py Do not restart the gateway until the dashboard builds; see the log above. Do not restart the gateway until the dashboard builds.

With a log open (POSIX), both lines are unchanged. The new sentence shows wherever no log was opened: always on Windows, and on POSIX when the log destination is refused. docs/guides/install.md, the build_frontend_sync docstring and the cli and slack-gateway specs say the same.

Backwards compatibility

Compatible: only message and doc text change; with a log open (POSIX) every printed line is the same as before.

Removes nothing: no path, key, record or function is removed; the CLI drops its "see the log above" pointer only when no log tail was printed.

Tests

  • test/test_frontend_build_log.py::test_a_failure_with_no_log_says_so_and_how_to_see_the_output: a failed result with no log says no build log was written and names npm ci and npm run build in website/.
  • test/test_cli_server_more_coverage.py::TestUpdateGitPath::test_frontend_build_failure_without_a_log_points_at_no_log: kirocrew update with a failed, log-less build exits 1 and does not print "see the log above".
  • TestUpdateGitPath::test_frontend_build_failure_installs_then_exits also pins that the pointer stays when a tail was printed.

Proof: PROVEN test/test_cli_server_more_coverage.py::TestUpdateGitPath::test_frontend_build_failure_without_a_log_points_at_no_log, test/test_frontend_build_log.py::test_a_failure_with_no_log_says_so_and_how_to_see_the_output (head 5cbba1d)

Manual verification

N/A — unit coverage sufficient: the Windows branch is the pinned_fs.supports_pinned_walk() capability, which the existing tests already force off on Linux; no Windows run was made.

Screenshots / video

N/A — the diff touches no frontend file; the changed text is a CLI line and the backend failure string, shown verbatim in the table above.

Related Issues

Closes #32737

Sibling sweep

Swept: git grep -n "failure_message()" -- src/kiro_crew
Swept: git grep -n "see the log above" -- src/kiro_crew
Sibling: src/kiro_crew/dashboard/handlers/updates_apply.py:928 -- not affected -- it shows failure_message(), which now carries the no-log sentence
Sibling: src/kiro_crew/slack/gateway_runtime/update_apply.py:950 -- not affected -- it shows failure_message(), which now carries the no-log sentence
Sibling: src/kiro_crew/cli_server_update.py:168 -- not affected -- the policy update command's own output is printed above that line

Pattern harvest

Not generalizable: one hint pointed at output that only the POSIX branch produces, and its only consumer is fixed here.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 9, 2026 18:34
@bolichen97
bolichen97 requested a review from Zedmor November 9, 2026 18:34
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 5cbba1d4b26cdcf26d3b887a73f3007ac75c8f32 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 5cbba1d4b26cdcf26d3b887a73f3007ac75c8f32 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. It changes only message text: a failed build with no log now says so and gives the commands to run by hand, and the CLI says "see the log above" only when a log tail was printed.

Notes

  • _build_failed(None, None) can also return before _open_build_log runs (frontend.py:1401, an exception in the lock or setup), so on POSIX that path now prints "No build log was written" too. The wording is still accurate there, but the spec text "always on Windows, or a refused log destination" leaves this case out.

[DESIGN-REVIEWED] 5cbba1d

Description read

[DESCRIPTION-READ] bae7324be010391c5a46d7ddfdacef00640280fd2cc90c3281b2c3538424aa6c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 5cbba1d4b26cdcf26d3b887a73f3007ac75c8f32 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Each item fixes a message that pointed a log-less failed build at a log that does not exist (#32737).

What this change ships

Inventory (4 items) — 4 justified

Intent: when a dashboard build fails and wrote no log, the user is told that no log exists and how to see the npm output. This is a FIX.

  1. A failed build with no log now says "No build log was written" and names npm ci / npm run build in website/. This shows on the CLI, the dashboard progress card and the auto-apply log line. — justified
  2. kirocrew update drops "see the log above" when no log tail was printed. — justified
  3. install.md, the cli and slack-gateway specs and the build_frontend_sync docstring now say Windows writes no build log. — justified
  4. Two tests pin the no-log sentence, and one pins that the CLI pointer is gone without a tail. A third test keeps the pointer when a tail was printed. — justified

[FIRST-PRINCIPLES-REVIEWED] 5cbba1d

Description read

[DESCRIPTION-READ] 437711fc92379268c4b5a27f1cfef2e710cf9f433bd165013bf625cf92bd32cd

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 5cbba1d4b26cdcf26d3b887a73f3007ac75c8f32 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 5cbba1d

Verdict parsed from the review's SHA-scoped output markers for commit 5cbba1d4b26cdcf26d3b887a73f3007ac75c8f32.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 5cbba1d4b26cdcf26d3b887a73f3007ac75c8f32 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 5cbba1d4b26cdcf26d3b887a73f3007ac75c8f32 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 5cbba1d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 5cbba1d4b26cdcf26d3b887a73f3007ac75c8f32 false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 enabled auto-merge (squash) November 9, 2026 18:48
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 9, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at 1e2fef2. A failed dashboard build with no log (always on Windows, or a refused log destination on POSIX) now says no log was written and to run npm ci / npm run build in website/ (src/kiro_crew/frontend.py:487-491). The CLI's "see the log above" prints only when a tail was printed (src/kiro_crew/cli_server_update.py:618-619). Message/doc text only; nothing changes when a log exists. GPT, Opus, UX and Security Scope pass. Backend 3.12 shard 7 is the known timing flake #28212 (test_the_scan_is_linear_not_quadratic), and Coverage Gate follows it.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 10, 2026
@bolichen97 bolichen97 closed this Nov 10, 2026
auto-merge was automatically disabled November 10, 2026 08:52

Pull request was closed

@bolichen97 bolichen97 reopened this Nov 10, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 10, 2026
Where no pinned directory walk exists (Windows) the update's frontend
build opens no log and discards the npm output by design, but a failed
build then printed only the bare sentence and the CLI still said "see
the log above". The failure now says no build log was written and to
run npm ci and npm run build in website/ to see the output, and the CLI
points at the log only when a tail was printed. The install guide and
the cli and gateway specs say the same.

Closes #32737
@bolichen97
bolichen97 force-pushed the fix/32737-frontend-build-uncaptured-hint branch from 1e2fef2 to 5cbba1d Compare November 11, 2026 11:40
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/guides/install.md, docs/system-specs/modules/cli.md, src/kiro_crew/cli_server_update.py, src/kiro_crew/frontend.py, test/test_cli_server_more_coverage.py and the gateway spec since this head's CI ran (69d3a9a -> dcd4830); CI re-running.

The new base carries #34537, the fix for the test_every_history_key_change_joins_the_alias_group timeout (#34284) that failed Backend Tests (3.12, 3) on the previous head. The patch is unchanged.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 11, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 11, 2026 13:05

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (7 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: a failed frontend build with no log file now says no log was written and how to see the npm output, instead of pointing at a log that does not exist; adds tests. Spec files changed as a ride-along (a minority of the diff on both file count and changed lines), not reviewed as a design decision: docs/system-specs/modules/cli.md, docs/system-specs/modules/slack-gateway.md.

@KiroCrewCaptain
KiroCrewCaptain merged commit 9e57594 into main Nov 11, 2026
99 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the fix/32737-frontend-build-uncaptured-hint branch November 11, 2026 13:06
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kirocrew update on Windows: a failed frontend build names no log and prints no npm output, but install.md says it writes logs/frontend-build.log

3 participants