Repository navigation
fix(signing): send the app to the notary service as a disk image when it refuses the signed zip (0.12.1 backport of #31848) - #34129
Conversation
… it refuses the signed zip (#31848) The universal app's signed zip was refused by notarytool ("must be a zip archive", exit 64) before anything was uploaded, and notarize.sh retried the same refusal three times. A probe on the CI runner image showed notarytool accepts well-formed zips of 94,000 entries, so the signed file itself is malformed in a way the job log did not show. notarize.sh now exits 64 at once instead of retrying. The workflow then runs notarize-image.sh, which logs what the zip is (size, first bytes, end record fields, entries) and submits an unsigned disk image of the unpacked app, which Apple notarizes in full. Staple and the Gatekeeper gate are unchanged. Co-authored-by: w <w@k.local> (cherry picked from commit e94281a)
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a clean backport of #31848 from main. The zip path still runs first, and the disk-image fallback only runs on notarytool's exit 64, with staple and the Gatekeeper gate unchanged. Notes
[DESIGN-REVIEWED] f6b4313 Description read[DESCRIPTION-READ] 69cd08155700d8e3c74b70679387369629e28ce19007ff5f3e8855b05dabba6a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This is a clean backport of #31848, which is already on main. It fixes a release-blocking notarization failure that has a named Release run, and every item is scoped to that failure. What this change shipsInventory (6 items) — 5 justifiedIntent: let the 0.12.1 release build notarize the universal macOS app, so the bare v0.12.1 tag can ship. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] f6b4313 Description read[DESCRIPTION-READ] 4e506dbbc8898503256741cccf4fab1de07314c4360cae6b39b24ce4d007319f That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: Let the 0.12.1 release build notarize the universal macOS app, by backporting main's #31848 to
release/0.12.0.The v0.12.1-rc.2 Release run (42672343465) failed only in
Sign + Notarize macOS / Notarize + staple:notarytoolrefused the universal app's signed zip before any upload ("signed.zip must be a zip archive (.zip), flat installer package (.pkg), or UDIF disk image (.dmg)") on all 3 attempts. The zip is now 1,084,177,868 bytes; v0.12.0-rc.10's was 1,007,118,449 bytes and notarized fine. The arm64-only and x64-only builds notarized and published.Why it matters
Without it the 0.12.1 Release run cannot finish, so stable-gate has no successful v0.12.1 run and the bare v0.12.1 tag cannot ship.
Not a goal
What changed (motivation → approach → change)
git cherry-pick -xof main's e94281a (#31848), clean: whennotarize.shsees notarytool refuse the file itself (exit 64),sign-and-notarize.ymlwraps the signed app in a disk image (notarize-image.sh) and notarizes that instead; Apple notarizes it in full and the app's ticket staples as before.Backwards compatibility
Compatible: the zip path is tried first, unchanged; the disk image is only a fallback.
Removes nothing.
Tests
Proof: not provable -- other: a clean cherry-pick of main's #31848, proven in its own main PR; the Release run of the next RC tag is the verification.
Manual verification
N/A: verified by the next RC's Release run.
Related Issues
Part of the 0.12.1 hot patch (#33974, #34032, #34021, #34033, #34035).
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.