Repository navigation
fix(settings): explain the windows cloud launcher block once - #34340
Conversation
On a Windows gateway the dashboard's cloud launcher answers 400 posix_host_required before any AWS call, but the Set-up tab still drew the AWS checklist: the raw POSIX error, a credentials row saying they were not checked, Ask the agent, and a disabled Launch, with no guide. The tab now shows one notice instead. It says the launcher needs a Linux or macOS gateway and the profile was not checked, and names the two ways forward: the CLI launch wizard in PowerShell, or a gateway inside WSL, which needs admin rights and a restart. A gateway known to be Windows skips the preflight entirely. The Windows guide gains the WSL steps the notice links to. Fixes #32150
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: every item serves the issue's single job, a Windows gateway's Set-up tab saying once why launch can't work. The Windows path reuses the existing What this change shipsInventory (8 items) — 8 justifiedIntent: a Windows user setting up a cloud crew learns once, without being told their AWS credentials are wrong, that the dashboard launcher needs Linux or macOS, and what to do instead. This is a FIX (#32150, #18614).
[FIRST-PRINCIPLES-REVIEWED] 14cff18 Description read[DESCRIPTION-READ] 1943861440eb508b3e9d8d2cd9899bf67775ab0b3f2144cccb50be18da8c9cb0 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the server's Notes
[DESIGN-REVIEWED] 14cff18 Description read[DESCRIPTION-READ] 25eccc3fde5c09ef596e5e7b009e658581ff692fe2cb786df3c4bfe700b64565 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the screenshots show both states, and the blind reader understood the guide link (the main next step) and would click it. Notes
[UX-REVIEWED] 14cff18 Description read[DESCRIPTION-READ] 6626d415d8a78241f87470ad2777107c690a8b39ce59517a9337899df5b1507e That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Review dispositions for 2c158a8:
|
When the preflight refusal, not the platform signal, is how the Set-up tab learns the gateway is Windows, the notice's sentence now renders through ErrorNotice with the rejection's report and agent hand-off. The desktop installer adds nothing to PATH, so the CLI sentence and the Windows guide now point desktop installs at the bundled shim's full path, and the guide says installing the AWS CLI usually needs admin rights. The notice now says the AWS profile is not the problem and that the Windows install keeps working. The fr, ru, hi and bn strings use the informal register their style guides require. The feature map lists the notice and the settings coverage gate waives it, as it holds no setting.
2c158a8 to
14cff18
Compare
Code change approver recommendation: ApproveAutomated, not a person, and not a review: a maintainer still decides.
Why: the decider approves with p_defect 0.1 <= 0.12 and every rail passes. I'm approving this. It is a small frontend-only change. On a Windows gateway, the built-in EC2 lane's AWS checklist and launch form are replaced by one notice card. The server-side How the client decides it's Windows. The server refuses when Scope. The notice only applies to the built-in lane: If this recommendation is wrong, reply here; the replies are how the approver is evaluated. |
|
Dispositions for the non-blocking notes on 14cff18:
|
bolichen97
left a comment
There was a problem hiding this comment.
Approved at 14cff18.
On a Windows gateway, the Set-up tab now shows one RemoteCrewWindowsNotice in place of the built-in lane's AWS checklist and launch form, instead of a checklist that implied the AWS profile was wrong.
- When it shows: when
useGatewayPlatform()readswindows, or when the preflight answers400 posix_host_required(in case the platform signal isn't loaded yet or the gateway is older). - No AWS check: a known-Windows gateway no longer sends the preflight at all (
enabledgains!windowsGateway). Other platforms and lanes an edition draws itself are unchanged. - What it says: the two ways forward,
kirocrew cloud launchin PowerShell (by its full path from a desktop install) or a gateway inside WSL, linking the new section inwindows-install.md. When the refusal is how the tab learned it, the sentence goes throughErrorNoticewith the rejection's report. - Strings: all 13 locales are added.
A frontend-only change, no new refusal and no regex. CI: all 97 checks are green on this head.
* fix(settings): explain the windows cloud launcher block once On a Windows gateway the dashboard's cloud launcher answers 400 posix_host_required before any AWS call, but the Set-up tab still drew the AWS checklist: the raw POSIX error, a credentials row saying they were not checked, Ask the agent, and a disabled Launch, with no guide. The tab now shows one notice instead. It says the launcher needs a Linux or macOS gateway and the profile was not checked, and names the two ways forward: the CLI launch wizard in PowerShell, or a gateway inside WSL, which needs admin rights and a restart. A gateway known to be Windows skips the preflight entirely. The Windows guide gains the WSL steps the notice links to. Fixes #32150 * fix(settings): route the refused preflight through the error notice When the preflight refusal, not the platform signal, is how the Set-up tab learns the gateway is Windows, the notice's sentence now renders through ErrorNotice with the rejection's report and agent hand-off. The desktop installer adds nothing to PATH, so the CLI sentence and the Windows guide now point desktop installs at the bundled shim's full path, and the guide says installing the AWS CLI usually needs admin rights. The notice now says the AWS profile is not the problem and that the Windows install keeps working. The fr, ru, hi and bn strings use the informal register their style guides require. The feature map lists the notice and the settings coverage gate waives it, as it holds no setting. (cherry picked from commit 715d4aa)
Problem / Motivation
Goal: On a Windows gateway, Settings → Remote Crew → Set up a new one says once, plainly, that the dashboard's cloud launcher needs Linux or macOS, says how to launch anyway, links a guide, and never suggests the AWS credentials are wrong.
On a Windows gateway the dashboard's cloud launcher refuses with
400 posix_host_requiredbefore it makes any AWS call. The Set-up tab still drew the whole AWS checklist around that refusal: the raw "cloud provisioning requires a POSIX host (Linux/macOS); use WSL on Windows" error, a credentials line ("your credentials were not checked", and "Could not reach AWS with this profile" on 0.12.0), an Ask the agent button, and a disabled Launch saying "Finish the AWS setup above to enable this." Nothing linked to a guide, nothing said WSL needs admin rights and a restart, and nothing mentioned the CLI launcher, which does run on Windows.Why it matters
Windows is the most common laptop. A Windows user who picks a cloud crew hits a dead end that also looks like their AWS credentials are broken, while
aws sts get-caller-identityworks fine for them. Seen in 7 of 7 clean-machine onboarding runs (#18614).Not a goal
/api/cloud/*stays as it is.posix_host_requiredresponse, or the CLI launcher.What changed (motivation → approach → change)
Symptom: the Windows refusal shows up as one error among AWS checklist rows that blame credentials. Root cause: the Set-up tab treated
posix_host_requiredlike any other preflight failure, so it drew the checklist, the generic error notice and the launch form as usual.Change:
RemoteCrewWindowsNotice(website/src/pages/settings/RemoteCrewWindowsNotice.tsx) replaces the built-in lane's prerequisites card and launch form when the gateway platform readswindows(useGatewayPlatform, read from the cached prerequisite status), or when the preflight answersposix_host_required(in case the platform signal isn't cached yet). In one card it says the launcher needs Linux or macOS, and that the AWS profile wasn't used so it isn't the problem. It then gives the two ways forward. One iskirocrew cloud launchin PowerShell, the launcherinstall.ps1already hands off to. A desktop install calls it by its full path, because the installer adds nothing toPATH. The other is Kiro Crew inside WSL, which needs administrator rights and a restart. It ends with a link to the guide.ErrorNoticewith the rejection's report and the agent hand-off (theerrors-use-error-noticerule). A known-Windows gateway sends no preflight, so nothing is rejected and the sentence is plain text.docs/guides/windows-install.mdgains "Launch a cloud crew from Windows" and a per-feature table row. The section covers the PowerShell path, with the desktop shim's full path and a note that installing the AWS CLI usually needs admin rights. It also covers the WSL steps:wsl --install, the AWS CLI and profile inside Ubuntu, the one-line installer, opening the dashboard from Windows, and the port 5476 clash with the desktop app.en-XAis regenerated.docs/system-specs/modules/instances.md) and the feature map record the notice.Backwards compatibility
Compatible: no API, response or config changes. Only how the Set-up tab draws on a Windows gateway changes, and Launch was already unusable there.
Removes nothing: on Windows the hidden checklist and Launch could never succeed, because the server refuses every launch with
posix_host_required. POSIX gateways render exactly as before (pinned by a test below).Tests
website/src/test/RemoteCrewPanelWindowsGateway.test.tsx:ErrorNoticealert, which carries the page's only Ask the agent button. It also shows thekirocrew cloud launchpath with the desktopPATHnote, the admin-and-restart note and the guide link. The page shows no POSIX error, no credential text, no "Finish the AWS setup above" and no Launch.cloudPreflightis never called, there is no alert and no Ask the agent, and the page shows the same absences.On main (
0cd8a209), the first two fail (Unable to find role="heading" and name /Cloud crews can’t launch from this Windows dashboard/). A probe on main showed the POSIX error, "credentials were not checked", "Finish the AWS setup above", Ask the agent and Launch all on screen.Proof: not provable -- frontend test (prove.py runs Python only)
All 13
RemoteCrewPanel*/SettingsRemoteCrewPanel*test files pass (273 tests).npm run typecheck, eslint on the touched files,npm run i18n:check(all diff-scoped checks PASS, en-XA in sync, DNT intact),scripts/docs-lint.shandscripts/check_feature_map.pypass.Manual verification
I rendered the built SPA (
website/dist) in headless Chromium with every/api/**call stubbed. No gateway and no AWS account were used. Two scenarios, each in dark and light:Windows: the notice renders, and/api/cloud/preflightwas called 0 times.400 posix_host_required: the same notice renders.Each frame was checked: no "requires a POSIX host", no "credentials were not checked", no "Finish the AWS setup above". Ask the agent appears on none of the known-Windows frames and exactly once, inside the notice, on the refused-preflight frames.
Not verified: a real Windows machine, or running
kirocrew cloud launchend to end on Windows.Screenshots / video
Windows gateway, dark:
Same card, light:
Platform not cached yet and the preflight answered posix_host_required: the same card, with its first sentence in the shared error notice and its Ask the agent hand-off:
Light
Related Issues
Fixes #32150
Sibling sweep
Swept: git grep -n "posix_host_required" -- website/src src/kiro_crew
Sibling: website/src/pages/settings/RemoteCrewPanel.tsx:381 -- not affected -- the launch-history route is not POSIX-gated, and the crew list already treats that code as "no history"
Sibling: website/src/apps/aws-control/AwsControlPage.tsx -- not affected -- it already shows its own Windows notice (add_accounts_unsupported) when the server reports the platform unsupported
Sibling: website/src/pages/settings/RemoteCrewPanelLaunch.tsx -- not affected -- the launch progress card only renders a job that exists, and a Windows gateway cannot create one
Pattern harvest
Not generalizable: one tab drew a host-capability refusal as one failed check among AWS rows. The other Windows-gated surface (AWS Control) already handles it up front.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.