Skip to content

fix(followup): name the renamed Start button and skip blank lines in the preview - #34483

Merged
bolichen97 merged 1 commit into
mainfrom
pearcekieser/fix-followup-card-leftovers
Nov 10, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
pearcekieser/fix-followup-card-leftovers

Conversation

@Pearcekieser

@Pearcekieser Pearcekieser commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Finish three optional points from the #25926 readiness review: the model-facing button name, the preview of a prompt that opens with blank lines, and the test file size.

#25926 renamed the follow-up card's first button to "Start in a separate copy" and added a three-line prompt preview. The readiness review on its last head listed three optional points, and the PR merged before they were done:

  1. The endpoint POST /api/chat/slots/{slot}/followup still tells the model that an unscoped session offers "Start in new chat" instead of "Start in new worktree". No button has that name now.
  2. The preview counts leading blank lines. A prompt that opens with three empty lines shows only "…" on the collapsed card.
  3. website/src/test/ChatPageW3Coverage.test.tsx grew to 1,673 lines, more than the 1,600-line split target.

Why it matters

The warning is the model's only view of the card in an unscoped session, so it must name the button that the user sees. A preview that shows only "…" hides the prompt that Run sends with one click.

Not a goal

No change to the send path, the setting, the footer text or the button labels.

What changed (motivation → approach → change)

followup_card.py now says "Start in a separate copy" in the no-project warning. The directive path in session_directive_apply_slot.py already uses that name.

FollowUpCard.tsx gets followupPromptLines, which returns the prompt's lines from the first line with text. The preview and the Show prompt check both use it. The send trims the prompt (composerSend.ts line 307), so the skipped lines never reach the new session. A prompt with three lines or fewer after the blank lines now shows in full with no toggle. No regular expression is added.

The ChatPage — follow-up "start in worktree" describe block moves without changes into ChatPage.followUpStart.test.tsx, with a copy of the setup it needs. Unused imports and recorders are removed from both files. The old file has 973 lines and 42 tests, the new file has 1,000 lines and 45 tests, and the total is 87 as before.

Backwards compatibility

Compatible. The warning is text only. The suggest_followup tool's arguments and result fields are unchanged.

Tests

  • FollowUpCard.test.tsx adds two tests: a prompt after three blank lines previews its first three text lines with Show prompt, and a one-line prompt after blank lines shows in full with no toggle.
  • npx vitest run on FollowUpCard, ChatPage.followUpStart, ChatPageW3Coverage, ChatPageFollowup, ChatPage.followUpBusySend and ChatPage.followUpToggle: 6 files, 179 tests pass.
  • pytest test/test_followup_suggest.py test/test_mcp_followup_dispatch.py test/test_dashboard_chat_handlers_coverage.py: 191 pass.
  • npm run typecheck and eslint on the changed files are clean.

Proof: not provable -- frontend test (prove.py runs Python only)

I swapped the file by hand instead. Both new tests fail with origin/main's FollowUpCard.tsx and pass with this one.

Manual verification

I built the SPA two times, once with main's FollowUpCard.tsx and once with this one, and rendered it with every API call stubbed and dummy data. The first card item has a prompt that opens with three blank lines.

Screenshots / video

Before, on main: the first item's preview shows only "…".

Before: the preview of a prompt that opens with three blank lines shows only an ellipsis

After: the preview shows the first three lines from the first line with text, then "…" and Show prompt. A prompt with no leading blank lines renders as before.

After: the preview starts at the first line with text

Related Issues

Follow-up to #25926.

Sibling sweep

Sibling: src/kiro_crew/dashboard/session_directive_apply_slot.py:607 -- not affected -- it already says "Start in a separate copy"
Sibling: src/kiro_crew/mcp_tools/control_parts/schemas.py:1086 -- not affected -- the tool description already uses the new name
Sibling: docs/request-for-change/rfc-followup-start-sends.md:23 -- not affected -- the accepted RFC describes the card before the rename

Pattern harvest

Not generalizable: one string that a rename did not reach, and the old label is ordinary prose that no rule can tell from valid text.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

…the preview

Three leftovers from #25926 that the readiness review listed as optional:

- The follow-up card endpoint's no-project warning, which the model reads,
  still named the old "Start in new worktree" button. It now names
  "Start in a separate copy", as the directive path already does.
- The collapsed prompt preview counted leading blank lines, so a prompt
  that opened with three empty lines showed only the ellipsis. The preview
  and the Show prompt check now start at the first line with text. The
  send trims the prompt, so those lines never reach the new session.
- The follow-up Start tests move from ChatPageW3Coverage.test.tsx
  (1,673 lines) into ChatPage.followUpStart.test.tsx. The 87 tests are
  unchanged: 42 stay and 45 move.
@Pearcekieser
Pearcekieser requested review from a team and KiroCrewCaptain as code owners November 10, 2026 09:45
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of f4b0c35b2b9cf2517a5c0d9a87c6c5de74b2550d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. The warning text now matches the directive path's wording, and the preview fix lives inside the component, which already owns preview logic.

[DESIGN-REVIEWED] f4b0c35

Description read

[DESCRIPTION-READ] 2dd4dfb9407b8efb1876ea27b4330c9dec719b99e756ddacfe0a892340c51143

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of f4b0c35b2b9cf2517a5c0d9a87c6c5de74b2550d — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. All four items are the three follow-ups that #25926's readiness review named, and each one fixes the code where the problem starts.

What this change ships

Inventory (4 items) — 4 justified

Intent: make the model's warning name the button the user actually sees, and stop a prompt that opens with blank lines from previewing as only "…". FIX.

  1. The no-project warning sent to the model now names "Start in a separate copy" instead of the old label — justified
  2. The collapsed card's preview skips leading blank lines, so it shows the first three lines that have text — justified
  3. "Show prompt" only appears when content is actually hidden, ignoring the leading blank lines — justified
  4. The follow-up Start tests move from ChatPageW3Coverage.test.tsx into ChatPage.followUpStart.test.tsx, still 87 tests in total — justified

[FIRST-PRINCIPLES-REVIEWED] f4b0c35

Description read

[DESCRIPTION-READ] b8d790b798996f44ebb574379e19db365c8081d48da4b22478421d00e6faa7ac

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of f4b0c35b2b9cf2517a5c0d9a87c6c5de74b2550d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The diff adds no control, label or state. It only changes which existing preview state a prompt with leading blank lines gets, and it fixes one model-facing string.

[UX-REVIEWED] f4b0c35

Description read

[DESCRIPTION-READ] d4174d31137cc572c804e5fa41ebe219913b2a6f1259429e005cad4299c70d24

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed f4b0c35b2b9cf2517a5c0d9a87c6c5de74b2550d — this comment is updated in place on each push.

Review details

No findings.

Notes:

  • If a short prompt starts with blank lines, the card still shows the raw prompt, so blank rows appear at the top. This only affects how the card looks.

[OPUS-REVIEWED] f4b0c35

Verdict parsed from the review's SHA-scoped output markers for commit f4b0c35b2b9cf2517a5c0d9a87c6c5de74b2550d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable f4b0c35b2b9cf2517a5c0d9a87c6c5de74b2550d false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of f4b0c35b2b9cf2517a5c0d9a87c6c5de74b2550d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f4b0c35

False positive or not applicable? A repository writer can comment:
/ai-review override gpt f4b0c35b2b9cf2517a5c0d9a87c6c5de74b2550d false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 10, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving f4b0c35. Two small product fixes plus a test split:

  • FollowUpCard.tsx: the collapsed prompt preview now starts at the first line with text (followupPromptLines, findIndex + trim, no regex). Before, a prompt that began with blank lines filled all three preview lines with nothing and showed only "…". followupPromptHasMore counts the same lines, so a short prompt after blank lines shows in full with no toggle. The send already trims the prompt, so this only changes the preview.
  • followup_card.py: the no-project warning now names the renamed button, "Start in a separate copy".
  • The Start-handler tests move unchanged from ChatPageW3Coverage.test.tsx into ChatPage.followUpStart.test.tsx, with the same setup. FollowUpCard.test.tsx adds the two blank-line cases.

Checks: every check is green on this head. The one red PR Policy run (09:46, no screenshot) is followed by a passing PR Policy run at 10:17 on the same head. I am leaving auto-merge off while that older failure still shows in the check list.

@bolichen97
bolichen97 merged commit 27cb69f into main Nov 10, 2026
106 of 108 checks passed
@bolichen97
bolichen97 deleted the pearcekieser/fix-followup-card-leftovers branch November 10, 2026 11:11
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants