Repository navigation
docs: propose local skill source governance - #34728
Open
hkrishg-aws wants to merge 1 commit into
Open
hkrishg-aws wants to merge 1 commit into
hkrishg-aws wants to merge 1 commit into
Conversation
Rebase onto the LTS Edition rename (kirodotdev#32970), which moved the appendix row this design splits from rfc-crew-enterprise-edition.md to rfc-crew-lts-edition.md. The Yellow class count also moved from 20 to 17 on main, so splitting one row into two now yields 18 rather than 21. Both the class-table cell and the appendix heading are updated, and the control count goes 66 to 67 in the two places it appears. Supersedes kirodotdev#30574, which cannot merge because it edits the pre-rename path.
5 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
Goal: Record the governance design for letting an operator's policy narrow which repository and config-selected local directories may supply skills to an agent.
A project's
.kiro/skills,skills.extra_paths, localskill://mappings and theKIROCREW_PROJECT_DIRsource can supplySKILL.mdinstructions, but no policy key represents those source roots today. Project skills have a local off switch and directory trust grant; neither gives an enterprise operator a central ceiling.Why it matters
A repository or local configuration can select skill content that enters the agent's context. The operator can govern discovery registries and many tool effects, but cannot centrally restrict these source directories. The design adds that missing ceiling without turning policy approval into a project trust grant.
Not a goal
What changed (motivation → approach → change)
This docs-only PR adds
rfc-local-skill-sources-governance.md. It proposes an allow-onlyskills.local_sourcespolicy key over canonical source roots, with policy acting as a conjunct beside the existing local controls. Four maintainer decisions are called out at the top.The rollout has two gates. Phase 0 inventories detected roots and previews the policy decision without changing admission. Phase 1 enforces the enterprise default-off behavior only after that preview exists. The RFC defines 22 executable Phase 1 assertions, including profile handling, path aliases, source replacement, catalog-generation races, duplicate-name shadowing, audit deduplication and harness parity.
The accepted enterprise-edition RFC's single "Extension sources" row is split into registry hosts and local skill sources, raising the appendix count from 66 to 67. The request-for-change index gains the new draft row.
Backwards compatibility
Compatible: this PR changes documentation only. The RFC records that its future Phase 1 would be a breaking enterprise default, preceded by a non-enforcing Phase 0 preview and migration recipe.
Removes nothing: no runtime, policy parser, skill source, configuration or user-facing behavior changes in this PR.
Tests
Proof: not provable -- docs-only change.
make buildpassed../scripts/docs-lint.shpassed..venv/bin/python scripts/local-gate.pypassed: 505 backend tests and 13,395 frontend tests.Manual verification
Reviewed all three changed documents against upstream
mainand confirmed the RFC index, enterprise control counts and cross-links agree. Confirmed no customer, private security-report or internal-only content appears in the diff.Screenshots / video
N/A, docs-only design proposal with no user-interface change.
Related Issues
Refs #29686
Checklist
Contribution License Agreement
Contributed under the repository's Apache-2.0 license.