Repository navigation
feat(stt): let the user dismiss a failed speech-model download - #34878
Conversation
The error row a failed speech-model download leaves under the model picker was the one error row on the voice settings page with no dismiss control, so it stayed on screen until the next attempt. It now has the same dismiss control as the page's other error rows. Dismissing hides that one failure for the page visit: a different failure, the same failure after the transfer left "failed", or pressing Download now again shows the row again. Closes #20719
Code change approver recommendation: ApproveWhy: the decider estimates an 8% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. Frontend-only change: the failed speech-model download row gets an ErrorNotice dismiss control. Hiding works by comparing the An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: one dismiss control on the failed-download row. It reuses What this change shipsInventory (3 items) — 3 justifiedIntent: let a user clear a speech-model download failure they have already read from Settings → Voice. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 79a416f Description read[DESCRIPTION-READ] 13b4cbb8dac54d7435f0d160e0df8ace7d6475cd1564a3e2231cf7fe0c3ed5c2 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this adds a small dismiss control on the frontend only, it can be reverted cleanly, and there is screenshot evidence for this revision. Notes
[DESIGN-REVIEWED] 79a416f Description read[DESCRIPTION-READ] 3bdb216d71897fc61489f52827fe7850153125ff450f33d205518d335308aeb3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The ✕ reuses the Notes
[UX-REVIEWED] 79a416f Description read[DESCRIPTION-READ] 16b654cbde97e64d831d19f62cec45f4cccf692a6ac08996a291f259d4bf3177 That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
buluoray
left a comment
There was a problem hiding this comment.
Approve on 79a416f. Adds the same ✕ dismiss to the failed speech-model download row as the page's other error rows. The dismissal is keyed on the status query's download object identity, and Download now clears it after the status re-read lands. Frontend only. Both guards are mutation-verified. Decisive lines: website/src/pages/settings/SttSettings.tsx:1516, website/src/pages/settings/SttSettings.tsx:990-993, website/src/pages/settings/SttSettings.tsx:839
Problem / Motivation
Goal: A user can dismiss the error row a failed speech-model download leaves in Settings → Voice, and a later failure or download attempt shows it again.
When a speech-model download fails, the voice settings page shows the reason under the model picker. That row has no dismiss control, unlike the page's other error rows, so it stays on screen until the next attempt.
Why it matters
A failure the user has already read and cannot clear keeps the panel looking broken while they switch model or provider, or simply decide to try later. Every other error row on the page can be dismissed, so this one reads as stuck.
Not a goal
What changed (motivation → approach → change)
The failed-download row in
website/src/pages/settings/SttSettings.tsxhas the same ✕ dismiss control as the page's other error rows, so a failure the user has already read no longer stays on screen until the next attempt.Dismissing hides that one failure for this page visit. The page keeps the dismissed status report itself; the status query hands back the same object while the gateway's answer is unchanged, so a different failure, or a failure after the transfer left
failed, is a new report and shows. Pressing Download now ends the dismissal once that attempt's status read lands, because a retry can fail the same way before any poll sees it running.Backwards compatibility
Compatible: a frontend-only addition; no API, config or stored state changes.
Removes nothing: the row still renders for every failure; only the user's own click hides it, until the next failure or attempt.
Tests
website/src/test/SttSettings.modelDownloadDisclosure.test.tsxaddslets the user dismiss a failed download until another failure or attempt. It locks in five things: the row has a Dismiss control that hides it; a re-read reporting the same failure keeps it hidden; the same failure after the transfer was seendownloadingshows again; a different failure shows; and pressing Download now shows the row again even when the retry reports the identical failure. The mocked status read returns a fresh body each time, as a real fetch does, through a newstatusBody()helper.Determinism: 20 consecutive runs of the file green on this head (
npx vitest run src/test/SttSettings.modelDownloadDisclosure.test.tsx, 20 times).Shuffled order with two sibling files as co-tenants (
npx vitest run <this file> src/test/SttSettings.decoder.test.tsx src/test/SttSettings.customModelGuard.test.tsx --sequence.shuffle --sequence.seed=1624): 39 passed.Red before: with the
SttSettings.tsxchange reverted, the new test fails (Unable to find an accessible element with the role "button" and name /dismiss/i); with it, the test passes.Manual verification
Ran the dashboard built from this head against a stubbed API (the repository's screenshot harness,
website/scripts/lib/serve-dist.mjswithstub-dashboard-api.mjs), with the status read reporting a failedbasedownload, in light and dark themes and at a 390 px phone width. The failed row shows a ✕; pressing it removes the row and leaves Download now offered; pressing Download now again, with the retry failing the same way, brings the row back.Screenshots / video
Settings → Voice after a failed download: the failure row with its ✕.
After pressing ✕: the row is gone and Download now is still offered.
After pressing Download now again, when the retry fails the same way: the row is back.
Dark theme
Phone width (390 px)
The ✕ sits beside Ask the agent on the line under the message.
Related Issues
Closes #20719
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)