Repository navigation
fix: 0.12.2 batch 5 (7 fixes from main) - #34923
Conversation
Sensitive Change ReviewSensitive files changed:
How to clear this check:
Only the author's comment counts this way. A reviewer can instead |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This PR backports seven fixes that are already merged on main. Each one comes from a linked main PR that has its own provenance and sibling sweep. No item changes a default or adds new surface beyond its fix. What this change shipsInventory (8 items) — 8 justifiedIntent: bring seven already-merged main fixes to 0.12 users in 0.12.2. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 6b3ea15 Description read[DESCRIPTION-READ] 63987ffa1b62dc1977745e1bfc24bf0e4e7a3280d824f224c5fdf4de279d1b43 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — 🔴 changes requested (blocking)GPT 6.1 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- src/kiro_crew/slack/gateway_runtime/cron_failure.py:394 -- Paused jobs incorrectly promise another scheduled run
[BLOCK-MERGE] 6b3ea15 Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1: LOW harm. The message wrongly promises an automatic rerun. It only appears when someone manually triggers a paused recurring job and the gateway restarts while it runs; the user still sees the job as paused. The message comes from False positive or not applicable? A repository writer can comment: |
buluoray
left a comment
There was a problem hiding this comment.
Approve on 6b3ea15. Seven backports of KAS/cron/connections/dashboard/MCP fixes. Every main twin is merged and on origin/main. Five picks are hand-resolved and each keeps its main fix's intent. No duplicates. No test failures caused by the batch. The PR is based on a7a6dd4, and release has since moved to a157d53 (#31892, #33045, #33478). merge-tree with live release exits 0, and the KAS suites pass on the merged tree. Decisive lines: GPT 6.1's upheld blocker at src/kiro_crew/slack/gateway_runtime/cron_failure.py:394 is real but inherited byte-for-byte from main ffc89b7 (#33905). The pick's src patch is identical to main, and origin/main has the same line at :394-395. No main fix exists yet, so under main-first it is a main follow-up, not a release blocker. The GPT lane needs a writer override.
Backport of #33905 (main ffc89b7). Conflicts resolved to the release side: dropped main-only trigger_run, expected_owner and overlay_owners imports and the quiet_run context lines; added set_interrupt_alert only. security.md: the PR sentence was applied into the release JWT bullet. test_cron_stop_interrupt_notice.py got a local _trigger_run helper in place of CronService.trigger_run.
Backport of #34004 (head b9596d4). Release names the LTS gate enterprise_boot (renamed to lts_boot on main), so the lts_boot.py and test_lts_harness_floor.py hunks were applied to enterprise_boot.py and test_enterprise_harness_floor.py with LTS wording changed to enterprise. Conflicts in platform/bootstrap.py and providers/acp_runtime_start.py were import-line context only (main-only bots_may_run_on_kas not carried). harness-parity.md: H1 row edits re-applied by hand, one Pinned-by test reference whose neighbour is absent on release was dropped.
6b3ea15 to
cd1a83c
Compare
Problem / Motivation
Goal: Ship seven more of our own fixes from main to 0.12 users in 0.12.2, on
release/0.12.0.These fix bugs that are in release code. Each is adapted to release's code and leaves out what needs code only on main; every adaptation is a
Backport note:line in its commit.Why it matters
0.12 users hit each of these today: a cron run cut by a restart that is reported as nothing, a KAS MCP sign-in saved where KAS chats do not read it, activity-index rows stamped instead of listed, a kiro-cli engine refusal that is not treated as a host verdict, a worktree create refusal with no reason, KAS sessions that start in the wrong mode or aim sub-agents at the wrong target, and a dead pooled MCP backend that is not named.
Not a goal
Backport note:line.What changed (motivation → approach → change)
The 7 picks, in main merge order, on
release/0.12.0ata7a6dd4397:ffc89b7979c84e4d728ef4b45992f04febed4cfcb1be19dddff6bc8875f935dc109f0dHand-ports with a
Backport note:carry what each commit body lists as adapted or left out.Backwards compatibility
No behaviour change beyond each listed fix. No config key, CLI flag or API is removed or renamed.
Tests
On a DevSpace (Python 3.12 venv, node 22.22.1), nothing run on a laptop.
release/0.12.0has no backend CI on pull requests (ci.yml targets main), so these runs are the gate:test_<module>*siblings, and tests that name a touched module): 1066 files in 18 batches withpytest -n auto --dist loadgroup --max-worker-restart=2. 39677 passed, 103 skipped, 1 xfailed, 12 failed. All 12 failures also fail on plainrelease/0.12.0(a7a6dd4) in the same host: 10 intest_cli_stt_memory_doctor.py(stale timezone data on the host makesdoctorexit 1),test_gateway_lock_diagnosis.py::test_flock_is_held_by_a_fork_orphan, andtest_kas_cli_floor.py::...kills_the_whole_probe_tree(os.pidfd_openabsent). 20 helper, e2e and integration files in the related set were not run; the gateway smoke below covers boot.tsc -p tsconfig.app.jsonclean,npm run buildok, 18 vitest files (374 tests) for the touched website code passed, afternpm ci.kirocrew --versionprints 0.12.1;kirocrew doctorruns (same host-state findings as on plain release); a gateway on a tempKIROCREW_HOMEand a free port answered 200 on/and/api/health, then stopped by PID.Rebased once onto the new
release/0.12.0tipa157d53d25(three KAS PRs landed during the run; the rebase was clean, 8 files overlap). Re-run on the rebased tree: the related tests of both sets plus the sibling tests of the 8 overlapping files, 183 files: 8538 passed, 62 skipped, 1 failed (the sameos.pidfd_openhost failure that fails on plain release); import check of 92 modules, 0 failed; wheel install and gateway smoke:/and/api/health200, stopped by PID.Proof: not provable -- other: a backport batch of already-merged main fixes, each proven in its own main PR
Manual verification
N/A: each fix was verified in its own main PR; the batch gets a wheel install and gateway smoke on a DevSpace (see Tests).
Screenshots / video
N/A: no visual change.
Related Issues
0.12.2 hotfix, batch 5: #33905, #33737, #33982, #34004, #34057, #33215, #33595.
Sibling sweep
Siblings: none -- a backport batch; each pick's own PR carried its sweep
Pattern harvest
Not generalizable: a release backport batch, not a new defect fix.
Checklist
Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.