Skip to content

docs(rfc): record session search acceptance and phase 1 on main - #35435

Merged
bolichen97 merged 1 commit into
kirodotdev:mainfrom
dma9527:docs/rfc-session-search-phase1-record
Nov 18, 2026
Merged

bolichen97 merged 1 commit into
kirodotdev:mainfrom
dma9527:docs/rfc-session-search-phase1-record

Conversation

@dma9527

@dma9527 dma9527 commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make the session search RFC's front matter and index row say what is decided and built.

The RFC still reads status: draft, implementation-prs: [] and "Nothing yet", although a maintainer accepted it on #24476 and phase 1 merged as #31794.

Why it matters

The First Principles lane and readers of docs/request-for-change/README.md take the status and the index row as the record. A stale draft reads as an undecided proposal, so the next phase's PR would look like it ships an unaccepted design.

Not a goal

  • No change to the RFC's design or phases.
  • No code change.

What changed (motivation → approach → change)

File Change
rfc-session-semantic-search.md status: partial, implementation-prs: [31794], last-audited and audited-at set to the commit the row was checked against
docs/request-for-change/README.md The index row names the acceptance on #24476, phase 1 on main, and what phases 2 to 4 have not built yet

partial is the README's word for "some phases are on main; the rest are open". The acceptance itself is the maintainer's decision on #24476; this PR only records it.

Backwards compatibility

Compatible: documentation only.

Removes nothing: two front-matter values and one index row are updated in place.

Tests

Proof: not provable -- docs or config only

./scripts/docs-lint.sh passes. The row's claims were checked at the audited commit: eval/bench/session_recall.py is on main, and history_search.py, history_index.py and mcp_tools/sessions.py hold no embedding code.

Manual verification

N/A: documentation only.

Related Issues

Part of #24476

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@dma9527
dma9527 requested review from a team and KiroCrewCaptain as code owners November 11, 2026 17:22
@dma9527
dma9527 requested a review from tim-finnigan November 11, 2026 17:22
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 11, 2026
@dma9527
dma9527 force-pushed the docs/rfc-session-search-phase1-record branch from 6749fb5 to cf171b5 Compare November 16, 2026 16:24
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention labels Nov 16, 2026
bolichen97
bolichen97 previously approved these changes Nov 16, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving cf171b5. Both facts it records hold: the RFC was accepted by a maintainer on #24476 (2026-11-04), and phase 1 merged as #31794. partial is the README's word for that state, and the index row now names what phases 2 to 4 have not built. Docs only, no design change. I approved the held fork CI runs; auto merge is on.

AI-assisted, sent by Bolin Review bot

@bolichen97
bolichen97 enabled auto-merge (squash) November 16, 2026 20:10
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision 11817ea968d1b664aedd3ab2a719ea124348a222 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⏭️ skipped

Revision 11817ea968d1b664aedd3ab2a719ea124348a222 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 11817ea968d1b664aedd3ab2a719ea124348a222 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: a docs-only status update, and its claims match the tree (eval/bench/session_recall.py is on main; partial is the README's own word for this state).

[DESIGN-REVIEWED] 11817ea

Description read

[DESCRIPTION-READ] b3d8cf5bfec5f56f5183c489dd57cd13aa6fa33ef483a13849581ef70333cc8d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 11817ea968d1b664aedd3ab2a719ea124348a222 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 11817ea

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 11817ea968d1b664aedd3ab2a719ea124348a222 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 11817ea

auto-merge was automatically disabled November 16, 2026 20:55

Head branch was pushed to by a user without write access

@dma9527
dma9527 force-pushed the docs/rfc-session-search-phase1-record branch from cf171b5 to e4cd402 Compare November 16, 2026 20:55
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 16, 2026
@dma9527

dma9527 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

@bolichen97 the Opus review flagged that the RFC body still said the design was a draft while the front matter said partial. Fixed in e4cd402: the body status line now matches the front matter, and the "read the code at" line no longer reads as the audit commit. I also rebased on bb8ca006c1 and re-checked the index row claims there. The push dismissed your approval and the held CI, so could you approve the workflows and re-approve when you have a moment? Thanks.

bolichen97
bolichen97 previously approved these changes Nov 16, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving e4cd402. It moves audited-at to the current main commit and adds the acceptance and phase-1 note to the RFC body itself, which matches the index row. Docs only. Auto merge is on.

AI-assisted, sent by Bolin Review bot

@bolichen97
bolichen97 enabled auto-merge (squash) November 16, 2026 21:09
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 16, 2026
@dma9527

dma9527 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for re-approving. CI failed only because Await Fast Gate read a duplicate Fast Gate run cancelled at checkout (43954734675); its sibling run 43954731365 passed. Could you rerun the failed jobs of run 43954731211?

auto-merge was automatically disabled November 17, 2026 14:31

Head branch was pushed to by a user without write access

@dma9527
dma9527 force-pushed the docs/rfc-session-search-phase1-record branch from e4cd402 to 35d209a Compare November 17, 2026 14:31
bolichen97
bolichen97 previously approved these changes Nov 17, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving 35d209a3ca. Against e4cd402a58 (the head I approved), the only change is the audit refresh: the RFC row's "verified at" commit and the last-audited / audited-at front matter now point at 8826a22397, dated 2026-11-17. Everything else is the same as before. I approved the held CI runs on this head.

AI-assisted, sent by Bolin Review bot

@bolichen97
bolichen97 enabled auto-merge (squash) November 17, 2026 14:36
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 17, 2026
@dma9527

dma9527 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

@bolichen97 thanks for the rerun. Await Fast Gate still read the duplicate Fast Gate run 43954734675 that was cancelled at checkout, and a rerun cannot change another run's result. I rebased on 8826a22 in 35d209a to get a fresh set of runs, and re-checked the index row claims on that commit. Could you approve the held CI and re-approve?

@bolichen97

Copy link
Copy Markdown
Contributor

The CI fix has landed: #38678 (the in-repo copy of #33281) merged, so the diff-scoped gates now measure from the merge commit's first parent. Please rebase this branch onto current main and push; the emoji-icon and Fast Gate reds should clear on the new head. My approval carries over once I re-check the new head.

AI-assisted, sent by Bolin Review bot

Status moves to partial: the RFC was accepted on kirodotdev#24476 and phase 1, the
session-recall harness, merged as kirodotdev#31794. The index row names what is on
main and what is not, verified at the audited commit.

Part of kirodotdev#24476
auto-merge was automatically disabled November 17, 2026 21:47

Head branch was pushed to by a user without write access

@dma9527
dma9527 force-pushed the docs/rfc-session-search-phase1-record branch from 35d209a to 11817ea Compare November 17, 2026 21:47
@dma9527

dma9527 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

@bolichen97 rebased on e6e9fff in 11817ea, now that #38678 is in. I re-checked the index row claims on that commit and moved the audit stamps to it. Could you approve the held CI and re-approve?

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving 11817ea. This is a rebase onto current main; the only changes are the two audit SHAs (8826a22397 to e6e9fff728). CI runs on this head are approved, and the earlier Fast Gate red should clear now that #38678 has landed.

AI-assisted, sent by Bolin Review bot

@bolichen97
bolichen97 enabled auto-merge (squash) November 17, 2026 22:38
@bolichen97 bolichen97 closed this Nov 18, 2026
auto-merge was automatically disabled November 18, 2026 15:34

Pull request was closed

@bolichen97 bolichen97 reopened this Nov 18, 2026
@bolichen97
bolichen97 enabled auto-merge (squash) November 18, 2026 15:35
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 18, 2026
@bolichen97
bolichen97 merged commit ff1dc47 into kirodotdev:main Nov 18, 2026
332 of 339 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants