Repository navigation
docs(rfc): record session search acceptance and phase 1 on main - #35435
Conversation
6749fb5 to
cf171b5
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Approving cf171b5. Both facts it records hold: the RFC was accepted by a maintainer on #24476 (2026-11-04), and phase 1 merged as #31794. partial is the README's word for that state, and the index row now names what phases 2 to 4 have not built. Docs only, no design change. I approved the held fork CI runs; auto merge is on.
AI-assisted, sent by Bolin Review bot
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: a docs-only status update, and its claims match the tree ( [DESIGN-REVIEWED] 11817ea Description read[DESCRIPTION-READ] b3d8cf5bfec5f56f5183c489dd57cd13aa6fa33ef483a13849581ef70333cc8d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Head branch was pushed to by a user without write access
cf171b5 to
e4cd402
Compare
|
@bolichen97 the Opus review flagged that the RFC body still said the design was a draft while the front matter said |
bolichen97
left a comment
There was a problem hiding this comment.
Re-approving e4cd402. It moves audited-at to the current main commit and adds the acceptance and phase-1 note to the RFC body itself, which matches the index row. Docs only. Auto merge is on.
AI-assisted, sent by Bolin Review bot
|
Thanks for re-approving. CI failed only because Await Fast Gate read a duplicate Fast Gate run cancelled at checkout (43954734675); its sibling run 43954731365 passed. Could you rerun the failed jobs of run 43954731211? |
Head branch was pushed to by a user without write access
e4cd402 to
35d209a
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Re-approving 35d209a3ca. Against e4cd402a58 (the head I approved), the only change is the audit refresh: the RFC row's "verified at" commit and the last-audited / audited-at front matter now point at 8826a22397, dated 2026-11-17. Everything else is the same as before. I approved the held CI runs on this head.
AI-assisted, sent by Bolin Review bot
|
@bolichen97 thanks for the rerun. |
|
The CI fix has landed: #38678 (the in-repo copy of #33281) merged, so the diff-scoped gates now measure from the merge commit's first parent. Please rebase this branch onto current AI-assisted, sent by Bolin Review bot |
Status moves to partial: the RFC was accepted on kirodotdev#24476 and phase 1, the session-recall harness, merged as kirodotdev#31794. The index row names what is on main and what is not, verified at the audited commit. Part of kirodotdev#24476
Head branch was pushed to by a user without write access
35d209a to
11817ea
Compare
|
@bolichen97 rebased on e6e9fff in 11817ea, now that #38678 is in. I re-checked the index row claims on that commit and moved the audit stamps to it. Could you approve the held CI and re-approve? |
Pull request was closed
Problem / Motivation
Goal: Make the session search RFC's front matter and index row say what is decided and built.
The RFC still reads
status: draft,implementation-prs: []and "Nothing yet", although a maintainer accepted it on #24476 and phase 1 merged as #31794.Why it matters
The First Principles lane and readers of
docs/request-for-change/README.mdtake the status and the index row as the record. A staledraftreads as an undecided proposal, so the next phase's PR would look like it ships an unaccepted design.Not a goal
What changed (motivation → approach → change)
rfc-session-semantic-search.mdstatus: partial,implementation-prs: [31794],last-auditedandaudited-atset to the commit the row was checked againstdocs/request-for-change/README.mdpartialis the README's word for "some phases are on main; the rest are open". The acceptance itself is the maintainer's decision on #24476; this PR only records it.Backwards compatibility
Compatible: documentation only.
Removes nothing: two front-matter values and one index row are updated in place.
Tests
Proof: not provable -- docs or config only
./scripts/docs-lint.shpasses. The row's claims were checked at the audited commit:eval/bench/session_recall.pyis on main, andhistory_search.py,history_index.pyandmcp_tools/sessions.pyhold no embedding code.Manual verification
N/A: documentation only.
Related Issues
Part of #24476
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)