Skip to content

docs(rfc): record whole-RFC acceptance for OTel tracing (#1643) - #35443

Merged
bolichen97 merged 1 commit into
mainfrom
crew/devmate/rfc-otel-accept-all
Nov 13, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
crew/devmate/rfc-otel-accept-all

Conversation

@kyleseaman

@kyleseaman kyleseaman commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The OTel tracing RFC records that its owner accepted the whole design, every phase, so each later phase's PR has a decision on main to trace to.

The RFC landed in #31433. #34685 recorded acceptance of phase 1a only, and phase 1a then merged as #31460. The RFC's author and owner, Kyle Seaman (@kyleseaman), accepted the whole RFC on 2026-11-11 and recorded it publicly in a comment on #1643.

Why it matters

Phase 1b (#35077) and every phase after it would otherwise implement design that main records as accepted for phase 1a alone. The status line also still says phase 1a is in review and nothing is on main, which has been false since #31460 merged.

Not a goal

  • No change to the RFC's design, phases, open questions or code facts.
  • No change to how phase 9 (opt-in content capture) is reviewed: it still goes through Sensitive Change Review.
  • No claim that a maintainer has approved a later phase; each phase's PR still needs one.

What changed (motivation → approach → change)

The RFC now says the whole design is accepted and that phases 1a and 1b are on main.

Where Now says
rfc-otel-tracing.md front matter status: partial, doc-pr: 31433, implementation-prs: [31460, 35077], audited 2026-11-12 at 386875ed0d
rfc-otel-tracing.md status line Whole RFC accepted 2026-11-11 by its author and owner, extending the phase 1a acceptance of #34685; phases 1a and 1b on main via #31460 and #35077; phases 2 to 9 not built and land PR by PR; phase 9 still goes through Sensitive Change Review
rfc-otel-tracing.md tracking-issue line A maintainer signed off on phases 1a and 1b (bolichen97 approved #31460 and #35077); each later phase still needs a maintainer's approval on its PR
docs/request-for-change/README.md index row The same facts and status, "Verified at 386875ed0d", with "Nothing on main yet" removed

The status is partial, which the README defines as "some phases are on main; the rest are open": phases 1a and 1b merged, and no open PR implements a later phase, so in-progress ("live in an open PR") no longer fits. Both are in the set the First Principles lane accepts as a decision.

The index row's code facts were re-checked at 386875ed0d. src/kiro_crew/tracing/ records default-off spans to a local JSONL sink, the OTLP guide still says traces are not exported, and metrics egress is still gated by metrics/otlp_governance.py.

Backwards compatibility

Compatible: documentation only; no code, config or contract changes.

Removes nothing: the edit rewrites status prose and adds a PR number; no file, key or reader is taken away.

Tests

N/A: docs only. ./scripts/docs-lint.sh passes.

Manual verification

Read both files after the edit. Checked with gh that #31460, #34685 and #35077 are merged and that no open PR implements a later phase. Checked the row's code facts on 386875ed0d with grep.

Related Issues

Part of #1643

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@kyleseaman
kyleseaman requested review from a team and KiroCrewCaptain as code owners November 11, 2026 17:36
@kyleseaman
kyleseaman requested a review from CrysisDeu November 11, 2026 17:36
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 11, 2026
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision ad149c716470ab6f0cf46c9e40a6df03bd2e6367 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision ad149c716470ab6f0cf46c9e40a6df03bd2e6367 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of ad149c716470ab6f0cf46c9e40a6df03bd2e6367 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

This is a docs-only status update. The stated facts match the tree: src/kiro_crew/tracing/ exists, including subagents.py and runs.py from phase 1b. Nothing is taken away.

[DESIGN-REVIEWED] ad149c7

Description read

[DESCRIPTION-READ] 58266d5107332382ce72519c14ff0ab3dd5bf4cf7e7b9951f2f167d0af4e7074

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed ad149c716470ab6f0cf46c9e40a6df03bd2e6367 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ad149c7

Verdict parsed from the review's SHA-scoped output markers for commit ad149c716470ab6f0cf46c9e40a6df03bd2e6367.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ad149c716470ab6f0cf46c9e40a6df03bd2e6367 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of ad149c716470ab6f0cf46c9e40a6df03bd2e6367 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ad149c7

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ad149c716470ab6f0cf46c9e40a6df03bd2e6367 false-positive: <reason, 20 to 500 characters>

@kyleseaman
kyleseaman force-pushed the crew/devmate/rfc-otel-accept-all branch from 6fe2982 to e928665 Compare November 12, 2026 08:20
@kyleseaman

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/request-for-change/README.md (#34048) and PR #35077 (phase 1b) merged since this head was pushed (5c6750e -> b98b7cf); CI re-running. The new head e928665 records phases 1a and 1b on main and sets status: partial. The stale head's CI run 43069814855 had been queued about 14.5h and was cancelled.

@KiroCrewCaptain

KiroCrewCaptain commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 7% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

Docs-only status update to the OTel tracing RFC: the whole RFC is now recorded as accepted by its author and owner, the status moves from in-progress to partial, and #35077 is added to implementation-prs. Checked against the code at head: phase 1a and 1b modules exist under src/kiro_crew/tracing/ (subagents.py, runs.py); tracing is off by default behind telemetry.traces_enabled; the only exporter is the local JsonlSpanExporter; and the OTLP guide still says traces are not exported. partial matches the README's definition. The First Principles lane accepts both in-progress and partial as a recorded decision, so no gate changes. No code reads implementation-prs or audited-at. The PR keeps phase 9 under Sensitive Change Review, claims maintainer sign-off only for the two PRs a listed maintainer (bolichen97) approved, and still requires a maintainer's approval on each later phase's PR.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 81ceef7a23 · 26 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 12, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

This records acceptance of the whole tracing RFC, and #1643 is tier T3, so a maintainer has to confirm that acceptance here before it can merge. A maintainer will post the decision here.

Review result: no blocking findings on this head. We checked these points:

One thing done well: every status claim can be checked, and the "Not a goal" section says plainly that no maintainer has approved a later phase.

Optional notes:

@bolichen97

Copy link
Copy Markdown
Contributor

Thanks for keeping the RFC's status in step with main. Before I can approve this, the acceptance it records needs a source someone can open.

What's signed today. On the maintainer side, only phase 1a is signed: #34685 recorded it, I approved that record, and #31460 built it. I then approved #35077 (phase 1b) as an implementation of that same design, which is what the new tracking-issue line says. I have not accepted phases 2 to 9, or the RFC as a whole, anywhere I can find. Issue #1643 has no comment accepting more than phase 1a either.

What this PR claims. The status line and the README row now say "The whole RFC, every phase, accepted 2026-11-11 by the RFC's author and owner", and the PR body gives "the conductor chat" as the source. That chat isn't public, so neither a reviewer nor the First Principles lane can check it.

Could you either:

The rest looks right to me and needs no change: status: partial, implementation-prs: [31460, 35077], the re-audit at 386875ed0d, dropping "Nothing on main yet", and phase 9 still going through Sensitive Change Review.

@kyleseaman
kyleseaman force-pushed the crew/devmate/rfc-otel-accept-all branch from e928665 to 81ceef7 Compare November 12, 2026 12:20
@kyleseaman

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/request-for-change/rfc-crew-owned-oauth.md (same directory as this PR's files) since this head went green (b98b7cf -> ccee605); CI re-running. The patch is byte-identical; new head 81ceef7.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Nov 12, 2026
@kyleseaman
kyleseaman force-pushed the crew/devmate/rfc-otel-accept-all branch from 81ceef7 to ad149c7 Compare November 12, 2026 15:35
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 12, 2026
@kyleseaman

Copy link
Copy Markdown
Contributor Author

Thanks @bolichen97. I posted the acceptance publicly on #1643 (comment), and the Status line, the README row and the PR body now cite it instead of the chat. The rest is unchanged.

@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 13, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 13, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at ad149c7. My earlier point, the whole-RFC acceptance claim with no record, is answered. The status lines now link a public comment on #1643 (issuecomment-6827891210) in which Kyle Seaman, the RFC's author and owner, accepts rfc-otel-tracing.md as a whole, all phases. The comment also says each later phase still lands as its own PR with maintainer review, and phase 9 still goes through Sensitive Change Review. The RFC header and the README row say the same: phases 1a and 1b are on main (#31460, #35077), phases 2 to 9 are not built, and each needs a maintainer's approval on its PR.

The diff is docs only (the RFC header and its README row): no code, no regex, and all 97 checks are green.

Nit: both places date the whole-RFC acceptance 2026-11-11, but the linked comment was posted 2026-11-12. Please use the comment's date.

@bolichen97
bolichen97 merged commit 6ef9d6b into main Nov 13, 2026
153 of 154 checks passed
@bolichen97
bolichen97 deleted the crew/devmate/rfc-otel-accept-all branch November 13, 2026 17:25
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 13, 2026
@bolichen97

Copy link
Copy Markdown
Contributor

Non-blocking follow-up, since this has merged. The status lines in rfc-otel-tracing.md and its README row now say phases 2 to 9 are not built, but two of them are on main:

Could a small follow-up mark those two done, add them to implementation-prs, and use 2026-11-12 (the date of the linked comment on #1643) for the whole-RFC acceptance instead of 2026-11-11?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants