Repository navigation
docs(rfc): record whole-RFC acceptance for OTel tracing (#1643) - #35443
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS This is a docs-only status update. The stated facts match the tree: [DESIGN-REVIEWED] ad149c7 Description read[DESCRIPTION-READ] 58266d5107332382ce72519c14ff0ab3dd5bf4cf7e7b9951f2f167d0af4e7074 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
6fe2982 to
e928665
Compare
|
Rebased: main moved in docs/request-for-change/README.md (#34048) and PR #35077 (phase 1b) merged since this head was pushed (5c6750e -> b98b7cf); CI re-running. The new head e928665 records phases 1a and 1b on main and sets |
Code change approver recommendation: ApproveWhy: the decider estimates a 7% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. Docs-only status update to the OTel tracing RFC: the whole RFC is now recorded as accepted by its author and owner, the status moves from in-progress to partial, and #35077 is added to implementation-prs. Checked against the code at head: phase 1a and 1b modules exist under src/kiro_crew/tracing/ (subagents.py, runs.py); tracing is off by default behind telemetry.traces_enabled; the only exporter is the local JsonlSpanExporter; and the OTLP guide still says traces are not exported. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
This records acceptance of the whole tracing RFC, and #1643 is tier T3, so a maintainer has to confirm that acceptance here before it can merge. A maintainer will post the decision here. Review result: no blocking findings on this head. We checked these points:
One thing done well: every status claim can be checked, and the "Not a goal" section says plainly that no maintainer has approved a later phase. Optional notes:
|
|
Thanks for keeping the RFC's status in step with main. Before I can approve this, the acceptance it records needs a source someone can open. What's signed today. On the maintainer side, only phase 1a is signed: #34685 recorded it, I approved that record, and #31460 built it. I then approved #35077 (phase 1b) as an implementation of that same design, which is what the new tracking-issue line says. I have not accepted phases 2 to 9, or the RFC as a whole, anywhere I can find. Issue #1643 has no comment accepting more than phase 1a either. What this PR claims. The status line and the README row now say "The whole RFC, every phase, accepted 2026-11-11 by the RFC's author and owner", and the PR body gives "the conductor chat" as the source. That chat isn't public, so neither a reviewer nor the First Principles lane can check it. Could you either:
The rest looks right to me and needs no change: |
e928665 to
81ceef7
Compare
81ceef7 to
ad149c7
Compare
|
Thanks @bolichen97. I posted the acceptance publicly on #1643 (comment), and the Status line, the README row and the PR body now cite it instead of the chat. The rest is unchanged. |
bolichen97
left a comment
There was a problem hiding this comment.
Approve at ad149c7. My earlier point, the whole-RFC acceptance claim with no record, is answered. The status lines now link a public comment on #1643 (issuecomment-6827891210) in which Kyle Seaman, the RFC's author and owner, accepts rfc-otel-tracing.md as a whole, all phases. The comment also says each later phase still lands as its own PR with maintainer review, and phase 9 still goes through Sensitive Change Review. The RFC header and the README row say the same: phases 1a and 1b are on main (#31460, #35077), phases 2 to 9 are not built, and each needs a maintainer's approval on its PR.
The diff is docs only (the RFC header and its README row): no code, no regex, and all 97 checks are green.
Nit: both places date the whole-RFC acceptance 2026-11-11, but the linked comment was posted 2026-11-12. Please use the comment's date.
|
Non-blocking follow-up, since this has merged. The status lines in
Could a small follow-up mark those two done, add them to |
Problem / Motivation
Goal: The OTel tracing RFC records that its owner accepted the whole design, every phase, so each later phase's PR has a decision on main to trace to.
The RFC landed in #31433. #34685 recorded acceptance of phase 1a only, and phase 1a then merged as #31460. The RFC's author and owner, Kyle Seaman (@kyleseaman), accepted the whole RFC on 2026-11-11 and recorded it publicly in a comment on #1643.
Why it matters
Phase 1b (#35077) and every phase after it would otherwise implement design that main records as accepted for phase 1a alone. The status line also still says phase 1a is in review and nothing is on main, which has been false since #31460 merged.
Not a goal
What changed (motivation → approach → change)
The RFC now says the whole design is accepted and that phases 1a and 1b are on main.
rfc-otel-tracing.mdfront matterstatus: partial,doc-pr: 31433,implementation-prs: [31460, 35077], audited 2026-11-12 at386875ed0drfc-otel-tracing.mdstatus linerfc-otel-tracing.mdtracking-issue linedocs/request-for-change/README.mdindex row386875ed0d", with "Nothing on main yet" removedThe status is
partial, which the README defines as "some phases are on main; the rest are open": phases 1a and 1b merged, and no open PR implements a later phase, soin-progress("live in an open PR") no longer fits. Both are in the set the First Principles lane accepts as a decision.The index row's code facts were re-checked at
386875ed0d.src/kiro_crew/tracing/records default-off spans to a local JSONL sink, the OTLP guide still says traces are not exported, and metrics egress is still gated bymetrics/otlp_governance.py.Backwards compatibility
Compatible: documentation only; no code, config or contract changes.
Removes nothing: the edit rewrites status prose and adds a PR number; no file, key or reader is taken away.
Tests
N/A: docs only.
./scripts/docs-lint.shpasses.Manual verification
Read both files after the edit. Checked with
ghthat #31460, #34685 and #35077 are merged and that no open PR implements a later phase. Checked the row's code facts on386875ed0dwithgrep.Related Issues
Part of #1643
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)