Repository navigation
feat(chat): add fork with another model to a reply's menu - #35517
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: the new menu entry reuses the existing fork request and the composer's model picker ( Notes
What this change shipsInventory (6 items) — 5 justifiedIntent: let a person fork a chat and ask the same question of a second model in one menu action. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] e741856 Description read[DESCRIPTION-READ] c6ff5e6b0e7a1a0023af30d855cd3e71e720e2eca1bf60d6158119e4e3fb1241 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the new entry reuses the existing fork path and the composer's own model picker, and it adds no new request field or second model list. Notes
[DESIGN-REVIEWED] e741856 Description read[DESCRIPTION-READ] a85fa353999a55c8eb278cd98f30082df9b884727d457cc48de52e40ea31b96e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The blind reader correctly read the new entry as "the same copy, but with a different AI answering", and every state the diff adds appears in a screenshot. Notes
[UX-REVIEWED] e741856 Description read[DESCRIPTION-READ] 8957e2f0bd782a8459bd4be36bf3cfbd82321a5dac030025d5feed6b42d05538 That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: ApproveWhy: the decider estimates a 12% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. Adds a "Fork with another model" entry to a reply's More menu. It reuses handleFork with direction 'head' and then opens the composer's existing model picker, but only when handleFork reports that the new chat is the open one. handleFork now reports true only after the switch lands on result.key, and false on every other path. Its only reader is the new handler; the other fork entries are unchanged apart from sharing the busy state with the new entry. The entry is gated like the existing fork entries (embedded/popout, fork point resolved). Tests cover the menu order, which handler is called, the picker opening only when the fork opened the new chat, and the false result after a switch-away. Strings are added to every catalog, and the spec and decision record are updated. No regressions or trust issues found. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
buluoray
left a comment
There was a problem hiding this comment.
Approve on b66bfc6. This adds "Fork with another model" to a reply's More menu. It sends the same request as "Fork with earlier messages" and then opens the new chat's normal model picker. The original chat is not changed. The picker opens only if the new chat is still the open one, so it never acts on a chat the person moved to. The change adds no model id and no model list of its own. Models come from the composer picker that every harness already uses, and a pick goes through the usual model route. There is no backend change, so the fork still keeps the parent's privacy mode. The label is in every catalog. The entry is a normal menu item: it works from the keyboard, and its text gives it its name. Tests cover the entry, the head direction, and the rule that the picker opens only on the new chat; breaking each one makes a named test fail. Non-blocking follow-ups: (1) no test covers the "Another fork is starting" line on the plain fork entry while this new fork runs; (2) the expect(opened).toBe(activeSlot() === CHILD) check in website/src/test/forkRespectsSwitchAway.test.tsx:261 passes whether the switch landed or not, so it should assert true; (3) as with "Fork with earlier messages", the entry is missing on old replies that have no message id. Decisive lines: website/src/pages/chat/AssistantMessage.tsx:663, website/src/pages/chat/page/transcriptRendering.tsx:235, website/src/pages/useChatPageSlotSwitches.ts:84
[operator: bolichen97] |
|
[operator: bolichen97] The red backend checks on this head are main's, not this PR's (the PR changes only
Today's main has two other backend reds (#35660: |
b66bfc6 to
9fdbb18
Compare
|
Rebased: main moved in docs/decisions/README.md, docs/system-specs/modules/history.md, website/src/pages/chat/AssistantMessage.tsx, website/src/pages/chat/page/transcriptRendering.tsx, website/src/test/AssistantMessage.test.tsx and the website/src/i18n catalogs since this head's CI ran (ee7a026 -> 2f7e9f2); CI re-running. The new base carries the fixes for the main reds the previous head failed on: [operator: bolichen97] |
Asking a second model the same question took a fork, a model change in the new chat and a retyped prompt. A reply's More menu now offers "Fork with another model": it forks with the earlier messages and then opens the new chat's own model picker, so the model and its effort are picked in the one combined control and go through the same route as any pick. The picker opens only when the new chat is the open one once the switch lands. The fork request, /fork and the agent fork are unchanged. Records the maintainer decision as a docs/decisions entry and documents the entry beside the fork paragraphs of the history spec. Closes #35226
9fdbb18 to
e741856
Compare
|
Rebased: main moved in docs/decisions/README.md, docs/system-specs/modules/history.md, website/src/pages/chat/AssistantMessage.tsx, website/src/pages/useChatPageSlotSwitches.ts and the website/src/i18n catalogs since this head's CI ran (2f7e9f2 -> d9839ee); CI re-running. The new base carries #35705, the fix for the one red the previous head failed on: [operator: bolichen97] |
buluoray
left a comment
There was a problem hiding this comment.
Approve on e741856. This head is a rebase of b66bfc6, which we approved, with the PR's two menu tests moved into a file of their own. No product code of the PR changed, and the two moved tests carry the same bodies and the same checks. What we checked still holds. This adds "Fork with another model" to a reply's More menu. It sends the same request as "Fork with earlier messages" and then opens the new chat's normal model picker. The original chat is not changed. The picker opens only if the new chat is still the open one, so it never acts on a chat the person moved to. The change adds no model id and no model list of its own. Models come from the composer picker that every harness already uses, and a pick goes through the usual model route. There is no backend change, so the fork still keeps the parent's privacy mode. The label is in every catalog. The entry is a normal menu item: it works from the keyboard, and its text gives it its name. Tests cover the entry, the head direction, and the rule that the picker opens only on the new chat. Every check on this head is green. Non-blocking follow-ups, unchanged: no test covers the "Another fork is starting" line on the plain fork entry while this new fork runs; one check in website/src/test/forkRespectsSwitchAway.test.tsx passes whether the switch landed or not, so it should assert true; and, as with "Fork with earlier messages", the entry is missing on old replies that have no message id. Decisive lines: website/src/pages/chat/AssistantMessage.tsx:670, website/src/pages/chat/page/transcriptRendering.tsx:238, website/src/pages/useChatPageSlotSwitches.ts:84
Problem / Motivation
Goal: a person can fork a chat onto a second model in one menu action, so the same question can be asked of that model.
To ask a second model the same question today, a person forks, opens the new chat, opens its model picker, changes the model and types the prompt again. A reply's More menu has no entry that ends on the model choice.
Why it matters
Comparing two models on one conversation is a common reason to fork. Each extra step is friction, and a fork that silently starts on the parent's model is easy to send on the wrong model.
Not a goal
modelfield on the fork request, and no change to/fork <prompt>.session_forktool.What changed (motivation → approach → change)
A reply's More menu gets Fork with another model. It forks the chat with this message and the ones before it, then opens the new chat's own model picker. The person picks the model there, and the effort with it where the harness offers one. The parent chat does not change.
The picker is the composer's existing one, so model and effort stay one control (
docs/decisions/2026-06-14-chat-composer-model-and-effort-are-one-control.md) and the pick goes through the same route and checks as any other pick. A second, fork-only model list would have had to copy those rules. The maintainer ruling is on the issue and recorded as a newdocs/decisions/entry.docs/system-specs/modules/history.mddescribes the entry; one new string in every catalog underwebsite/src/i18n, with its translator note.Backwards compatibility
Compatible: an added menu entry; the existing fork entries, the fork request and its response are unchanged, and
handleForkresolving whether the new chat opened is read only by the new entry.Removes nothing: the diff adds a menu entry, one string and docs.
Tests
website/src/test/AssistantMessage.forkWithModel.test.tsx: the entry is listed after the fork entries with its label and line, and hands the fork point to its own handler; it is not offered before the fork point resolves.website/src/pages/ChatPage.transcriptRendering.test.tsx: the entry forks with the earlier messages and opens the model picker only when the fork opened the new chat.website/src/test/forkRespectsSwitchAway.test.tsx:handleForkresolves false when the person opened another chat while the fork ran, and reports the opened chat otherwise.Determinism: the three files plus the other fork suites (
ChatPage.handleFork,ChatSidebar.forkOpensCollapsedFolder,forkOpenPending, catalog parity) passed three runs in shuffled order (139 tests each).Manual verification
AssistantMessagein Chromium (a local capture page, not committed): entry order with Tail-only Fork on and off, light and dark, the in-flight state, and that a click hands the fork point to the new handler.Screenshots / video
The menu on a finished reply, and the new chat right after choosing the entry:
With Tail-only Fork on, light theme, and while the fork runs
Related Issues
Closes #35226
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)