Repository navigation
fix(auto-research): mark the campaign detail toggles as disclosures - #35524
dodgeblaster wants to merge 1 commit into
Conversation
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS No screenshot needed: the diff adds only ARIA state, ids and [UX-REVIEWED] 00d0559 Description read[DESCRIPTION-READ] 56467fedd0fbb9047bfc2440a41a7e818945fa6b7b1293c4c2af37f9b724c9ee That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. All four items add ARIA state to existing toggles for #32047, at mechanism level, and the sibling sweep covers this view. What this change shipsInventory (4 items) — 4 justifiedIntent: a screen-reader user can hear whether each expand/collapse toggle in the campaign detail view is open or closed. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 00d0559 Description read[DESCRIPTION-READ] 5f949727ad82a429ad2b7b4cfdda789492b6b8a8f7aaf2023ce38f1fe2f0f21c That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS No design-level concerns: adding ARIA state to three in-place toggles is a proportionate fix aimed at the stated harm, and it matches the existing View report pattern. Notes
[DESIGN-REVIEWED] 00d0559 Description read[DESCRIPTION-READ] 528825ba23c495ca08fef0f4715d0c70cc9f88c4b22ddcbcdbc4ede36fdb438c That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
4072323 to
1642cf6
Compare
|
Rebased onto current main as 1642cf6. The patch is unchanged and still touches only the two auto-research files. Why: on 4072323, |
1642cf6 to
6c4b7c6
Compare
|
Disposition: rebutted — GPT 6.1 F1,
|
The campaign detail clamps a question longer than 280 characters to three lines under a Show more / Show less button. The button carried no aria-expanded and its chevrons were exposed to assistive tech, so a screen reader heard only a label change. Each finding card and the sub-question guidance list in the same view open and close in place with the same gap. Each of the three toggles now carries aria-expanded bound to its open state and aria-controls naming the content it reveals, and its chevron is aria-hidden; the Show more button also gets type="button". This matches the View report toggle in the same view. The report toggle's test file covers all four. Fixes #32047
6c4b7c6 to
00d0559
Compare
|
Rebased onto main as 00d0559 (patch unchanged). All AI review lanes now pass on this head, including GPT 6.1 (the earlier UserMessage.tsx finding is gone). One check still fails: PR Hygiene's adopted-app rule. auto-research is now an adopted app, so this fix must first land in KiroCrewCaptain/kirocrew-app-auto-research ( |
Problem / Motivation
Goal: a screen-reader user hears whether each in-place toggle in an Auto Research campaign's detail view is open or closed, starting with the long-question Show more button.
A campaign question longer than 280 characters is clamped to three lines under a Show more / Show less button. The button carries no
aria-expandedand its chevrons are not hidden from assistive tech, so a screen reader hears only a label change and no expanded or collapsed state. Each finding card and the sub-question guidance list in the same view expand in place with the same gap.Why it matters
A disclosure with no state leaves a screen-reader user guessing whether more content is now on the page, and gives no way to reach it.
Not a goal
<button>or<Clickable>with another component.What changed (motivation → approach → change)
Symptom: Show more, a finding card and the guidance list announce no open or closed state. Cause: none of the three toggles carries ARIA state, and their chevrons are exposed. Change, in
website/src/apps/auto-research/ResearchLabPage.tsx: each toggle getsaria-expandedbound to its open state andaria-controlsnaming the content it reveals (ids fromuseId), and its chevron icons getaria-hidden. The Show more button also getstype="button". This matches the View report toggle (#32046) and theGrillTreecollapse buttons in the same app.Backwards compatibility
Compatible: only ARIA attributes and element ids are added; rendering and behaviour stay the same.
Removes nothing: the diff adds attributes and test cases and deletes no element, key or test.
Tests
website/src/apps/auto-research/ResearchLabPage.reportToggle.test.tsx, which already covers the View report toggle in this view, gains two cases:aria-expanded="false",aria-controlsnames the element holding the question text, its chevron isaria-hidden, and it flips to true / Show less and back on clicks.aria-expandedfalse → true → false, name an element that exists once open, and have anaria-hiddenchevron.aria-expandedabsent); all 119 tests undersrc/apps/auto-research/pass with the fix. The file passed 5 runs in a row with--sequence.shuffle.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
N/A — unit coverage sufficient: the change is ARIA attributes and ids only, asserted through role-based queries.
Screenshots / video
Why no screenshot: the change adds ARIA attributes and element ids only, so nothing on screen changes.
Related Issues
Fixes #32047
Sibling sweep
Swept: git grep -nE "ChevronDown|setOpen(|set[A-Z][a-zA-Z]*(v => !v)" -- website/src/apps/auto-research/
Sibling: website/src/apps/auto-research/ResearchLabPage.tsx:142 -- changed here -- the finding card expand toggle
Sibling: website/src/apps/auto-research/ResearchLabPage.tsx:639 -- changed here -- the sub-question guidance list toggle
Sibling: website/src/apps/auto-research/ResearchLabPage.tsx:831 -- not affected -- the View report toggle already has aria-expanded and aria-controls
Sibling: website/src/apps/auto-research/GrillTree.tsx:106 -- not affected -- the grill tree collapse button already has aria-expanded
Pattern harvest
Not generalizable: a handful of hand-built toggles in one view; a lint for every expand state would need to know which booleans gate visible content.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the Apache-2.0 license of this project.