Repository navigation
fix(i18n): say the crew patrol interval in unit words - #35603
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This fixes one sentence through the helper's only caller. The defect is pinned by a test that fails on base. What this change shipsInventory (5 items) — 5 justifiedIntent: Make the crewmate patrol row say its wake interval in unit words, so the Japanese sentence reads naturally. This is a FIX (#33514).
[FIRST-PRINCIPLES-REVIEWED] f59bbdc Description read[DESCRIPTION-READ] 8bc12e4da62bd8a97fa997a126fc07b5138fa739a86ea02c3274b674824d39a7 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: a one-argument unit-width fix at the formatter's one caller, with screenshots of this revision in both languages. [DESIGN-REVIEWED] f59bbdc Description read[DESCRIPTION-READ] c0beaa79095e452c735eb9e11c6429243c1707665c320097dc61c84dd300915d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The only change is the unit width of one interval string. Both screenshots show the row, and the blind reader read it correctly in English and Japanese ("starts every 15 minutes"). Notes
[UX-REVIEWED] f59bbdc Description read[DESCRIPTION-READ] 14a79e2cfdb839da0c9997fdc92343925cd31c2ac353cf7e41b5c9e1f4e18286 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: ApproveWhy: the decider estimates a 5% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. This one-line change makes
An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
buluoray
left a comment
There was a problem hiding this comment.
Approve on bed4c15. On a Bot's Schedules tab, the "Watching its tasks" row under "On its own" used to say the patrol interval in the narrow form, so English read "every 15m" and Japanese read "15mごと". This PR formats that interval with short unit words, so it reads "every 15 min" and "15 分ごと". The change is one option on intervalText, and the patrol row is that function's only caller. No catalog value or key changed; only the English translator note moved from '15m' to '15 min'. A new Japanese test fails without the fix, and so does the updated English test. Non-blocking: the facts line on the same card still mixes 2分前 with 次回は12m後, which #35442 already tracks. Decisive lines: website/src/components/autoNudgeLoop.ts:151, website/src/pages/members/CrewOnItsOwn.test.tsx:87-92
|
[operator: bolichen97] The red Backend Tests shards (3.12 5 and 6, Windows 2 and 4), and the Coverage Gate that fails closed on them, are main's red, not this diff's. CI tested this head merged into main at bb7048c, and the same node ids are red on main's own push run https://github.com/kirodotdev/KiroCrew/actions/runs/43111938067 (e8283ce):
This PR changes only the patrol row's unit width, its translator note, spec quote, capture script and frontend test, so it waits for those two fixes to merge, then re-syncs onto main and re-runs CI. No push, rerun or override for this red until then. |
The crewmate patrol row on the Schedules tab rendered its wake interval with the narrow unit default, so the Japanese sentence read 15mごとに起動します and English read every 15m. Format the interval with the short unit display its doc comment already describes, the form the Heartbeat row above it uses: 15 分ごと in Japanese, every 15 min in English. Closes #33514
bed4c15 to
f59bbdc
Compare
|
Rebased: main moved in the Crew Mode spec (docs/system-specs/modules) and website/src/i18n/en.context.json since this head went green (ee7a026 -> 9ef0fc4); CI re-running. The new base carries #35625, the fix for the two Backend Tests node ids that were red on main and on the old head. The patch is unchanged and the screenshots above were re-taken from this head. |
Problem / Motivation
Goal: The crewmate patrol row says how often it wakes in unit words, so the Japanese sentence reads
15 分ごとに起動しますinstead of15mごとに起動します.With the dashboard in Japanese, Members > a crewmate > Schedules > On its own reads
タスクから報告があったとき、または15mごとに起動します: a narrow Latinminside a Japanese sentence. English readsWakes when a task reports back, or every 15m.Why it matters
Every reader of that row outside English meets an abbreviation their language does not use mid-sentence. The Heartbeat row right above it in the same tab already says
30 min, and the Schedule template cadence was fixed the same way in #33700, so today the patrol row is the one line on the tab that still reads15m.Not a goal
Next in 13m,Hit its 7d time limit,Runs in 13m): they come from a different helper and are tracked in Japanese UI: the crewmate schedule countdowns say "次回は13m後" (narrow unit inside a sentence) #35442.What changed (motivation → approach → change)
The patrol row on a crewmate's Schedules tab put a narrow
15minside its sentence, becauseintervalTextinwebsite/src/components/autoNudgeLoop.tscalledfmtDurationwith the narrow unit default. That form is meant for tight chrome such as log rows and tab pills, not for a value dropped into a sentence.intervalTextpassesunitDisplay: 'short', the form its own doc comment already promised (20 min,1 hr 30 min) and the one the Heartbeat row uses. Japanese reads15 分ごとに起動します, Englishevery 15 min. The row is its only caller. The row keeps the grammar the 2026-10-23 decision chose (docs/decisions/2026-10-23-crewmate-watch-is-a-schedules-row-not-a-profile-readout.md: "Wakes when a task reports back, or every …", not "Every …"); only the unit width of its15mexample changes.The translator note for
pages.membersPage.patrol_wakes(en.context.json), the crew-mode spec's quote of the row (docs/system-specs/modules/crew-mode.md) and the expected text in the panel capture script (website/scripts/capture-crewmate-panel-ia.mjs) say15 minto match.Backwards compatibility
Compatible: only the rendered interval text changes; no catalog key, value, prop or API moves.
Removes nothing: the row keeps every word it had, with the unit spelled out.
Tests
website/src/pages/members/CrewOnItsOwn.test.tsx: the running-patrol case expectsevery 15 minin English, and a new case renders the row in Japanese and expects…または15 分ごとに起動します. With theintervalTextchange reverted both fail (2 failed, 20 passed); with it, all 22 pass.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Rendered the crewmate Schedules tab from this head's built dashboard with the repo's capture harness (
website/scripts/capture-crewmate-panel-ia.mjs, fixture API, no gateway), in English and in Japanese, and read the patrol row:Wakes when a task reports back, or every 15 minandタスクから報告があったとき、または15 分ごとに起動します.Screenshots / video
The patrol row on a crewmate's Schedules tab, from this head.
English:
Japanese:
Related Issues
Closes #33514
Sibling sweep
Swept: git grep -nE "fmtDuration(|fmtUnit(" -- website/src ':!website/src/apps', and every ja value with a placeholder right before ごと
Sibling: website/src/components/autoNudgeLoop.ts:151 -- changed here
Sibling: website/src/pages/members/CrewScheduleList.tsx:18 -- tracked in #35442
Sibling: website/src/pages/members/CrewGoals.tsx:241 -- not affected -- the Heartbeat interval already uses the short unit display
Sibling: website/src/cards/kindBodies.tsx:33 -- not affected -- the goal heartbeat note already uses the short unit display
Sibling: website/src/cards/scheduleText.ts:27 -- not affected -- the change-card cadence uses the long unit display
Sibling: website/src/utils/scheduleCadence.ts:56 -- not affected -- the Schedule template cadence uses the short unit display since #33700
Pattern harvest
Rule candidate: lint
Pattern: a
fmtDuration(...)orfmtUnit(...)value with the narrow default passed as an interpolation value into ani18nT/tsentenceChecklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)