Skip to content

feat: add a static canvas artifact kind - #35618

Open
dodgeblaster wants to merge 2 commits into
mainfrom
feat/kcanvas
Open

dodgeblaster wants to merge 2 commits into
mainfrom
feat/kcanvas

Conversation

@dodgeblaster

@dodgeblaster dodgeblaster commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: People can create, draw on and keep a whiteboard canvas in the Artifacts library, with no AI involved.

Today the Artifacts library holds documents, widgets and images, but nothing you can sketch on. The FigJam-style board built for docwork sessions only lives inside a session and is tied to its conductor.

Why it matters

A canvas is the first native "surface" from the surfaces design: a file type people own and edit by hand. Shipping it static first lets the editor, the file format and the save path settle before any AI is layered on top.

Not a goal

  • Any AI: no conductor, asks, threads, goals, overlays or session cards.
  • Surface records, linked targets or the .kcanvas file living in a folder the person picks; the canvas is stored in the artifact store.
  • Rich text (links, lists) or font choice inside text boxes.
  • Real-time collaboration.

What changed (motivation → approach → change)

A new artifact kind, canvas, holds a .canvas file: a JSON Canvas 1.0 document with Kiro's own fields added ({"kirocanvas": 1, "nodes", "edges"}), so Obsidian opens Kiro's boards and Kiro opens Obsidian's. jsonCanvas.ts converts at the file boundary: what JSON Canvas has no field for (shape kind, named colour, outline, type style, line style) rides along as added fields, and a save writes back the file it read with only the edited values changed, so exact colours, stacking order, file/link cards and fields Kiro does not use stay as they were. Its detail page opens straight into a FigJam-style editor ported from the docwork board, with every AI part removed.

Area What a person gets
Artifacts page a Canvas tile beside Doc in the desktop quick-create row, and New canvas in the add menu on a phone; .canvas files import through Add Artifact and download back; library cards draw the canvas's shapes
Editor stickies, rectangles, ellipses, diamonds, text, sections and connectors; select, move, resize, undo, copy/paste, right-click menu, zoom, dot grid
Look shapes are die-cut stickers (white edge, or the picked border colour); stickies are tilted, taped, dog-eared paper; themed floating panels instead of FigJam's fixed dark ones
Text a text toolbar (colour, size, bold, strikethrough, alignment); shapes with text get alignment and size, centred by default
Saving no edit mode: a silent live save shortly after each change, on the content token it read; a conflict stops autosave and asks to reload or keep mine; past versions, canvases mirroring a file on disk or showing masked text, and a chat's artifact side panel show it read-only, and an unreadable document is never saved over and offers to ask the agent
Page controls Back, the version picker, Compare with, Snapshot and Send to session send a waiting save first; Download and Copy take what the screen shows; leaving right after an edit waits for its save, and edits a failed save left behind ask before any exit drops them; undo and unfinished gestures never write back over a canvas changed elsewhere
Narrow canvases finger drags move shapes instead of scrolling; at any canvas width (a phone, or a desktop split with chat open) the dock scrolls inside the canvas and zoom sits top right off its row; on a phone the selection toolbar sits across the top with its panels fitting the canvas

The kind is in ALLOWED_KINDS, inferred from a .canvas source path, and deliberately not in USER_SELECTABLE_KINDS, like dashboard: prose flipped to canvas would be a document the editor cannot read. The editor's CSS paint values live in canvasPaint.ts, exempted by exact path from the i18n literal scan like themeCss.ts. All new strings are translated into the eleven shipped catalogs. The artifacts spec documents the kind.

The canvas code stays out of the dashboard's first load: the editor, the model, the JSON Canvas reader, the thumbnail and the panel view are reached only through components/canvas/lazyCanvas.ts's import() entry points, so a page that never shows a canvas does not download them. A chunk that fails to load shows "The canvas couldn't load" with Try Again and Reload page in the canvas's place.

Where it plugs in: artifact_store/rules.py (the kind and extension), dashboard/handlers/artifacts_parts/record_serialization.py (the detail read flags masked text as content_redacted), lib/artifactImport.ts and types/index.artifacts.ts, the Artifacts pages under pages/ (ArtifactsPage.tsx for New canvas, ArtifactDetailPageHeader.tsx and useArtifactDetailPageEditor.ts for Back, versions and Snapshot), and the catalogs in i18n/locales with their en.context.json notes.

Backwards compatibility

Compatible: a new kind and a new extension mapping; every stored artifact and route reads as before. Two additive changes reach every kind: the detail read gains a content_redacted field when masking changed the text, and Open full chat and Back to library on the detail page ask before discarding an edited markdown or text buffer, as the version picker already did.

Removes nothing: the change only adds a kind, a file type and an editor.

Tests

  • test/test_artifacts_kind_inference.py: .canvas infers canvas, the detail read flags masked content as content_redacted, a canvas keeps its kind through a save, and canvas is not user-selectable.
  • website/src/test/canvas.test.tsx: the model and the editor driven through real pointer and key events (shapes and connectors, ids that never repeat on paste or import, a route that collapses to one point, sections, colours and a dismissed colour gesture, locks surviving undo, keys on toolbar buttons, stickers, stickies, text toolbar, shape text controls, dock tooltip).
  • website/src/test/canvasFormat.test.tsx: the .canvas format read from a file exactly as Obsidian saved it after editing a Kiro board (a moved and recoloured sticky, a new card, a dropped default arrow), colour presets and stale named colours, start-only arrows, an untouched file written back identical, and each edit (recolour, move, retext, arrow, restack, delete, undo) changing only what it edited.
  • website/src/test/canvasArtifact.test.tsx: autosave on the read token, the conflict path (keep mine / reload), unreadable documents never saved over and handed to the agent, past versions read-only, the live token taken on returning from an identical version, flushing before Snapshot, a failed save guarding the exit, undo and open gestures cleared when the canvas changes elsewhere, an exit held until a waiting save lands, Download reading the shown canvas, the hex field committing only typed colours, the phone layout, the custom colour picker (drag, typing, eyedropper), toolbar panels closing one another, the zoom menu, linked files read-only, bounds of very large canvases, the chat side panel view, the right-click menu's keyboard, New canvas and import filing, the thumbnail.

Run locally: the canvas, artifact and i18n suites, static gates (black, isort, flake8, mypy, comment-history, brand, file-line cap) and the i18n gate chain. The full suites are left to CI.

Manual verification

Tried live on a pod: New canvas, drawing and editing every shape kind, connectors, text and shape toolbars, reload keeps the canvas, dark and light themes.

Screenshots / video

Screenshot 2026-11-11 at 12 29 31 PM Screenshot 2026-11-11 at 12 29 41 PM

Related Issues

Part of #36836

Design: RFC #38136 (docs/request-for-change/rfc-canvas-artifact-kind.md) records the .canvas format, autosave, the kind's place in the artifact model and the design, UX, First Principles and toolbar decisions for a maintainer to accept. This PR merges after that RFC is accepted.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 11, 2026
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ human override accepted

@dodgeblaster overrode this lane for 6934dee6e00deb7f2a681b21ede6d76b6478346f via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ human override accepted

@dodgeblaster overrode this lane for 6934dee6e00deb7f2a681b21ede6d76b6478346f via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@dodgeblaster overrode this lane for 6934dee6e00deb7f2a681b21ede6d76b6478346f via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — 🔴 changes requested (blocking)

GPT 6.1 found at least one blocking issue that must be resolved before merging 6934dee6e00deb7f2a681b21ede6d76b6478346f. Adjudication upheld 2 of 2 blocking finding(s); those must be resolved before merging.

This comment is updated in place on each push.

BLOCKING -- website/src/components/canvas/TextSizeMenu.tsx:50 -- Text-size menu is clipped near the canvas bottom

className="absolute inset-x-0 top-full mt-2 ..."
Trigger: Select a text box near the bottom of a desktop canvas and open Text size. CanvasEditor.toolbarAt positions its toolbar above the selection, but TextSizeMenu always opens downward, ignoring data-below.
Outcome: The editor’s overflow-hidden clips the lower size options and custom-size input, although there is space above the toolbar.
Anchor: defect
Fix: Follow the other toolbar menus’ desktop positioning: open upward by default and downward when data-below is true.
Sites: website/src/components/canvas/TextToolbar.tsx:56; website/src/components/canvas/ShapeToolbar.tsx:166.

BLOCKING -- website/src/components/canvas/CanvasEditor.tsx:1123 -- Selection toolbars cannot fit beside the chat panel

style={narrow ? at.style : { ...at.style, left, width: 'max-content' }}
Trigger: Open the artifact’s chat panel in an 800px-wide desktop window and select text. The fixed 480px chat column leaves less than 304px for the canvas, while viewport-based useIsMobile() retains the nonwrapping desktop toolbar.
Outcome: The toolbar exceeds the canvas width. Its horizontal clamp cannot satisfy both edges, so formatting controls extend beyond the editor’s hidden overflow and cannot be clicked. Panels wider than the canvas have the same problem.
Anchor: defect
Fix: Constrain toolbars and panels to the measured canvas width, allowing wrapping or internal scrolling when their natural width does not fit.
Sites: website/src/components/canvas/TextToolbar.tsx:51; website/src/components/canvas/ShapeToolbar.tsx:119; website/src/components/canvas/ConnectorToolbar.tsx:46; panel clamp in website/src/components/canvas/CanvasEditor.tsx:1098.

[BLOCK-MERGE] 6934dee
[GPT-REVIEWED] 6934dee

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

F1 is MEDIUM harm. On a desktop canvas, toolbarAt places the toolbar above the selection (CanvasEditor.tsx:319-321), but the Text size menu always opens downward (TextSizeMenu.tsx:50, top-full). The editor root's overflow-hidden (CanvasEditor.tsx:840) then clips the menu's lower options. The other toolbar menus already follow data-below (ShapeToolbar.tsx:41, SwatchPicker.tsx:110). The real fix is to reuse that same class string in one place, with no new state, so the cost is far below the harm.

F2 is MEDIUM harm. The narrow check comes from the window width via useIsMobile() (CanvasEditor.tsx:311), not the canvas pane. When the pane is narrow but the window is not, the desktop toolbar keeps width: max-content (CanvasEditor.tsx:1123). The toolbar is placed on the canvas width (CanvasEditor.tsx:1121) and so are the panels (CanvasEditor.tsx:1098), but neither placement can fit something wider than the canvas. Controls end up out of reach, and the only workaround is closing the chat or widening the window. The fix is moderate: the canvas width is already measured at CanvasEditor.tsx:1086-1089, so it can drive the narrow layout or wrapping. That needs no new mechanism, so the cost does not exceed the harm.

[ADJUDICATION] 6934dee6e00deb7f2a681b21ede6d76b6478346f total=2 uphold=2 downgrade=0
UPHOLD F1 website/src/components/canvas/TextSizeMenu.tsx:50 reason=harm-warrants-remedy
UPHOLD F2 website/src/components/canvas/CanvasEditor.tsx:1123 reason=harm-warrants-remedy
[GPT-ADJUDICATED] 6934dee6e00deb7f2a681b21ede6d76b6478346f

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 6934dee6e00deb7f2a681b21ede6d76b6478346f false-positive: <reason, 20 to 500 characters>

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Owner decision (design/UX): the canvas visual design (sticker look, toolbars, sticky notes, dock) is being worked out directly with the design team. I accept the Design Review and UX Review objections on this PR and am overriding those two lanes; design feedback is tracked with the design team, not in these lanes.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override design 2164b6b owner-decision: design is being worked out with the design team, recorded at #35618 (comment)

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override ux 2164b6b owner-decision: design is being worked out with the design team, recorded at #35618 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a owner-decision release (class owner-decision) for the design AI finding on 2164b6b6bded050671821bed4bbd1864dea7ad0c.

design is being worked out with the design team, recorded at #35618 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: Design Review. Re-run the lane's latest workflow run for 2164b6b6bded050671821bed4bbd1864dea7ad0c manually from the Actions tab.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a owner-decision release (class owner-decision) for the ux AI finding on 2164b6b6bded050671821bed4bbd1864dea7ad0c.

design is being worked out with the design team, recorded at #35618 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: UX Review. Re-run the lane's latest workflow run for 2164b6b6bded050671821bed4bbd1864dea7ad0c manually from the Actions tab.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override design 332384e reissue: same owner decision for the new head, recorded at #35618 (comment)

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override ux 332384e reissue: same owner decision for the new head, recorded at #35618 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a reissue release (class reissue) for the design AI finding on 332384eaf1702d982e32c597a45c8a5f2b164ad7.

same owner decision for the new head, recorded at #35618 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a reissue release (class reissue) for the ux AI finding on 332384eaf1702d982e32c597a45c8a5f2b164ad7.

same owner decision for the new head, recorded at #35618 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ human override accepted

Reviewed 6934dee6e00deb7f2a681b21ede6d76b6478346f — this comment is updated in place on each push.

Human judgment by @dodgeblaster overrides the Opus 5.5 finding for 6934dee6e00deb7f2a681b21ede6d76b6478346f; the recorded reason is authoritative for this commit.

[OPUS-OVERRIDE] 6934dee

Verdict recorded from an authorized human decision for commit 6934dee6e00deb7f2a681b21ede6d76b6478346f.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 6934dee6e00deb7f2a681b21ede6d76b6478346f false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Nov 12, 2026
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override design f2a28ed reissue: same owner decision for the new head, recorded at #35618 (comment)

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override ux f2a28ed reissue: same owner decision for the new head, recorded at #35618 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a reissue release (class reissue) for the design AI finding on f2a28ed7ba3417deff74ffef6376e4e306fa3a5f.

same owner decision for the new head, recorded at #35618 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a reissue release (class reissue) for the ux AI finding on f2a28ed7ba3417deff74ffef6376e4e306fa3a5f.

same owner decision for the new head, recorded at #35618 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 12, 2026
@dodgeblaster

Copy link
Copy Markdown
Contributor Author
  • span=81641241a734 Expanded colour pickers are clipped on phones

fixed in b0596f6: below md the swatch panel measures the room between its top and the canvas bottom, caps its height there and scrolls (overflow-y-auto, overscroll-contain, touch-pan-y), so Custom colour stays reachable; every md: class is unchanged.
One fix covers the Colour, Border and Text colour pickers (one SwatchPicker); canvas.test.tsx adds a case per picker that fails on the old panel.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override design b0596f6 reissue: same owner decision for the new head, recorded at #35618 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a reissue release (class reissue) for the design AI finding on b0596f6112b1bc2cef08071ac22d8cea6a67fc1c.

same owner decision for the new head, recorded at #35618 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: Design Review. Re-run the lane's latest workflow run for b0596f6112b1bc2cef08071ac22d8cea6a67fc1c manually from the Actions tab.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override ux b0596f6 reissue: same owner decision for the new head, recorded at #35618 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a reissue release (class reissue) for the ux AI finding on b0596f6112b1bc2cef08071ac22d8cea6a67fc1c.

same owner decision for the new head, recorded at #35618 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: UX Review. Re-run the lane's latest workflow run for b0596f6112b1bc2cef08071ac22d8cea6a67fc1c manually from the Actions tab.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles b0596f6 reissue: same owner decision for the new head, recorded at #35618 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a reissue release (class reissue) for the first-principles AI finding on b0596f6112b1bc2cef08071ac22d8cea6a67fc1c.

same owner decision for the new head, recorded at #35618 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for b0596f6112b1bc2cef08071ac22d8cea6a67fc1c manually from the Actions tab.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override fable b0596f6 owner-decision: the canvas selection toolbars keep FigJam-style formatting controls and the Artifacts create row keeps Doc and Canvas tiles beside More, by the owner's decisions recorded at #35618 (comment) and #issuecomment-6953579440

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a owner-decision release (class owner-decision) for the fable AI finding on b0596f6112b1bc2cef08071ac22d8cea6a67fc1c.

the canvas selection toolbars keep FigJam-style formatting controls and the Artifacts create row keeps Doc and Canvas tiles beside More, by the owner's decisions recorded at #35618 (comment) and #issuecomment-6953579440

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: Opus 5.5. Re-run the lane's latest workflow run for b0596f6112b1bc2cef08071ac22d8cea6a67fc1c manually from the Actions tab.

Shapes are drawn as die-cut stickers: a white edge (or the picked
border colour and weight) with a short lift, instead of FigJam's
coloured outline; only a dashed border draws an outline. Stickies are
tilted, dog-eared and taped paper. Connectors stop clear of the shapes
they join. The chrome moves from FigJam's fixed dark panels to themed
floating panels, with purple stickers for the active state.

Text boxes get a toolbar for colour, size, bold, strikethrough and
alignment, and shapes with text get alignment and size, centred by
default. Shape text is typed centred with an Add text hint. The dock
shows a tool's name and key after a short hover, and the selection
frame stays visible while resizing.

The canvas strings are translated into all eleven shipped catalogs,
inserted in each catalog's existing order.
@dodgeblaster

Copy link
Copy Markdown
Contributor Author
  • span=8cae56766b45 Selection controls are clipped at the canvas’s horizontal edges

fixed in 6934dee: on desktop ToolbarPlace measures its own width against the canvas and clamps its left edge 12px inside both sides, centred on the selection whenever there is room; the narrow branch of toolbarAt and all vertical placement are unchanged.
Open toolbar panels (colour, shape, text size) right-align when they would overflow, then clamp to the opposite edge; canvas.test.tsx adds left-edge, right-edge, centred and per-panel cases, which fail on the old wrapper.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override design 6934dee reissue: same owner decision for the new head, recorded at #35618 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a reissue release (class reissue) for the design AI finding on 6934dee6e00deb7f2a681b21ede6d76b6478346f.

same owner decision for the new head, recorded at #35618 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: Design Review. Re-run the lane's latest workflow run for 6934dee6e00deb7f2a681b21ede6d76b6478346f manually from the Actions tab.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override ux 6934dee reissue: same owner decision for the new head, recorded at #35618 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a reissue release (class reissue) for the ux AI finding on 6934dee6e00deb7f2a681b21ede6d76b6478346f.

same owner decision for the new head, recorded at #35618 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: UX Review. Re-run the lane's latest workflow run for 6934dee6e00deb7f2a681b21ede6d76b6478346f manually from the Actions tab.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 6934dee reissue: same owner decision for the new head, recorded at #35618 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a reissue release (class reissue) for the first-principles AI finding on 6934dee6e00deb7f2a681b21ede6d76b6478346f.

same owner decision for the new head, recorded at #35618 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for 6934dee6e00deb7f2a681b21ede6d76b6478346f manually from the Actions tab.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override fable 6934dee owner-decision: the canvas selection toolbars keep FigJam-style formatting controls and the Artifacts create row keeps Doc and Canvas tiles beside More, by the owner's decisions recorded at #35618 (comment) and #issuecomment-6953579440

@github-actions

Copy link
Copy Markdown
Contributor

AI-review override not recorded: the handler could not load its command reader (a GitHub read failed, not your command). Re-issue the command.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

/ai-review override fable 6934dee owner-decision: the canvas selection toolbars keep FigJam-style formatting controls and the Artifacts create row keeps Doc and Canvas tiles beside More, by the owner's decisions recorded at #35618 (comment) and #issuecomment-6953579440

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@dodgeblaster recorded a owner-decision release (class owner-decision) for the fable AI finding on 6934dee6e00deb7f2a681b21ede6d76b6478346f.

the canvas selection toolbars keep FigJam-style formatting controls and the Artifacts create row keeps Doc and Canvas tiles beside More, by the owner's decisions recorded at #35618 (comment) and #issuecomment-6953579440

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: Opus 5.5. Re-run the lane's latest workflow run for 6934dee6e00deb7f2a681b21ede6d76b6478346f manually from the Actions tab.

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, it's a careful piece of work, and thanks for the rebase. I reviewed head 6934dee6 against current main. It now merges cleanly, and the code looks good to me. There is one small gap and one CI item.

1. Agent tool schema does not list canvas (non-blocking). In src/kiro_crew/mcp_tools/catalog/artifacts.py, the artifact_save kind list (lines 53-62) and the artifact_list kind list (lines 243-252) stop at dashboard. But docs/system-specs/modules/artifacts.md:324 says the field accepts canvas, and server validation already accepts it. So an agent cannot save with kind="canvas" or filter the list by it. Could you either add canvas to both lists, the way dashboard was added, or say in the doc that agents edit canvases but do not create them? (image is missing from these lists on main too, so this is not a regression.)

2. Screenshot Evidence check. PR Policy is red on this head because Screenshot Evidence failed. This is a UI change, so it needs screenshots before it can merge. The other red checks (GPT 6.1 Review did not finish, Dependency License Gate hit a rate limit, CodeQL analyze) look like infra problems and should pass on a rerun.

The new commit lazy-loads the canvas code and keeps toolbars and colour panels inside the canvas. Neither change touches saving, parsing or the backend.

What I checked and found fine:

  • No new route, listener or file path. The backend change adds one boolean, content_redacted, to the existing serializer.
  • Canvas content renders as native React, not in an iframe, and is never treated as HTML. The canvas components have no dangerouslySetInnerHTML, <img>, <a>, <iframe> or fetch. lazyCanvas.ts only loads the app's own chunks.
  • Untrusted fields are validated before they reach styles. Colours must be 6-digit hex (toHex), and fills, borders, weights and swatches come from fixed sets. Sizes are clamped. A url(...) value cannot reach CSS.
  • file and link nodes are kept and written back but never drawn, so opening a canvas loads nothing from the network. Prototype keys and deep nesting are handled.
  • Every autosave sends expected_token. A 409 stops autosave and offers Reload or Keep mine. File-backed canvases, masked content and past versions open read-only, so placeholders are never saved over hidden text.
  • Kind handling matches dashboard: it is allowed, but people cannot pick it in the type control.
  • Page exits (Back, version switch, Compare, Snapshot, Send to session) flush pending saves first.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

license-override Maintainer skipped the Dependency License Gate for one commit readiness: action required A blocking check or review needs attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants