Skip to content

fix: dock bot dot shows only for unread and clears once read - #35726

Merged
bolichen97 merged 1 commit into
mainfrom
fix/dock-mate-dot-unread-only
Nov 12, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/dock-mate-dot-unread-only

Conversation

@CrysisDeu

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A starred Bot's dot in the left dock shows only when its chat has an unread reply, and goes away as soon as the person reads it.

The dock dot lit for three reasons: the Bot is working, its chat is unread, or it waits on the person. All three drew the same dot. So while a Bot (or a worker it sent) kept working, the dot stayed on even after the person read the reply. On nightly this read as "reading does not clear the dot".

Why it matters

The dot is the dock's notification mark. If it stays on after reading, people stop trusting it and miss the replies it should point to.

Not a goal

  • No change to the Bots page rows, which keep their working / unread / needs-you signals.
  • No change to the dot's look, size or color.
  • No change to the Bots nav count.

What changed (motivation → approach → change)

The dot in matesDock.tsx (MateNavItem) now reads one fact: is the Bot's chat in unreadSlots. Reading the chat removes it from unreadSlots, so the dot goes at once.

Bot state Dot before Dot after
Unread reply yes yes
Read, still working yes no
Waiting on you yes no

Working still shows on the avatar's face, as before. The crew-mode.md spec and the mateNeedsYouByKey comment in crewMode.ts are updated to match.

Backwards compatibility

Compatible: only when the dock dot appears changes; no data, API or setting is touched.

Reader: website/src/shell/nav/matesDock.tsx:MateNavItem -- crew page -- the working signal it no longer draws as a dot is still drawn on the CrewAvatar face (face-a data-working assertions in matesDock.test.tsx)
Reader: website/src/pages/members/MembersPageRoster.tsx:mateNeedsYouByKey -- crew page -- still the needs-you source for the Bots page rows, unchanged

Tests

matesDock.test.tsx now locks in: the dot shows only for an unread reply; it drops once read even while the Bot still works; working shows on the face with no dot; a turn or dispatched session waiting on the person adds no dot.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Built the dashboard and shot the dock on main and on this branch with the same seeded data: Unflaky working, Issue Triage unread, Docs Keeper waiting on you. Before, all three had a dot. After, only Issue Triage does.

Screenshots / video

Before (main):

Before: all three Bots have a dot

After:

After: only Issue Triage, which has an unread reply, has a dot

Narrow dock

Before: narrow dock

After: narrow dock

Related Issues

Closes #34851

Sibling sweep

Swept: git grep -nE "unreadSlots|busySlotKeys" -- website/src/shell
Sibling: website/src/pages/members/CrewmateRowBody.tsx -- not affected -- the Bots page row shows working and needs-you on purpose
Sibling: website/src/shell/nav/matesDock.tsx -- changed here

Pattern harvest

Not generalizable: one dot was fed by three signals by design choice; this is a product rule change, not a code pattern.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners November 12, 2026 02:52
@CrysisDeu
CrysisDeu requested a review from buluoray November 12, 2026 02:52
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 05b211bfa44f84d541905c5f97d6ac5f9ec6d491 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the dock dot now means one thing, and the description's table and spec edit cover the change, including dropping needs-you.

Notes

  • Dropping needs-you goes further than the reported bug, which was a dot that stayed on after reading while the Bot was working. A docked Bot waiting on an approval now has no mark in the dock. Confirm the global approval surfaces cover it, or keep needs-you as its own distinct mark in a follow-up.

[DESIGN-REVIEWED] 05b211b

Description read

[DESCRIPTION-READ] 2e005fa2489fef69bcb611babcf776c854171a1326d83ab31a1a3fc2a322cfaa

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 05b211bfa44f84d541905c5f97d6ac5f9ec6d491 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The reported defect, that working kept the dot lit after reading, is fixed where it starts. Removing the needs-you dot goes further than that defect and has no evidence behind it, but it can be undone, so it is a note.

Notes

  • Item 2 — rides along: the defect is that "while a Bot (or a worker it sent) kept working, the dot stayed on even after the person read the reply". Removing the working source fixes that on its own. Removing needs-you also deletes the test "marks the mate when a session it dispatched waits on an approval" and the comment "The Mates page rows and the dock's mate rows both read this one map." Nothing shows that decision was wrong, and a pending approval is cleared by answering it, not by reading. After this change nothing in website/src/shell/nav shows needs-you: a grep for needs_input|pending_approval|needsYou there finds 0 matches outside tests. Subtraction: shrink the MateNavItem hunk to removing only the working reason, and keep the mateNeedsYouByKey reason and its test.

What this change ships

Inventory (4 items) — 3 justified

Intent: a person wants a starred Bot's dock dot to point at a reply they have not read, and to clear once they read it. FIX.

  1. The dock dot no longer lights while a Bot or its worker is working; working shows on the face only — justified
  2. The dock dot no longer lights when a Bot's turn or dispatched session waits on an approval or answer — rides along; a reversed pin with no evidence
  3. The dock dot's accessible name is always "Unread message" — justified
  4. The crew-mode spec and the mateNeedsYouByKey comment now describe an unread-only dot — justified

[FIRST-PRINCIPLES-REVIEWED] 05b211b

Description read

[DESCRIPTION-READ] 6c0afdf0a8e562914e31834eb74fb375b3b3ca08a0ba32fc6155b2d90bf9d06d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 05b211bfa44f84d541905c5f97d6ac5f9ec6d491 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The blind reader took the dot to mean "something new/unread", which is what this PR makes it mean, and the before/after shots cover the change in both rail widths.

Notes

  • After this change, a Bot waiting on an approval or an answer gets no mark on its own dock row. The only remaining signal is the Bots nav "1", and the blind reader said of it: "I don't know what the number counts." Suggestion for a follow-up: give that count an accessible name or tooltip, such as "Bots waiting on you".
  • The narrow dock shows a plain dot on the Bots icon where the wide dock shows the "1". The blind reader could only "guess they mean the same thing". This is outside this PR's goal, so it's worth tracking separately.

[UX-REVIEWED] 05b211b

Description read

[DESCRIPTION-READ] 62c413ff1afe45700ebb2ec750c177c0d9eda9d62f3f44d4dda4e19da10c5790

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 05b211bfa44f84d541905c5f97d6ac5f9ec6d491 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 05b211b

Verdict parsed from the review's SHA-scoped output markers for commit 05b211bfa44f84d541905c5f97d6ac5f9ec6d491.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 05b211bfa44f84d541905c5f97d6ac5f9ec6d491 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 05b211bfa44f84d541905c5f97d6ac5f9ec6d491 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 05b211b

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 05b211bfa44f84d541905c5f97d6ac5f9ec6d491 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Nov 12, 2026
@CrysisDeu
CrysisDeu force-pushed the fix/dock-mate-dot-unread-only branch from dadbad6 to 077f6e7 Compare November 12, 2026 05:09
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/shell/nav/matesDock.tsx, website/src/shell/nav/matesDock.test.tsx and docs/system-specs/modules (cli.md, cloud.md, instances.md) since this head went green (e1b079c -> 80cf3df); CI re-running. The base now carries #35725 (Coverage Gate fix for main) and #35648 (the wide row's dot sits after the name); the conflict kept #35648's in-flow dot class and this PR's unread-only condition.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 12, 2026
@KiroCrewCaptain

KiroCrewCaptain commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider thinks the change is probably fine but estimates a 15% chance that this change introduces a defect, above the 12% limit for approving on its own.

MateNavItem now draws the dock dot only when the Bot's DM slot is in unreadSlots, so reading clears it even while the Bot or its worker keeps working. Working still shows on the avatar face for both rail surfaces. The crew-mode spec and the mateNeedsYouByKey comment are updated in the same change. The tests would fail on main: unread-only dot, dot clears after read while still working, no dot for working or needs-you. Dropping the needs-you dot is an explicit, documented part of the stated goal ("only when unread"), and no docs/decisions entry records the dock dot behaviour. The Bots page rows are unchanged, as the non-goals say. CI is green except the rate-limited readiness publisher.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 05b211bfa4 · 83 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@CrysisDeu
CrysisDeu force-pushed the fix/dock-mate-dot-unread-only branch from 077f6e7 to 05b211b Compare November 12, 2026 06:14
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules (messaging.md) since this head went red on a main-owned test (80cf3df -> 54b06e2); CI re-running. The base now carries #35746, which fixes the TestAmiArchitectureCheck red (#35745) that failed Backend Tests (3.12, 2) and Backend Tests (Windows) (2) on 077f6e7.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 12, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the whole diff, tests and the spec edit included, and the linked issue.

  • MateNavItem now reads only unreadSlots for the dock dot. Working stays on the avatar face through the working prop, as before, and a turn or dispatched session that waits on the person no longer adds a dot. This is the behavior the issue asks for in its "What it should do" section, so the dot clears the moment the thread is read.
  • The dot keeps its accessible name, now the fixed unread label, and its position classes for the touch, collapsed and expanded rails are unchanged. mateNeedsYouByKey is no longer imported by the dock, and its doc comment is updated to say only the Mates page rows read it.
  • The tests cover the face for a working mate on both surfaces, the dot only for unread and cleared on read even while a worker runs, and no dot for a turn waiting on the person. The crew-mode spec paragraph matches the new rule.
  • The PR description has before and after screenshots. No regex added.

I did not run the tests locally.

@bolichen97
bolichen97 merged commit bfd2423 into main Nov 12, 2026
97 of 100 checks passed
@bolichen97
bolichen97 deleted the fix/dock-mate-dot-unread-only branch November 12, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dock Bot dot should only mean unread, and clear once read

3 participants