Skip to content

feat(settings): merge Releases into About - #35758

Merged
adlio merged 2 commits into
mainfrom
feat/about-releases-merge
Nov 13, 2026
Merged

adlio merged 2 commits into
mainfrom
feat/about-releases-merge

Conversation

@adlio

@adlio adlio commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Settings answers "what am I on, can I update, and what would the update change?" on one About page, with the release notes included and the page kept short.

Settings has two tabs about the install itself. About shows the version, channel and update controls; Releases shows the release notes. A reader has to open both to see what they run and what changed. What an available update contains is shown only as raw text: on the desktop, About prints the feed's notes as unformatted markdown in a 160-pixel scroll box (AboutPanel.tsx:645 on main); for a gateway update, the notes appear only in the confirmation dialog after the user clicks Update.

Why it matters

The update decision is made on About, but the facts that inform it (what the running release brought, what the pending one brings) live on another tab or nowhere. Every user who checks for updates pays that extra navigation, and a gateway user cannot see the pending update's changes before starting the update. The raw box gives no count and no headings, so the reader scrolls markdown source to learn what changes.

Not a goal

  • No gateway API change: /api/releases and /api/update/check are read as they are.
  • No new source of release notes for a pip or wheel install, whose update check carries none today. When an update carries no notes, About reads this install's existing release list (/api/releases), which it already shows below.
  • No change to how updates are checked, downloaded or applied.

What changed (motivation → approach → change)

About becomes one stacked page; the Releases tab is gone.

Section What it shows
Install card Version, channel badge, build, platform, licence and commit, as before, plus the read-only channel row and Check for updates
Newer than yours Only when the release list has versions above the running one; they never mix into Earlier releases
Updates The channel switcher and the auto-update switch, always. When an update exists, "Kiro Crew X is available", the Update control and What you'd get, the changes it brings
What's new in Tagged Installed: the running release's summary, the rest behind Read all notes, the Unreleased badge on a prerelease, and View commits on GitHub
Earlier releases Five collapsed rows (version and date), the total count and Show N more. A row opens in place
Report a problem Unchanged

What you'd get reads the changelog text the update already carries. A git checkout's check returns the lines it adds to CHANGELOG.md. The desktop feed's releaseNotes is unchanged: the update's own CHANGELOG.md section, so builds already shipped read it as before. A promoted stable build does not count its own release. Each bullet counts as one change, named by its bold lead, and each bold-led paragraph as one change, shown as its area plus first sentence (updateChanges.ts); notes with nothing to count still show, under a title with no count. The list names five and folds the rest into Read the full notes. A checkout that has not checked in this tab offers Show what's in this update; a check that found no lines says so, and an update with no notes falls back to this install's release list, cut to the releases newer than the running build (notesSince, using releaseVersion.ts, with the desktop's own version in the app), so it says "N changes since your build"; it links the GitHub release only when the list lacks it.

While Settings > About is open, the update-found pop-up stays closed for a voluntary update that About shows in place; a mandatory update still opens it, and so does a gateway update the desktop About page does not draw.

The list stays bounded because only the running release is open by default and earlier releases grow five rows at a time on request. The header comment in ReleasesPanel.tsx records this. Prereleases (rc, nightly) still fold into their base version's row.

/settings/releases/<version> redirects to /settings/about?release=<version>, which opens that release, grows the list to the page that holds it and scrolls it into view; bare /settings/releases and ?tab=releases land on ?release=notes, which scrolls to and focuses the release notes section. A version not in the list gets a one-line notice. Leaving About through the rail drops the parameter. The Decisions card's "update from Settings › Releases" link now points at About in all 12 languages. Settings search and the command bar find About ("version") and its release notes ("release notes", "changelog", "what's new"). The update popup stays closed while About is open unless the update is mandatory, and each Settings tab's title is an h2 (SidePanelLayout.tsx).

i18n: removed keys settings.tabs.releases.*, aboutPanel.view_all_releases, releases.row_current_no_notes and releases.detail_unreleased; added 25 keys, translated in every catalog, with plural keys registered in pluralKeys.json; en-XA.json and ui-index.generated.json regenerated. Docs that named Settings › Releases now name About (docs/build/release.md, decisions.md, the feature map, the packaged index.md settings table and dashboard.md, changelog.py, feed_release_notes.py), and the GUI test catalog (test/gui_user/features.json, FEATURES.md) points at About. The two capture harnesses for the old tab (capture-releases-scroll.mjs, capture-settings-link.mjs) are deleted; capture-releases.mjs now shoots the About page and capture/update-card.tsx seeds the release list. Comments in SidePanelLayout.tsx and sidePanelFixedContent.test.tsx that cited the Releases tab are reworded.

Backwards compatibility

Compatible: every old Releases address still lands on the same notes, now on About.

Reader: website/src/pages/settings/DecisionsCard.tsx:SettingsLink tab="releases" -- crew page -- now tab="about"; decisionsCard.test.tsx asserts the href
Reader: src/kiro_crew/docs/ui-index.generated.json:settings.tab.releases -- chat (agent ui lookup) -- regenerated without the entry; uiLocations tests pass
Reader: test/gui_user/features.json:settings-releases start_url /settings/releases -- release (GUI test backlog) -- the URL redirects to About (SettingsPage.test.tsx "sends the old Releases address")
Reader: bookmarks and links to /settings/releases[/] or ?tab=releases -- crew page -- redirected, same test

Tests

  • ReleasesPanel.test.tsx (rewritten): the running release heads the section; prerelease named; commit ranges for unreleased, released-without-notes and released-with-notes; open and close in place; five-row cap and Show 5 more / Show 2 more; no Show more under five; ?release= opens and reveals a row past the first page; prerelease link folds to its release; unknown version notice, with and without earlier releases; stale caveat; empty and failed fetch; unmatched running version; outline badge; focus moves to the first revealed row; aria-controls only while open; ?release=notes scrolls to and focuses the section; newer versions apart and the running one tagged Installed; summary plus Read all notes.
  • UpdateFoundModal.test.tsx, UpdateModal.cov80.test.tsx: the popup stays closed on Settings > About unless the update is mandatory.
  • AboutPanelUpdateChanges.test.tsx (new): notesSince and archiveNotes cuts; the release-list fallback; prose-only notes still shown; section named by its title; entry extraction from changelog sections and checkout diffs; count, first five, "N more"; singular; desktop title names the version; no notes; untagged version link; the load offer; checked with no entries.
  • AboutPanel.layout.test.tsx (new): section order on the page; the Updates card names the version; About and its release notes in the search registry; Check for updates in the install card; a checkout offers the load, then lists the changes or says none were written; a command-updated install never offers it.
  • SettingsPage.test.tsx: no Releases tab; four old addresses redirect; leaving About drops release.
  • decisionsCard.test.tsx, settingsCoverage.test.ts: the link and the panel map follow the move. releasesPanelNarrow.test.ts is deleted with the split layout it measured.

Release notes reach MarkdownRenderer unmodified, so code spans such as <name> survive and raw <script> is still neutralised by its own post-parse sanitizer (tests in both files).

Local: tsc, eslint, I18N_BASE_REF=origin/main npm run i18n:check (19 checks pass), the scoped frontend set (605 files, 16,067 tests) pass, semgrep diff-scoped clean.

Determinism: every added test is synchronous or waits on rendered state; none reads a clock or random value.

Manual verification

Inputs exercised in the harness below: stable 0.12.1, nightly 0.13.0-nightly, no update vs update available, a deep link to 0.9.0 and to 9.9.9 (unit test), and a 390 px window. An insider or rc build was not shot: it takes the same prerelease path as nightly, which the unit tests cover with 0.2.0-nightly. A release list with fewer than five earlier entries and an update with no notes are covered by unit tests only. The desktop app path was not run by hand.

Screenshots / video

Captured with website/scripts/capture-releases.mjs at 89e3848: Vite dev server on 127.0.0.1, /api/** from fixtures, release data from the real parser over the real CHANGELOG.md; the desktop frame stands in a stub preload that delivers the real feed_release_notes.py output.

Update available, changes loaded (wide, light), and up to date (wide, light):

About with an update available
About up to date

Narrow (390 px): update available in dark, up to date in light:

About narrow dark, update
About narrow light, up to date

Desktop: 0.12.0 running, 0.12.2 offered, and newer releases sit in their own card (captured at 89e3848, when the feed still carried several sections; the card now lists the 0.12.2 section only):

Desktop update
Newer than yours

An update whose notes are not in reach (a command install, version not in the list), the offer to load a checkout's changes, and a check that returned no changelog lines:

Notes not shown
Load offer
No changelog entries

The old bare /settings/releases address, and a link to a version this build does not list:

Bare Releases address
Unknown version and Show more

Old link /settings/releases/0.10.0 lands on About with 0.10.0 open, then a release opens in place and Show 5 more adds rows:

/home/adlio/.kiro/crew/scratch/4325afd7/evidence5/redirect-and-expand.mp4

More frames

Nightly build
Wide dark, update
Narrow light, update
Expanded release, dark
Redirect to 0.9.0

Related Issues

Closes #35743

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff
redirect-and-expand.mp4
redirect-and-expand.mp4
redirect-and-expand.mp4
redirect-and-expand.mp4
redirect-and-expand.mp4

@adlio
adlio requested review from a team and KiroCrewCaptain as code owners November 12, 2026 06:05
@adlio
adlio requested a review from iamwhatever November 12, 2026 06:05
@adlio
adlio force-pushed the feat/about-releases-merge branch from 7d68665 to bdb3a7e Compare November 12, 2026 06:37
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 035a6b0579f44467325b02334fb023aaa028e77f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. The old Releases addresses redirect to About, nothing outside the patch still reads the removed tab or keys, and the PR carries rendered evidence.

Notes

  • UpdateFoundModal now hides its pop-up based on which Settings tab is open, so the modal depends on the route. If more surfaces start drawing updates in place, have About register that it is showing the update, rather than adding more route checks to the modal.

[DESIGN-REVIEWED] 035a6b0

Description read

[DESCRIPTION-READ] c2c6cf8bf07f4f24a001d440f09d4d19fe5529f6f231108b7af076c14bb5f348

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 035a6b0579f44467325b02334fb023aaa028e77f — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The Releases tab's removal is a move nobody reported failing at. The update preview it rides with is a recorded decision.

Notes

  • Item 1 — unjustified move: the only harm given is "A reader has to open both". No report names anyone who failed to find the release notes on their own tab, and every user who knew that tab now has to relearn where it is. Subtraction: keep the Releases tab and its route. Ship only the "What you'd get" preview into About, which docs/decisions/2026-11-10-the-update-preview-lives-inline-in-about-under-update.md already covers.
  • Item 5 — rides along: the redirect from /settings/releases/<version> to ?release=, plus the paging that grows the list to the requested release, exists only because of Item 1. Subtraction: it goes away with Item 1's subtraction.

What this change ships

Inventory (9 items) — 6 justified

Intent: see what you run, whether you can update, and what the update changes, all on one Settings page. ADDITION.

  1. The Releases tab is gone; its notes now sit in sections on About. — unjustified move
  2. "What you'd get" lists an available update's changes before you click Update. — justified
  3. Releases newer than yours are listed apart, and the running one is tagged Installed. — justified
  4. Earlier releases show five collapsed rows, with Show N more. — justified
  5. Old Releases URLs redirect to About, which opens and scrolls to the release. — rides along
  6. The update pop-up stays closed on About unless the update is mandatory. — justified
  7. Check for updates and the channel row moved into the install card. — unjustified move
  8. Settings search and the command bar find About for "version", "changelog" and "what's new". — justified
  9. Docs, the Decisions card link and translations in 12 languages now point at About. — justified

[FIRST-PRINCIPLES-REVIEWED] 035a6b0

Description read

[DESCRIPTION-READ] bff681d854dc968c89f730bdc391e09116514afc62eb2b19cbdf1b9f0f17788c

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 035a6b0579f44467325b02334fb023aaa028e77f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the blind reader identified and would use the main controls (What you'd get, Read all notes, Earlier releases, Show 5 more, a row opening in place). Two secondary misreads below can't be written as a Trigger and Outcome.

Notes

  • shot-06: the green "Up to date" tag sits on the same page as "Newer than yours: 0.12.2", and the blind reader said "these contradict each other — no idea which one is true." ReleasesPanel.tsx:190 builds the Newer list from the install's own release list, not from the update check. On a build whose release list already includes newer versions, either hide the section or retitle it, for example "Listed in this build, newer than its version tag".
  • shot-01: the first bullet under "What you'd get" reads just "Updates", which looks like a section heading counted as one of the "15 changes". Skip heading-only entries in updateChanges.ts so the count and the five shown lines are real changes.
  • Three links on this page do the same job with three names: "Read all notes", "Read the full notes" and "Show what's in this update". The blind reader noticed: "same kind of link with three different names". Use one verb, for example "Read all notes" and "Read the update's notes".

[UX-REVIEWED] 035a6b0

Description read

[DESCRIPTION-READ] eee4fbd1fe2bb71851b591caf4871f5201980eae174f53113aef7d5b4877e55a

That sha256 names everything this verdict read: the PR description, plus the 19 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 035a6b0579f44467325b02334fb023aaa028e77f — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 035a6b0

Verdict parsed from the review's SHA-scoped output markers for commit 035a6b0579f44467325b02334fb023aaa028e77f.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 035a6b0579f44467325b02334fb023aaa028e77f false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 035a6b0579f44467325b02334fb023aaa028e77f and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 035a6b0

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 035a6b0579f44467325b02334fb023aaa028e77f false-positive: <reason, 20 to 500 characters>

@adlio
adlio force-pushed the feat/about-releases-merge branch 2 times, most recently from f23445d to 537585b Compare November 12, 2026 07:35
@adlio

adlio commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: DOMPurify pass on markdown before MarkdownRenderer

  • span=a27ed3daf9c0 Sanitizing Markdown as HTML removes command arguments

fixed in 537585b: both update notes (AboutPanelUpdateChanges.tsx) and release bodies (ReleasesPanel.tsx) now go to MarkdownRenderer unmodified; its rehypeSanitize runs after parsing.
Tests in both files assert a <name> --source <dir> code span renders intact and a raw <script> leaves no script element.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 12, 2026
@adlio

adlio commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: ?release= link state in ReleasesPanel

  • span=e476e655836b Clear stale release-link state when the parameter is removed

fixed in 62ce28b: when release is absent the effect clears linkTarget and handledLink, leaving opened rows and the shown count alone.
ReleasesPanel.test.tsx navigates from ?release=9.9.9 to the bare URL in one mounted router and asserts the notice is gone, then that ?release=0.4.0 still opens.

@adlio
adlio force-pushed the feat/about-releases-merge branch from 537585b to 62ce28b Compare November 12, 2026 07:55
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 12, 2026
@adlio

adlio commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

self-added: no
mechanism: linkedRelease folds a ?release= value to its X.Y.Z base

  • span=e476e655836b Normalize wheel versions before resolving release links

Rebutted: disproportionate. Every in-app link and every old Releases URL names a bare X.Y.Z or a semver prerelease, which linkedRelease folds; only a hand-typed PEP 440 spelling misses.
A miss shows the "not in this build's release list" notice and leaves every row openable; mirroring changelog.running_release in the frontend would add a second parser to keep in sync. Adjudication downgraded it for the same reason.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 12, 2026
@KiroCrewCaptain

KiroCrewCaptain commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider thinks the change is probably fine but estimates a 20% chance that this change introduces a defect, above the 12% limit for approving on its own.

This PR folds the Releases tab into Settings > About and adds a "What you'd get" preview for an available update. The old Releases addresses (/settings/releases, /settings/releases/<version>, ?tab=releases) redirect to About before the layout renders. A remembered releases tab in session storage is checked against the tab list and falls back cleanly. Leaving About through the rail drops the release parameter. No reference to the removed i18n keys remains, and the new keys are in every catalog. The Check for updates button keeps its old display conditions on desktop and in the browser. On About, the update pop-up stays closed only for a voluntary update that About itself draws; mandatory updates and a desktop app's adopted or remote gateway still open it, and tests cover each case. The new reset of the local check result when a newer background check arrives fits the existing "newest answer wins" rule and has a test. No decision record is contradicted, and no file passes the line cap. The remaining problems are doc drift, the UX review's polish points and pending CI, none of which blocks.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 035a6b0579 · 3837 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@adlio

adlio commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/feature-map/README.md, src/kiro_crew/docs/ui-index.generated.json and website/src/i18n/locales/de.json (conflict resolved: kept main's wording and this PR's About link; ui-index regenerated) since this head was pushed (9dc068e -> b98b7cf); CI re-running.

@adlio
adlio force-pushed the feat/about-releases-merge branch from 62ce28b to b71f563 Compare November 12, 2026 08:31
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 12, 2026
@adlio

adlio commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/feature-map/README.md since this head went green (b98b7cf -> 9cc553f); CI re-running.

@adlio
adlio force-pushed the feat/about-releases-merge branch from b71f563 to 5611c5e Compare November 12, 2026 09:47
@adlio
adlio force-pushed the feat/about-releases-merge branch from 826ef02 to 80dc201 Compare November 13, 2026 12:30
@adlio

adlio commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=4464213526e3 Feature-map Release notes row names owners that do not call its endpoints

fixed in 80dc201: the about → Release notes row in docs/feature-map/README.md now covers only the release-notes list and "What you'd get", with GET /api/releases, which its files call (ReleasesPanel.tsx, AboutPanelUpdateChanges.tsx). The release channel, update check and CLI poke text, and GET /api/update/check, POST /api/update, POST /api/update/revalidate and GET /api/changelog, moved to the about row with their real owners. check_feature_map.py and docs-lint.sh pass.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 13, 2026
@adlio
adlio force-pushed the feat/about-releases-merge branch from 80dc201 to 0c1d49a Compare November 13, 2026 13:30
@adlio

adlio commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in. Head 80dc201 conflicted with main after #36271 (a29fcc3, "let an administrator allow or refuse each decision model"), in docs/system-specs/modules/decisions.md and the decisions_egress / decisions_backend_required keys in 13 locale files (en.manual.json, en-XA.json, bn, de, es, fr, hi, it, ja, ko, pt, ru, zh-CN). Rebased onto 0bf02ec. #36271 reworded decisions_egress and this PR changed decisions_backend_required (Settings › Releases → Settings › About), so each side's change is kept; in decisions.md the #36271 paragraph is kept with its "Settings › Releases" pointer changed to About. gen:ui, gen:settings and i18n:pseudo produced no further changes. New head 0c1d49a.

@adlio

adlio commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=59d9ab2a301e Preserve release sections the desktop has not installed

fixed in 0c1d49a: archiveNotes takes a cutAtGatewayCurrent option (default true). AboutPanelUpdateChanges passes false for the desktop caller (the one that supplies runningVersion), so every target-bounded section is kept and notesSince cuts at the desktop's version; gateway callers keep the gateway-current cutoff.
New test in AboutPanelUpdateChanges.test.tsx, lists and counts both releases newer than the desktop when the gateway is ahead, fails without the fix (1 change instead of 2).

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 13, 2026
@adlio
adlio force-pushed the feat/about-releases-merge branch from 0c1d49a to 37d1474 Compare November 13, 2026 13:49
@adlio

adlio commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=cb89bcf01ddf Keep confirmation notes aligned with the selected update

fixed in 37d1474 by changing approach: this is the third finding in AboutPanelGatewayUpdate.tsx where this tab's local check result outlives a newer background check, so it is now fixed in useAboutPanelGatewayUpdate itself. When a background check newer than the local one lands, the hook clears the whole local result (notes, target, verdict fields) and resets gwCheck. The Update button's !gwChanges guard then re-checks, and the confirmation shows only fresh notes. Fields with a status fallback (can_apply, channel, command) fall back to the status.
New test re-checks a superseded local checkout result and confirms only the fresh release notes in AboutPanelGatewayUpdate.target.test.tsx fails without the fix.

@adlio

adlio commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=9ff8fed62739 || true left in the reset effect, so a superseded local answer is never cleared

fixed in b4dfe3c: the guard reads if (local === null || newestIsLocal) return again. The || true was mine: it was left over from checking that the new test fails without the fix, and the restore step did not take effect. re-checks a superseded local checkout result and confirms only the fresh release notes passes again.

@adlio
adlio force-pushed the feat/about-releases-merge branch from 37d1474 to b4dfe3c Compare November 13, 2026 14:05
@adlio

adlio commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=cb89bcf01ddf Superseded notes appear in another version's update confirmation

fixed in b4dfe3c: the stray || true is removed, so a newer background check clears the local answer and the Update button re-checks before the confirmation opens. Same root cause as opus span 9ff8fed62739 on this head.

@adlio

adlio commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=3d62d97c8389 The "What you'd get" premise is contradicted by the diff

fixed in the description: it now says main already shows a desktop update's notes, as unformatted markdown in a 160-pixel scroll box (AboutPanel.tsx:645 on main), and shows a gateway update's notes only in the confirmation dialog after Update is clicked. It names the harm the summary removes: no count and no headings, so the reader scrolls markdown source, and a gateway user cannot see the changes before starting the update.
Notes: item 1 (Releases moved into About) is the owner's request this PR implements. Item 5: the fallback reads this install's existing release list (/api/releases), already shown on the same page, not a new source; the "Not a goal" line now says so.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 13, 2026
@adlio

adlio commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

Re-sync budget reset authorized by @adlio's standing instruction to resolve conflicts with main; generated ui-index conflict from #36358

@adlio
adlio force-pushed the feat/about-releases-merge branch from b4dfe3c to ffd586a Compare November 13, 2026 14:56
@adlio

adlio commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in. Head b4dfe3c conflicted with main after #36358 (c000f31, "make the Command Bar a dashboard setting instead of a built-in app") in the generated src/kiro_crew/docs/ui-index.generated.json, plus website/src/i18n/pluralKeys.json. Rebased onto c000f31. ui-index.generated.json: took main's copy and regenerated it with npm run gen:ui. pluralKeys.json: kept main's list in its order and appended this PR's 5 keys. gen:settings and i18n:pseudo produced no changes. New head ffd586a.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 13, 2026
Check for updates and the read-only channel sit in the install card; the
desktop feed carries the earlier sections and the app keeps those newer than
the build; prose-only notes are shown; the bare /settings/releases address
lands on the release notes section; the Updates card names the version and
falls back to this install's release list; newer releases are listed apart
and the running one is tagged Installed; the running release shows its
summary with Read all notes; About and its release notes are in settings
search; the update popup stays closed on About.
@adlio
adlio force-pushed the feat/about-releases-merge branch from ffd586a to 035a6b0 Compare November 13, 2026 15:49
@kyleseaman
kyleseaman enabled auto-merge (squash) November 13, 2026 17:38
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 13, 2026
@adlio
adlio merged commit 6c8b798 into main Nov 13, 2026
191 of 199 checks passed
@adlio
adlio deleted the feat/about-releases-merge branch November 13, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings: merge Releases into About

3 participants