Repository navigation
feat(settings): merge Releases into About - #35758
Conversation
7d68665 to
bdb3a7e
Compare
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The old Releases addresses redirect to About, nothing outside the patch still reads the removed tab or keys, and the PR carries rendered evidence. Notes
[DESIGN-REVIEWED] 035a6b0 Description read[DESCRIPTION-READ] c2c6cf8bf07f4f24a001d440f09d4d19fe5529f6f231108b7af076c14bb5f348 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS The Releases tab's removal is a move nobody reported failing at. The update preview it rides with is a recorded decision. Notes
What this change shipsInventory (9 items) — 6 justifiedIntent: see what you run, whether you can update, and what the update changes, all on one Settings page. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 035a6b0 Description read[DESCRIPTION-READ] bff681d854dc968c89f730bdc391e09116514afc62eb2b19cbdf1b9f0f17788c That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the blind reader identified and would use the main controls (What you'd get, Read all notes, Earlier releases, Show 5 more, a row opening in place). Two secondary misreads below can't be written as a Trigger and Outcome. Notes
[UX-REVIEWED] 035a6b0 Description read[DESCRIPTION-READ] eee4fbd1fe2bb71851b591caf4871f5201980eae174f53113aef7d5b4877e55a That sha256 names everything this verdict read: the PR description, plus the 19 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
f23445d to
537585b
Compare
|
self-added: yes
|
|
self-added: yes
|
537585b to
62ce28b
Compare
|
self-added: no
|
Code change approver recommendation: A person should decideWhy: the decider thinks the change is probably fine but estimates a 20% chance that this change introduces a defect, above the 12% limit for approving on its own. This PR folds the Releases tab into Settings > About and adds a "What you'd get" preview for an available update. The old Releases addresses ( An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
62ce28b to
b71f563
Compare
b71f563 to
5611c5e
Compare
826ef02 to
80dc201
Compare
|
self-added: no
|
80dc201 to
0c1d49a
Compare
|
Rebased: main moved in. Head 80dc201 conflicted with main after #36271 (a29fcc3, "let an administrator allow or refuse each decision model"), in |
|
self-added: no
|
0c1d49a to
37d1474
Compare
|
self-added: no
|
|
self-added: no
|
37d1474 to
b4dfe3c
Compare
|
self-added: no
|
|
self-added: no
|
b4dfe3c to
ffd586a
Compare
|
Rebased: main moved in. Head b4dfe3c conflicted with main after #36358 (c000f31, "make the Command Bar a dashboard setting instead of a built-in app") in the generated |
Check for updates and the read-only channel sit in the install card; the desktop feed carries the earlier sections and the app keeps those newer than the build; prose-only notes are shown; the bare /settings/releases address lands on the release notes section; the Updates card names the version and falls back to this install's release list; newer releases are listed apart and the running one is tagged Installed; the running release shows its summary with Read all notes; About and its release notes are in settings search; the update popup stays closed on About.
ffd586a to
035a6b0
Compare
Problem / Motivation
Goal: Settings answers "what am I on, can I update, and what would the update change?" on one About page, with the release notes included and the page kept short.
Settings has two tabs about the install itself. About shows the version, channel and update controls; Releases shows the release notes. A reader has to open both to see what they run and what changed. What an available update contains is shown only as raw text: on the desktop, About prints the feed's notes as unformatted markdown in a 160-pixel scroll box (
AboutPanel.tsx:645on main); for a gateway update, the notes appear only in the confirmation dialog after the user clicks Update.Why it matters
The update decision is made on About, but the facts that inform it (what the running release brought, what the pending one brings) live on another tab or nowhere. Every user who checks for updates pays that extra navigation, and a gateway user cannot see the pending update's changes before starting the update. The raw box gives no count and no headings, so the reader scrolls markdown source to learn what changes.
Not a goal
/api/releasesand/api/update/checkare read as they are./api/releases), which it already shows below.What changed (motivation → approach → change)
About becomes one stacked page; the Releases tab is gone.
What you'd get reads the changelog text the update already carries. A git checkout's check returns the lines it adds to
CHANGELOG.md. The desktop feed'sreleaseNotesis unchanged: the update's ownCHANGELOG.mdsection, so builds already shipped read it as before. A promoted stable build does not count its own release. Each bullet counts as one change, named by its bold lead, and each bold-led paragraph as one change, shown as its area plus first sentence (updateChanges.ts); notes with nothing to count still show, under a title with no count. The list names five and folds the rest into Read the full notes. A checkout that has not checked in this tab offers Show what's in this update; a check that found no lines says so, and an update with no notes falls back to this install's release list, cut to the releases newer than the running build (notesSince, usingreleaseVersion.ts, with the desktop's own version in the app), so it says "N changes since your build"; it links the GitHub release only when the list lacks it.While Settings > About is open, the update-found pop-up stays closed for a voluntary update that About shows in place; a mandatory update still opens it, and so does a gateway update the desktop About page does not draw.
The list stays bounded because only the running release is open by default and earlier releases grow five rows at a time on request. The header comment in
ReleasesPanel.tsxrecords this. Prereleases (rc, nightly) still fold into their base version's row./settings/releases/<version>redirects to/settings/about?release=<version>, which opens that release, grows the list to the page that holds it and scrolls it into view; bare/settings/releasesand?tab=releasesland on?release=notes, which scrolls to and focuses the release notes section. A version not in the list gets a one-line notice. Leaving About through the rail drops the parameter. The Decisions card's "update from Settings › Releases" link now points at About in all 12 languages. Settings search and the command bar find About ("version") and its release notes ("release notes", "changelog", "what's new"). The update popup stays closed while About is open unless the update is mandatory, and each Settings tab's title is anh2(SidePanelLayout.tsx).i18n: removed keys
settings.tabs.releases.*,aboutPanel.view_all_releases,releases.row_current_no_notesandreleases.detail_unreleased; added 25 keys, translated in every catalog, with plural keys registered inpluralKeys.json;en-XA.jsonandui-index.generated.jsonregenerated. Docs that named Settings › Releases now name About (docs/build/release.md,decisions.md, the feature map, the packagedindex.mdsettings table anddashboard.md,changelog.py,feed_release_notes.py), and the GUI test catalog (test/gui_user/features.json,FEATURES.md) points at About. The two capture harnesses for the old tab (capture-releases-scroll.mjs,capture-settings-link.mjs) are deleted;capture-releases.mjsnow shoots the About page andcapture/update-card.tsxseeds the release list. Comments inSidePanelLayout.tsxandsidePanelFixedContent.test.tsxthat cited the Releases tab are reworded.Backwards compatibility
Compatible: every old Releases address still lands on the same notes, now on About.
Reader: website/src/pages/settings/DecisionsCard.tsx:SettingsLink tab="releases" -- crew page -- now tab="about"; decisionsCard.test.tsx asserts the href
Reader: src/kiro_crew/docs/ui-index.generated.json:settings.tab.releases -- chat (agent ui lookup) -- regenerated without the entry; uiLocations tests pass
Reader: test/gui_user/features.json:settings-releases start_url /settings/releases -- release (GUI test backlog) -- the URL redirects to About (SettingsPage.test.tsx "sends the old Releases address")
Reader: bookmarks and links to /settings/releases[/] or ?tab=releases -- crew page -- redirected, same test
Tests
ReleasesPanel.test.tsx(rewritten): the running release heads the section; prerelease named; commit ranges for unreleased, released-without-notes and released-with-notes; open and close in place; five-row cap and Show 5 more / Show 2 more; no Show more under five;?release=opens and reveals a row past the first page; prerelease link folds to its release; unknown version notice, with and without earlier releases; stale caveat; empty and failed fetch; unmatched running version; outline badge; focus moves to the first revealed row;aria-controlsonly while open;?release=notesscrolls to and focuses the section; newer versions apart and the running one tagged Installed; summary plus Read all notes.UpdateFoundModal.test.tsx,UpdateModal.cov80.test.tsx: the popup stays closed on Settings > About unless the update is mandatory.AboutPanelUpdateChanges.test.tsx(new):notesSinceandarchiveNotescuts; the release-list fallback; prose-only notes still shown; section named by its title; entry extraction from changelog sections and checkout diffs; count, first five, "N more"; singular; desktop title names the version; no notes; untagged version link; the load offer; checked with no entries.AboutPanel.layout.test.tsx(new): section order on the page; the Updates card names the version; About and its release notes in the search registry; Check for updates in the install card; a checkout offers the load, then lists the changes or says none were written; a command-updated install never offers it.SettingsPage.test.tsx: no Releases tab; four old addresses redirect; leaving About dropsrelease.decisionsCard.test.tsx,settingsCoverage.test.ts: the link and the panel map follow the move.releasesPanelNarrow.test.tsis deleted with the split layout it measured.Release notes reach
MarkdownRendererunmodified, so code spans such as<name>survive and raw<script>is still neutralised by its own post-parse sanitizer (tests in both files).Local:
tsc, eslint,I18N_BASE_REF=origin/main npm run i18n:check(19 checks pass), the scoped frontend set (605 files, 16,067 tests) pass, semgrep diff-scoped clean.Determinism: every added test is synchronous or waits on rendered state; none reads a clock or random value.
Manual verification
Inputs exercised in the harness below: stable 0.12.1, nightly 0.13.0-nightly, no update vs update available, a deep link to 0.9.0 and to 9.9.9 (unit test), and a 390 px window. An insider or rc build was not shot: it takes the same prerelease path as nightly, which the unit tests cover with
0.2.0-nightly. A release list with fewer than five earlier entries and an update with no notes are covered by unit tests only. The desktop app path was not run by hand.Screenshots / video
Captured with
website/scripts/capture-releases.mjsat 89e3848: Vite dev server on 127.0.0.1,/api/**from fixtures, release data from the real parser over the realCHANGELOG.md; the desktop frame stands in a stub preload that delivers the realfeed_release_notes.pyoutput.Update available, changes loaded (wide, light), and up to date (wide, light):
Narrow (390 px): update available in dark, up to date in light:
Desktop: 0.12.0 running, 0.12.2 offered, and newer releases sit in their own card (captured at 89e3848, when the feed still carried several sections; the card now lists the 0.12.2 section only):
An update whose notes are not in reach (a command install, version not in the list), the offer to load a checkout's changes, and a check that returned no changelog lines:
The old bare
/settings/releasesaddress, and a link to a version this build does not list:Old link
/settings/releases/0.10.0lands on About with 0.10.0 open, then a release opens in place and Show 5 more adds rows:/home/adlio/.kiro/crew/scratch/4325afd7/evidence5/redirect-and-expand.mp4
More frames
Related Issues
Closes #35743
Checklist
redirect-and-expand.mp4
redirect-and-expand.mp4
redirect-and-expand.mp4
redirect-and-expand.mp4
redirect-and-expand.mp4