Repository navigation
fix(onboarding): keep other coding agents collapsed on a fresh config - #35993
Conversation
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First-run setup opened "Use other coding agents" by itself whenever the config named any harness other than Kiro CLI. Since KAS became the default, a config with no choice reads as KAS, so every fresh install drew the section open and the first click closed it. KAS is a Kiro harness that the Kiro cards set up, so the section now starts collapsed for both Kiro harnesses (KIRO_HARNESS_BACKENDS) and still starts open for a config that names a non-Kiro agent such as Claude Code. What the section shows once open is unchanged. Closes #34949
acabdec to
7f67fa2
Compare
|
self-added: no
[operator: bolichen97] |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: this is a one-line fix to the starting state, the defect is #34949, and the new test fails on the parent. What this change shipsInventory (3 items) — 3 justifiedIntent: on a fresh install, one click on "Use other coding agents" should open the section instead of closing it. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 7f67fa2 Description read[DESCRIPTION-READ] 8889189292d8aec5933b6e9c503bb9faed575d932c1b1e014f241eafb32853b9 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a one-line fix to the starting open state that reuses the existing [DESIGN-REVIEWED] 7f67fa2 Description read[DESCRIPTION-READ] c464db72bc2db8c2e1d7e531de547d8b514bbd8a997c0e93cc9064ffcd298055 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The change only sets the section's starting state, and the blind reader correctly read the collapsed "Use other coding agents" row: "clicking opens it… sure → yes". Notes
[UX-REVIEWED] 7f67fa2 Description read[DESCRIPTION-READ] 9b960bdb16a413f0ad1bfcf83e7991cddbb90026d5f5d526b41915cba570b45e That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: ApproveWhy: the decider estimates a 6% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. One-line fix: the OtherCodingAgents disclosure now starts open only when the configured harness is outside KIRO_HARNESS_BACKENDS (kiro, kas), not whenever it isn't 'kiro'. A fresh config resolves to KAS (DEFAULT_ACP_BACKEND), so it now starts collapsed. KIRO_HARNESS_BACKENDS was already imported and is the same check the gate uses for kiroGated at line 1481. otherBackendConfigured, configuredOther and the notice and row logic are unchanged, so who the gate lets through and what the open section shows stay the same. Before the config loads the component gets KIRO_BACKEND and starts collapsed, as on main. A Claude Code config still starts open, which an existing test covers. The new test checks that a fresh config starts with aria-expanded=false and that one click opens it; it would fail without the fix. The spec doc is updated to match. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (3 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: a bug fix that keeps the "Use other coding agents" picker collapsed on a fresh config, which runs a Kiro harness, and opens it only when the config names a non-Kiro harness, with a test. Spec files changed as a ride-along (a minority of the diff on both file count and changed lines), not reviewed as a design decision: docs/system-specs/modules/learn-cron-dashboard.md.
Problem / Motivation
Goal: On a fresh install, first-run setup shows "Use other coding agents" collapsed, so the first click opens it.
On a fresh install the setup page drew "Use other coding agents" already open, chevron pointing up. The first click closed it, and the user needed a second click to see the agents (#34949).
Why it matters
Every new user meets this on the first screen the dashboard shows. A disclosure that starts open for no reason, and answers the first click by hiding what the user asked to see, makes the first minute of setup feel broken.
Not a goal
otherBackendConfiguredand the KAS admission path are untouched).What changed (motivation → approach → change)
The "Use other coding agents" section on the first-run setup page opened itself on a fresh install because it opens by default whenever the config names an agent other than Kiro CLI. A config with no choice runs KAS, the default since #20359, so every fresh config counted as "another agent".
The section now starts open only when the configured harness is outside
KIRO_HARNESS_BACKENDS(Kiro CLI and KAS), the named setacpBackend.tsalready exports. KAS is set up by the Kiro cards above the section, so a fresh config gets a collapsed section and one click opens it. A config that names a non-Kiro agent, such as Claude Code, still starts open, because then this section is what stands between the user and the dashboard. The first-run gate entry inlearn-cron-dashboard.mdnow says when the picker starts open.Backwards compatibility
Compatible: config, API and the gate's admission rules are untouched; only the section's starting open state changes, and only for a KAS config.
Removes nothing: the section, its list and its notices render exactly as before once it is open.
Tests
KiroPrerequisiteGate.agentChoice.test.tsx› "keeps other agents collapsed on a fresh config, which runs the KAS default": a config with noacp_backendrenders the toggle witharia-expanded="false", and one click opens it to the agent list. It failed on the parent commit (aria-expanded="true") and passes with the fix.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Reproduced and smoke-tested on Ubuntu Linux with headless Chromium 145 (Playwright), against a real isolated gateway: a fresh empty data home, a free loopback port, Kiro CLI not installed. On such a host the bundled engine would finish first-run setup by itself, so the gateway ran with
KIROCREW_KAS_VERSIONpointed at an engine that is not installed: the default could not start and the setup page showed.Smoke evidence, "Use other coding agents" on a fresh config (no
agent.acp_backend), the same in the dark and light themes:Nearby check: with
agent.acp_backend: "claude"the section still starts open on first paint, with Claude Code selected (first paint aria-expanded=true).Screenshots / video
First-run setup on that gateway, fresh config (no
agent.acp_backend, so KAS), Kiro CLI not installed.Before (parent commit): the section is drawn open, chevron up, and one click closes it.
After (this head): the section is drawn collapsed, chevron down, and one click opens it. What it shows once open is unchanged.
A config naming Claude Code (this head): the section still starts open, with the Claude Code notice.
Related Issues
Closes #34949
Sibling sweep
Swept: git grep -nE "!==? (KIRO_BACKEND|ACP_BACKEND_KIRO|'kiro')" -- website/src
Sibling: website/src/components/KiroPrerequisiteGate.tsx:1480 -- not affected --
otherBackendConfiguredmust stay true for KAS, which it lets through on kiro-cli ACP support; the other hit,configuredOtherat line 1072, picks the row and the notice once the section is open, which this PR leaves as it isPattern harvest
Rule candidate: review-prompt
Pattern: a "not Kiro CLI" test (
!== 'kiro') used to mean "a non-Kiro agent" also catches KAS, the default harness; test membership inKIRO_HARNESS_BACKENDSinsteadChecklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)