Skip to content

fix(onboarding): keep other coding agents collapsed on a fresh config - #35993

Merged
bolichen97 merged 1 commit into
mainfrom
fix/34949-other-agents-default-collapsed
Nov 13, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/34949-other-agents-default-collapsed

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On a fresh install, first-run setup shows "Use other coding agents" collapsed, so the first click opens it.

On a fresh install the setup page drew "Use other coding agents" already open, chevron pointing up. The first click closed it, and the user needed a second click to see the agents (#34949).

Why it matters

Every new user meets this on the first screen the dashboard shows. A disclosure that starts open for no reason, and answers the first click by hiding what the user asked to see, makes the first minute of setup feel broken.

Not a goal

What changed (motivation → approach → change)

The "Use other coding agents" section on the first-run setup page opened itself on a fresh install because it opens by default whenever the config names an agent other than Kiro CLI. A config with no choice runs KAS, the default since #20359, so every fresh config counted as "another agent".

The section now starts open only when the configured harness is outside KIRO_HARNESS_BACKENDS (Kiro CLI and KAS), the named set acpBackend.ts already exports. KAS is set up by the Kiro cards above the section, so a fresh config gets a collapsed section and one click opens it. A config that names a non-Kiro agent, such as Claude Code, still starts open, because then this section is what stands between the user and the dashboard. The first-run gate entry in learn-cron-dashboard.md now says when the picker starts open.

Backwards compatibility

Compatible: config, API and the gate's admission rules are untouched; only the section's starting open state changes, and only for a KAS config.

Removes nothing: the section, its list and its notices render exactly as before once it is open.

Tests

  • KiroPrerequisiteGate.agentChoice.test.tsx › "keeps other agents collapsed on a fresh config, which runs the KAS default": a config with no acp_backend renders the toggle with aria-expanded="false", and one click opens it to the agent list. It failed on the parent commit (aria-expanded="true") and passes with the fix.
  • The existing "keeps setup up for a configured agent that is not installed" test still pins that a Claude Code config starts open.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Reproduced and smoke-tested on Ubuntu Linux with headless Chromium 145 (Playwright), against a real isolated gateway: a fresh empty data home, a free loopback port, Kiro CLI not installed. On such a host the bundled engine would finish first-run setup by itself, so the gateway ran with KIROCREW_KAS_VERSION pointed at an engine that is not installed: the default could not start and the setup page showed.

Smoke evidence, "Use other coding agents" on a fresh config (no agent.acp_backend), the same in the dark and light themes:

parent    first paint aria-expanded=true    after one click aria-expanded=false
this head first paint aria-expanded=false   after one click aria-expanded=true
          agent radios visible: ["Claude Code","OpenAI Codex","GitHub Copilot CLI","DeepSeek Harness","goose","OpenCode","Pi","Strands"]

Nearby check: with agent.acp_backend: "claude" the section still starts open on first paint, with Claude Code selected (first paint aria-expanded=true).

Screenshots / video

First-run setup on that gateway, fresh config (no agent.acp_backend, so KAS), Kiro CLI not installed.

Before (parent commit): the section is drawn open, chevron up, and one click closes it.

before: drawn open on first paint, dark

before: after one click it is closed, dark

After (this head): the section is drawn collapsed, chevron down, and one click opens it. What it shows once open is unchanged.

after: collapsed on first paint, dark

after: one click opens it, dark

after: collapsed on first paint, light

after: one click opens it, light

A config naming Claude Code (this head): the section still starts open, with the Claude Code notice.

claude config: open on first paint, dark

Related Issues

Closes #34949

Sibling sweep

Swept: git grep -nE "!==? (KIRO_BACKEND|ACP_BACKEND_KIRO|'kiro')" -- website/src
Sibling: website/src/components/KiroPrerequisiteGate.tsx:1480 -- not affected -- otherBackendConfigured must stay true for KAS, which it lets through on kiro-cli ACP support; the other hit, configuredOther at line 1072, picks the row and the notice once the section is open, which this PR leaves as it is

Pattern harvest

Rule candidate: review-prompt
Pattern: a "not Kiro CLI" test (!== 'kiro') used to mean "a non-Kiro agent" also catches KAS, the default harness; test membership in KIRO_HARNESS_BACKENDS instead

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 12, 2026 18:08
@bolichen97
bolichen97 requested a review from buluoray November 12, 2026 18:08
@bolichen97
bolichen97 enabled auto-merge (squash) November 12, 2026 18:20
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 7f67fa29d8f589a1cdac25ef298c8e737f94a15c and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 7f67fa2

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 7f67fa29d8f589a1cdac25ef298c8e737f94a15c false-positive: <reason, 20 to 500 characters>

First-run setup opened "Use other coding agents" by itself whenever the
config named any harness other than Kiro CLI. Since KAS became the
default, a config with no choice reads as KAS, so every fresh install
drew the section open and the first click closed it.

KAS is a Kiro harness that the Kiro cards set up, so the section now
starts collapsed for both Kiro harnesses (KIRO_HARNESS_BACKENDS) and
still starts open for a config that names a non-Kiro agent such as
Claude Code. What the section shows once open is unchanged.

Closes #34949
@bolichen97
bolichen97 force-pushed the fix/34949-other-agents-default-collapsed branch from acabdec to 7f67fa2 Compare November 12, 2026 23:08
@bolichen97

bolichen97 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor Author

self-added: no

  • Bound the chained-query wait explicitly (span=114ffae79e6c)

fixed in 7f67fa2: the new test's first wait now passes GATE_READS_LAND ({ timeout: 5000 }), the ceiling settle() already uses for the gate's status -> config -> probe read chain; that constant's comment names the chain, so no second comment was added at the call site.
Class sweep: this was the only wait the PR adds right after render(); the matching wait in the older "opens other agents" test is on main and is not changed by this diff.

[operator: bolichen97]

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 7f67fa29d8f589a1cdac25ef298c8e737f94a15c — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: this is a one-line fix to the starting state, the defect is #34949, and the new test fails on the parent.

What this change ships

Inventory (3 items) — 3 justified

Intent: on a fresh install, one click on "Use other coding agents" should open the section instead of closing it. This is a FIX.

  1. On a fresh config (no choice, so KAS), the "Use other coding agents" section now starts collapsed and the first click opens it — justified
  2. A config naming a non-Kiro agent such as Claude Code still starts with the section open, now tested with the shared KIRO_HARNESS_BACKENDS set from website/src/api/acpBackend.ts:27 (3 other call sites already use it) — justified
  3. The first-run gate entry in learn-cron-dashboard.md now says when the picker starts open, and the component comment is reworded to match — justified

[FIRST-PRINCIPLES-REVIEWED] 7f67fa2

Description read

[DESCRIPTION-READ] 8889189292d8aec5933b6e9c503bb9faed575d932c1b1e014f241eafb32853b9

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 7f67fa29d8f589a1cdac25ef298c8e737f94a15c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a one-line fix to the starting open state that reuses the existing KIRO_HARNESS_BACKENDS set, and the PR includes rendered before/after evidence.

[DESIGN-REVIEWED] 7f67fa2

Description read

[DESCRIPTION-READ] c464db72bc2db8c2e1d7e531de547d8b514bbd8a997c0e93cc9064ffcd298055

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 7f67fa29d8f589a1cdac25ef298c8e737f94a15c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The change only sets the section's starting state, and the blind reader correctly read the collapsed "Use other coding agents" row: "clicking opens it… sure → yes".

Notes

[UX-REVIEWED] 7f67fa2

Description read

[DESCRIPTION-READ] 9b960bdb16a413f0ad1bfcf83e7991cddbb90026d5f5d526b41915cba570b45e

That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 7f67fa29d8f589a1cdac25ef298c8e737f94a15c — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 7f67fa2

Verdict parsed from the review's SHA-scoped output markers for commit 7f67fa29d8f589a1cdac25ef298c8e737f94a15c.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 7f67fa29d8f589a1cdac25ef298c8e737f94a15c false-positive: <reason, 20 to 500 characters>

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 6% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

One-line fix: the OtherCodingAgents disclosure now starts open only when the configured harness is outside KIRO_HARNESS_BACKENDS (kiro, kas), not whenever it isn't 'kiro'. A fresh config resolves to KAS (DEFAULT_ACP_BACKEND), so it now starts collapsed. KIRO_HARNESS_BACKENDS was already imported and is the same check the gate uses for kiroGated at line 1481. otherBackendConfigured, configuredOther and the notice and row logic are unchanged, so who the gate lets through and what the open section shows stay the same. Before the config loads the component gets KIRO_BACKEND and starts collapsed, as on main. A Claude Code config still starts open, which an existing test covers. The new test checks that a fresh config starts with aria-expanded=false and that one click opens it; it would fail without the fix. The spec doc is updated to match.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 7f67fa29d8 · 34 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 13, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (3 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: a bug fix that keeps the "Use other coding agents" picker collapsed on a fresh config, which runs a Kiro harness, and opens it only when the config names a non-Kiro harness, with a test. Spec files changed as a ride-along (a minority of the diff on both file count and changed lines), not reviewed as a design decision: docs/system-specs/modules/learn-cron-dashboard.md.

@bolichen97
bolichen97 merged commit 3f5b945 into main Nov 13, 2026
108 of 119 checks passed
@bolichen97
bolichen97 deleted the fix/34949-other-agents-default-collapsed branch November 13, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking 'Use other coding agents' the first time collapsed a section that was already open (its chevron pointed up) ins

2 participants