Skip to content

fix(mcp): list session_queue as a redaction sink and name its manager-chain reach - #36081

Merged
bolichen97 merged 1 commit into
mainfrom
pearcekieser/session-queue-followup
Nov 13, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
pearcekieser/session-queue-followup

Conversation

@Pearcekieser

@Pearcekieser Pearcekieser commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: the Security panel lists the session_queue route as a redaction sink, and the session_queue docs name every session that can reach a queue.

The session_queue route sends queued text to the calling agent as a redacted excerpt. The Security panel's sink list in src/kiro_crew/security_posture_sinks_gateway.py has no row for that route, because the module calls queued_text_for_display, and the sink check does not see that name as a redactor. The tool description and the user doc say the target is "one you created, or one handed to you". With agent.session_manager_chain on, the caller can also reach a session that one of its managed sessions manages, and so on down the chain. Review on #15423 found these points, and that PR left them to this one, together with a missing test for the cron row's two id spellings.

Why it matters

The Security panel is where a maintainer checks which routes send text out and how each one redacts it. A route that is missing from that list is not checked when the redaction rules change. An agent that reads the docs should learn the same reach that the code applies.

A cron notification's queued transcript row carries its id twice. If the two ids ever differed, a move would leave that row out of order in the transcript. Nothing tested that the one writer keeps them equal.

Not a goal

  • Changing what list returns. Every row keeps its redacted excerpt, and the reply keeps title and running.
  • Changing who can list or move a queue, or which entries a move can pass.
  • Changing the queue card or the human queue routes.

What changed (motivation → approach → change)

The queue route now has its own row on the Security panel, so a change to its redaction shows up in the same place as every other output path.

The excerpt in src/kiro_crew/dashboard/session_control_queue.py now calls _redact_for_display directly. Before, it called queued_text_for_display(user_origin=False), which reaches the same function and gives the same text. The sink check looks for a redactor call in the module that a row names, so the direct call is what lets the new Session control queue row in src/kiro_crew/security_posture_sinks_gateway.py pass that check.

The session_queue tool description in src/kiro_crew/mcp_dashboard_session_tools.py, the user doc src/kiro_crew/docs/session-control.md and the spec row in docs/system-specs/modules/session-control.md now name the manager-chain reach. The feature map's Session control row in docs/feature-map/README.md names session_control_queue.py. A comment in _render_session_queue in src/kiro_crew/mcp_dashboard_session_runs.py now says that the entry id is collapsed to one line for the same reason as the excerpt.

The cron row keeps its id in the JSON cls and in meta.queueId. Remove matches either one, and the reorder reads meta.queueId first. A new test pins queue_cron_notification, the one writer of both, to the same id in each.

Backwards compatibility

Compatible: the route accepts the same request body, applies the same gates and returns the same reply. The excerpt text is the same, because both calls reach the same redactor.

Tests

  • test_session_control_parts_contract.py compares the session-control sink rows with a fixed set, and that set holds the new Session control queue row.
  • test/test_security_posture.py checks that every redactor call site is a registered sink and that each listed sink module calls a redactor.
  • test_a_cron_twin_row_names_one_id_in_both_spellings reads cls and meta.queueId directly, checks that each holds the id queue_cron_notification returns, and checks that remove finds the row by that id.
  • The existing session_queue tests pass unchanged, including test_list_redacts_and_cuts_every_excerpt.

Proof: PROVEN test/test_session_control_parts_contract.py::test_the_drop_notice_is_its_own_output_path_beside_the_session_control_read (head c324d63)

The proof test is the sink-set check above. It fails when the Session control queue row is taken out.

Determinism: the 2 changed tests passed 15 times at -n0. The 91 tests in test/test_mcp_dashboard_session_queue.py, test/test_session_control_parts_contract.py and test/test_session_control.py passed at -n 4 --dist loadgroup.

The backend related set from scripts/run_scoped_tests.py --surface backend passes, 550 tests. flake8, isort, black and mypy are clean on the changed modules.

Manual verification

N/A: unit coverage is sufficient. The change is a redactor call with the same output, a sink row, doc text and one test.

Related Issues

Fixes #36080

Follow-up to #15423.

Sibling sweep

Swept: git grep -n "_redact_for_display(|queued_text_for_display(" -- src/kiro_crew/dashboard/session_control_queue.py src/kiro_crew/dashboard/session_control_parts/ src/kiro_crew/dashboard/session_control.py
Siblings: none -- the only other session-control module that calls a redactor is session_control_parts/delivery_containment.py, which already has its own sink row. Outside session control, four modules redact only through queued_text_for_display, as the Pattern harvest says.

Pattern harvest

Rule candidate: the sink check in test/test_security_posture.py finds redactor calls with _REDACTOR_CALL_RE, which matches \w*redact\w*( and not queued_text_for_display(. So a module that redacts only through that wrapper is never classified. Four modules do that today: dashboard/card_send.py, dashboard/chat_api/prompt_queue.py, dashboard/chat_rewind.py and dashboard/chat_turn/steer_queue.py. Adding the wrapper's name to the pattern would make each one take a sink row or a NON_EGRESS_REDACTION_MODULES entry. This PR does not make that change, because it would classify four routes outside the session-control queue.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/security_posture_sinks_gateway.py

  • @Pearcekieser posted a complete reasoning template for 018cec8.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 018cec8a1161b251552de0db8748d815b4ccdd62 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 018cec8a1161b251552de0db8748d815b4ccdd62 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

No design-level concerns. The new direct call returns the same text as the wrapper, the sink row and its contract pin are added together, and the doc edits match the manager-chain reach the code applies.

Notes

  • The excerpt now calls _redact_for_display directly just so _REDACTOR_CALL_RE sees it. That skips the wrapper whose only job is to make every caller state user_origin. The better fix is the follow-up the Pattern harvest names: teach the sink check to recognise queued_text_for_display(, so the four other modules that redact only through it get classified too, and this call can go back to the wrapper.

[DESIGN-REVIEWED] 018cec8

Description read

[DESCRIPTION-READ] 19b9830b0a186b0e0979602c559d0a3ec04aa02869ca9c308ecbf691a8ebc9ce

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 018cec8a1161b251552de0db8748d815b4ccdd62 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The fix swaps the call to suit a regex instead of fixing the regex. The redaction sink check still misses every route that redacts only through queued_text_for_display. The author names this and defers it, and it is reversible.

Notes

  • Item 2 — symptom-level: the diff swaps the call to _redact_for_display because "the sink check does not see that name as a redactor". The cause is _REDACTOR_CALL_RE in test/test_security_posture.py:63. Grepping queued_text_for_display( finds 7 other modules in src/kiro_crew/dashboard/ that call it; the description counts 4 of them as having no direct redactor call. The wrapper's docstring says "This helper is the one decision", and this site now goes around that decision.
    Subtraction: put back the queued_text_for_display(..., user_origin=False) call and replace the regex workaround with the wrapper's name in _REDACTOR_CALL_RE, as a deferred follow-up that covers all four siblings.

What this change ships

Inventory (8 items) — 7 justified

Intent: let a maintainer see the agent-facing queue route among the Security panel's redaction sinks, and make the docs state the reach the code already gives. This is a FIX.

  1. The Security panel lists a new "Session control queue" redaction sink — justified
  2. The queue excerpt is redacted by a direct private-helper call instead of the shared wrapper — symptom-level (works around the sink regex)
  3. The session_queue tool description names the manager-chain reach — justified
  4. The user doc session-control.md names the manager-chain reach and what happens after a handoff — justified
  5. The spec row and the feature-map row name the chain reach and the new module — justified
  6. The _render_session_queue comment now covers the entry id as well as the text — justified
  7. A new test checks that a cron notification's queued row carries the same id in both places — justified
  8. The session-control sink-set contract gains the new row — justified

[FIRST-PRINCIPLES-REVIEWED] 018cec8

Description read

[DESCRIPTION-READ] d98288e779be2dcb91acbcce4da168b4057a82cbdbecef47f5af2d04a642ece2

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 018cec8a1161b251552de0db8748d815b4ccdd62 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 018cec8

Verdict parsed from the review's SHA-scoped output markers for commit 018cec8a1161b251552de0db8748d815b4ccdd62.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 018cec8a1161b251552de0db8748d815b4ccdd62 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 018cec8a1161b251552de0db8748d815b4ccdd62 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 018cec8

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 018cec8a1161b251552de0db8748d815b4ccdd62 false-positive: <reason, 20 to 500 characters>

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 0a0b5a1
  • What rule changed: No allow or deny rule changed. The diff adds one row, "Session control queue", to _GATEWAY_SINKS in security_posture_sinks_gateway.py, which is the redaction-sink list that the Security panel shows.
  • Before -> after (what was allowed/blocked, now): Before, the list had no row for dashboard/session_control_queue.py, and that module redacted through queued_text_for_display(user_origin=False). After, the list names the module, and _queue_excerpt calls _redact_for_display directly. That is the same function the old call reached, so the output is the same. Nothing that was allowed or blocked has changed.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): The new row could describe the queue route wrongly on the Security panel. The row is display data, and the redactor is the same function as before, so no command breaks, no secret leaks and no user is locked out.
  • Evidence checked (which sandbox result proves it): No sandbox rule changed, so no sandbox run applies. test/test_security_posture.py passes on this head, including test_every_redactor_call_site_is_a_registered_sink_or_allowlisted and the check that each listed sink module calls a redactor. test_list_redacts_and_cuts_every_excerpt and test_a_restored_id_is_redacted_before_it_is_cut put an AWS-style key in the caller's own entry and in an entry id, and assert that the key is not in the reply.
  • No regression:
    • Tools still work (which tools/commands were run, result): The session_queue tool tests in test/test_mcp_dashboard_session_queue.py pass for list and move, including the test that the tool posts the verified caller key to POST /api/session-control/queue.
    • Backward compatible (old config / old data / old callers still work, how checked): Each sink row keeps its shape of three strings, and test/test_session_control_parts_contract.py reads the new row with the existing reader. No config key, stored file or caller argument changed.
    • Existing tests (which suites passed on this head): pre_push_gate.py ran 23 gates with 0 failures on tree 5a25b2174600. The 4 targeted files test_mcp_dashboard_session_queue.py, test_session_control_parts_contract.py, test_security_posture.py and test_slot_running_readers.py had 120 passed on 7f5f49e550, and the scoped backend run had 551 passed on the first commit of this change. git range-diff shows the same patch on this head.
  • How to undo: Revert this commit. To undo only the sensitive part, delete the "Session control queue" row and restore the queued_text_for_display(text, user_origin=False) call in _queue_excerpt.

@KiroCrewCaptain

KiroCrewCaptain commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 7% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

Approved. The excerpt now calls _redact_for_display directly. That gives the same text as before, because queued_text_for_display(user_origin=False) just returns _redact_for_display(text). With the direct call, the redactor-call regex sees the module, so the new 'Session control queue' sink row passes the registry checks. Running both scanners means the row needs no "only" disclosure. Its claim that the entry id is redacted is true: the id goes through sanitize_outbound, which runs both scanners. The session-control sink-set contract test now includes the row and would fail without it. The manager-chain doc text matches _outside_reach: queue is in HANDOFF_WIDENED_OPERATIONS, and the chain walk applies to it. The new cron test pins the one writer to the same id in both places. No behaviour regressions found.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 018cec8a11 · 70 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 12, 2026
@Pearcekieser
Pearcekieser force-pushed the pearcekieser/session-queue-followup branch from 0a0b5a1 to 7323c9f Compare November 12, 2026 22:46
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 7323c9f
  • What rule changed: No allow or deny rule changed. The diff adds one row, "Session control queue", to _GATEWAY_SINKS in security_posture_sinks_gateway.py, which is the redaction-sink list that the Security panel shows.
  • Before -> after (what was allowed/blocked, now): Before, the list had no row for dashboard/session_control_queue.py, and that module redacted through queued_text_for_display(user_origin=False). After, the list names the module, and _queue_excerpt calls _redact_for_display directly. That is the same function the old call reached, so the output is the same. Nothing that was allowed or blocked has changed.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): The new row could describe the queue route wrongly on the Security panel. The row is display data, and the redactor is the same function as before, so no command breaks, no secret leaks and no user is locked out.
  • Evidence checked (which sandbox result proves it): No sandbox rule changed, so no sandbox run applies. test/test_security_posture.py passes on this head, including test_every_redactor_call_site_is_a_registered_sink_or_allowlisted and the check that each listed sink module calls a redactor. test_list_redacts_and_cuts_every_excerpt and test_a_restored_id_is_redacted_before_it_is_cut put an AWS-style key in the caller's own entry and in an entry id, and assert that the key is not in the reply.
  • No regression:
    • Tools still work (which tools/commands were run, result): The session_queue tool tests in test/test_mcp_dashboard_session_queue.py pass for list and move, including the test that the tool posts the verified caller key to POST /api/session-control/queue.
    • Backward compatible (old config / old data / old callers still work, how checked): Each sink row keeps its shape of three strings, and test/test_session_control_parts_contract.py reads the new row with the existing reader. No config key, stored file or caller argument changed.
    • Existing tests (which suites passed on this head): pre_push_gate.py ran 23 gates with 0 failures on tree 80e5d557c97c. These 8 files had 241 passed and 2 xfailed on this head: the 4 files this PR changes or reads (test_mcp_dashboard_session_queue.py, test_session_control_parts_contract.py, test_security_posture.py, test_slot_running_readers.py) and the 4 test files main changed near it (test_mcp_oauth_expiry_watch.py, test_restore_large_session_fixture.py, test_shared_crew_access_set.py, test_slack_title_text.py). The previous head 0a0b5a1 passed all 96 CI checks, and git range-diff shows the same patch on this head.
  • How to undo: Revert this commit. To undo only the sensitive part, delete the "Session control queue" row and restore the queued_text_for_display(text, user_origin=False) call in _queue_excerpt.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/feature-map/README.md, docs/system-specs/modules/history.md, docs/system-specs/modules/metrics.md, docs/system-specs/modules/shared-crew.md, src/kiro_crew/dashboard/chat_utils.py, src/kiro_crew/dashboard/chat_utils_display.py, src/kiro_crew/dashboard/mcp_oauth_expiry_watch.py, test/test_mcp_oauth_expiry_watch.py, test/test_restore_large_session_fixture.py, test/test_shared_crew_access_set.py, test/test_slack_title_text.py since this head went green (4de745e -> 0feaa8b); CI re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Nov 12, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I read the whole diff on this head, and all checks are green. Several parts are good to keep as they are:

  • The docs and tool description now name the agent.session_manager_chain reach, which matches what the code already applies.
  • The new "Session control queue" posture row.
  • The renderer's one-line guard, now covering the entry id too.
  • The cron twin-row id test.

I am requesting changes on one part: what list returns.

On main, session_queue list gives the calling agent a redacted, 200-character excerpt for every entry, and the target's title and running state. This head drops the excerpt for a person's entry and another session's, and drops title and running from the reply. No call fails, but the same caller on the same manager line now gets less than main gives it. That is a new restriction on an existing reader, and this repo does not take added strictness by default.

Please keep main's behavior as the default:

  • Keep excerpt on every listed row, redacted with user_origin=False as on main (queued_text_for_display).
  • Keep title and running in the reply and in _render_session_queue's header.

If you want the own-entries-only view, put it behind an opt-in setting that is off by default, and leave main's listing unchanged when it is off. The parts listed above can stay as they are. I will approve once the listing matches main by default.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 13, 2026
@Pearcekieser Pearcekieser changed the title fix(mcp): session_queue lists text only for the caller's own entries fix(mcp): list session_queue as a redaction sink and name its manager-chain reach Nov 13, 2026
@Pearcekieser
Pearcekieser force-pushed the pearcekieser/session-queue-followup branch from 7323c9f to c324d63 Compare November 13, 2026 02:47
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: c324d63
  • What rule changed: No allow or deny rule changed. The diff adds one row, "Session control queue", to _GATEWAY_SINKS in security_posture_sinks_gateway.py, which is the redaction-sink list that the Security panel shows.
  • Before -> after (what was allowed/blocked, now): Before, the list had no row for dashboard/session_control_queue.py, and that module redacted through queued_text_for_display(user_origin=False). After, the list names the module, and _queue_excerpt calls _redact_for_display directly. That is the same function the old call reached, so the output is the same. The list reply is the same as on main. Nothing that was allowed or blocked has changed.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): The new row could describe the queue route wrongly on the Security panel. The row is display data, and the redactor is the same function as before, so no command breaks, no secret leaks and no user is locked out.
  • Evidence checked (which sandbox result proves it): No sandbox rule changed, so no sandbox run applies. test/test_security_posture.py passes on this head, including test_every_redactor_call_site_is_a_registered_sink_or_allowlisted and the check that each listed sink module calls a redactor. test_list_redacts_and_cuts_every_excerpt puts an AWS-style key in a person's queued entry, and test_a_restored_id_is_redacted_before_it_is_cut puts one in an entry id. Both assert that the key is not in the reply.
  • No regression:
    • Tools still work (which tools/commands were run, result): The session_queue tool tests in test/test_mcp_dashboard_session_queue.py pass for list and move, including the test that the tool posts the verified caller key to POST /api/session-control/queue.
    • Backward compatible (old config / old data / old callers still work, how checked): Each sink row keeps its shape of three strings, and test/test_session_control_parts_contract.py reads the new row with the existing reader. No config key, stored file, caller argument or reply field changed.
    • Existing tests (which suites passed on this head): pre_push_gate.py ran 23 gates with 0 failures on tree cc1f95ba3e11. These 8 files had 240 passed and 2 xfailed on this head: the 4 files this PR changes or reads (test_mcp_dashboard_session_queue.py, test_session_control_parts_contract.py, test_security_posture.py, test_slot_running_readers.py) and 4 test files near it that main changed (test_mcp_oauth_expiry_watch.py, test_restore_large_session_fixture.py, test_shared_crew_access_set.py, test_slack_title_text.py). prove.py reports PROVEN for the sink-set test. git range-diff shows the same patch as e3a65679798b, where the backend related set had 550 passed.
  • How to undo: Revert this commit. To undo only the sensitive part, delete the "Session control queue" row and restore the queued_text_for_display(text, user_origin=False) call in _queue_excerpt.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note (non-blocking): the session_queue listing matches main by default again.

At this head, list is main's code. Every listed row carries its excerpt, redacted as queued_text_for_display(user_origin=False) redacts it. The reply and the _render_session_queue header keep title and running. I did not add the own-entries-only view behind a setting, because no caller needs it now.

The PR keeps the parts you named. The tool description, the user doc and the spec row name the manager-chain reach. The Security panel has a Session control queue row. The renderer comment says why the entry id is collapsed to one line. test_a_cron_twin_row_names_one_id_in_both_spellings pins the cron row's two id spellings. The excerpt calls _redact_for_display directly, which gives the same text, so that the sink check can see a redactor call in the module.

The head is c324d63.

…-chain reach

The session_queue route sends queued text to the calling agent, but the
Security panel listed no redaction sink for it. The queue excerpt now
calls the display redactor directly, which gives the same text as
queued_text_for_display(user_origin=False), and the route has its own
"Session control queue" sink row.

The tool description, the user doc and the spec now say that, with
agent.session_manager_chain on, a manager further up the line can reach
the queue too. The feature map names session_control_queue.py. A test
pins the cron twin row to one id in both its cls and meta spellings.

The listing is unchanged: every row keeps its redacted excerpt, and the
reply keeps the target's title and running state.
@Pearcekieser
Pearcekieser force-pushed the pearcekieser/session-queue-followup branch from c324d63 to 018cec8 Compare November 13, 2026 04:02
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 018cec8
  • What rule changed: No allow or deny rule changed. The diff adds one row, "Session control queue", to _GATEWAY_SINKS in security_posture_sinks_gateway.py, which is the redaction-sink list that the Security panel shows.
  • Before -> after (what was allowed/blocked, now): Before, the list had no row for dashboard/session_control_queue.py, and that module redacted through queued_text_for_display(user_origin=False). After, the list names the module, and _queue_excerpt calls _redact_for_display directly. That is the same function the old call reached, so the output is the same. The list reply is the same as on main. Nothing that was allowed or blocked has changed.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): The new row could describe the queue route wrongly on the Security panel. The row is display data, and the redactor is the same function as before, so no command breaks, no secret leaks and no user is locked out.
  • Evidence checked (which sandbox result proves it): No sandbox rule changed, so no sandbox run applies. test/test_security_posture.py passes on this head, including test_every_redactor_call_site_is_a_registered_sink_or_allowlisted and the check that each listed sink module calls a redactor. test_list_redacts_and_cuts_every_excerpt puts an AWS-style key in a person's queued entry, and test_a_restored_id_is_redacted_before_it_is_cut puts one in an entry id. Both assert that the key is not in the reply.
  • No regression:
    • Tools still work (which tools/commands were run, result): The session_queue tool tests in test/test_mcp_dashboard_session_queue.py pass for list and move, including the test that the tool posts the verified caller key to POST /api/session-control/queue.
    • Backward compatible (old config / old data / old callers still work, how checked): Each sink row keeps its shape of three strings, and test/test_session_control_parts_contract.py reads the new row with the existing reader. No config key, stored file, caller argument or reply field changed.
    • Existing tests (which suites passed on this head): This head is the same patch rebased onto main 27e9359, and git range-diff shows no change to it. pre_push_gate.py ran 23 gates with 0 failures on tree c1d3d71ae28f. These 8 files had 240 passed and 2 xfailed: test_mcp_dashboard_session_queue.py, test_session_control_parts_contract.py, test_security_posture.py, test_slot_running_readers.py, test_mcp_oauth_expiry_watch.py, test_restore_large_session_fixture.py, test_shared_crew_access_set.py and test_slack_title_text.py. test_reply_format_once.py and test_instances_crew_reads.py, which main changed next to this diff, had 129 passed. prove.py reports PROVEN for the sink-set test.
  • How to undo: Revert this commit. To undo only the sensitive part, delete the "Session control queue" row and restore the queued_text_for_display(text, user_origin=False) call in _queue_excerpt.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/instances.md, docs/system-specs/modules/session.md, src/kiro_crew/dashboard/chat_regenerate.py, src/kiro_crew/dashboard/chat_rewind.py, src/kiro_crew/dashboard/handlers/sessions.py, src/kiro_crew/dashboard/handlers_instances_crew_reads.py, src/kiro_crew/ui_prefs.py, test/test_instances_crew_reads.py, test/test_reply_format_once.py since this head went green (4e4bba3 -> 27e9359); CI re-running.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 13, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RC point fixed. I read the whole diff on this head, and all checks are green.

The point from my earlier change request (review on 7323c9f) is addressed. session_queue list now matches main:

  • Every listed row keeps its excerpt. _queue_excerpt calls _redact_for_display directly. On main, queued_text_for_display(text, user_origin=False) returns exactly _redact_for_display(text) (dashboard/chat_delivery.py), so the output is the same. The direct call is what lets the new posture row name this module as its own redaction sink.
  • title and running are no longer removed. Neither the reply nor _render_session_queue's header changes against main.

The parts I said could stay are unchanged: the agent.session_manager_chain wording in the docs and tool description, the "Session control queue" posture row and its contract test, the renderer's one-line guard comment for the entry id, and the cron twin-row id test. No regex, and no new refusal.

Approving. This approval replaces my earlier change request.

@bolichen97
bolichen97 merged commit 9911639 into main Nov 13, 2026
134 of 146 checks passed
@bolichen97
bolichen97 deleted the pearcekieser/session-queue-followup branch November 13, 2026 07:47
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

session_queue follow-ups from #15423: manager-chain wording, queue redaction sink, cron twin-row test

3 participants