Repository navigation
docs(rfc): correct the dispatch patrol bounds in the goal blocker lifecycle row - #36122
Conversation
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS I found no design-level concerns. This is a one-clause docs correction, and it matches main: Notes
[DESIGN-REVIEWED] dc2b00d Description read[DESCRIPTION-READ] 787980badf1e45404bc94c9ffe5145eec9d6140d722f01e780f5e4314fedda2d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Code change approver recommendation: ApproveWhy: the decider estimates a 4% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. This PR changes one clause in one row of the RFC index and touches no code. I checked the new wording against the head tree and it is accurate. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
…ecycle row The rfc-goal-blocker-lifecycle row in the request-for-change index said the dispatch patrol re-arms with a 300-cycle, 86,400-second pair. Since kirodotdev#33385 it arms with no cycle cap and the operator runtime ceiling, and 300 is its interval. The row now says so and names the commit it was checked at. Closes kirodotdev#36106
04d65ba to
dc2b00d
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Read the full diff. Fixes #36106, a one-row correction in the RFC index. The goal-blocker-lifecycle row said the dispatch patrol re-arms with a 300-cycle, 86,400-second pair. It now says no cycle cap (PATROL_MAX_CYCLES = 0), the operator runtime ceiling (patrol_max_runtime_secs), on the 300-second interval. I checked main's conductor_patrol.py: PATROL_INTERVAL_SECS = 300 and PATROL_MAX_CYCLES = 0 at lines 51-52, and ensure_patrol passes max_runtime_secs=patrol_max_runtime_secs(). The RFC's status stays draft; nothing is accepted here. LGTM.
Problem / Motivation
Goal: The request-for-change index states what main's dispatch patrol does, in the row #13013 added for the goal blocker lifecycle RFC.
The
rfc-goal-blocker-lifecycle.mdrow indocs/request-for-change/README.mdsays the dispatch patrol replaces a STOP-sentinel stop with "a fresh 300-cycle, 86,400-second pair". Since #33385,conductor_patrol.ensure_patrolarms with no cycle cap (PATROL_MAX_CYCLES= 0) and the operator runtime ceiling (patrol_max_runtime_secs); 300 is the patrol's interval (PATROL_INTERVAL_SECS). The Opus 5.5 review on #13013 raised this as a blocking finding (5790035564) shortly before the merge.Why it matters
The index's "What is actually on main" column is where readers look up what main does. This row tells them a re-armed patrol stops after 300 cycles or one day, while on main it has no cycle cap and runs to the operator ceiling, seven days as shipped. The RFC's own §5 table already says the right thing, so the index contradicts the document it indexes.
Not a goal
What changed (motivation → approach → change)
One clause in the
rfc-goal-blocker-lifecycle.mdindex row now says what main does: the dispatch patrol replaces a STOP-sentinel stop with a fresh arm that has no cycle cap and the operator runtime ceiling, on its 300-second interval. The clause names the commit it was checked at,c90518ed8a, and links #33385, because the row's other claims stay dated toea45e802e9.Backwards compatibility
Compatible: documentation only. No code, schema or stored data changes.
Removes nothing: the diff rewords one clause in one index row and deletes no file, row or documented capability.
Tests
./scripts/docs-lint.shandpython scripts/docs_lint.py --test: pass.test/*.pyfiles that readdocs/request-for-change/, plustest/test_docs*.py): 2,653 passed, 50 skipped.push_guard.py --base main --require-single-on-base:STATUS: SAFE TO PUSH (single commit on base).Manual verification
Read on
c90518ed8a:ensure_patrolinsrc/kiro_crew/conductor_patrol.pyarms withmax_cycles=PATROL_MAX_CYCLES(0) andmax_runtime_secs=patrol_max_runtime_secs(),PATROL_INTERVAL_SECSis300, and a STOP-sentinel stop stays replaceable (STOP_SENTINEL_REASONis inFINISHED_LOOP_REASONSinsrc/kiro_crew/autonudge_service/model.py). None of those files changed betweenc90518ed8aand this PR's base.Related Issues
Closes #36106
Follow-up to #13013 and #33385.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.