Skip to content

docs(rfc): correct the dispatch patrol bounds in the goal blocker lifecycle row - #36122

Merged
bolichen97 merged 1 commit into
kirodotdev:mainfrom
rubencu:docs/rfc-index-goal-blocker-patrol-bounds
Nov 13, 2026
Merged

bolichen97 merged 1 commit into
kirodotdev:mainfrom
rubencu:docs/rfc-index-goal-blocker-patrol-bounds

Conversation

@rubencu

@rubencu rubencu commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The request-for-change index states what main's dispatch patrol does, in the row #13013 added for the goal blocker lifecycle RFC.

The rfc-goal-blocker-lifecycle.md row in docs/request-for-change/README.md says the dispatch patrol replaces a STOP-sentinel stop with "a fresh 300-cycle, 86,400-second pair". Since #33385, conductor_patrol.ensure_patrol arms with no cycle cap (PATROL_MAX_CYCLES = 0) and the operator runtime ceiling (patrol_max_runtime_secs); 300 is the patrol's interval (PATROL_INTERVAL_SECS). The Opus 5.5 review on #13013 raised this as a blocking finding (5790035564) shortly before the merge.

Why it matters

The index's "What is actually on main" column is where readers look up what main does. This row tells them a re-armed patrol stops after 300 cycles or one day, while on main it has no cycle cap and runs to the operator ceiling, seven days as shipped. The RFC's own §5 table already says the right thing, so the index contradicts the document it indexes.

Not a goal

  • Re-auditing the row's other claims or the RFC itself. The row's other five claims still hold on main.
  • Changing what the dispatch patrol does.

What changed (motivation → approach → change)

One clause in the rfc-goal-blocker-lifecycle.md index row now says what main does: the dispatch patrol replaces a STOP-sentinel stop with a fresh arm that has no cycle cap and the operator runtime ceiling, on its 300-second interval. The clause names the commit it was checked at, c90518ed8a, and links #33385, because the row's other claims stay dated to ea45e802e9.

Backwards compatibility

Compatible: documentation only. No code, schema or stored data changes.

Removes nothing: the diff rewords one clause in one index row and deletes no file, row or documented capability.

Tests

  • ./scripts/docs-lint.sh and python scripts/docs_lint.py --test: pass.
  • The docs and RFC-index tests (the test/*.py files that read docs/request-for-change/, plus test/test_docs*.py): 2,653 passed, 50 skipped.
  • push_guard.py --base main --require-single-on-base: STATUS: SAFE TO PUSH (single commit on base).

Manual verification

Read on c90518ed8a: ensure_patrol in src/kiro_crew/conductor_patrol.py arms with max_cycles=PATROL_MAX_CYCLES (0) and max_runtime_secs=patrol_max_runtime_secs(), PATROL_INTERVAL_SECS is 300, and a STOP-sentinel stop stays replaceable (STOP_SENTINEL_REASON is in FINISHED_LOOP_REASONS in src/kiro_crew/autonudge_service/model.py). None of those files changed between c90518ed8a and this PR's base.

Related Issues

Closes #36106

Follow-up to #13013 and #33385.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@rubencu
rubencu requested review from a team and KiroCrewCaptain as code owners November 12, 2026 21:50
@rubencu
rubencu requested a review from mbriones98 November 12, 2026 21:50
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⏭️ skipped

Revision dc2b00dd80ecaf4c015794293987a4b91e7ad7d8 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision dc2b00dd80ecaf4c015794293987a4b91e7ad7d8 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of dc2b00dd80ecaf4c015794293987a4b91e7ad7d8 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

I found no design-level concerns. This is a one-clause docs correction, and it matches main: PATROL_MAX_CYCLES = 0, PATROL_INTERVAL_SECS = 300 and max_runtime_secs=patrol_max_runtime_secs() are all in conductor_patrol.py.

Notes

  • ## Backwards compatibility has both a Compatible: line and a Removes nothing: line. The format expects only the single Removes nothing: line.

[DESIGN-REVIEWED] dc2b00d

Description read

[DESCRIPTION-READ] 787980badf1e45404bc94c9ffe5145eec9d6140d722f01e780f5e4314fedda2d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed dc2b00dd80ecaf4c015794293987a4b91e7ad7d8 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] dc2b00d

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed dc2b00dd80ecaf4c015794293987a4b91e7ad7d8 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] dc2b00d

@KiroCrewCaptain

KiroCrewCaptain commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 4% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

This PR changes one clause in one row of the RFC index and touches no code. I checked the new wording against the head tree and it is accurate. PATROL_INTERVAL_SECS = 300 and PATROL_MAX_CYCLES = 0 are at conductor_patrol.py:51-52. ensure_patrol arms with max_cycles=PATROL_MAX_CYCLES and max_runtime_secs=patrol_max_runtime_secs(), and that function returns the operator's runtime ceiling (conductor_patrol.py:55-63, 412-414). A STOP-sentinel stop can still be replaced, because STOP_SENTINEL_REASON is in FINISHED_LOOP_REASONS (autonudge_service/model.py:58). The RFC's own text at rfc-goal-blocker-lifecycle.md:84-86 already says the same thing, so the change fixes the mismatch between the index and the document it indexes. The old "300-cycle, 86,400-second" wording appears nowhere else, and no test reads it. The edit removes nothing and leaves no other claim in the row stale.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit dc2b00dd80 · 2 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 12, 2026
…ecycle row

The rfc-goal-blocker-lifecycle row in the request-for-change index said the
dispatch patrol re-arms with a 300-cycle, 86,400-second pair. Since kirodotdev#33385 it
arms with no cycle cap and the operator runtime ceiling, and 300 is its
interval. The row now says so and names the commit it was checked at.

Closes kirodotdev#36106
@rubencu
rubencu force-pushed the docs/rfc-index-goal-blocker-patrol-bounds branch from 04d65ba to dc2b00d Compare November 12, 2026 23:32
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 12, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the full diff. Fixes #36106, a one-row correction in the RFC index. The goal-blocker-lifecycle row said the dispatch patrol re-arms with a 300-cycle, 86,400-second pair. It now says no cycle cap (PATROL_MAX_CYCLES = 0), the operator runtime ceiling (patrol_max_runtime_secs), on the 300-second interval. I checked main's conductor_patrol.py: PATROL_INTERVAL_SECS = 300 and PATROL_MAX_CYCLES = 0 at lines 51-52, and ensure_patrol passes max_runtime_secs=patrol_max_runtime_secs(). The RFC's status stays draft; nothing is accepted here. LGTM.

@bolichen97
bolichen97 merged commit 215822f into kirodotdev:main Nov 13, 2026
94 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(rfc): the goal blocker lifecycle index row states the dispatch patrol's pre-#33385 bounds

3 participants