Skip to content

docs: record rfc-large-session-bounded-restore as accepted - #36148

Merged
bolichen97 merged 1 commit into
mainfrom
docs/35875-rfc-accepted
Nov 13, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
docs/35875-rfc-accepted

Conversation

@chenmingwei23

@chenmingwei23 chenmingwei23 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record that the bounded-time restore RFC is accepted, so work that builds on it can merge.

The RFC merged in #35916 and maintainer chenmingwei23 (Mingwei) accepted it on #35875 on 2026-11-13: #35875 (comment). Its front matter still says draft, so the First Principles review on #36141 blocks: an RFC covering the focus-first restore order must be non-draft on base.

Why it matters

Without the status change, the implementation PR #36141 stays blocked on a decision that is already made.

Not a goal

  • No change to the design text.
  • No code change.

What changed (motivation → approach → change)

The RFC front matter moves from draft to partial (the CI fixture #35960 is merged), with the audit sha and implementation-prs [35960, 36141, 36259, 36035]. Its Status line records the acceptance. Section 5 records the decided values. The row in docs/request-for-change/README.md says partial and that the CI fixture (#35960) is merged while the rest is not built yet.

Backwards compatibility

Compatible: documentation status only.
Removes nothing: no behaviour, key or path changes.

Tests

Proof: not provable -- docs or config only. scripts/docs-lint.sh passes.

Manual verification

N/A — docs only; docs lint run locally.

Screenshots / video

N/A — no user-visible UI change.

Related Issues

Refs #35875

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality (N/A, docs only)
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 6baaa4405ffc7183a4c75862f4ccf51610056df6 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 6baaa4405ffc7183a4c75862f4ccf51610056df6 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 6baaa4405ffc7183a4c75862f4ccf51610056df6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Docs-only status change, backed by a linked maintainer acceptance; it removes nothing and adds no surface.

Notes

  • Section 5 item 2 now accepts only "1.1 and 1.2". Section 3's third behaviour change, the new open_slots.json focused and visible keys that perf(restore): build the focused tab first, then visible tabs, then the rest #36141 needs, is no longer listed as accepted. Either name it as accepted, or say it needs no decision because older builds ignore the new fields.
  • The Status: line says "1.2 and 1.1" and section 5 says "1.1 and 1.2". These are section-1 part numbers, while the behaviour changes themselves are listed in section 3. Cite §3.1, §3.2 and §3.3 so the acceptance points at the items it approves.

[DESIGN-REVIEWED] 6baaa44

Description read

[DESCRIPTION-READ] 938056ed41359bc725b8124f98d854b4979aabda197308948cc0dc94caf06837

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 6baaa4405ffc7183a4c75862f4ccf51610056df6 — this comment is updated in place on each push.

Review details

No findings.

Notes:

  • docs/request-for-change/README.md:10 says "the rest is not built yet", but crew_log/projection_slot_share.py, crew_log/slot_prime.py and test/test_crew_log_slot_one_walk.py on main already do §1.3's one walk per slot. The row, the status line and audited-at: 0feaa8be90 (still next to last-audited: 2026-11-12 and the 029b6db029 citations) should be re-audited together.

[OPUS-REVIEWED] 6baaa44

Verdict parsed from the review's SHA-scoped output markers for commit 6baaa4405ffc7183a4c75862f4ccf51610056df6.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 6baaa4405ffc7183a4c75862f4ccf51610056df6 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 6baaa4405ffc7183a4c75862f4ccf51610056df6 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 6baaa44

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 6baaa4405ffc7183a4c75862f4ccf51610056df6 false-positive: <reason, 20 to 500 characters>

@KiroCrewCaptain

KiroCrewCaptain commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider thinks the change is probably fine but estimates a 22% chance that this change introduces a defect, above the 12% limit for approving on its own.

This PR only changes RFC status text: it records acceptance of rfc-large-session-bounded-restore, moving it from draft to partial and linking the acceptance comment on #35875. partial is correct under the README's status table, because the 1.4 CI fixture (test/test_restore_large_session_fixture.py, #35960) is on main and the rest isn't built. Recording the decision in a separate PR, apart from the implementation PR, is how the README says it should be done, so it doesn't break the First Principles gate's rules. chenmingwei23 is not listed in MAINTAINERS.md, but GOVERNANCE.md counts anyone with commit access as a maintainer, and other RFC rows show them merging PRs. A listed maintainer merging this PR also ratifies the decision. The Fast Gate and Source Gates failures don't name a step, and none of the gates should fail on these two markdown files. What remains is wording drift: the audit pointer, the third behaviour change, and the delivery-plan table.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 6c626616c1 · 14 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 13, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the diff. Before this status change can merge I could not find a public record of the acceptance it states, and I would like a link.

The README row and the PR description say the RFC was "approved in review by KiroCrewCaptain" on #35916 and that "the repository owner's lead accepted it as the plan". What I can see is:

  • #35916 merged as a draft RFC with one approval, from KiroCrewCaptain, whose own review comment says a person should decide that PR.
  • The tracking issue #35875 carries the tier:T3 and parked labels, and has no comment from a maintainer or the repository owner accepting the plan.

Other accepted RFCs in the README name where the decision is written, such as a maintainer's sign-off on a pull request or a decision recorded in the document's Open questions. Could you add the link to the owner's acceptance (a comment, a review or a decision record) to the PR description, and name it in the README row and the RFC's Status line in place of the sentence about the owner's lead? If the acceptance has not been given yet, the status should stay draft until it is.

I am not approving until that record is linked.

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping this small. Before this status change can merge, it needs one fix to the decision record.

  1. docs/request-for-change/rfc-large-session-bounded-restore.md:17 and docs/request-for-change/README.md:31 say the RFC was "approved in review by KiroCrewCaptain on #35916; the repository owner's lead accepted it as the plan."
    • Trigger: this merges as written, then #36141 (1.2) and #36259 (1.1) rebase. Their base now carries status: accepted.
    • Outcome: the First Principles lane reads that field from base as the recorded product decision. Two behaviour changes users will see (a large tab opens with only its newest rows, and the sidebar order changes during restore) would pass that check on a record that names no human decider. The approval on #35916 comes from an automation account, and it checked a draft document for accuracy. It did not accept the plan. The "owner's lead" has no name and no link, and #35875 has no comments. GOVERNANCE.md says decisions happen in public on the issue or pull request they belong to. A maintainer asked for this same link in a review on this head.
    • Smallest fix: on the Status line, in the README row and in the PR body, replace that sentence with a link to a named maintainer's public acceptance (a comment, a review or a decisions entry). If no such record exists yet, keep status: draft until a maintainer records the decision.

Optional:

  • Section 5 ("Decisions requested") still lists the 16 MB threshold, the 500-row window and the three behaviour changes as open. Once the decision is recorded, write down which values were accepted.
  • The README row says part 1.4 (#35960) is already merged. The vocabulary calls that partial, not accepted ("Nothing built yet"). Both values clear the same check.
  • implementation-prs leaves out #36259, even though the Status line says 1.1 is approved.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 13, 2026
@chenmingwei23
chenmingwei23 force-pushed the docs/35875-rfc-accepted branch from ec5a40a to 402beb0 Compare November 13, 2026 01:53
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Re: KiroCrewCaptain review: fixed in 402beb0. The Status line and the README row now cite maintainer chenmingwei23's acceptance on #35875 (#35875 (comment)) instead of the earlier sentence. Also done: status is partial, implementation-prs is [35960, 36141, 36259, 36035], and section 5 records the 16 MB threshold, the 500-row window and 1.1 and 1.2 as accepted behaviour changes. The PR body cites the same link.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Re: bolichen97 review: fixed in 402beb0. The link to the acceptance is #35875 (comment). It is named on the RFC Status line, in the README row and in the PR description, in place of the sentence about the owner's lead.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 13, 2026
@chenmingwei23
chenmingwei23 force-pushed the docs/35875-rfc-accepted branch from 402beb0 to 8735a6c Compare November 13, 2026 04:55
@github-actions github-actions Bot added readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention labels Nov 13, 2026
@chenmingwei23
chenmingwei23 force-pushed the docs/35875-rfc-accepted branch from 8735a6c to c77f013 Compare November 13, 2026 06:30
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 13, 2026
@chenmingwei23
chenmingwei23 force-pushed the docs/35875-rfc-accepted branch from c77f013 to f38aec8 Compare November 13, 2026 07:48
@github-actions github-actions Bot added readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention labels Nov 13, 2026
@chenmingwei23
chenmingwei23 force-pushed the docs/35875-rfc-accepted branch from f38aec8 to 6c62661 Compare November 13, 2026 08:19
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 13, 2026
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 13, 2026
@chenmingwei23
chenmingwei23 force-pushed the docs/35875-rfc-accepted branch from 6c62661 to 6baaa44 Compare November 13, 2026 09:39
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 13, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. I read the whole diff.

The acceptance record I asked for is now there. The PR body, the README row, the RFC Status line and section 5 all link the maintainer decision comment on issue 35875. I read that comment: it is written by chenmingwei23 (a repository member), says "Maintainer decision", and accepts this RFC for part B with the four decided points.

  • The front matter moves from draft to partial, which fits the status the README row states: the CI fixture 35960 is merged and the rest is not built. implementation-prs lists 35960, 36141, 36259 and 36035, the same four PRs the decision comment names.
  • Section 5 now records the decided values and keeps the three existing decisions in order. The design text is unchanged, and no code changes.
  • No regex, no new refusal, and all 97 checks are green.

I did not check the new audited-at sha against main.

@bolichen97
bolichen97 enabled auto-merge (squash) November 13, 2026 12:04

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. On head 6baaa44 I read the full diff (two RFC files, +7/-7, no design text changed), checked that the four implementation PRs in implementation-prs match the ones the decision comment on #35875 names, checked that partial is a defined README status, and confirmed PR Readiness is green.

Follow-up on my earlier review:

  1. Decision record: fixed. The Status line, the README row, section 5 and the PR body now link the public decision comment on #35875 in place of the unnamed sentence, and a listed maintainer approved this head after reading it.
  2. Optional, section 5 values: fixed. Section 5 now records the decided threshold, window and behaviour changes.
  3. Optional, partial vs accepted: fixed.
  4. Optional, implementation-prs missing #36259: fixed.

Done well: the decision lands as its own docs-only PR ahead of #36141 and #36259, so their First Principles check reads it from base, as the RFC README asks.

The design is signed off under the standing maintainer sign-off for changes by team members.

Optional:

  • docs/request-for-change/README.md:33 and the Status line say "the rest is not built yet" and that each cold slot fold walks its unit separately. But #36035 (section 1.3, one walk per slot) is already on main, before this PR's merge-base, and the new audited-at 0feaa8b predates it. A follow-up re-audit could say 1.4 and 1.3 are on main and bump last-audited.
  • Section 5 item 1 credits the 500-row window to the decision comment, which names only the 16 MB threshold and accepts the document as a whole. Saying the window follows from section 1.1 would match the source.
  • Section 5 item 2 accepts "1.1 and 1.2" but does not name section 3 item 3 (the new open_slots.json focused and visible keys that #36141 needs).

@bolichen97
bolichen97 merged commit 4eaacd5 into main Nov 13, 2026
101 of 103 checks passed
@bolichen97
bolichen97 deleted the docs/35875-rfc-accepted branch November 13, 2026 14:22
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants