Skip to content

fix: name the dashboard control for the refused app verb - #36345

Merged
bolichen97 merged 1 commit into
mainfrom
fix/smoke3-c3
Nov 13, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/smoke3-c3

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: When a running gateway refuses kirocrew app update or kirocrew app uninstall, the CLI names the dashboard control for that verb instead of telling the operator to toggle the app.

Adoption smoke 3 for #26967: with a gateway running, kirocrew app update not-an-app printed ❌ gateway refused: app 'not-an-app' not installed. Toggle the app in the dashboard instead. Toggling an app does not update it. The same hint followed every refused uninstall.

Why it matters

The built-in app campaign moves apps out of core, so kirocrew app update is now a common way to apply an app's fix release. An operator whose update is refused is sent to a control that cannot do what they asked, and the dashboard's Update (or Sync) button, which carries the trust-the-repository consent the CLI has no flag for, goes unmentioned.

Not a goal

  • Changing what the gateway refuses or the reason text it sends.
  • A per-reason remedy (for example "not installed"): the hint stays one line per verb.
  • The install hint, which already has its own wording.

What changed (motivation → approach → change)

Symptom: a refused app update or app uninstall told the operator to toggle the app. Cause: _run_app_action_through_gateway, shared by enable, disable, update and uninstall, passed one fixed hint. Change: the hint is looked up per verb in _DASHBOARD_REMEDY_BY_ACTION. Enable and disable keep the toggle wording. Update names Update (or Sync) on the app's page, the wording the native-Windows refusal of the same verb already uses. Uninstall names Uninstall on that page. The cli spec row for kirocrew app now states this, and src/kiro_crew/cli_commands.py lists the new name in its type-checking imports of the facade's served names.

Backwards compatibility

Compatible: only the hint after a gateway refusal changes for update and uninstall. Exit codes, the refusal reason and the enable and disable text are unchanged.

Removes nothing: no path, key, record or function is taken away; one stderr sentence is reworded for two verbs.

Tests

  • test_cli_app_update.py::TestCliUpdate::test_a_refusal_names_the_update_control_not_the_toggle: a refused update names Update (or Sync) and never says Toggle.
  • test_apps_uninstall_backend_stop.py::TestCliUninstallDelegatesToTheGateway::test_a_refusal_names_the_uninstall_control_not_the_toggle: a refused uninstall names Uninstall, never says Toggle, and runs no file-only uninstall.
  • The existing test_gateway_mint_error_exits_with_dashboard_hint still pins the toggle wording for disable.

Proof: PROVEN test/test_apps_uninstall_backend_stop.py::TestCliUninstallDelegatesToTheGateway::test_a_refusal_names_the_uninstall_control_not_the_toggle, test/test_cli_app_update.py::TestCliUpdate::test_a_refusal_names_the_update_control_not_the_toggle (head 144e223)

Determinism: both new tests passed 10 repeats in a row, and passed again run in reverse order ahead of test_cli_commands_coverage.py. They fake the gateway call and read only captured stderr: no clock, port, sleep or ordering.

Manual verification

N/A: unit coverage sufficient. The change is one stderr string per verb, and the tests drive the real _handle_app path down to the faked gateway call.

Related Issues

Part of #26967

Sibling sweep

Swept: git grep -n "dashboard instead|hint=" -- src/kiro_crew/cli_commands*.py
Sibling: src/kiro_crew/cli_commands_app.py:170 -- not affected -- install has its own hint, and the file-only uninstall warning at :352 already names uninstall from the dashboard

Pattern harvest

Not generalizable: one shared helper carried one fixed remedy string for four verbs; the fix makes the string a per-verb table at that single call site.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 13, 2026 03:10
@bolichen97
bolichen97 enabled auto-merge (squash) November 13, 2026 03:10
When a running gateway refused `kirocrew app update` or `kirocrew app
uninstall`, the CLI told the operator to toggle the app in the
dashboard, a remedy that fits only enable and disable. Each gateway
verb now names its own dashboard control: the toggle for enable and
disable, Update (or Sync) on the app's page for update, and Uninstall
there for uninstall.

Part of #26967
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased onto main (5f92090 → b7a4e1e) to pick up the red-main fix #36290.

  • Backend Tests (3.12, 8), Backend Tests (Windows) (8) and Coverage Gate on ab62747 were one failure, test/test_reply_format_once.py::TestEveryMessageWhereTheBlockCannotBeTakenOut::test_the_table_names_every_selectable_harness ('mimocode' missing from COMPACTION_SEEN). This PR does not touch that file; fix(test): add mimocode to the compaction table every selectable harness needs #36290 fixed it on main after this head's CI base.
  • The Design, First Principles, UX, GPT, Opus, Dependency License Gate, CodeQL Analyze (actions) and Publish readiness signal reds on ab62747 all failed closed on API rate limit exceeded for installation before reviewing anything, so they posted no findings to answer. The new head 144e223 re-runs them.

@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 144e223711bc387906f32d8109675f6c9f149c7f touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 144e223711bc387906f32d8109675f6c9f149c7f — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. The table has four keys, and each key matches one of the four verbs that call the shared helper.

What this change ships

Inventory (3 items) — 3 justified

Intent: when the gateway refuses app update or app uninstall, the operator is pointed to the dashboard control that actually does that verb. This is a FIX.

  1. A refused kirocrew app update now names Update (or Sync) on the app's page instead of the toggle — justified
  2. A refused kirocrew app uninstall now names Uninstall on the app's page instead of the toggle — justified
  3. The new name is added to the facade's TYPE_CHECKING import list, and the cli spec row describes the per-verb hint — justified

[FIRST-PRINCIPLES-REVIEWED] 144e223

Description read

[DESCRIPTION-READ] ac16ecb17a21005dc7ad6e12cd2c4c279bb7ab324aedb6f0e631f6fde3bf7da5

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 144e223711bc387906f32d8109675f6c9f149c7f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the fix sits at the one shared call site, and the gateway is only called with the four verbs the table covers.

[DESIGN-REVIEWED] 144e223

Description read

[DESCRIPTION-READ] 95aaee148e94ac75c30b6710585b69de127e804830eb10404493a13a5185c542

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 144e223711bc387906f32d8109675f6c9f149c7f — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 144e223

Verdict parsed from the review's SHA-scoped output markers for commit 144e223711bc387906f32d8109675f6c9f149c7f.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 144e223711bc387906f32d8109675f6c9f149c7f false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 144e223711bc387906f32d8109675f6c9f149c7f and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 144e223

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 144e223711bc387906f32d8109675f6c9f149c7f false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 13, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Head 144e223 is green: PR Readiness passed, every lane PASS / no findings (GPT, Opus, Design, First Principles, UX), CI green, auto-merge armed.

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (5 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: a refused app lifecycle verb names the dashboard control for that verb, with tests. Spec files changed as a ride-along (a minority of the diff on both file count and changed lines), not reviewed as a design decision: docs/system-specs/modules/cli.md.

@bolichen97
bolichen97 merged commit debf9f5 into main Nov 13, 2026
209 of 222 checks passed
@bolichen97
bolichen97 deleted the fix/smoke3-c3 branch November 13, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants