Repository navigation
Conversation
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS This is a draft RFC and changes no code, so nothing here blocks it. It reuses the existing [DESIGN-REVIEWED] d59f4bd Description read[DESCRIPTION-READ] 3e91e6159baa26dde58f9d79ec376930b56fd5fa7a81700e5e79fb283234529c That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
bolichen97
left a comment
There was a problem hiding this comment.
Direction signed by maintainer (bolichen97) for phases 1-3 only: a Normal / Reads start mode for the owner's plain dashboard chats. Phase 4 (Trust) is not signed here.
I read the full diff at 2cde0fd. My answers to section 7:
- Yes. A
normal/trust_readsdefault inconfig.json, applied throughseed_slot_approvalat the owner's plainPOST /api/chat/slots, is acceptable as phases 2-3. It reuses the seeder the crewmate and Slack code-channel defaults already use. The ceiling clamps it, it leaves a YOLO grant and an existing posture alone, and it records its own SEL caller. The store sits in_CREW_READONLY_LEAVES, so an agent cannot set its owner's next start mode. The default staysnormal, so nothing changes until the owner opts in. A bad, missing or unreadable value reads asnormal, and a failed seed never fails the create. Every other creation path in the 3.2 table keeps how it starts today. - Trust (phase 4) is left open for a separate decision. Please don't add it to the key in phases 2-3.
- Once. The proposed one-time composer line when the ceiling clamps a Reads default is right.
For phase 2, please keep apply_approval_mode out of the create path exactly as 3.3 says, and pin with a test that a declared YOLO grant survives opening a new chat with the default set to Reads.
Not checked: "Dependency License Gate" is red on this head. This is a docs-only change, and I did not read that log.
Code change approver recommendation: A person should decideWhy: the decider raised 2 possible problems and estimates a 55% chance that this change introduces a defect; a person should check them. I'm requesting changes on this docs-only RFC: the boundary it draws around who gets the stored start mode doesn't match the gate it names. The default is meant to apply only to the machine owner's plain dashboard chats, and the RFC's table says a Shared Crew teammate's chat stays on Normal. But the gate it names, Things to check (possible problems the decider raised; at this confidence many turn out to be fine):
Tier: 2, held for a person: design-doc-gate: D. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
The design for phases 1 to 3 is signed off by a maintainer in the review on this head, so this PR now waits for a maintainer approval. Review result: nothing blocks. The diff is docs only. It adds the new RFC and one row in the request-for-change index, and changes no code. The review checked the RFC's code references against the commit it names and against current main, and they hold. These include the slot's Normal start state, the clamp in Optional:
|
|
Hello maintainers: this RFC PR is ready for review. At 2cde0fd readiness passes and auto-merge is armed; the only red lane is the Dependency License Gate, which this docs-only change does not touch. It proposes the Trust step for #6812, and its open questions are listed in the RFC itself. Thank you for taking a look. |
2cde0fd to
4ce43d1
Compare
4ce43d1 to
699eb20
Compare
Every plain dashboard chat starts on Normal, and people who work at Reads or Trust re-pick it each time (#6812, 8 reactions, three duplicates). The maintainer asked for a request-for-change. Propose an owner setting, Normal or Reads, stored in the sealed config.json and seeded through seed_slot_approval, the seeder the crewmate and Slack code-channel start modes already use, only for a plain chat the owner opens from the dashboard. The approval_modes ceiling clamps it and a YOLO grant is left alone. Crewmate chats, channels, cron, subagents, apps and agent-created sessions keep how they start; Trust is left to a maintainer decision. Part of #6812
699eb20 to
d59f4bd
Compare
Problem / Motivation
Goal: Record a proposal, for a maintainer to accept or change, that lets the owner choose the approval mode a new dashboard chat starts on.
Every plain dashboard chat starts on Normal. A person who works at Reads or Trust re-picks the mode in the composer for each new chat, and again after a restart. #6812 has 8 reactions and three duplicates; the one implementation attempt (#8984, closed) stalled on whether Trust may be a stored default, and the maintainer asked for a request-for-change on 2026-11-05.
Why it matters
Without a recorded decision, every implementation of #6812 re-opens the same question (which modes, which chats, which store), and nothing ships. An accepted RFC lets phases 2-3 land as small, reviewable PRs.
Not a goal
What changed (motivation → approach → change)
docs/request-for-change/rfc-default-approval-mode.md(statusdraft) and its row indocs/request-for-change/README.md.config.json(a sealed, read-only leaf inside the sandbox, so the agent cannot pick the owner’s next start mode). It is applied only to a plain chat the owner opens from the dashboard, throughseed_slot_approvalwith callerchat_default_mode, the seeder the crewmate Profile and Slack code-channel start modes already use. The seeder clamps to theapproval_modesceiling, never ends a declared YOLO grant and never replaces a posture the slot already holds;apply_approval_modeis rejected because a Reads or Trust press through it ends a YOLO grant.0feaa8be90. Section 4 splits the work into phases that each ship alone. Section 7 lists the three questions for the maintainer.Backwards compatibility
Compatible: docs only; no code, key or behaviour changes.
Removes nothing: the diff adds one RFC file and one index row.
Tests
Proof: not provable -- docs or config only
scripts/docs-lint.shpasses.Manual verification
N/A — docs only; every code reference in the RFC was re-read at
0feaa8be90.Real-machine verification
N/A -- the diff adds one RFC document and one RFC index row; nothing in it runs.
Related Issues
Part of #6812
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project’s Apache-2.0 license.