Repository navigation
fix: name the approval field and cli command in the auto refusal - #36420
Conversation
The cron tools refuse approval_mode='auto' and send the user to the Schedule page, but did not say which control to use, so a user could not find it. The refusal and the reset note now name the job editor's Approval field (Auto-approve) and the equivalent 'kirocrew cron update <id> --approval-mode auto', and the refusal says a later behaviour edit turns it off again.
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the only change is the wording of two agent-facing replies, and both routes they name exist ( Notes
[DESIGN-REVIEWED] ea1d7d0 Description read[DESCRIPTION-READ] cf1c58364d1db6cbbebb3657069fa426d54263a723783778ee276691f5ef3f48 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The change is three reply strings and one doc sentence, all aimed at the control the reporter of #36334 could not find. What this change shipsInventory (4 items) — 4 justifiedIntent: when a cron tool refuses auto-approve, the owner learns exactly which control turns it on. FIX.
[FIRST-PRINCIPLES-REVIEWED] ea1d7d0 Description read[DESCRIPTION-READ] 38896708b18336711db16b244249fc725ce353b323878ff99fa8e3ae1909fe36 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (3 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: the refusal text for approval_mode auto names the Schedule field and CLI command; gate logic unchanged, with tests.
bolichen97
left a comment
There was a problem hiding this comment.
Approving. I read the whole diff, tests included.
- This only changes wording. The
cron_addandcron_updaterefusal forapproval_mode="auto"fires on the same condition as on main, and no new condition is added. The text now names the Approval field on the Schedule page and thekirocrew cron update <job-id> --approval-mode autocommand. - The reset note after a tool edit now fills in the job id with
.format(job_id=updated.id)._AUTO_APPROVAL_RESET_NOTEhas one caller on main, and it is the one this PR updates. The note has one placeholder and no other braces. - The docs paragraph matches the new messages. The tests check the refusal text and the reset note with the real job id.
- No regex, no new refusal, and all 96 checks are green.
I did not run the tests locally.
Problem / Motivation
Goal: When an agent's cron tool refuses auto-approve, the user is told exactly which control turns it on, on the Schedule page or from the CLI.
cron_add/cron_updaterefuseapproval_mode='auto'and tell the agent to "ask the user to turn on auto-approve for this job on the Schedule page". The reporter could not find the control and fell back tokirocrew cron update <id> --approval-mode auto, which worked.Why it matters
Every owner whose agent creates a cron that needs auto-approve hits this refusal. If the message names a page but not the control, the owner is stuck unless they already know the CLI flag, and the job keeps stopping on approvals.
Not a goal
website/src/components/JobForm.tsx, vertical layout, label "Approval", options Default / Auto-approve).What changed (motivation → approach → change)
Symptom: the refusal points at a page, not a control. Cause:
_AUTO_APPROVAL_OWNER_ONLYand_AUTO_APPROVAL_RESET_NOTEinsrc/kiro_crew/mcp_cron.pysay "on the Schedule page" and stop there. Change:kirocrew cron update <job-id> --approval-mode auto. It also says that a later tool edit to the message, agent, model, schedule, channel or thread turns auto-approve off again (_AUTO_RESETTING_FIELDS).cron_updateadds when that reset happens gives the same two routes, with the job's real id in the CLI command.src/kiro_crew/docs/cron-and-scheduling.mdnames the field and the CLI route.Backwards compatibility
Compatible: only the text of two tool replies changes. The refusal still starts with the same
Error: approval_mode 'auto' can only be turned on by the ownerprefix, and the reset note still containsAuto-approve was turned off.Removes nothing: no path, field, record or validator is taken away; two strings get longer.
Tests
test_the_refusal_names_the_owner_s_controls: the refusal names the Approval field, the CLI command and the reset rule.test_a_behaviour_edit_turns_auto_off[*]: the reset note now carrieskirocrew cron update <that job's id> --approval-mode auto.Proof: PROVEN test/test_cron_auto_approval_owner_only.py::test_the_refusal_names_the_owner_s_controls, test/test_cron_auto_approval_owner_only.py::test_a_behaviour_edit_turns_auto_off[message] (head ea1d7d0)
Manual verification
N/A: unit coverage is enough for a change to tool reply text. The CLI flag it names (
cron update --approval-mode {auto,default}) is defined insrc/kiro_crew/cli_parser_agent.py.Related Issues
Closes #36334
Sibling sweep
Swept: git grep -n "Schedule page" -- src/kiro_crew/mcp_cron.py src/kiro_crew/mcp_cron_tool_list.py
Sibling: src/kiro_crew/mcp_cron.py -- changed here
Sibling: src/kiro_crew/mcp_cron_tool_list.py -- not affected -- the schema text only says auto is refused and owner-only; the refusal carries the instructions
Pattern harvest
Not generalizable: one tool reply was missing the directions to its control. Nothing else repeats the defect.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.