Skip to content

fix(kas-login): say a company sso form error in the user's language - #36451

Merged
bolichen97 merged 1 commit into
mainfrom
fix/32061-sso-hint-i18n
Nov 20, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/32061-sso-hint-i18n

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The company SSO form says why a start URL or Region was refused in the user's own language, without AWS's raw answer.

In the dashboard's company SSO form (Settings > Kiro account > Continue with company SSO), #33747 made the headline name the field to fix. Under that headline two things are still wrong. The detail is the gateway's English sentence even when the UI is translated: a German user reads "Prüfe die Anmelde-URL deiner Firma." and then "That does not look like a web address. …". And after an AWS refusal the detail ends with AWS's raw answer, (AWS: Invalid request).

Why it matters

Company SSO is how organisations sign in, and a typo in the start URL or Region is the usual first-run mistake. A user with a translated UI gets the one sentence that says what to fix in English, followed by an AWS error token that means nothing to them, so they guess or take it for an outage.

Not a goal

  • Changing the gateway's own English error texts in cloud/login_target.py and auth/service.py (fix: say what is wrong with a start URL in plain words #35577 rewrites those). kirocrew kas login, the cloud wizard and the audit log keep the text they print today.
  • Changing any HTTP status or code.
  • Translating begin errors other than the Region and start-URL refusals: auth_service_unreachable, for example, keeps its "Check your connection" headline and the gateway's detail.

What changed (motivation → approach → change)

The sentence under the headline now comes from the dashboard's catalog, so it is in the user's language and never ends with AWS's raw answer.

Refusal (code / reason) Under the headline before (English in every language) After, English (translated in every locale)
invalid_start_url / characters, not_a_url, not_https, credentials, port, hostname the gateway's sentence, e.g. That does not look like a web address. … the same plain sentence, in the UI's language
invalid_start_url / aws_rejected AWS did not accept the start URL '…'. … (AWS: Invalid start url provided) AWS did not accept this URL. …
start_url_or_region_rejected AWS found no Identity Center for '…' in region us-east-1. … (AWS: Invalid request) AWS found no Identity Center for this URL in this Region. Check the URL for a typo; …
invalid_region Not a valid AWS region name. the same, in the UI's language

The form showed the gateway's error string as it came. The gateway named only the field (code), never the rule the URL broke, so the form had nothing to pick a translated sentence from. Now LoginTargetError (cloud/login_target.py) carries a reason at each reachable start-URL check, InvalidStartUrlError (auth/service.py) passes it on, and the begin-device 400 (dashboard/handlers/kas_login.py) answers it as a reason field, aws_rejected when AWS itself refuses the URL. useKasLoginFlow (hooks/useKasLogin.ts) hands the begin's error to KasLoginGate.tsx, which picks the catalog sentence from code and reason. A reason it has no sentence for keeps the gateway's text, and the error report still goes with the alert, so "Ask the agent" hands off the status and code.

The catalog sentences (website/src/i18n/locales/) say each rule in the plain words #35577 gave the gateway's English texts, and call the field "the URL". The kas-auth and cloud specs say the same.

Backwards compatibility

Compatible: the 400 answer only gains an optional reason field; error, HTTP status and code are unchanged (curl evidence below), and reason is a keyword-only argument with a default on both exception types.

Removes nothing: the diff adds a field and catalog keys, and renames or removes no path, key, record or function.

Tests

  • test/test_cloud_login_target.py::test_a_refusal_names_the_rule_it_broke: each start-URL check names its rule, and an empty URL names none.
  • test/test_kas_login_service.py and test/test_kas_login_api.py: the service's refusal carries the reason, and the 400 answers it (not_https, aws_rejected) with status and code unchanged.
  • website/src/components/KasLoginGate.test.tsx: one row per code and reason shows the catalog sentence, no (AWS: text and only the named fields aria-invalid; an unknown reason keeps the gateway's text; the card's hand-off of a translated refusal still carries 400 and invalid_start_url; in German, an aws_rejected refusal and a bad Region show the German sentences and no (AWS: text.

Proof: PROVEN test/test_kas_login_api.py::test_begin_device_bad_start_url_is_a_coded_400_with_the_reason[malformed-not_https], test/test_kas_login_api.py::test_begin_device_bad_start_url_is_a_coded_400_with_the_reason[refused-by-aws-aws_rejected], test/test_kas_login_service.py::test_begin_idc_refuses_an_unusable_start_url_before_calling_aws[http://acme.awsapps.com/start-not_https], test/test_kas_login_service.py::test_begin_idc_refuses_an_unusable_start_url_before_calling_aws[https://acme.awsapps.com/start?x=1-characters], test/test_kas_login_service.py::test_begin_idc_refuses_an_unusable_start_url_before_calling_aws[https://acme.awsapps.com:abc/start-not_a_url] (head 0cd15f36fb5b)

That head is the verification host's commit of this PR's tree (5267934be1).

prove.py runs Python only; the frontend half was checked by reverting the alert's message to beginError, which fails 11 KasLoginGate cases (every catalog row and both German cases).

Determinism: npx vitest run src/components/KasLoginGate.test.tsx --sequence.shuffle passed 3 of 3 runs (59 tests each). The changed backend tests (-k 'reason or rule or start_url', 23 tests) passed 3 of 3 runs with -n0 (no repeat or shuffle plugin is installed). test/test_flake_pattern_ratchet.py passes.

Manual verification

Run on Linux (Ubuntu 24.04.5) against an isolated gateway (a fresh KIROCREW_HOME, agent.acp_backend kas, a loopback port), driven with scripted Playwright in Chromium on Settings > Kiro account. The AWS case really calls SSO-OIDC StartDeviceAuthorization in us-east-1.

Before (main at 5c9bf25f3e), German UI:

not-a-url    Prüfe die Anmelde-URL deiner Firma. That does not look like a web address. Use your company's AWS access portal URL, ...
aws-refused  Prüfe die Anmelde-URL deiner Firma und die AWS-Region. AWS found no Identity Center for '...' in region us-east-1. ... (AWS: Invalid request)
bad-region   Prüfe die AWS-Region. Ein Regionsname sieht so aus: us-east-1. Not a valid AWS region name.

After, German UI:

not-a-url    Prüfe die Anmelde-URL deiner Firma. Das sieht nicht nach einer Webadresse aus. Verwende die URL des AWS-Zugangsportals deiner Firma. Sie sieht so aus: https://your-company.awsapps.com/start.
aws-refused  Prüfe die Anmelde-URL deiner Firma und die AWS-Region. AWS hat für diese URL in dieser Region kein Identity Center gefunden. Prüfe die URL auf Tippfehler; wenn sie stimmt, stelle als Region die Region ein, in der das Identity Center deiner Firma liegt.
bad-region   Prüfe die AWS-Region. Ein Regionsname sieht so aus: us-east-1. Das ist kein gültiger AWS-Regionsname.

After, English UI:

not-a-url    Check the company sign-in URL. That does not look like a web address. Use your company's AWS access portal URL, which looks like https://your-company.awsapps.com/start.
aws-refused  Check the company sign-in URL and the AWS Region. AWS found no Identity Center for this URL in this Region. Check the URL for a typo; if it is right, set Region to the Region your company's Identity Center is in.
bad-region   Check the AWS Region. A Region name looks like us-east-1. Not a valid AWS region name.

In both languages, before and after, the named inputs carry aria-invalid="true" and aria-describedby="kas-sso-begin-error", and the other input carries neither. The gateway's begin-device answer keeps error, status and code, and adds reason where one applies:

{"error": "That does not look like a web address. Use your company's AWS access portal URL, ...", "code": "invalid_start_url", "reason": "hostname"} [HTTP 400]
{"error": "AWS found no Identity Center for '...' in region us-east-1. ... (AWS: Invalid request)", "code": "start_url_or_region_rejected"} [HTTP 400]
{"error": "Not a valid AWS region name.", "code": "invalid_region"} [HTTP 400]

Happy path: a well-formed https://my-company.awsapps.com/start with us-east-1 raises no form-side error and reaches AWS (which refuses it, since that portal does not exist, and the form shows the catalog sentence); "Continue with AWS Builder ID" starts a device sign-in (HTTP 200, a device code on the page) with no begin error, then was cancelled.

Real-machine verification

Machine: EC2 m7i.2xlarge, Ubuntu 24.04.5 LTS x86_64, 8 vCPU / 31 GiB
Before (main 5c9bf25): node capture.mjs (scripted Playwright on Settings > Kiro account, company SSO, German UI, against an isolated gateway) -> Prüfe die Anmelde-URL deiner Firma und die AWS-Region. AWS found no Identity Center for '...' in region us-east-1. ... (AWS: Invalid request)
After (this PR's patch on main 5c9bf25, tree 71859ba0e3): the same command -> Prüfe die Anmelde-URL deiner Firma und die AWS-Region. AWS hat für diese URL in dieser Region kein Identity Center gefunden. ..., and no (AWS: in any of the six German and English frames
Cleanup: both gateways stopped by their own pid and their temporary homes removed; the instance is a disposable verification host with no inbound rules, terminated when idle

Screenshots / video

Light theme, the whole Settings > Kiro account page, signed out, with the sign-in choices in its card: the German UI before and after, and the English UI after.

Before, German (English detail and (AWS: Invalid request)):
before, German, AWS refusal

After, German:
after, German, AWS refusal

More states

before, German, not a URL
before, German, bad Region
after, German, not a URL
after, German, bad Region
after, English, AWS refusal
after, English, not a URL
after, English, bad Region

Related Issues

Fixes #32061

Follows #33747 (the headline that names the field). #35577 rewrote the gateway's own start-URL texts in plain words; this PR leaves them as they are.

Sibling sweep

Swept: git grep -nE "beginError|message={.*[Ee]rror" -- website/src/components/KasLoginGate.tsx website/src/components/KiroPrerequisiteGate.tsx website/src/pages/developer/KiroSignInCard.tsx website/src/hooks/useKasLogin.ts
Sibling: website/src/components/KasLoginGate.tsx -- changed here
Sibling: website/src/hooks/useKasLogin.ts -- changed here
Sibling: website/src/pages/developer/KiroSignInCard.tsx -- not affected -- it embeds KasLoginEmbedded, which renders the same Chooser alert changed here
Sibling: website/src/components/KiroPrerequisiteGate.tsx -- not affected -- it wraps KasLoginGate, which renders the same Chooser alert changed here

Pattern harvest

Not generalizable: the gateway already returned a machine-readable code for refusals the user can fix; one form showed the developer-facing error text where it should have keyed its catalog off that code, and a rule matching "render error as it came" would flag the deliberate raw detail of errors the user cannot fix.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 51b3e266e60037e50a7d5cf78e255aa76638a54c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the 400 response only gains an optional reason field, unknown reasons fall back to the gateway's text, and screenshots of this revision are attached.

Notes

  • The ?/# query branch in normalize_start_url still carries no reason. The characters check catches it first, so the form never sees it today. If that check order changes, the user gets the gateway's English text again, not a wrong sentence.

[DESIGN-REVIEWED] 51b3e26

Description read

[DESCRIPTION-READ] 644fde10600926d5b9b5a090f9addf5ed7b95c038745117fd47d21ef2de3cb28

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 51b3e266e60037e50a7d5cf78e255aa76638a54c — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. The new reason field is read by the SSO form, and the form's text now comes from the catalog, so the English text and AWS's raw answer are no longer shown.

What this change ships

Inventory (6 items) — 6 justified

Intent: a company SSO user with a translated UI reads why the start URL or Region was refused in their own language, without AWS's raw error token. This is a FIX.

  1. The sentence under the SSO form's headline now comes from the catalog in the UI's language, for the start-URL rules, the Region refusal and AWS's refusal — justified
  2. After an AWS refusal the form no longer ends with (AWS: …) — justified
  3. The begin-device 400 answer gains an optional reason field (characters, not_a_url, not_https, credentials, port, hostname, aws_rejected) — justified
  4. LoginTargetError and InvalidStartUrlError take a keyword-only reason — justified
  5. "Ask the agent" from the refusal alert still hands off the gateway's status and code under the translated message — justified
  6. The kas-auth and cloud specs describe reason and the catalog wording — justified

[FIRST-PRINCIPLES-REVIEWED] 51b3e26

Description read

[DESCRIPTION-READ] bf7f7b3011f75c88d7aa35c19369b425198107092ac41a8e1eeb0662bcae722c

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 51b3e266e60037e50a7d5cf78e255aa76638a54c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: this PR only changes error copy, and the before/after screenshots in German and English (shots 1–9) show it.

Notes

  • sso_region_not_a_name ("Not a valid AWS region name.") only repeats the headline above it, "Check the AWS Region. A Region name looks like us-east-1." The blind reader said it "says the same thing twice" (shots 4, 6, 9). Have the catalog return nothing for invalid_region so only the headline shows, or write something the headline doesn't already say.
  • The same string writes "region" in lowercase, while its sibling strings use "Region". The reader asked whether these "are the same thing". Change it to "Region".

[UX-REVIEWED] 51b3e26

Description read

[DESCRIPTION-READ] 38a221294238dc59f380b17f25a3611482fcb65aea20f812a3f49a987cae43c0

That sha256 names everything this verdict read: the PR description, plus the 12 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 51b3e266e60037e50a7d5cf78e255aa76638a54c — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 51b3e26

Verdict parsed from the review's SHA-scoped output markers for commit 51b3e266e60037e50a7d5cf78e255aa76638a54c.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 51b3e266e60037e50a7d5cf78e255aa76638a54c false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 51b3e266e60037e50a7d5cf78e255aa76638a54c and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 51b3e26

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 51b3e266e60037e50a7d5cf78e255aa76638a54c false-positive: <reason, 20 to 500 characters>

@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] CI on 0a0744db04 is red in two places; neither is a test this PR changes.

@KiroCrewCaptain

KiroCrewCaptain commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 10% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

The change adds an optional reason to the begin-device 400 response, taken from LoginTargetError through InvalidStartUrlError, plus aws_rejected when AWS refuses the URL. The SSO form maps code and reason to a catalog sentence and falls back to the gateway's text for any reason it doesn't know. Status, code and error are unchanged, and the CLI and audit text are untouched. The region and start_url_or_region_rejected mappings are correct because the gateway's text for those is fixed. All 13 hand-maintained locale files gain the same keys. Passing the error report changes nothing for other errors. Tests cover each rule's reason, the API response, the service and the form, including German and the unknown-reason fallback. Nothing blocks.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit c9eb67e993 · 396 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 13, 2026
@bolichen97
bolichen97 force-pushed the fix/32061-sso-hint-i18n branch from 0a0744d to c9eb67e Compare November 13, 2026 12:08
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/components/KasLoginGate.tsx, KasLoginGate.test.tsx, auth/service.py, cloud/login_target.py, test/test_kas_login_service.py, docs/system-specs/modules/kas-auth.md, cloud.md and the website/src/i18n/locales/*.json catalogs since this head went green (2f7e9f2 -> 98046f8); CI re-running.

The red on 0a0744db04 came from main: Backend Lint & Type Check was main's mypy error, fixed on main by #36457, and the frontend lint and both builds failed on a duplicate reportForError import, because main added the same import to KasLoginGate.tsx. The rebase drops this PR's copy of that line; the rest of the patch is unchanged.
[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] Status on c9eb67e993: every build, lint, type-check and test lane is green (97 checks, 0 running). The 10 red ones all failed for the same reason, and none of them judged this code:

  • Analyze (actions), Dependency License Gate, PR Policy (Screenshot Evidence) and Publish readiness signal hit the repository's hourly Actions API limit while this head was being checked (API rate limit exceeded for installation, core rate limit -- 0/15000 remaining). The License Gate log says it itself: "This is not a license finding; re-run this job once the API recovers." PR Policy's log says the same: "This is a read failure, not missing evidence."
  • Design Review, First Principles Review and UX Review could not fetch the diff, so each printed "did not produce a verdict ... NOT blocking".
  • GPT 6.1 Review could not read this PR's comments after six attempts and withheld its verdict; Opus 5.5 Review was skipped and failed closed.

The description's nine screenshots are intact: each attachment URL answers 200 with PNG bytes.

So nothing here is a code defect and no push is warranted. These lanes need a re-run, which I am holding until the repository's Actions queue drops — 22 branches are running CI right now, and re-running 8 workflows into that is what exhausted the API limit in the first place. Auto-merge stays armed; the remaining gate is a maintainer approval.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 16, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/components/KasLoginGate.tsx, KasLoginGate.test.tsx, hooks/useKasLogin.ts, dashboard/handlers/kas_login.py, auth/service.py, cloud/login_target.py, test/test_cloud_login_target.py, test/test_kas_login_service.py, docs/system-specs/modules/kas-auth.md, cloud.md and the website/src/i18n/locales/*.json catalogs since this head went green (98046f8 -> e65debd); CI re-running.

GitHub reported this PR as conflicting in three files. #35577 rewrote each start-URL refusal's English text in cloud/login_target.py in plain words: the rebase keeps main's text and adds this PR's reason to the same lines, and kas-auth.md says both. #38803 moved the sign-in flow's state into useKasLoginFlow: KasLoginGate.tsx keeps this PR's two helpers and props next to main's bare prop, and the hook returns one more field, the device begin's error, which the form reads the reason and the report from. The later #39247 (no caption under the Builder ID and company SSO buttons) and #39206 (relay Crews closed on sign-in and sign-out) change none of this PR's lines. The same patch was then re-applied unchanged on main e65debd while the push waited for a CI slot. With the patch on main 910f01f, on Linux (Ubuntu 24.04): the static gates, mypy src/kiro_crew, tsc, i18n:check and eslint pass; the 16 related backend test files (697 passed) and the 5 related frontend test files (155 passed) pass; and the change-scoped scripts/local-gate.py passes on both surfaces except two tests that fail the same way on the clean main (test_find_ui_auto.py::test_the_generated_auto_tier_answers_labels_only_it_carries[continue with github-…] and test_host_git_repo_exec_neutralization.py::TestCliUpdate::test_up_to_date_diff_runs_no_textconv_planted_during_the_fetch). The repository's semgrep rules report nothing on the diff. The description's screenshots and manual verification are re-taken from this head on a real isolated gateway, because #39247 changed what the sign-in card shows.
[operator: bolichen97]

@bolichen97
bolichen97 force-pushed the fix/32061-sso-hint-i18n branch from c9eb67e to d380383 Compare November 19, 2026 12:19
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 19, 2026
@bolichen97

bolichen97 commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/kas-auth.md and the website/src/i18n/locales/*.json catalogs since this head was pushed (e65debd -> 8c917a5); CI re-running.

The previous head's CI had two reds, and neither comes from this PR's change, so there was no code to fix; this push re-runs both. E2E (stub ACP backend, offline) failed before any test ran: the runner could not install lsof because the Ubuntu package mirror answered 503 Service Unavailable on all three attempts (the same job passes on main). Backend Tests (3.12, 7) failed one test, test_source_link_github_case.py::TestOneChipPerObject::test_case_variants_collapse_to_one_chip, a known flaky test about session-card source links tracked in #39460 (fix open in #39470); Coverage Gate failed only because that shard did. #39349 (the shorter expired Kiro sign-in copy) changed other keys in the same catalogs and a different section of kas-auth.md, so the patch re-applies unchanged: no duplicate keys, and every components.kasLogin key the form reads is still there. On the rebased commit, on Linux: black, isort and flake8 on the changed Python files, the repository's change-scoped static checks, i18n:check, gen:ui -- --check, the docs lint and the semgrep rules on the diff all pass; the backend and frontend test suites run in CI.
[operator: bolichen97]

@bolichen97
bolichen97 force-pushed the fix/32061-sso-hint-i18n branch from d380383 to a356be3 Compare November 19, 2026 13:01
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 19, 2026
The company SSO form showed the gateway's English sentence under a
translated headline, and after an AWS refusal that sentence ended with
AWS's raw answer, "(AWS: Invalid request)".

The gateway now names the start-URL rule a refusal broke in a `reason`
field of the begin-device 400 (`characters`, `not_a_url`, `not_https`,
`credentials`, `port`, `hostname`, carried from LoginTargetError, and
`aws_rejected` for AWS's own refusal). The form says each refusal it
can fix from its catalog instead, in plain words that call the field
"the URL": the Region error, the refusal that names neither field, and
every start-URL rule. A reason the form has no sentence for keeps the
gateway's text. The error text, status and code are unchanged, so
`kirocrew kas login` and the audit log still carry AWS's answer, and
the agent hand-off keeps the error's report.

Fixes #32061
@bolichen97
bolichen97 force-pushed the fix/32061-sso-hint-i18n branch from a356be3 to 51b3e26 Compare November 19, 2026 20:09
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/cloud.md, docs/system-specs/modules/kas-auth.md and the website/src/i18n/locales/*.json catalogs since this head was pushed (8c917a5 -> be1ce64); CI re-running.

The new base carries #39470, the fix for the one test red on the previous head (Backend Tests (3.12, 7): test_source_link_github_case, tracked in #39460; Coverage Gate failed only because that shard did). The change itself is unchanged: the rebased commit carries the same patch.

The screenshots in the description are re-taken on the whole Settings > Kiro account page, which main changed in #39373 to show the sign-in choices in its card.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 19, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed head 51b3e26. The start URL checks now attach a reason to each refusal. The begin device 400 response returns it as an optional field and keeps the error, status and code as they were. The form shows a translated sentence for each known code and reason, and falls back to the gateway's text for anything else. I ran the changed backend suites, the login gate component tests and the catalog parity tests on this head and all passed. I also checked that every locale has the new keys and that the error report the form passes on still carries the original status and code. I found no wrong behaviour, compatibility break or security concern, so nothing blocks.

@bolichen97
bolichen97 merged commit 0724986 into main Nov 20, 2026
160 of 169 checks passed
@bolichen97
bolichen97 deleted the fix/32061-sso-hint-i18n branch November 20, 2026 01:06
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Company SSO form: a wrong region or start URL is shown as "Check your connection"

2 participants