Repository navigation
fix(ui): give schedule notice buttons a visible resting fill - #36509
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This fix stays inside its Goal. All three changed tests fail on base, and the 15 unfixed sibling sites are listed and tracked in #32636. Notes
What this change shipsInventory (3 items) — 3 justifiedIntent: make the Schedule page's tinted-notice buttons read as buttons at rest in both themes. FIX.
[FIRST-PRINCIPLES-REVIEWED] 6099a8d Description read[DESCRIPTION-READ] ddef06e07cb7ff702b419df3101724e75a7aa33ba65c2f63a8848400ef6391a3 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a class-only fix on five buttons, it matches the fill and edge pair #31924 and #32711 already use, and it comes with rendered before/after evidence. Notes
[DESIGN-REVIEWED] 6099a8d Description read[DESCRIPTION-READ] 4f32999337028d6eb40a2ddb79c2c2d0d5a49262971670e53701ad9aeba21f5f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. All five restyled buttons appear in before and after shots in both themes, and the blind reader says the after state "plainly" reads as a button. Notes
[UX-REVIEWED] 6099a8d Description read[DESCRIPTION-READ] 1c089ce02fd0f0cb4032fe833748a975e5eb2c4bfb2326d20f649635e1cebacb That sha256 names everything this verdict read: the PR description, plus the 15 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
A stock Btn draws a faint --border edge on a transparent fill. On the Schedule page's tinted notices (the folder delete confirm, both in the jobs table and under an empty folder, and a script job's pending secrets request) that edge falls well below what the plain page gives it in at least one theme, so the buttons read as text until hovered. Give each of those five buttons an opaque --bg-elevated fill and a --border-strong edge, the pair #32711 used for the banner buttons. Hover and the danger text stay as they were. Part of #32636
88fc6a4 to
6099a8d
Compare
|
Rebased: main moved in That run went red only in Fast Gate's docs-lint ( [operator: bolichen97] |
Code change approver recommendation: ApproveWhy: the decider estimates a 5% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. This PR only changes classes. Five stock An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
[operator: bolichen97] CodeQL is red on this head for a platform reason, not a code one. Both |
buluoray
left a comment
There was a problem hiding this comment.
Approve on 6099a8d. This PR makes the five buttons on the Schedule page's tinted notices look like buttons before anyone hovers: the folder delete confirm in the jobs table, the folder delete confirm under an empty folder, and Deny on a pending secrets request. Each button gets the theme's elevated surface as its fill and the theme's strong border as its edge, set at the call site. The shared button component is not changed, so no other button moves. Hover, disabled and the danger text colour keep their own classes, and the global focus outline is untouched. The contrast numbers in the description match the default dark and light theme values, and in every shipped theme the new edge is at least as visible as before or the new fill makes up for it. Each of the five changes has a test that fails without it. CodeQL is red on this head because GitHub's API rate limit stopped both analyses, not because of the code. Follow-ups: in several dark themes the red Delete and Deny text has a little less contrast on the new fill than it had on the tint, and the remaining tinted notices are still to be fixed under #32636. Decisive lines: website/src/components/CronFolderHeader.tsx:143-157, website/src/pages/SchedulePage.tsx:274-281, website/src/pages/SchedulePage.tsx:1658-1662, website/src/components/ui.tsx:82-107 (Btn, not changed), website/src/test/cronFoldersSchedulePage.test.tsx:216-223, website/src/test/cronFoldersSchedulePage.test.tsx:582-588, website/src/pages/SchedulePage.secrets.test.tsx:184-189
Problem / Motivation
Goal: The buttons on the Schedule page's tinted notices (the folder delete confirm and a script job's pending secrets request) read as buttons at rest, in dark and light themes, without hovering.
A stock
Btnhas a transparent fill and a faint--borderedge. On these notices' translucentdanger/warntint that edge falls well below what the plain page or card gives it in at least one theme, so the buttons look like plain text until the pointer is over them. #32636 lists them among the notice sites still to fix after #32711 and #34394.Why it matters
Each of these notices asks for a decision: delete a folder or keep it, deny an agent's request for a secret. A button that does not look like one gets missed or misread, and on touch there is no hover to reveal it.
Not a goal
Btnitself: every other button keeps its look.SendBtn, already filled.What changed (motivation → approach → change)
Five buttons on three Schedule notices get a solid fill and a stronger edge, so they look like buttons before anyone hovers.
Each one now carries an opaque
--bg-elevatedfill and a--border-strongedge, the pair #31924 and #32711 used.twMergedrops the stockbg-transparentandborder-border, so hover, focus, disabled and the danger text stay as they were.components/CronFolderHeader.tsx)bg-danger/5on the cardEmptyFolderChip,pages/SchedulePage.tsx)bg-danger/5on the pageJobSecretsPanel,pages/SchedulePage.tsx)bg-warn-subtleon the cardContrast is computed from the default dark and light values in
website/src/styles/design-tokens.css.Backwards compatibility
Compatible: a class change on five buttons; no prop, string, route or API changes.
Removes nothing: the added classes replace the transparent fill and faint border, nothing is hidden or deleted.
Tests
Each assertion checks the button carries
bg-bg-elevatedandborder-border-strongand neitherbg-transparentnorborder-border:website/src/test/cronFoldersSchedulePage.test.tsx: both buttons of the in-table confirm row (delete folder shows inline confirmation row) and of the empty-folder confirm (empty-state folder delete requires confirm before calling API).website/src/pages/SchedulePage.secrets.test.tsx: the Deny button of a pending request, which keepstext-danger.With the two production files at the base and these tests kept, exactly the three changed tests fail, each on its
toHaveClass("bg-bg-elevated border-border-strong")assertion; with the fix all 32 tests in both files pass. The unchanged tests at the base pass 32 of 32.Proof: not provable -- frontend test (prove.py runs Python only)
Determinism: five repeat runs and one
--sequence.shufflerun of both files on this patch over mainb9ddf797c7, 32 of 32 passed each time.On Ubuntu 24.04 every local gate passes on this patch over main
b9ddf797c7:npm run build, tsc, eslint, flake8, mypy, docs-lint and the related tests (scripts/run_scoped_tests.py: 29 frontend files, 259 tests; the backend set's two reds fail the same way on a cleanb9ddf797c7). The whole frontend suite passed on the same patch overee18fa5303(npm run test: 4,415 files, 68,728 tests).Manual verification
Reproduced and smoke-tested on Ubuntu 24.04.5 LTS (Linux x86_64): Playwright drove
/schedulein Chromium against the built SPA (website/dist) of the base and of this head, with/api/**answered by the sharedwebsite/scripts/lib/stub-dashboard-api.mjsstubs. Each notice was shot at rest, pointer away, in dark and light (frames below).ee18fa5303): all five buttons are transparent with only the faint--borderedge; in dark, Deny on the warn tint shows no edge at all and reads as red text.--bg-elevatedfill and a visible--border-strongedge in both themes; the danger text colour is unchanged.Screenshots / video
Each frame shows the notice at rest, pointer away. The in-table confirm moves focus to its Delete button when it opens; the frames blur it so the edge, not the focus ring, is what shows.
Secrets request, dark. Before, Deny has no visible edge on the warn tint; after, it has a fill and an edge.
Folder delete confirm in the jobs table, light.
Folder delete confirm under an empty folder, light.
Secrets request light, both folder confirms dark (before, then after)
Related Issues
Part of #32636
Sibling sweep
Swept: the #32636 list, plus a nesting-aware scan of every
<Btn>with noprimaryand no fill of its own inside a container classedbg-(ok|warn|danger|info|accent)(-subtle|/N)underwebsite/srcSibling: website/src/components/CronFolderHeader.tsx:139 -- changed here
Sibling: website/src/pages/SchedulePage.tsx -- changed here
Sibling: website/src/pages/system/SessionsTab.tsx:415 -- not affected -- the Retry button sits on no tint
Sibling: website/src/components/DirectDeployFlow.tsx:66 -- tracked in #32636
Sibling: website/src/components/CrashReportNotice.tsx:123 -- tracked in #32636
Sibling: website/src/components/AgentImportFlow.tsx:995 -- tracked in #32636
Sibling: website/src/components/PullRequestPanel.tsx:1407 -- tracked in #32636
Sibling: website/src/components/RegistryManager.tsx:484 -- tracked in #32636
Sibling: website/src/components/VoicePlaybackBar.tsx:33 -- tracked in #32636
Sibling: website/src/components/CrewAvatarLibraryTab.tsx:436 -- tracked in #32636
Sibling: website/src/components/crew/CrewEditorNextDialog.tsx:1039 -- tracked in #32636
Sibling: website/src/pages/ArtifactDetailPageBody.tsx:465 -- tracked in #32636
Sibling: website/src/pages/chat/BrowserLiveCardViews.tsx:234 -- tracked in #32636
Sibling: website/src/pages/chat/WorkflowRunCard.tsx:185 -- tracked in #32636
Sibling: website/src/pages/chat/quickAsk/useQuickAsk.tsx:69 -- tracked in #32636
Sibling: website/src/pages/chat/share/ShareMessageModal.tsx:318 -- tracked in #32636
Sibling: website/src/pages/settings/SecurityPanelConfigPending.tsx:350 -- tracked in #32636
Sibling: website/src/pages/settings/SecretsPanel.tsx:787 -- tracked in #32636
Sibling: website/src/pages/settings/SttSettings.tsx:1783 -- tracked in #32636
Pattern harvest
Rule candidate: review-prompt
Pattern: a stock
Btn(transparent fill,--borderedge) placed inside a translucent tinted container with no at-rest fill of its ownChecklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.