Skip to content

fix(ui): give schedule notice buttons a visible resting fill - #36509

Merged
bolichen97 merged 1 commit into
mainfrom
fix/32636-notice-button-edges
Nov 14, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/32636-notice-button-edges

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The buttons on the Schedule page's tinted notices (the folder delete confirm and a script job's pending secrets request) read as buttons at rest, in dark and light themes, without hovering.

A stock Btn has a transparent fill and a faint --border edge. On these notices' translucent danger/warn tint that edge falls well below what the plain page or card gives it in at least one theme, so the buttons look like plain text until the pointer is over them. #32636 lists them among the notice sites still to fix after #32711 and #34394.

Why it matters

Each of these notices asks for a decision: delete a folder or keep it, deny an agent's request for a secret. A button that does not look like one gets missed or misread, and on touch there is no hover to reveal it.

Not a goal

What changed (motivation → approach → change)

Five buttons on three Schedule notices get a solid fill and a stronger edge, so they look like buttons before anyone hovers.

Each one now carries an opaque --bg-elevated fill and a --border-strong edge, the pair #31924 and #32711 used. twMerge drops the stock bg-transparent and border-border, so hover, focus, disabled and the danger text stay as they were.

Notice Buttons Tint Edge vs tint, dark Edge vs tint, light
Folder delete confirm, folder with jobs (components/CronFolderHeader.tsx) Delete "…", Cancel bg-danger/5 on the card 1.11 → 1.58 (plain card 1.16) 1.18 → 1.37 (plain card 1.27)
Folder delete confirm, empty folder (EmptyFolderChip, pages/SchedulePage.tsx) Delete "…", Cancel bg-danger/5 on the page 1.19 → 1.69 (plain page 1.24) 1.13 → 1.31 (plain page 1.22)
Pending secrets request in the job dialog (JobSecretsPanel, pages/SchedulePage.tsx) Deny bg-warn-subtle on the card 1.09 → 1.31 (plain card 1.16) 1.11 → 1.30 (plain card 1.27)

Contrast is computed from the default dark and light values in website/src/styles/design-tokens.css.

Backwards compatibility

Compatible: a class change on five buttons; no prop, string, route or API changes.
Removes nothing: the added classes replace the transparent fill and faint border, nothing is hidden or deleted.

Tests

Each assertion checks the button carries bg-bg-elevated and border-border-strong and neither bg-transparent nor border-border:

  • website/src/test/cronFoldersSchedulePage.test.tsx: both buttons of the in-table confirm row (delete folder shows inline confirmation row) and of the empty-folder confirm (empty-state folder delete requires confirm before calling API).
  • website/src/pages/SchedulePage.secrets.test.tsx: the Deny button of a pending request, which keeps text-danger.

With the two production files at the base and these tests kept, exactly the three changed tests fail, each on its toHaveClass("bg-bg-elevated border-border-strong") assertion; with the fix all 32 tests in both files pass. The unchanged tests at the base pass 32 of 32.

Proof: not provable -- frontend test (prove.py runs Python only)

Determinism: five repeat runs and one --sequence.shuffle run of both files on this patch over main b9ddf797c7, 32 of 32 passed each time.

On Ubuntu 24.04 every local gate passes on this patch over main b9ddf797c7: npm run build, tsc, eslint, flake8, mypy, docs-lint and the related tests (scripts/run_scoped_tests.py: 29 frontend files, 259 tests; the backend set's two reds fail the same way on a clean b9ddf797c7). The whole frontend suite passed on the same patch over ee18fa5303 (npm run test: 4,415 files, 68,728 tests).

Manual verification

Reproduced and smoke-tested on Ubuntu 24.04.5 LTS (Linux x86_64): Playwright drove /schedule in Chromium against the built SPA (website/dist) of the base and of this head, with /api/** answered by the shared website/scripts/lib/stub-dashboard-api.mjs stubs. Each notice was shot at rest, pointer away, in dark and light (frames below).

  • Before (base ee18fa5303): all five buttons are transparent with only the faint --border edge; in dark, Deny on the warn tint shows no edge at all and reads as red text.
  • After (this head): each of the five has an opaque --bg-elevated fill and a visible --border-strong edge in both themes; the danger text colour is unchanged.
  • Happy paths after the fix, from the smoke run:
table row: Cancel class has bg-bg-elevated=true border-border-strong=true
table row: Cancel closed the confirm; folder DELETE calls=0
empty folder: Cancel class has bg-bg-elevated=true border-border-strong=true
empty folder: Cancel closed the confirm; folder DELETE calls=0
Deny request: [{"path":"/api/crons/c3/secrets","method":"PUT","body":{"deny_pending":true,...}}]

Screenshots / video

Each frame shows the notice at rest, pointer away. The in-table confirm moves focus to its Delete button when it opens; the frames blur it so the edge, not the focus ring, is what shows.

Secrets request, dark. Before, Deny has no visible edge on the warn tint; after, it has a fill and an edge.

Pending secrets request, dark, before

Pending secrets request, dark, after

Folder delete confirm in the jobs table, light.

Folder delete confirm row, light, before

Folder delete confirm row, light, after

Folder delete confirm under an empty folder, light.

Empty folder delete confirm, light, before

Empty folder delete confirm, light, after

Secrets request light, both folder confirms dark (before, then after)

Pending secrets request, light, before

Pending secrets request, light, after

Folder delete confirm row, dark, before

Folder delete confirm row, dark, after

Empty folder delete confirm, dark, before

Empty folder delete confirm, dark, after

Related Issues

Part of #32636

Sibling sweep

Swept: the #32636 list, plus a nesting-aware scan of every <Btn> with no primary and no fill of its own inside a container classed bg-(ok|warn|danger|info|accent)(-subtle|/N) under website/src
Sibling: website/src/components/CronFolderHeader.tsx:139 -- changed here
Sibling: website/src/pages/SchedulePage.tsx -- changed here
Sibling: website/src/pages/system/SessionsTab.tsx:415 -- not affected -- the Retry button sits on no tint
Sibling: website/src/components/DirectDeployFlow.tsx:66 -- tracked in #32636
Sibling: website/src/components/CrashReportNotice.tsx:123 -- tracked in #32636
Sibling: website/src/components/AgentImportFlow.tsx:995 -- tracked in #32636
Sibling: website/src/components/PullRequestPanel.tsx:1407 -- tracked in #32636
Sibling: website/src/components/RegistryManager.tsx:484 -- tracked in #32636
Sibling: website/src/components/VoicePlaybackBar.tsx:33 -- tracked in #32636
Sibling: website/src/components/CrewAvatarLibraryTab.tsx:436 -- tracked in #32636
Sibling: website/src/components/crew/CrewEditorNextDialog.tsx:1039 -- tracked in #32636
Sibling: website/src/pages/ArtifactDetailPageBody.tsx:465 -- tracked in #32636
Sibling: website/src/pages/chat/BrowserLiveCardViews.tsx:234 -- tracked in #32636
Sibling: website/src/pages/chat/WorkflowRunCard.tsx:185 -- tracked in #32636
Sibling: website/src/pages/chat/quickAsk/useQuickAsk.tsx:69 -- tracked in #32636
Sibling: website/src/pages/chat/share/ShareMessageModal.tsx:318 -- tracked in #32636
Sibling: website/src/pages/settings/SecurityPanelConfigPending.tsx:350 -- tracked in #32636
Sibling: website/src/pages/settings/SecretsPanel.tsx:787 -- tracked in #32636
Sibling: website/src/pages/settings/SttSettings.tsx:1783 -- tracked in #32636

Pattern harvest

Rule candidate: review-prompt
Pattern: a stock Btn (transparent fill, --border edge) placed inside a translucent tinted container with no at-rest fill of its own

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 6099a8d955b559e80f047b447e37e58e9b5db0c3 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This fix stays inside its Goal. All three changed tests fail on base, and the 15 unfixed sibling sites are listed and tracked in #32636.

Notes

  • Item 1 — symptom-level: the shared cause is that a stock Btn (website/src/components/ui.tsx:101-102, border-border bg-transparent) gets no resting edge on a tinted container. This PR adds the same className="border-border-strong bg-bg-elevated" override at 5 call sites, and the description names 15 more call sites tracked in More buttons on tinted notices and selected rows have no visible edge until hover #32636. That pair already appears 37 times across 22 files under website/src, so each fix copies the override again instead of fixing it once. The description declares this deferral ("Changing the stock Btn itself" is a Not a goal), so this is a note, not a blocker.

What this change ships

Inventory (3 items) — 3 justified

Intent: make the Schedule page's tinted-notice buttons read as buttons at rest in both themes. FIX.

  1. Delete and Cancel in the jobs-table folder delete confirm now have an opaque fill and a stronger edge at rest — justified
  2. Delete and Cancel in the empty-folder delete confirm now have an opaque fill and a stronger edge at rest — justified
  3. Deny on the pending secrets request now has an opaque fill and a stronger edge at rest — justified

[FIRST-PRINCIPLES-REVIEWED] 6099a8d

Description read

[DESCRIPTION-READ] ddef06e07cb7ff702b419df3101724e75a7aa33ba65c2f63a8848400ef6391a3

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 6099a8d955b559e80f047b447e37e58e9b5db0c3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a class-only fix on five buttons, it matches the fill and edge pair #31924 and #32711 already use, and it comes with rendered before/after evidence.

Notes

[DESIGN-REVIEWED] 6099a8d

Description read

[DESCRIPTION-READ] 4f32999337028d6eb40a2ddb79c2c2d0d5a49262971670e53701ad9aeba21f5f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 6099a8d955b559e80f047b447e37e58e9b5db0c3 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 6099a8d

Verdict parsed from the review's SHA-scoped output markers for commit 6099a8d955b559e80f047b447e37e58e9b5db0c3.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 6099a8d955b559e80f047b447e37e58e9b5db0c3 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 6099a8d955b559e80f047b447e37e58e9b5db0c3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. All five restyled buttons appear in before and after shots in both themes, and the blind reader says the after state "plainly" reads as a button.

Notes

  • The blind reader would not press "Approve" because nothing says what the secret unlocks. This PR doesn't touch that copy, so it belongs in a follow-up.

[UX-REVIEWED] 6099a8d

Description read

[DESCRIPTION-READ] 1c089ce02fd0f0cb4032fe833748a975e5eb2c4bfb2326d20f649635e1cebacb

That sha256 names everything this verdict read: the PR description, plus the 15 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 6099a8d955b559e80f047b447e37e58e9b5db0c3 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 6099a8d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 6099a8d955b559e80f047b447e37e58e9b5db0c3 false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 enabled auto-merge (squash) November 13, 2026 08:50
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 13, 2026
A stock Btn draws a faint --border edge on a transparent fill. On the
Schedule page's tinted notices (the folder delete confirm, both in the
jobs table and under an empty folder, and a script job's pending
secrets request) that edge falls well below what the plain page gives
it in at least one theme, so the buttons read as text until hovered.

Give each of those five buttons an opaque --bg-elevated fill and a
--border-strong edge, the pair #32711 used for the banner buttons.
Hover and the danger text stay as they were.

Part of #32636
@bolichen97
bolichen97 force-pushed the fix/32636-notice-button-edges branch from 88fc6a4 to 6099a8d Compare November 13, 2026 11:51
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/components/ and website/src/pages/ (the directories of this PR's files; none of its four files changed) since this head's last CI run, and fixed its own docs-lint regression in #36504 (ee18fa5 -> a45e97a); CI re-running.

That run went red only in Fast Gate's docs-lint (docs/request-for-change/rfc-app-agent-tools-third-party-grant.md not reachable from any index), which came from main and is fixed there; the heavy jobs were skipped behind it. The patch is unchanged (git range-diff shows it identical), so the screenshots in the description still show this head.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 13, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 5% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

This PR only changes classes. Five stock Btns on three Schedule-page tinted notices get className="border-border-strong bg-bg-elevated": Delete and Cancel in the in-table folder delete confirm, Delete and Cancel in the empty-folder confirm, and Deny on the pending secrets request. Btn (ui.tsx:97) passes the caller's className through twMerge. That replaces the base bg-transparent and border-border and leaves the hover:, disabled: and text-danger classes alone, so hover, disabled and danger styling don't change. The same pair is already used on stock Btns elsewhere: McpTab.tsx:859/862 and ArtifactsPage.tsx:920/923. No props, handlers, state or behaviour change, so there's no state, lifecycle or trust surface to check. New assertions in both test files check that the new classes are present and the old ones are gone, and they would fail without the change. The items listed as out of scope are honestly deferred to the tracking issue.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 6099a8d955 · 34 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 13, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] CodeQL is red on this head for a platform reason, not a code one. Both Analyze (python) and Analyze (javascript-typescript) ended with API rate limit exceeded for installation, and main carries the same failure in its own CodeQL push run (Analyze (actions), 2026-11-13 19:06 UTC) - it is the shared-quota exhaustion tracked in #28761. Every other lane on this head passed, including all three whole-design reviews, and nothing in this diff touches the step that failed. The two failed jobs get one rerun as soon as the repository's CI queue has room; no code change is owed here.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 14, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on 6099a8d. This PR makes the five buttons on the Schedule page's tinted notices look like buttons before anyone hovers: the folder delete confirm in the jobs table, the folder delete confirm under an empty folder, and Deny on a pending secrets request. Each button gets the theme's elevated surface as its fill and the theme's strong border as its edge, set at the call site. The shared button component is not changed, so no other button moves. Hover, disabled and the danger text colour keep their own classes, and the global focus outline is untouched. The contrast numbers in the description match the default dark and light theme values, and in every shipped theme the new edge is at least as visible as before or the new fill makes up for it. Each of the five changes has a test that fails without it. CodeQL is red on this head because GitHub's API rate limit stopped both analyses, not because of the code. Follow-ups: in several dark themes the red Delete and Deny text has a little less contrast on the new fill than it had on the tint, and the remaining tinted notices are still to be fixed under #32636. Decisive lines: website/src/components/CronFolderHeader.tsx:143-157, website/src/pages/SchedulePage.tsx:274-281, website/src/pages/SchedulePage.tsx:1658-1662, website/src/components/ui.tsx:82-107 (Btn, not changed), website/src/test/cronFoldersSchedulePage.test.tsx:216-223, website/src/test/cronFoldersSchedulePage.test.tsx:582-588, website/src/pages/SchedulePage.secrets.test.tsx:184-189

@bolichen97
bolichen97 merged commit e5d20ea into main Nov 14, 2026
100 of 102 checks passed
@bolichen97
bolichen97 deleted the fix/32636-notice-button-edges branch November 14, 2026 20:27
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants