Repository navigation
feat(sidebar): add title-only session cards - #36625
Closed
bolichen97 wants to merge 2 commits into
Closed
bolichen97 wants to merge 2 commits into
bolichen97 wants to merge 2 commits into
Conversation
A title-only card hides the Ultra Mode root's status line, and its title marker counted only local crew rows waiting on a tool approval. A remote worker in the approval group and a ledger item on a person left the title bare. The marker now reads the status line's own needs-you count (useCrewSubtreeNeedsYou), so both say the same thing. SessionRow.tsx was past the 2,000-line cap, so the root summary line, the row line styles and the row's prop types move to sibling modules. The sidebar test's tag and folder mocks resolve to lists, so an awaited crew read no longer throws after the test ends.
Contributor
Author
|
Fallback only. Rio updated #23512 on 11-13 11:47Z, so his PR stays primary. This draft will close if Rio pushes by 11-14 12:00Z. |
Contributor
Author
|
Closing: Rio pushed the fix to #23512. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
Goal: Let people reduce sidebar session cards to their titles with one optional setting.
The sidebar has separate controls for some card details, but no single title-only mode. People who organize many sessions by title still see repeated agent metadata, timestamps, activity previews, and linked-source chips.
Why it matters
A title-only option makes dense session lists faster to scan and keeps unrelated issue or pull-request references out of screenshots and screen shares.
Not a goal
What changed (motivation → approach → change)
Takeover of #23512 by Rio (credit kept). His commit was rebased onto main; conflict resolutions only:
src/kiro_crew/docs/ui-index.generated.json: regenerated withnpm run gen:ui, not hand-merged.website/src/pages/chat-sidebar/SessionRow.tsx: kept main'sslotStatusTextblock (with itscompactingparameter) and main'slucide-reactimport line, and added Rio'sCOMPACT_LIVE_ROW_STATE_KEYSandPauseimport.website/src/pages/chat/ChatSettings.tsx: kept bothDEFAULTSentries (main'sreasoningStartsExpanded: falseand Rio'scompactSessionCards: false).Nothing else in his commit changed; it keeps his author name, email and date.
Rio's commit (
feat(sidebar): add title-only session cards): a browser-local Title-only session cards switch under Settings → Chat → Sessions, default off. When on, a session row keeps its title and hides the agent/timestamp line, the activity or message line and linked source chips. A row that needs the user keeps one labelled icon in front of its title (an owed approval, a question, a waiting loop, an interrupted turn, a blocked monitor, an unread result); a goal loop, workflow run or monitor action lights the live dot; a collapsed conductor shows its hidden sessions' needs-you icon or live dot; a Crew Mode root keeps its bolt and a paused crew its Paused icon; a Slack code channel conductor keeps its crew state, badge and worker fold; a muted session keeps its mute icon.Fix commit (Bolin Chen), for Crew Captain's change request on #23512:
group: "approval", no local slot), or whose ledger has an item on a person (crew_work.person > 0), showed a bare title.crewWaitingApprovals), while the hidden status line counts the server's worker list, live approvals and the ledger (crewNeedsYou).useCrewSubtreeNeedsYou, now gives that count to both the status line and the title marker. The marker uses the status line'sHandglyph and "N needs you" label (statecrew_needs_you). The hook reads nothing for a row that is not a title-only crew root.SessionRow.tsxwas over the 2,000-line cap after the rebase (2,117 lines), so whole definitions move to sibling modules: the crew summary line, its hook and the Paused mark tochat-sidebar/CrewRootSummaryLine.tsx; the row line classes and icon size tochat-sidebar/rowLineStyle.ts; the row's prop types tochat-sidebar/sessionRowTypes.ts.SessionRow.tsxis now 1,923 lines.chatTagsandchatFoldersas{}. An awaited crew read let those queries land after the test, so Vitest exited 1 with unhandled errors. Both mocks now resolve to lists.The generated settings registry, command-palette registry, UI index and locale catalogs come from Rio's commit.
Backwards compatibility
Compatible: the new browser-local preference defaults to
false, so existing installations keep detailed session cards.Reader: website/src/pages/ChatSidebar.tsx:ChatSidebar -- chat -- reads the preference and passes it through the shared row shell.
Reader: website/src/pages/chat-sidebar/SessionRow.tsx:SessionRow -- chat -- hides only rendered card details when the preference is on; slot payloads and row actions are unchanged.
Reader: website/src/pages/settings/ChatPanel.tsx:ChatPanel -- settings -- writes the preference through the existing
mc-chat-configpath.Tests
ChatSettings.test.tsxcovers the detailed default, a stored opt-in and repair of invalid stored values.ChatSidebar.sourceLinkChip.test.tsxcovers the title-only card: hidden preview, timestamp and source chips; the labelled title markers; the live dot for a workflow run and a goal loop; the stalled-loop marker; a collapsed conductor's needs-you icon; a Crew Mode root's needs-you marker for a local worker's approval, a remote worker's approval with no local slot and a ledger item waiting on a person (the two cases from the change request, added in the fix commit); the Crew Mode and Paused marks; the running-crew marker; and no extra cues on full cards.ChatSidebar.codeChannelCrew.test.tsxcovers a title-only code channel conductor.tsc --noEmit, targeted ESLint,npm run build,i18n:check,npm run gen:ui(no changes) andscripts/check_file_line_cap.py(0 failures) passed.Manual verification
From Rio's PR, in an isolated local dashboard profile: detailed cards showed metadata, timestamps, previews and source chips; enabling the setting reduced each card to its title; a refresh kept the preference; disabling it restored detailed cards. The fix commit's marker is covered by the tests above.
Screenshots / video
Rio's screenshots (synthetic sessions and links). They show the title-only layout, not the title-line icons, which the tests cover.
Related Issues
Part of #21239
Refs #23512
Follow-ups left out of this PR: #29861 (collapsed-parent live-dot test), #29862 (pinned, incognito/temporary, popped-out and released icons), #29863 (setting description copy), #29864 (
history.mdspec paragraph).Related overlap: #21925 provides a narrower preview-only setting and keeps status indicators and other card details visible.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of
CONTRIBUTING.md.