Repository navigation
test(conductor): map the shared goal_plan rule to its Ultra Mode anchor - #36652
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. This is a test-only change that adds one map entry. Both anchor phrases appear in [DESIGN-REVIEWED] e706659 Description read[DESCRIPTION-READ] ccd5c87ee77694b61bc623cbf8c7c45b67c2a64df604bcb4df45823658dcf18b That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: ApproveWhy: the decider estimates a 3% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. Test-only, one-line fix. It adds a An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
buluoray
left a comment
There was a problem hiding this comment.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:
Approve. This fixes the red on main.
#36540 added the shared conductor rule goal_plan, and #36529 added the guard that every shared rule must map to an Ultra Mode anchor or a named gap. Together they left goal_plan unmapped, so test_every_shared_rule_has_an_ultra_counterpart_or_a_named_gap fails on main (Linux shard 3 and Windows shard 3 of the latest main run).
The two anchors are real text in the chain the team lead reads: src/kiro_crew/builtin_skills/goal-conductor/SKILL.md:334-335 ("A finding rewrites the plan at once", "rewrite the goal text's Plan and"). So this is a mapping, not a gap, and it does not weaken the guard.
Checked on current main with this diff applied: test/test_mate_conductor_parity.py 24 passed.
Problem / Motivation
Goal: Put main's conductor parity test back to green.
On main,
test/test_mate_conductor_parity.py::test_every_shared_rule_has_an_ultra_counterpart_or_a_named_gapfails withshared rules with no Ultra Mode counterpart: ['goal_plan']. #36529 added that check; #36540 added the sharedgoal_planrule. Each passed alone, and together the new key has no anchor.Why it matters
Every PR whose Backend Tests run this file is red until it lands.
Not a goal
What changed (motivation → approach → change)
The rule already has its Ultra Mode counterpart:
goal-conductor/SKILL.mdPatrol says "A finding rewrites the plan at once ... rewrite the goal text's Plan and ...". This mapsgoal_planto those two phrases inULTRA_SKILL_ANCHORS.Backwards compatibility
Compatible: test-only.
Removes nothing: it adds one map entry.
Tests
Proof: not provable -- test-only change
test/test_mate_conductor_parity.py: 24 passed with this change; 1 failed, 23 passed on main.Manual verification
N/A — test-only.
Related Issues
Closes #36651
Sibling sweep
Siblings: none -- every other
_LEDGER_CONDUCTOR_RULESkey is already mapped or gapped; the test checks all keys.Pattern harvest
Not generalizable: a one-off merge-order clash between two PRs that each passed alone.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)