Skip to content

fix(members): read the hidden-bots hint as one list in every language - #36757

Merged
bolichen97 merged 1 commit into
mainfrom
fix/35583-members-hidden-hint-list
Nov 19, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/35583-members-hidden-hint-list

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On the Members page, the line that names some hidden bots and counts the rest reads as one natural list in every dashboard language.

With more than three unused bots hidden, the line at the end of the roster read a, b und c und 3 weitere Bots … in German (two "und"), abc 和另外 3 个… in Chinese (the names run together) and a b c ほか 3 個… in Japanese (spaces where 、 belongs).

Why it matters

Anyone running the dashboard in German, French, Italian, Portuguese, Chinese, Japanese, Korean or Russian with more than three unused bots sees a garbled sentence on the one line that tells them which bots the roster hides and that the count above leaves them out.

Not a goal

What changed (motivation → approach → change)

Each language now reads the hint as one list with one conjunction and its own separator. English reads "a, b, c, and 3 more bots you haven't used yet are hidden and aren't counted above.", gaining the serial comma the all-named form already uses.

The cause: the first three names went in as a unit list, and the sentence then closed that list with its own "and N more bots". A unit list still carries "und", "et" or "e" in some languages and no separator at all in Chinese, so the sentence's own conjunction doubled or the names ran together.

The count is now the list's last item. A new pages.membersPage.hidden_more_count string ("N more bots", plural by count) is formatted together with the names by fmtList in members/MembersPageRoster.tsx, and hidden_more_hint wraps that one list. All twelve catalogs carry the reworded pair (en-XA regenerated), i18n/pluralKeys.json moves the plural from the hint to the count, and the crew-mode spec names the shape. It is the shape #35643 gave the theme editor's capped name list.

Backwards compatibility

Compatible: a display string only; no stored data, API, prop or setting changes. The hint's catalog keys change shape (hidden_more_hint_one/_other become one hidden_more_hint plus hidden_more_count_*).

Reader: website/src/pages/members/MembersPageRoster.tsx:MembersPageRosterColumn -- crew page -- the only reader of pages.membersPage.hidden_more_hint, switched to the new pair here; MembersPage.filters.test.tsx past three hidden mates, names the first three in roster order and counts the rest

Tests

  • website/src/pages/members/MembersPage.filters.test.tsx: joins the named and the counted hidden mates as one de / zh-CN / ja list renders five hidden bots and expects the whole line, one "und" in German, 、 and 和 in Chinese, 、 in Japanese. The three English counted-form cases expect the serial comma. With the MembersPageRoster.tsx hunk reverted, all six fail.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Reproduced on a disposable Linux host (Ubuntu 24.04.5) against the real dashboard: an isolated gateway (KIROCREW_HOME under ~/scratch, free 127.0.0.1 port, never port 5476), five source: "package" agents seeded into config.json and applied through POST /api/security/config-pending/config.json/apply, so the Members roster hides 6 bots with 1 listed. Playwright read [data-testid="member-hidden-hint"] in en/de/zh-CN/ja, built the fixed tree and reread. Before and after:

en  before: "default, pkg-alpha, pkg-bravo and 3 more bots ..."
en  after:  "default, pkg-alpha, pkg-bravo, and 3 more bots ..."
de  before: "default, pkg-alpha und pkg-bravo und 3 weitere Bots ..."
de  after:  "default, pkg-alpha, pkg-bravo und 3 weitere Bots ..."
zh  before: "defaultpkg-alphapkg-bravo 和另外 3 个 ..."
zh  after:  "default、pkg-alpha、pkg-bravo和另外 3 个 Bot ..."
ja  before: "default pkg-alpha pkg-bravo ほか 3 個、まだ使っていない ..."
ja  after:  "default、pkg-alpha、pkg-bravo、ほか 3 個の Bot ..."

The named form (three or fewer hidden, hidden_named_hint) is unchanged and the no-hidden case still draws no line.

Screenshots / video

Hidden-bots hint on the Members page in four languages, before and after. The dashboard is run in each language with six hidden bots and one listed (the hint names three and counts the rest).

Before After
English
German
Simplified Chinese
Japanese

Related Issues

Closes #35583

Sibling sweep

Swept: git grep -nE "type: 'unit'" -- website/src (tests left out), each hit read for whether its list goes into a sentence that adds its own conjunction; plus the English catalogs for "and {{count}} more" sentences.
Sibling: website/src/pages/chat-sidebar/CrewGroups.tsx:293 -- not affected -- the counts list is the whole value after the target, no conjunction of its own
Sibling: website/src/pages/chat-sidebar/SearchDock.tsx:1215 -- not affected -- a chip label, "Hiding {{filter}}", adds no conjunction
Sibling: website/src/pages/settings/SecurityPanelGovernance.tsx:586 -- not affected -- "Affected: {{profiles}}." adds no conjunction
Sibling: website/src/i18n/locales/en.manual.json:11524 -- not affected -- and_more follows one title, not a list

Pattern harvest

Rule candidate: review-prompt
Pattern: a formatted name list passed into a translated sentence that closes the list with its own "and N more"; make the count the list's last item instead

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 68a67d41e3a54493cd716661772d22697eea8ed8 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: this rewrites one string for the defect in #35583, at the cause, which was a unit list closed by the sentence's own conjunction.

Notes

  • Item 2 — rides along: the English line gains a serial comma, "pkg-tool, and 1 more bot", as a side effect of fmtList on en. The description declares it, so this is no defect.

What this change ships

Inventory (4 items) — 3 justified

Intent: Members-page users in any language read the "some hidden bots named, the rest counted" line as one grammatical list. FIX.

  1. In de/fr/it/pt/zh/ja/ko/ru, the hidden-bots line with more than three hidden now has one conjunction and the language's own separator — justified
  2. The English line gains a serial comma before "and N more bots" — rides along
  3. The plural catalog keys for this line change shape: hidden_more_hint_* becomes hidden_more_hint plus hidden_more_count_* across all twelve catalogs, with pluralKeys.json updated to match — justified
  4. The crew-mode spec now says the count is the last item of the list — justified

[FIRST-PRINCIPLES-REVIEWED] 68a67d4

Description read

[DESCRIPTION-READ] bb9a3d0d51d3d8320c0c3d152db03a77fb3ec00171112903e69da08a23c187cf

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 68a67d41e3a54493cd716661772d22697eea8ed8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

This is a catalog-only display fix. The count becomes the last item of a single locale-formatted list, it matches the pattern from #35643, and the screenshots cover all four affected languages.

Notes

  • The hint now relies on {{names}} sitting at the start of each locale's sentence. Locales that inflect the noun by its position in the sentence (ru, bn, hi) are left with an uninflected "Bot". Ask native speakers to check those.

[DESIGN-REVIEWED] 68a67d4

Description read

[DESCRIPTION-READ] fad0aa734cf483ebc88271c3ec48ef87808f34da6d706d74a90d96b00a66e30a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 68a67d41e3a54493cd716661772d22697eea8ed8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

The diff only rewords one hint line that can't be clicked. The before and after screenshots in four languages show it, and the blind reader read each "after" version as one clean list.

Notes

  • hidden_more_hint, "…aren't counted above": the blind reader "can't see any count above the note" (shot-01). This wording isn't new in this PR, but a follow-up should name the count it means, e.g. "…aren't in the bot count".

[UX-REVIEWED] 68a67d4

Description read

[DESCRIPTION-READ] 7be693299bd48d0f0c00c3c4fe2ad752c878b65e04b3af7c7be6ab8e69c758dc

That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 68a67d41e3a54493cd716661772d22697eea8ed8 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 68a67d4

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 68a67d41e3a54493cd716661772d22697eea8ed8 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 68a67d41e3a54493cd716661772d22697eea8ed8 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 68a67d4

Verdict parsed from the review's SHA-scoped output markers for commit 68a67d41e3a54493cd716661772d22697eea8ed8.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 68a67d41e3a54493cd716661772d22697eea8ed8 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 13, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates an 8% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

This fixes the problem it describes. The plural "N more bots" string is now the last item of a single Intl.ListFormat conjunction list, and hidden_more_hint wraps that whole list. Each language therefore gets exactly one conjunction and its own separator. The old type: 'unit' list, which caused the doubled "und"/"et" and the Chinese names running together, is gone. All 13 catalogs (including en-XA) have the new key pair and the old hidden_more_hint_* keys are removed. pluralKeys.json now marks the new count key as the plural one. The only reader of the key is MembersPageRoster.tsx:972, which is updated. The new hint string no longer uses {{count}}; it never needed it for plural agreement because this form always lists four or more bots. The named form for three or fewer bots and the no-hidden case are unchanged. The tests pin the full line in en (now with the serial comma) and in de, zh-CN and ja. They switch language with i18next.changeLanguage, as other tests in the repo already do, and they would fail on base. The only CI failures are two unrelated backend tests (test_transcribe and a subprocess timeout) and the Coverage Gate and readiness signal that follow fr

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 33e2d99d30 · 114 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@buluoray

Copy link
Copy Markdown
Contributor

Review passed on this head. Please rebase onto the latest main so CI can run fresh; the approval will follow once the rebased head is green.

@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/pages/members/MembersPageRoster.tsx, website/src/pages/members/MembersPage.filters.test.tsx, website/src/i18n/pluralKeys.json, the website/src/i18n/locales/*.json catalogs and the crew mode spec under docs/system-specs/modules/, which this PR edits, since this head's CI ran (c22557c -> 88ce21a); CI re-running.

This is the rebase asked for above. The only test red on 33e2d99 was Backend Tests (3.12, 7): test/test_testing_determinism_helpers.py::test_the_helper_modules_import_without_pytest timing out on a loaded runner (tracked in #36539; this PR changes no Python). The test's fix, #36575, is on main and in the new base. The patch is unchanged by the rebase.

[operator: bolichen97]

@bolichen97
bolichen97 force-pushed the fix/35583-members-hidden-hint-list branch from 33e2d99 to 7b6ccfa Compare November 18, 2026 01:31
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 18, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/i18n/pluralKeys.json, the website/src/i18n/locales/*.json catalogs and the crew mode spec under docs/system-specs/modules/, which this PR edits, since this head's CI ran (88ce21a -> 5c7dcb8); CI re-running.

This is the fresh rebased head asked for above. The only test red on 7b6ccfa was Frontend Tests (2): website/src/test/ChatPage.reasoningEffort.test.tsx "syncs the default thumb when live levels arrive asynchronously", a timing race in the reasoning-effort dropdown tracked in #39101 (this PR does not touch that component). Its fix, #39116, is on main and in the new base. The patch is unchanged by the rebase.

[operator: bolichen97]

@bolichen97
bolichen97 force-pushed the fix/35583-members-hidden-hint-list branch from 7b6ccfa to a9159c7 Compare November 19, 2026 15:33
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 19, 2026
On the Members page, the line under the roster that names the first
three hidden bots and counts the rest closed a unit-formatted name list
with its own "and N more", so German read two "und", Chinese ran the
names together and Japanese put spaces where 、 belongs. The count is
now the list's last item ("N more bots") and the sentence wraps the
whole list, so each language places one conjunction and its own
separator. English gains the list's serial comma.

Closes #35583
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in the website/src/i18n/locales/*.json catalogs and the crew mode spec under docs/system-specs/modules/, which this PR edits, since this head's CI ran (5c7dcb8 -> 4aded46); CI re-running.

The only red on a9159c7 was Backend Tests (Windows) (5): test_pr_watchers.py::TestCloneLifecycleAndExport::test_the_pass_fix_is_exported_to_the_pr_queue failing with watcher never reached {'exhausted'}, the Windows flake tracked in #39485 that unrelated PRs hit after the Windows shards moved to 6 xdist workers (#39390). This PR changes no Python. #39516, which puts the Windows shards back on 4 workers, is on main and in the new base. The patch is unchanged by the rebase.

[operator: bolichen97]

@bolichen97
bolichen97 force-pushed the fix/35583-members-hidden-hint-list branch from a9159c7 to 68a67d4 Compare November 19, 2026 20:30
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 19, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] The only red on 68a67d4 is Backend Tests (Windows) (1): test/test_hooks_shell_command.py::TestShellCommandUseAws::test_use_aws_not_denied_by_default_gate got deny because the sensitive-path check did not finish inside its resolver budget on the Windows runner (sensitive-path symlink resolution did not complete in 0.4s (stalled mount?)), job log. This PR changes no Python.

The same Windows backend check is red on main's newest completed CI run, run 44604901688 on be1ce64, which is in this PR's base: test/test_security_path_resolve_bounded.py::test_the_rebuild_is_one_pool_job raised PathResolutionStalled. The slow Windows rebuild of the sensitive target set behind both reds is tracked in #38631, and #39038 is open to fix it. This PR waits for that fix and is rebased onto it once it lands; nothing is pushed or overridden for this red. The patch and its screenshots are unchanged.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 19, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed head 68a67d4. The hidden-bots hint now formats the named bots and the plural "N more bots" count as one locale list, so each language places a single conjunction and its own separator. Every catalog carries the new hint and count keys with the plural forms its language needs, no stale plural hint key remains, and the plural key registry points at the new count key. The members filter tests pass on this head, including the new German, Chinese and Japanese whole-line cases, and every check on this head is green. I found no behaviour or test defect, so nothing blocks.

@bolichen97
bolichen97 merged commit 336d530 into main Nov 19, 2026
157 of 158 checks passed
@bolichen97
bolichen97 deleted the fix/35583-members-hidden-hint-list branch November 19, 2026 23:56
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Members page: the hidden-bots hint reads two conjunctions in German and runs the names together in Chinese

3 participants