Repository navigation
fix(members): read the hidden-bots hint as one list in every language - #36757
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: this rewrites one string for the defect in #35583, at the cause, which was a unit list closed by the sentence's own conjunction. Notes
What this change shipsInventory (4 items) — 3 justifiedIntent: Members-page users in any language read the "some hidden bots named, the rest counted" line as one grammatical list. FIX.
[FIRST-PRINCIPLES-REVIEWED] 68a67d4 Description read[DESCRIPTION-READ] bb9a3d0d51d3d8320c0c3d152db03a77fb3ec00171112903e69da08a23c187cf That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS This is a catalog-only display fix. The count becomes the last item of a single locale-formatted list, it matches the pattern from #35643, and the screenshots cover all four affected languages. Notes
[DESIGN-REVIEWED] 68a67d4 Description read[DESCRIPTION-READ] fad0aa734cf483ebc88271c3ec48ef87808f34da6d706d74a90d96b00a66e30a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS The diff only rewords one hint line that can't be clicked. The before and after screenshots in four languages show it, and the blind reader read each "after" version as one clean list. Notes
[UX-REVIEWED] 68a67d4 Description read[DESCRIPTION-READ] 7be693299bd48d0f0c00c3c4fe2ad752c878b65e04b3af7c7be6ab8e69c758dc That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: ApproveWhy: the decider estimates an 8% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. This fixes the problem it describes. The plural "N more bots" string is now the last item of a single An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
Review passed on this head. Please rebase onto the latest main so CI can run fresh; the approval will follow once the rebased head is green. |
|
Rebased: main moved in website/src/pages/members/MembersPageRoster.tsx, website/src/pages/members/MembersPage.filters.test.tsx, website/src/i18n/pluralKeys.json, the website/src/i18n/locales/*.json catalogs and the crew mode spec under docs/system-specs/modules/, which this PR edits, since this head's CI ran (c22557c -> 88ce21a); CI re-running. This is the rebase asked for above. The only test red on 33e2d99 was Backend Tests (3.12, 7): [operator: bolichen97] |
33e2d99 to
7b6ccfa
Compare
|
Rebased: main moved in website/src/i18n/pluralKeys.json, the website/src/i18n/locales/*.json catalogs and the crew mode spec under docs/system-specs/modules/, which this PR edits, since this head's CI ran (88ce21a -> 5c7dcb8); CI re-running. This is the fresh rebased head asked for above. The only test red on 7b6ccfa was Frontend Tests (2): [operator: bolichen97] |
7b6ccfa to
a9159c7
Compare
On the Members page, the line under the roster that names the first
three hidden bots and counts the rest closed a unit-formatted name list
with its own "and N more", so German read two "und", Chinese ran the
names together and Japanese put spaces where 、 belongs. The count is
now the list's last item ("N more bots") and the sentence wraps the
whole list, so each language places one conjunction and its own
separator. English gains the list's serial comma.
Closes #35583
|
Rebased: main moved in the website/src/i18n/locales/*.json catalogs and the crew mode spec under docs/system-specs/modules/, which this PR edits, since this head's CI ran (5c7dcb8 -> 4aded46); CI re-running. The only red on a9159c7 was Backend Tests (Windows) (5): [operator: bolichen97] |
a9159c7 to
68a67d4
Compare
|
[operator: bolichen97] The only red on 68a67d4 is Backend Tests (Windows) (1): The same Windows backend check is red on main's newest completed CI run, run 44604901688 on be1ce64, which is in this PR's base: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
I reviewed head 68a67d4. The hidden-bots hint now formats the named bots and the plural "N more bots" count as one locale list, so each language places a single conjunction and its own separator. Every catalog carries the new hint and count keys with the plural forms its language needs, no stale plural hint key remains, and the plural key registry points at the new count key. The members filter tests pass on this head, including the new German, Chinese and Japanese whole-line cases, and every check on this head is green. I found no behaviour or test defect, so nothing blocks.
Problem / Motivation
Goal: On the Members page, the line that names some hidden bots and counts the rest reads as one natural list in every dashboard language.
With more than three unused bots hidden, the line at the end of the roster read
a, b und c und 3 weitere Bots …in German (two "und"),abc 和另外 3 个…in Chinese (the names run together) anda b c ほか 3 個…in Japanese (spaces where、belongs).Why it matters
Anyone running the dashboard in German, French, Italian, Portuguese, Chinese, Japanese, Korean or Russian with more than three unused bots sees a garbled sentence on the one line that tells them which bots the roster hides and that the count above leaves them out.
Not a goal
hidden_named_hint, three or fewer), which already joins its names the language's way.What changed (motivation → approach → change)
Each language now reads the hint as one list with one conjunction and its own separator. English reads "a, b, c, and 3 more bots you haven't used yet are hidden and aren't counted above.", gaining the serial comma the all-named form already uses.
The cause: the first three names went in as a unit list, and the sentence then closed that list with its own "and N more bots". A unit list still carries "und", "et" or "e" in some languages and no separator at all in Chinese, so the sentence's own conjunction doubled or the names ran together.
The count is now the list's last item. A new
pages.membersPage.hidden_more_countstring ("N more bots", plural by count) is formatted together with the names byfmtListinmembers/MembersPageRoster.tsx, andhidden_more_hintwraps that one list. All twelve catalogs carry the reworded pair (en-XAregenerated),i18n/pluralKeys.jsonmoves the plural from the hint to the count, and the crew-mode spec names the shape. It is the shape #35643 gave the theme editor's capped name list.Backwards compatibility
Compatible: a display string only; no stored data, API, prop or setting changes. The hint's catalog keys change shape (
hidden_more_hint_one/_otherbecome onehidden_more_hintplushidden_more_count_*).Reader: website/src/pages/members/MembersPageRoster.tsx:MembersPageRosterColumn -- crew page -- the only reader of
pages.membersPage.hidden_more_hint, switched to the new pair here; MembersPage.filters.test.tsxpast three hidden mates, names the first three in roster order and counts the restTests
website/src/pages/members/MembersPage.filters.test.tsx:joins the named and the counted hidden mates as one de / zh-CN / ja listrenders five hidden bots and expects the whole line, one "und" in German,、and和in Chinese,、in Japanese. The three English counted-form cases expect the serial comma. With theMembersPageRoster.tsxhunk reverted, all six fail.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Reproduced on a disposable Linux host (Ubuntu 24.04.5) against the real dashboard: an isolated gateway (
KIROCREW_HOMEunder~/scratch, free 127.0.0.1 port, never port 5476), fivesource: "package"agents seeded intoconfig.jsonand applied throughPOST /api/security/config-pending/config.json/apply, so the Members roster hides 6 bots with 1 listed. Playwright read[data-testid="member-hidden-hint"]in en/de/zh-CN/ja, built the fixed tree and reread. Before and after:The named form (three or fewer hidden,
hidden_named_hint) is unchanged and the no-hidden case still draws no line.Screenshots / video
Hidden-bots hint on the Members page in four languages, before and after. The dashboard is run in each language with six hidden bots and one listed (the hint names three and counts the rest).
Related Issues
Closes #35583
Sibling sweep
Swept: git grep -nE "type: 'unit'" -- website/src (tests left out), each hit read for whether its list goes into a sentence that adds its own conjunction; plus the English catalogs for "and {{count}} more" sentences.
Sibling: website/src/pages/chat-sidebar/CrewGroups.tsx:293 -- not affected -- the counts list is the whole value after the target, no conjunction of its own
Sibling: website/src/pages/chat-sidebar/SearchDock.tsx:1215 -- not affected -- a chip label, "Hiding {{filter}}", adds no conjunction
Sibling: website/src/pages/settings/SecurityPanelGovernance.tsx:586 -- not affected -- "Affected: {{profiles}}." adds no conjunction
Sibling: website/src/i18n/locales/en.manual.json:11524 -- not affected --
and_morefollows one title, not a listPattern harvest
Rule candidate: review-prompt
Pattern: a formatted name list passed into a translated sentence that closes the list with its own "and N more"; make the count the list's last item instead
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)