Skip to content

fix(projects): show task-run status in the app language - #36808

Merged
RohanK6 merged 1 commit into
mainfrom
crew/conductor/r61-projects-run-status
Nov 13, 2026
Merged

RohanK6 merged 1 commit into
mainfrom
crew/conductor/r61-projects-run-status

Conversation

@RohanK6

@RohanK6 RohanK6 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Task-run states on the Projects page show in the app language.

The run rail printed {r.running ? 'running' : r.status} and the run header printed selectedRun.status, so "completed", "failed", "planned", "paused" and a hard-coded "running" appeared in English in every language.

Why it matters

The state is the one word a user reads on each run row, and it was the only untranslated text in an otherwise translated list.

Not a goal

  • The step-level statuses inside the run detail pane.
  • Changing the run states themselves.

What changed (motivation → approach → change)

Symptom: English run states in a translated UI. Root cause: raw status strings rendered directly. Change, in website/src/pages/ProjectsPage.tsx: a runStatusLabel(run) helper maps every RunStatus (planning, planned, running, completed, failed, cancelled, paused, pausing) to a catalog label, reusing the page's existing running and planning keys; a status outside that set is shown verbatim. Both sites use it, and the rail's meta row now leads with the step count and state ("2/5 · Fehlgeschlagen · run-…"): they are never truncated, and where a long label cannot fit the narrow rail it wraps, breaking before the "·" so the separator stays with the state. The run id follows and takes only the space left, so it truncates first and drops out entirely; the full row stays in its title. Six keys (status_completed, status_failed, status_cancelled, status_planned, status_paused, status_pausing) are added to every shipped locale, reusing each locale's existing wording for the same states elsewhere in the catalog; en-XA is regenerated.

Backwards compatibility

Compatible: display only; no status value or API changes.

Removes nothing.

Tests

  • website/src/test/ProjectsPage.test.tsx and website/playwright/projects.spec.ts: two expectations that pinned the raw running / planned text now expect the labels (and the rail row's new count · state · id order).
  • website/src/test/ProjectsPageCoverage.test.tsx: in German, a failed run's rail row reads "Fehlgeschlagen" and not "failed", as "1/2 · Fehlgeschlagen" in an element that wraps rather than truncates (fails on main); runStatusLabel keeps an unknown status verbatim and labels a running run "Running".

Proof: not provable -- frontend test (prove.py runs Python only). Checked by hand: the rail test fails against the main-branch page; the file's 64 tests, the i18n suite (I18N_BASE_REF=origin/main), check-i18n-keys, check-i18n-strings, tsc and eslint pass.

Manual verification

Captured with a local Playwright harness (not part of this PR) that mounts the real ProjectsPage with five runs (completed, failed, cancelled, planned, paused) and checks the rail text for raw and labelled states before writing each frame. The frames below use long run ids; the runner checks that every rail row's count and state are rendered whole, with no clipping or overflow past the text column, and, after selecting the failed run, that the header shows its label. The same check over all 12 shipped locales finds no row clipped; the labels that cannot fit one line (de "Fehlgeschlagen", and longer ru, hi and bn labels) wrap.

Screenshots / video

Projects run rail, English and German.

Before (main):

before en: raw states

before de: English raw states under German UI

After (this PR):

after en: labelled states

after de: Abgeschlossen, Fehlgeschlagen, Abgebrochen, Geplant, Pausiert

Updated after frames for this revision, with long run ids: the count and state lead and stay whole, the id truncates after them, and German "Fehlgeschlagen" wraps instead of being cut.

after en: 3/7 · Paused · run-… rows, counts and states whole

after de: counts and states whole, Fehlgeschlagen wrapped

Run header of the selected failed run (the second site this PR changes):

after en: header reads Failed

after de: header reads Fehlgeschlagen

Related Issues

Fixes #36805

Sibling sweep

Swept: grep -n ".status}" website/src/pages/ProjectsPage.tsx
Sibling: ProjectsPage.tsx rail row and run header -- changed here

Pattern harvest

Rule candidate: none
Pattern: a raw enum value rendered as text; covered by the existing untranslated-strings checks only when it is a literal.

Overlap

Open PR #25471 also edits ProjectsPage.tsx; its hunks (imports, the YAML panel) do not touch the lines changed here. Open PRs #36361 and #30515 match a search for the page but change none of its lines.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners November 13, 2026 18:23
@RohanK6
RohanK6 requested a review from buluoray November 13, 2026 18:23
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 13, 2026
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of f1987edabadfbaa8e1a5f8dfe5b2c906e916b534 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a display-only change that removes nothing, and the PR includes images of both changed sites.

Notes

  • The header still has its own planning/running branches next to runStatusLabel. Two places now decide the running state, and they can drift apart. Have the header pick only the icon and take its text from the helper.

[DESIGN-REVIEWED] f1987ed

Description read

[DESCRIPTION-READ] b4a4d102c0f3800d8508fa0aa4b67bdd75d31d00ba22500ce23d9410e264219d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of f1987edabadfbaa8e1a5f8dfe5b2c906e916b534 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The fix is narrow and backed by an issue (#36805) and a test that fails on main. Only the reordered rail row (state first, id last) rides along, and it is reversible.

Notes

  • Item 3 — unjustified move: the description gives only "they are never truncated." The old row was not truncated either: its div had no truncate and simply wrapped. No report says anyone misread the id-first order. Subtraction: keep the original {r.task_id} · {r.completed}/{r.tasks} · {runStatusLabel(r)} order in the existing plain div. Delete the two-span flex split and its title.

What this change ships

Inventory (5 items) — 3 justified

Intent: show each task run's state on the Projects page in the user's language (FIX).

  1. The run rail's state word ("failed", "running", …) is translated — justified
  2. The selected run's header shows a translated state for completed, failed, cancelled, paused and pausing — justified
  3. Rail row order changes from id · count · state to count · state · id; the id truncates first — rides along, unjustified move
  4. A full-row tooltip on each rail meta line — rides along
  5. Six new status_* catalog keys in every locale — justified

[FIRST-PRINCIPLES-REVIEWED] f1987ed

Description read

[DESCRIPTION-READ] ff946772f02b8ecbc1a20e1b45b7acc686876fc0de715d60b0bfca2e790577de

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of f1987edabadfbaa8e1a5f8dfe5b2c906e916b534 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. All three changed spots (rail state label, the new count · state · id order, header state) appear in English and German screenshots, and the blind reader read the labels correctly.

Notes

  • In German, the long "Fehlgeschlagen" label pushes "2/5" onto its own line with "· Fehlgeschlagen" below it. In the same row the progress bar shrinks and loses its grey track (shot-06; the reader saw "its grey track is gone"). Give the bar a fixed shrink-0 width so the label never squeezes it.
  • The run id now shows only as "run-…" / "ru…", and the reader had "no idea" what it was (shot-05). Drop the id from the visible meta row and keep it in the title.

[UX-REVIEWED] f1987ed

Description read

[DESCRIPTION-READ] e1a25ec5e53a659f7bd374c24649e8cc222491858559e95ef073b9afc7aa33b0

That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed f1987edabadfbaa8e1a5f8dfe5b2c906e916b534 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] f1987ed

Verdict parsed from the review's SHA-scoped output markers for commit f1987edabadfbaa8e1a5f8dfe5b2c906e916b534.

False positive or not applicable? A repository writer can comment:
/ai-review override fable f1987edabadfbaa8e1a5f8dfe5b2c906e916b534 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of f1987edabadfbaa8e1a5f8dfe5b2c906e916b534 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f1987ed

False positive or not applicable? A repository writer can comment:
/ai-review override gpt f1987edabadfbaa8e1a5f8dfe5b2c906e916b534 false-positive: <reason, 20 to 500 characters>

@RohanK6
RohanK6 force-pushed the crew/conductor/r61-projects-run-status branch from 7599479 to 2ccf100 Compare November 13, 2026 19:02
@KiroCrewCaptain

KiroCrewCaptain commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 10% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

This is a display-only fix, and it does what it says. Before, the Projects page printed the raw status string in two places: the run rail and the run header. A new runStatusLabel helper now covers all eight RunStatus values. It reuses the page's existing running and planning keys and shows any unknown status as-is, so nothing disappears. Both places use it. The six new keys are in all 12 shipped locales plus the en-XA pseudolocale, so the key sets still match. Adding them to en.json by hand is allowed: website/docs/i18n-catalog.md says the file is "also maintained by hand… Add keys by hand or with --merge". In the header, the 'planning' and running branches still come first, so those two states render as before; only completed, failed, cancelled, paused and pausing change from raw text to labels. The rail row's order changes from id · count · state to count · state · id, with the id truncating. The two tests that pinned the old text were updated. getByText collapses the non-breaking space to a normal space before matching, and the \s in the textContent regex also matches it, so both still pass. I searched the website tree for other tests that match the old rail te

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit f1987edaba · 136 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@RohanK6
RohanK6 force-pushed the crew/conductor/r61-projects-run-status branch from 2ccf100 to 60b8e3a Compare November 13, 2026 19:40
The Task Runner rail and the run header printed the raw run status
("completed", "failed", "planned", ...) and a literal English
"running", so every non-English dashboard showed English states. Map
each status to a catalog label, keeping an unknown one verbatim.

Fixes #36805
@RohanK6
RohanK6 force-pushed the crew/conductor/r61-projects-run-status branch from 60b8e3a to f1987ed Compare November 13, 2026 20:25
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 13, 2026
@RohanK6
RohanK6 enabled auto-merge (squash) November 13, 2026 22:48

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review covered the full diff on this head: 17 frontend files, all in ProjectsPage.tsx, the locale catalogs and tests. runStatusLabel covers all eight RunStatus values. A running run takes priority over its stored status, and an unknown status still shows as-is. Both raw-status sites from #36805 (the rail row and the header fallback) now use it. All six new keys exist in every shipped locale plus en-XA, and each file parses as valid JSON. No other screen prints a raw run status. The change is plain text rendering only. PR Readiness is green on this head.
Done well: the German rail test fails on main. It checks that "Fehlgeschlagen" shows and "failed" is absent, and it restores the language in onTestFinished, so a timeout cannot leak German into later tests.
Optional:

  • The rail row reorder (count · state · id), the two-span flex split and the row title go beyond the Goal. The original single div, with only the state swapped to runStatusLabel(r), would also meet it. A maintainer may want to accept the new layout on purpose or revert it in a follow-up.
  • The runner briefly sets cancelling during cancel cleanup. That value is not in RunStatus, so it still shows in English. A follow-up could add the value, a matching case and a status_cancelling key.
  • A table-driven it.each over the eight statuses would pin every switch arm. Today only the failed, running and unknown paths are tested.

@RohanK6
RohanK6 merged commit 59d9773 into main Nov 13, 2026
99 of 107 checks passed
@RohanK6
RohanK6 deleted the crew/conductor/r61-projects-run-status branch November 13, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task Runner shows run status as raw English values

2 participants