Repository navigation
feat(apps): add Mood Music, songs that match how you feel - #37035
iamwhatever wants to merge 1 commit into
Conversation
GPT 6.1 Review — 🔴 changes requested (blocking)GPT 6.1 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- src/kiro_crew/apps/builtins/init.py:18 -- New app expands the closed built-in set
BLOCKING -- src/kiro_crew/apps/builtins/mood_music/backend/routes.py:47 -- Separate request locks allow successful writes to discard data
BLOCKING -- website/src/apps/mood-music/MoodMusicPage.tsx:122 -- Failed answer submission discards the unsent draft
BLOCKING -- website/src/apps/mood-music/NowPlaying.tsx:83 -- Three peer actions exceed the two-control limit
BLOCKING -- website/src/apps/mood-music/MoodMusicPage.tsx:278 -- Error notice lacks the required hand-off decision
[BLOCK-MERGE] 2c19635 Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1: UPHOLD. The finding is tied to F4: UPHOLD. The finding is tied to F5: UPHOLD. The finding is tied to F2 (fenced): UPHOLD-FENCED. The lock in F3 (fenced): UPHOLD-FENCED. False positive or not applicable? A repository writer can comment: |
c4289b3 to
2c19635
Compare
First Principles Review (Opus 5.5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK The whole app is added as a new built-in in core. AGENTS.md "No built-in apps" and the 2026-11-01 decision forbid that. A dedicated repo listed in What this change shipsInventory (8 items) — 1 justifiedIntent: say a mood, or name a song, and get matching songs played. ADDITION.
BlockersThe new built-in app is a second way to ship an app — duplicate of the external app-repo and registry route [FIRST-PRINCIPLES-REVIEWED] 2c19635 Description read[DESCRIPTION-READ] 7bcf34c58d5d8c458545450c8f7bbfac1ba9fca1c18872a8ede6f3045196530b That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)Design-level review of Design-Verdict: PASS Kiro Crew no longer accepts new built-in apps, and this PR adds one: a new BlockersMood Music ships as a new built-in app in core Notes
[DESIGN-REVIEWED] 2c19635 Description read[DESCRIPTION-READ] 6eb7dc31cc1f3be3e051abc1dcf22557474a1269b1302749156e343bf24dcc12 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK Clicking a mood chip only changes the background colour; no new songs come up. The pause icon in the header stops the background motion, not the music. The DJ's question, the loading state and the empty state appear in no screenshot. BlockersMood chips look like they pick songs, but they only change the colour A pause icon on a music page pauses the background, not the music Evidence gaps
Notes
[UX-REVIEWED] 2c19635 Description read[DESCRIPTION-READ] 1f951bd722059c6adc0c78ba53eaa4f04527cc7034a1fd4cf1a860fe0e670ee5 That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — 🔴 changes requested (blocking)Reviewed This PR adds a new built-in app (Mood Music) to core, which the blocking BLOCKING — src/kiro_crew/apps/builtins/init.py:18 Trigger: The PR adds a new BLOCKING — src/kiro_crew/apps/builtins/mood_music/backend/routes.py:268 Trigger: Every handler calls [BLOCK-MERGE] 2c19635 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Moving Mood Music out of core: the planThis PR adds Mood Music as a built-in, which AGENTS.md "No built-in apps" and the 2026-11-01 decision do not allow. First Principles and Design are right. No override will be asked for. The app moves to its own repository, and core gets one small app-agnostic seam. This PR does not get more builtin fixes. 1. The app repositoryIt is first-party, so it starts from What changes when the code leaves core:
The UX fixes the UX lane asked for are already written locally (a chip starts a search, and the motion toggle reads "Pause background motion" as text). They ride into the app repository, not onto this PR. 2. The core seam: a manifest declares its frame originsThe page plays YouTube in an iframe, and
Mood Music then declares 3. How this PR ends
Nothing in this PR is pushed again in the meantime. |
Ported from the Kiro Crew built-in draft (kirodotdev/KiroCrew#37035) to an external app: backend.hooks.routes with ctx.require_owner, the page as a committed ESM bundle, strings in ui/i18n, and ui.frameSources declaring https://www.youtube-nocookie.com for the in-page player. Includes the UX fixes from that PR's review: a mood chip starts a search, and the motion toggle says it pauses the background. Co-authored-by: zejiangg <zejiangg@amazon.com>
|
Closing in favour of the standalone app, per the migration plan above and AGENTS.md "No built-in apps".
The |
Problem / Motivation
Goal: Say how you feel, or name a song that moved you, and Kiro Crew finds songs with the same feeling and plays them.
Music players pick by genre and play history, not by how you feel. When one song moves you, you cannot ask for "more like this feeling", and nothing says why a pick fits.
Why it matters
People want music that meets their mood in the moment. Kiro Crew already has agents that can search the web; this turns that into a small, pretty app anyone can switch on.
Not a goal
What changed (motivation → approach → change)
A new opt-in builtin app, Mood Music (
mood-music,defaultEnabled: false)./mood-musicmood-music-dj+ skillmood-musicweb_searchandweb_fetchonly. Replies end with onemood-musicJSON block: picks, or a single question/api/apps/mood-music/*https://www.youtube-nocookie.com/embed/<id>. bilibili opens in a new tab of your own browser--bg, so light and dark both work. A pause button stops the drift; reduced motion keeps it stillHow a turn works: the page sends the mood plus a short taste summary (liked, skipped, recent moods) to one hidden worker slot, polls it, and reads the reply's block. Every link is checked twice, in
website/src/apps/mood-music/links.tsand again inbackend/links.py: a YouTube pick keeps only an id matching^[A-Za-z0-9_-]{11}$; a bilibili pick must behttpson exactlywww.bilibili.com,m.bilibili.comorb23.tv, with no user info or port. One bad pick makes the backend refuse the whole queue.Why bilibili is not in the side panel: the agent-browser panel is a screen cast with no sound, and the
browsertool cannot be limited to "navigate only" on a browser that may be signed in to the person's account. A plain link to their own browser plays sound and gives the agent no account access.What the CSP opens.
frame-srcinsrc/kiro_crew/dashboard/server.pygains one source,https://www.youtube-nocookie.com/embed/, path-scoped, no wildcard. Any page in the dashboard could now frame that path; it opens no new way out, sinceimg-srcalready admits every https host.Also: the slot uses
memory_mode: temporaryand its own worker mode (seams.py), so feelings typed here stay out of Kiro Crew memory and the chat sidebar. Docs insrc/kiro_crew/docs/apps.mdandindex.mdlist the app. The app is registered inbuiltinRegistry.ts,builtinIcons.tsxandcomponents/appstore/appManifest.ts; its strings are in every catalog underwebsite/src/i18n/locales/.Backwards compatibility
Compatible: a new app that is off by default; the CSP only adds a source.
Removes nothing: no existing route, key, field or behaviour is removed or tightened.
Tests
mood_music/tests/test_links.py: 11-char ids only; 12-char id,http://,bilibili.com.evil.com, user info, ports, backslashes refused.mood_music/tests/test_routes.py: the full mood → queue → feedback path; each bad pick refuses the whole queue and writes nothing; empty mood refused; an unknown mood word is plain text; non-owner, no-app-claim and disabled callers get 403 on every route.mood_music/tests/test_store.py: bounds, feedback kept after the queue moves on, a damaged file moved aside, not overwritten.test/test_dashboard_security_headers.py: frame-src carries exactly one YouTube source, the nocookie embed path.website/src/apps/mood-music/*.test.ts(x): link checks, mood→theme mapping, reply parsing, and the page end to end on fake timers (taste sent, bad link dropped, nocookie src and sandbox, bilibilirel="noopener noreferrer", question flow, skip, pause control, reduced motion, dark theme through variables only).Determinism: backend tests passed 3 runs in a row (
-n 2); frontend tests passed 3 runs with--sequence.shuffle.Manual verification
Rendered the page with a stubbed API in light and dark, for four moods, a bilibili pick and the Moments tab (screenshots below). The YouTube embed loaded in the page. Not run: a live turn against a real agent.
Screenshots / video
Light and dark, "missing someone":
More moods, bilibili, Moments
Related Issues
Closes #36991
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)